diff --git a/.changeset/chatty-teeth-joke.md b/.changeset/chatty-teeth-joke.md new file mode 100644 index 00000000000..d7cd3a3e19c --- /dev/null +++ b/.changeset/chatty-teeth-joke.md @@ -0,0 +1,5 @@ +--- +'@mastra/core': patch +--- + +Fixed JSON parsing in memory component to prevent crashes when encountering strings that start with '[' or '{' but are not valid JSON diff --git a/packages/core/src/memory/memory.ts b/packages/core/src/memory/memory.ts index df25170526b..bf2ec1fee74 100644 --- a/packages/core/src/memory/memory.ts +++ b/packages/core/src/memory/memory.ts @@ -157,15 +157,22 @@ export abstract class MastraMemory extends MastraBase { } protected parseMessages(messages: MessageType[]): CoreMessage[] { - return messages.map(msg => ({ - ...msg, - content: - typeof msg.content === 'string' && (msg.content.startsWith('[') || msg.content.startsWith('{')) - ? JSON.parse((msg as MessageType).content as string) - : typeof msg.content === 'number' - ? String(msg.content) - : msg.content, - })); + return messages.map(msg => { + let content = msg.content; + if (typeof content === 'string' && (content.startsWith('[') || content.startsWith('{'))) { + try { + content = JSON.parse(content); + } catch (e) { + // Keep the original string if it's not valid JSON + } + } else if (typeof content === 'number') { + content = String(content); + } + return { + ...msg, + content, + }; + }) as CoreMessage[]; } protected convertToUIMessages(messages: MessageType[]): AiMessageType[] {