Enable `typescript/no-unnecessary-template-expression` in the shared
TypeScript configuration and simplify 17 redundant interpolations.
Preserve 11 intentional coercions at runtime boundaries and in mock
response text with local explanations. Existing lint scope and package
manifests are unchanged.
Reviewed every edit and compared emitted JavaScript after the approved
string simplifications, including interpolation order and tagged
templates. All 916 function return types and 1,833 variable binding
types in the 21 affected source files are unchanged. CI lint and build
pass; the local 57-task build, CLI typecheck, formatting, and whitespace
checks pass.
Validation covers 193 focused processor, CLI, Couchbase, and GraphRAG
tests, plus 902 deployer tests across the full run and an isolated retry
of one timeout. That protocol-import case passed alone in 14.55 seconds;
unchanged main took 14.61 seconds against its 15-second timeout. Both
selected published-package monorepo E2E cases pass, including the
extended HTTP check for external module resolution. The broad rule audit
found zero rule violations across 15,106 files, alongside four
TypeScript configuration diagnostics in unchanged files; the targeted
scan passes cleanly.
The DuckDB CI job also fails two existing capability-list assertions
because their expected arrays omit `span-aggregate`. Both failures were
reproduced on unchanged base `f4cbdb4d78`; DuckDB and core storage files
are unchanged by this PR.
No changeset is included for this lint maintenance, as requested; the
changeset check is expected to fail. Keep this PR as a draft.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->
## ELI5
This PR adds a check that finds template strings with unnecessary string
insertions. It removes those insertions while preserving explicit
conversions where they may affect behavior.
## Summary
- Enable `typescript/no-unnecessary-template-expression` as an error in
the shared TypeScript configuration.
- Simplify redundant template expressions across CLI, core, deployer,
storage, test, and end-to-end test code.
- Preserve intentional string coercion at runtime boundaries and in mock
responses with local Oxlint suppression comments.
- Keep the existing lint scope and package manifests unchanged,
according to the PR objectives.
## Validation
The PR objectives report passing lint, build, typecheck, formatting,
whitespace, and focused test checks. They also report DuckDB
capability-list failures reproduced on the unchanged base. No changeset
is included as requested. The changeset check is expected to fail.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->