mirror of
https://github.com/mastra-ai/mastra.git
synced 2026-11-17 08:44:46 +00:00
Enables all eleven requested Oxlint rules as errors in the root config and migrates the 115 existing findings across 55 files. JSX curly-brace simplification is limited to props (`props: 'never', children: 'ignore'`), boolean props use shorthand, and empty elements become self-closing. The manual edits preserve the exact continued-string and template values, remove redundant assignment-side non-null assertions, and retain the indexed-read assertion in fastembed's compound assignment. The BigInt and octal conversions use native globals and exact values supported by the existing compilation targets. No lint suppressions were added. Validation: the eleven-rule scan reports zero diagnostics; before/after emitted-JavaScript comparison passes for all 55 migrated files, including 31 JSX files, after normalizing only the reviewed syntax rewrites. Formatting and whitespace checks pass. Core utility/clone tests (146), fastembed pooling tests (9), the changed A2A signature test (1), and fastembed build-config typechecking pass. The root lint scan retains the same 1,244 pre-existing diagnostics with no new findings. GitHub CI now also passes the full lint/format job, build, Mastra Code typecheck, generated-file check, and bundle validation. Local UI/evals runs were limited by missing dependencies; the CodeDiff folding failure was reproduced on unchanged baseline code. A second audit confirmed native unshadowed globals for all five literal conversions, pure targets for all twelve assignment rewrites, no references or direct eval in all eight simplified catches, and ordinary semantics for both computed keys. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## ELI5 This PR turns on more code-style checks and updates existing code to pass them. The changes simplify syntax while preserving the intended behavior. ## Changes - Enabled eleven Oxlint rules as errors in the root configuration. - Updated 115 findings across 55 files. Changes include simpler string and JSX syntax, compound assignments, native BigInt and octal literals, and catch clauses without unused error variables. - Configured JSX curly-brace simplification for props only. JSX children remain unchanged. - Removed redundant assignment-side non-null assertions while retaining the indexed-read assertion needed for fastembed’s compound assignment. - Added no lint suppressions. ## Validation The author reports zero diagnostics from the eleven-rule scan and no new findings in the root lint scan, which retains 1,244 pre-existing diagnostics. Before-and-after emitted-JavaScript comparisons reportedly pass for all 55 changed files after normalizing the reviewed syntax rewrites. Formatting and whitespace checks also pass. Reported tests include 146 core utility and clone tests, 9 fastembed pooling tests, 1 changed A2A signature test, and fastembed build-config typechecking. Full workspace lint and the UI/evals suites were limited by missing dependencies in the checkout. The CodeDiff folding test fails on unchanged baseline code. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
221 lines
6.5 KiB
221 lines
6.5 KiB