mirror of
https://github.com/mastra-ai/mastra.git
synced 2026-11-17 08:44:46 +00:00
Enables `no-else-return: error` in the root Oxlint config and removes 186 redundant `else` branches across 111 source/test files. Existing rule defaults are retained. Reviewed every code diff for behavior preservation. An independent TypeScript AST comparison confirms that changes are limited to removing `else` after returning branches, with the same expressions, statement order, return values, and `try`/`catch`/`finally` boundaries. All 181,158 identifier occurrences retain their bindings. The recorder replay path keeps an explicit block: flattening it would shadow the earlier request `body` with the response `body` and introduce a temporal-dead-zone error. Extends the existing monorepo optimized-dependency test to assert that a raw TypeScript workspace package, including its enum and transitive dependency, still executes in the production bundle. Validation: the root rule-only scan passes on 15,273 files with zero diagnostics; formatting and `git diff --check` pass. Schema compatibility tests: 1,060 passed, 9 skipped. Recorder runtime tests: 21 passed. The core selection initially passed 3,513 tests; rerunning the suites requiring local server/cache access passed 185 tests, with one remaining cache-file assertion also reproduced on unchanged `main`. Remaining validation limits: four asset-download cases cannot reach `placehold.co`; the changed-file lint run reports six import-order errors reproduced on unchanged files from `main`. Deployer unit tests and the monorepo test could not run because this checkout lacks required package dependencies (`fs-extra`/workspace links and `get-port`, respectively). These limits are left visible for CI. No changeset is included because this is a behavior-preserving lint cleanup. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## ELI5 This PR makes the code easier to read by removing `else` branches that are not needed after a return. It also enables a rule that catches those branches and adds a test for loading a raw TypeScript workspace package in a production bundle. ## Summary - Enables Oxlint’s `no-else-return` rule at error severity and removes 186 redundant `else` branches across 111 files. - Extends the monorepo optimized-dependencies test to check a raw TypeScript workspace package, its enum, and a transitive dependency. - Updates the deployer’s transpile-package path pattern. - In workflow event processing, a truthy branch index with no matching child now falls through to publish a skipped-step end event. Previously, this case published no event. - Keeps the recorder replay block explicit to avoid request/response `body` shadowing and a temporal-dead-zone error. ## Validation Reported checks passed: the rule-only scan across 15,273 files, formatting, `git diff --check`, schema compatibility tests (1,060 passed, 9 skipped), recorder runtime tests (21 passed), and an initial core test selection (3,513 passed). Some test limits remain. Four asset-download cases could not reach `placehold.co`. Changed-file lint reported six import-order errors that also occur on unchanged files from `main`. Deployer unit tests and the monorepo test could not run because dependencies were unavailable. On rerun, suites requiring local server/cache access had 185 passes; one cache-file assertion also reproduced on unchanged `main`. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
269 lines
9.6 KiB
269 lines
9.6 KiB