mirror of
https://github.com/monoscope-tech/monoscope.git
synced 2026-11-16 10:18:01 +00:00
Clear the hlint backlog, including ten hints no edit could ever satisfy
`make lint` had been red for long enough that nobody read it. Ten of the thirty findings were unsatisfiable: the `Control.Exception.fromException` rule also matches the already-correct *unqualified* use, so it reported `Found: fromException / Perhaps: fromException` once per call site. The file already documented this exact trap for `displayException`, ending "if one starts self-suggesting, delete it for the same reason" — `fromException` started when the Slack retry paths began using it bare, so it goes for the stated reason. The other twenty are real and applied by hand, since `hlint --refactor` cannot run here (it looks for a GHC 8.10.7 that is not installed): six `pure () -> pass`, two redundant `toStrict` under `decodeUtf8`, an explicit '0'..'9' range that is `isDigit`, two `foldMap`/`<$>` fusions, a redundant `&` on a section, `atomicModifyIORef'_`, Relude's `decodeUtf8'`, `fmap f $ x -> f <$> x`, a single -constructor `data` -> `newtype`, two lambdas that eta-reduce, and a `do` wrapping one statement. Also drops two test statements that reset `apis.anomalies.acknowledged_at` / `archived_at`. Nothing has written those columns since the mirror was retired, so they were resetting state no code produces. `hlint src` now reports no hints.
This commit is contained in:
parent
23dafe4f62
commit
14da1fd0e6
12 changed files with 38 additions and 42 deletions
19
.hlint.yaml
19
.hlint.yaml
Loading…
Add table
Add a link
Reference in a new issue