mirror of
https://github.com/monoscope-tech/monoscope.git
synced 2026-11-16 10:18:01 +00:00
* Escape dashboard variables in query templates; harden local CI and dev tooling
Security
- Dashboard templates quote request variables ('{{var-x}}' in SQL, "{{var-x}}" in
KQL) but received them verbatim, so a quote in a URL value ended the literal and
the rest ran as SQL. fillQueryTemplate now takes the template language and escapes
var- values for it, once, where text becomes a query (maps stay raw, so the cache
key path that re-feeds presets no longer double-escapes). Server presets are
merged after request params, so a request can no longer re-point project_id or
time_filter. Variable/constant KQL queries use the KQL presets.
- Bump overrides for dompurify (^3.4.17) and tmp (^0.2.6), pin katex for
micromark-extension-math, and override @babel/core and postcss-selector-parser;
root lock regenerated with npm 10 (npm 11 drops bundled optional deps and breaks
npm ci).
CI / dev
- Local CI builds its Linux chart-cli to a container path (CHART_CLI_PATH) instead
of overwriting the host's native ./chart-cli through the bind mount.
- scripts/e2e.sh refuses a server binary older than the Haskell source.
- Watchers restart ghcid when it gives up after a branch switch, and log it.
- hpack-check runs before ci-signoff.
- Integration shards record their exit status; a shard that crashes after a
clean summary is now reported with its signal instead of skipped.
- Heavier widget-drawer e2e tests get test.slow() and longer inner waits.
Cleanup
- Weekly report chart URLs are Maybe Text end to end (no "" sentinel).
- tab.slug is the single tab-name slug rule.
- streamFrames/completeFrame live in TestUtils; specs render via renderT.
* Pass the template language in DashboardTemplatesSpec
90 lines
4.6 KiB
Executable file
90 lines
4.6 KiB
Executable file