From 4e4e8902e5bec12befd191b6ce412d60ced819f4 Mon Sep 17 00:00:00 2001 From: Jacob Young Date: Sat, 19 Sep 2026 08:20:15 -0400 Subject: [PATCH] Build: fix UAF of step names --- lib/std/Build/Step.zig | 2 +- lib/std/Build/Step/CheckFile.zig | 2 +- lib/std/Build/Step/Run.zig | 2 +- test/tests.zig | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/std/Build/Step.zig b/lib/std/Build/Step.zig index 78c1e3343c..a4d6987126 100644 --- a/lib/std/Build/Step.zig +++ b/lib/std/Build/Step.zig @@ -95,7 +95,7 @@ pub fn init(options: StepOptions) Step { return .{ .tag = options.tag, - .name = arena.dupe(u8, options.name) catch @panic("OOM"), + .name = options.owner.graph.dupeString(options.name), .owner = options.owner, .dependencies = .empty, .max_rss = options.max_rss, diff --git a/lib/std/Build/Step/CheckFile.zig b/lib/std/Build/Step/CheckFile.zig index 21ebbd4621..44c0494c1e 100644 --- a/lib/std/Build/Step/CheckFile.zig +++ b/lib/std/Build/Step/CheckFile.zig @@ -41,5 +41,5 @@ pub fn create(owner: *std.Build, file: std.Build.LazyPath, options: Options) *Ch } pub fn setName(check_file: *CheckFile, name: []const u8) void { - check_file.step.name = name; + check_file.step.name = check_file.step.owner.graph.dupeString(name); } diff --git a/lib/std/Build/Step/Run.zig b/lib/std/Build/Step/Run.zig index e8a26ea36b..8662d5258a 100644 --- a/lib/std/Build/Step/Run.zig +++ b/lib/std/Build/Step/Run.zig @@ -241,7 +241,7 @@ pub fn create(owner: *std.Build, name: []const u8) *Run { } pub fn setName(run: *Run, name: []const u8) void { - run.step.name = name; + run.step.name = run.step.owner.graph.dupeString(name); run.rename_step_with_output_arg = false; } diff --git a/test/tests.zig b/test/tests.zig index 0d41503255..b782307a36 100644 --- a/test/tests.zig +++ b/test/tests.zig @@ -2502,7 +2502,7 @@ pub fn addStandaloneTests( .simple_skip_release_small = mem.findScalar(OptimizeMode, optimize_modes, .small) == null, }); const test_cases_dep_step = test_cases_dep.builder.default_step; - test_cases_dep_step.name = b.graph.dupeString(test_cases_dep_name); + test_cases_dep_step.name = test_cases_dep_name; step.dependOn(test_cases_dep.builder.default_step); return step; }