mirror of
https://codeberg.org/ziglang/zig
synced 2026-11-18 07:05:05 +00:00
x86_64: fix unencodable rem lowerings
The memory operand might use one of the extended GPRs R8 through R15 and hence require a REX prefix, but having a REX prefix makes the high-byte register AH unencodeable as the src operand. This latent bug was exposed by this branch, presumably because `select` now happens to be putting something in an extended GPR instead of a legacy GPR. In theory this could be fixed with minimal cost by introducing a way to communicate to `select` that neither the destination memory nor the other temporary can be in an extended GPR. However, I just went for the simple solution which comes at a cost of one trivial instruction: copy the remainder from AH to AL, and *then* copy AL to the destination.
This commit is contained in:
parent
77fca1652f
commit
611c38e6da
1 changed files with 8 additions and 4 deletions
Loading…
Add table
Add a link
Reference in a new issue