mirror of
https://codeberg.org/ziglang/zig
synced 2026-11-18 07:05:05 +00:00
When compiling Arm Thumb code, GCC and LLVM ([including zig](https://godbolt.org/z/sfxd37P3x)) use R7 as the frame pointer (except when `-fomit-frame-pointer` is specified, of course) rather than R11 which is used in 32-bit mode. This is mainly due to Thumb1's `PUSH`/`POP` instructions only supporting R0-R7 and R14/R15. Armv7-M does have Thumb2 `PUSH.W`/`POP.W` which can do it, but LLVM still uses R7, even if you explicitly use e.g. `-mcpu cortex_m3`. Note that AAPCS32 doesn't mention using R7 as FP in Thumb mode at all, but it also only barely mentions using R11 as FP: "In some variants r11 (FP) may be used as a frame pointer in order to chain frame activation records into a linked list." `std.debug.cpu_context.Arm` currently always assumes R11 is the frame pointer for both `arm` and `thumb` targets, which means FP unwinding simply doesn't work on thumb targets, including most arm microcontrollers. It would be nice to have stack tracing available through the FP on these constrained platforms since you often don't have enough ROM space to waste on the `.debug_frame` section, and [`.ARM.exidx`/`.ARM.extab` unwinding](https://codeberg.org/ziglang/zig/issues/30931) isn't implemented yet. On some platforms, it's possible to have both thumb and arm functions interleaved within a single call stack. In these cases, [compilers use R11 for the FP in arm functions, and R7 in thumb functions](https://godbolt.org/z/EsaYW8rhh), so neither blindly using R11 nor R7 will guarantee a correct stack unwinding in the general case. The most reliable way to determine which register is the FP for the currently executing stack frame would be by reading `CPSR` using the `MRS` instruction and checking the `T` bit, but since zig currently doesn't have an equivalent to `__attribute__((target("thumb")))` that can be applied on a per-function basis, the thumb-ness of all non-extern functions will always match `@import("builtin").target.arch.isThumb()`. For deeper stack frames, it doesn't matter what register the FP was stored in, since when we unwind we're getting it from the stack instead. As long as all functions were compiled with `-fno-omit-frame-pointer`, the FP will always have been pushed immediately after the LR. So the first change is to have `std.debug.cpu_context.Arm.getFp()` use R7 when `native_arch` is thumb. The current inline assembly for grabbing the CPU context mentions only using `STM` for R0-R12 for thumb compatibility, but it still uses several 32-bit Thumb2 instructions that don't exist on architectures like Cortex M0/M0+. This PR adds a slightly more verbose alternative version that only uses 16-bit instructions if the target doesn't support Thumb2. I thought about skipping R8-R12 entirely on targets that only support Thumb1, since it's highly unlikely that they'll actually be used for anything, but for now they are still being captured. With these two changes, and appropriate `debug` declarations in the root module to enable symbol lookup using a custom minified string table tacked onto the end of the firmware blob, I can get stack traces on an RP2040 microcontroller (Cortex M0+): ``` src/main.zig:135:37: 0x10000b5a in dumpCurrentStack (firmware) src/main.zig:131:5: 0x10000b50 in iAmAFunctionYesIAm (firmware) src/main.zig💯21: 0x10000a7c in main (firmware) $rpi/src/rp2040/boot.zig:112:16: 0x10000310 in _start (firmware) $rpi/src/rp2040/boot.zig:31:11: 0x100002b6 in _boot3 (firmware) ``` But there's still one more problem: all of the reported addresses point to the instruction immediately following the `BL`/`BLX` instruction that we would expect. For example, here's the disassembly for the top two functions: ``` main.iAmAFunctionYesIAm: 10000b48 80b5 push {r7, lr} 10000b4a 00af add r7, sp, #0 10000b4c 00f001f8 bl #main.dumpCurrentStack 10000b50 80bd pop {r7, pc} main.dumpCurrentStack: 10000b52 80b5 push {r7, lr} 10000b54 00af add r7, sp, #0 10000b56 00f001f8 bl #debug.writeCurrentStackTrace 10000b5a 80bd pop {r7, pc} ``` In this case, none of the resolved symbols or source locations are affected by the incorrect instruction addresses, but if the next instruction after the subroutine happened to be an inlined function, they could be erroneous. We need to make sure that the thumb bit is cleared so that when `std.debug.StackIterator` subtracts 1 from the return address, it ends up in the previous call instruction. I put this in `std.debug.stripInstructionPtrAuthCode` and renamed it to `std.debug.stripInstructionPtrMarkerBits` since I believe everywhere that's currently used should have the thumb bit stripped as well (or at least it shouldn't harm anything to do so). With all of the changes, my RP2040 test now looks correct: ``` src/main.zig:135:37: 0x10000b59 in dumpCurrentStack (firmware) src/main.zig:131:5: 0x10000b4f in iAmAFunctionYesIAm (firmware) src/main.zig💯21: 0x10000a7b in main (firmware) $rpi/src/rp2040/boot.zig:112:16: 0x1000030f in _start (firmware) $rpi/src/rp2040/boot.zig:31:11: 0x100002b5 in _boot3 (firmware) ``` Reviewed-on: https://codeberg.org/ziglang/zig/pulls/37482 Reviewed-by: Alex Rønne Petersen <alex@alexrp.com>
1947 lines
78 KiB
1947 lines
78 KiB