mirror of
https://codeberg.org/ziglang/zig
synced 2026-11-18 07:05:05 +00:00
On MIPS, $a3 ($7) carries the fourth argument [1] and returns the kernel's error flag [2]. The kernel writes the flag on every return, success included [3]. syscall4 and up declared $7 an input only, so the compiler assumed it still held the argument after the syscall. In release builds, a pointer passed as the fourth argument then reads back as the flag, 0 on success, and using it faults at address 0. Commit5b29b4ffa6("Fix MIPS inline assembly clobbers") took $7 out of the clobbers, since an input cannot be one, but never made it an output. Add that output, as alpha.zig does for its argument registers [4] and musl does with "+r" [5]. $7 stays out of the clobbers, because a register that is input, output and clobber at once can miscompile (#35724). [1] - https://refspecs.linuxfoundation.org/elf/mipsabi.pdf#page=24 [2] - https://man7.org/linux/man-pages/man2/syscall.2.html [3] - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/kernel/scall32-o32.S?h=v7.1#n112 [4] -d893812013/lib/std/os/linux/alpha.zig (L38-L46)[5] - https://git.musl-libc.org/cgit/musl/tree/arch/mips/syscall_arch.h?h=v1.2.6#n81 closes #37247
267 lines
8.4 KiB
267 lines
8.4 KiB