From 8cfbdb14ad61070b7f153b291dc6ac6b35cef600 Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Fri, 13 Nov 2026 10:20:41 +0000 Subject: [PATCH 1/8] zml: introduce `zml/meta` and `zml/constants` modules --- zml/BUILD.bazel | 19 +++++++++++++++++-- zml/Compiler.zig | 2 +- zml/buffer.zig | 4 ++-- zml/exe.zig | 2 +- zml/io.zig | 2 +- zml/mem.zig | 2 +- zml/nn.zig | 4 ++-- zml/ops.zig | 4 ++-- zml/ops/manual_computation.zig | 2 +- zml/pjrtx.zig | 2 +- zml/platform.zig | 2 +- zml/shape.zig | 2 +- zml/slice.zig | 4 ++-- zml/tensor.zig | 4 ++-- zml/zml.zig | 8 ++++---- 15 files changed, 39 insertions(+), 24 deletions(-) diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index f52ecdd5..5f8b93f1 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -73,6 +73,21 @@ zig_library( visibility = ["//visibility:public"], ) +zig_library( + name = "meta", + import_name = "zml/meta", + main = "meta.zig", + visibility = ["//visibility:public"], + deps = ["//stdx"], +) + +zig_library( + name = "constants", + import_name = "zml/constants", + main = "constants.zig", + visibility = ["//visibility:public"], +) + zig_library( name = "zml", srcs = [ @@ -82,7 +97,6 @@ zig_library( "attention/attention.zig", "buffer.zig", "buffer/HostAccessible.zig", - "constants.zig", "dtype.zig", "exe.zig", "floats.zig", @@ -97,7 +111,6 @@ zig_library( "kernels/paged_attention/paged_attention.zig", "logo.zig", "mem.zig", - "meta.zig", "mlirx.zig", "nn.zig", "ops.zig", @@ -146,6 +159,8 @@ zig_library( "-freference-trace=20", ], deps = [ + ":constants", + ":meta", ":posix", ":profiler_options", ":profiling_traceme_lib", diff --git a/zml/Compiler.zig b/zml/Compiler.zig index 93eafa8d..73b5057a 100644 --- a/zml/Compiler.zig +++ b/zml/Compiler.zig @@ -2,6 +2,7 @@ const std = @import("std"); const c = @import("c"); const func = @import("mlir/dialects/func"); +const meta = @import("zml/meta"); const mlir = @import("mlir"); const pjrt = @import("pjrt"); const shardy = @import("mlir/dialects/shardy"); @@ -14,7 +15,6 @@ const Buffer = @import("buffer.zig").Buffer; const DataType = @import("dtype.zig").DataType; const Exe = @import("exe.zig").Exe; const Memory = @import("platform.zig").Memory; -const meta = @import("meta.zig"); const mlirx = @import("mlirx.zig"); const ops = @import("ops.zig"); const pjrtx = @import("pjrtx.zig"); diff --git a/zml/buffer.zig b/zml/buffer.zig index 8714d80f..70be7c83 100644 --- a/zml/buffer.zig +++ b/zml/buffer.zig @@ -1,14 +1,14 @@ const std = @import("std"); +const constants = @import("zml/constants"); +const meta = @import("zml/meta"); const pjrt = @import("pjrt"); const platforms = @import("platforms"); const stdx = @import("stdx"); -const constants = @import("constants.zig"); const DataType = @import("dtype.zig").DataType; const mem = @import("mem.zig"); const Memory = @import("platform.zig").Memory; -const meta = @import("meta.zig"); const pjrtx = @import("pjrtx.zig"); const Platform = @import("platform.zig").Platform; const Shape = @import("shape.zig").Shape; diff --git a/zml/exe.zig b/zml/exe.zig index 32c0ac48..93895b85 100644 --- a/zml/exe.zig +++ b/zml/exe.zig @@ -1,13 +1,13 @@ const std = @import("std"); const builtin = @import("builtin"); +const meta = @import("zml/meta"); const pjrt = @import("pjrt"); const stdx = @import("stdx"); const Buffer = @import("buffer.zig").Buffer; const Compiler = @import("Compiler.zig"); const mem = @import("mem.zig"); -const meta = @import("meta.zig"); const Platform = @import("platform.zig").Platform; const tracer = @import("profiling/tracer.zig"); const Shape = @import("shape.zig").Shape; diff --git a/zml/io.zig b/zml/io.zig index ab8d8e6e..35501213 100644 --- a/zml/io.zig +++ b/zml/io.zig @@ -1,5 +1,6 @@ const std = @import("std"); +const meta = @import("zml/meta"); const pjrt = @import("pjrt"); const stdx = @import("stdx"); pub const VFS = @import("vfs"); @@ -10,7 +11,6 @@ const CreateOptions = @import("platform.zig").CreateOptions; const Exe = @import("exe.zig").Exe; const mem = @import("mem.zig"); const Memory = @import("platform.zig").Memory; -const meta = @import("meta.zig"); const pjrtx = @import("pjrtx.zig"); const Platform = @import("platform.zig").Platform; const tracer = @import("profiling/tracer.zig"); diff --git a/zml/mem.zig b/zml/mem.zig index a64ae968..3007044c 100644 --- a/zml/mem.zig +++ b/zml/mem.zig @@ -3,12 +3,12 @@ const Allocator = std.mem.Allocator; const Alignment = std.mem.Alignment; const assert = std.debug.assert; +const meta = @import("zml/meta"); const pjrt = @import("pjrt"); const Buffer = @import("buffer.zig").Buffer; const Device = @import("platform.zig").Device; const Memory = @import("platform.zig").Memory; -const meta = @import("meta.zig"); const Platform = @import("platform.zig").Platform; const Tensor = @import("tensor.zig").Tensor; diff --git a/zml/nn.zig b/zml/nn.zig index eceb316b..71474302 100644 --- a/zml/nn.zig +++ b/zml/nn.zig @@ -1,13 +1,13 @@ //! Common layer definition and functions for Neural Networks (NN) const std = @import("std"); +const constants = @import("zml/constants"); +const meta = @import("zml/meta"); const mlir = @import("mlir"); const stablehlo = @import("mlir/dialects/stablehlo"); const stdx = @import("stdx"); -const constants = @import("constants.zig"); const DataType = @import("dtype.zig").DataType; -const meta = @import("meta.zig"); const mlirx = @import("mlirx.zig"); const ops = @import("ops.zig"); const quantization = @import("quantization.zig"); diff --git a/zml/ops.zig b/zml/ops.zig index f8fdba7e..f1b0a8bd 100644 --- a/zml/ops.zig +++ b/zml/ops.zig @@ -1,7 +1,9 @@ const std = @import("std"); const builtin = @import("builtin"); +const constants = @import("zml/constants"); const func = @import("mlir/dialects/func"); +const meta = @import("zml/meta"); const mlir = @import("mlir"); const pjrt = @import("pjrt"); const platforms = @import("platforms"); @@ -11,10 +13,8 @@ const stdx = @import("stdx"); const Buffer = @import("buffer.zig").Buffer; const Bufferized = @import("mem.zig").Bufferized; const Compiler = @import("Compiler.zig"); -const constants = @import("constants.zig"); const CustomCallBuffer = @import("pjrtx.zig").CustomCallBuffer; const DataType = @import("dtype.zig").DataType; -const meta = @import("meta.zig"); const mlirx = @import("mlirx.zig"); const manual_computation = @import("ops/manual_computation.zig"); pub const manualComputation = manual_computation.manualComputation; diff --git a/zml/ops/manual_computation.zig b/zml/ops/manual_computation.zig index a0ec0037..d39ef844 100644 --- a/zml/ops/manual_computation.zig +++ b/zml/ops/manual_computation.zig @@ -6,7 +6,7 @@ const stablehlo = @import("mlir/dialects/stablehlo"); const stdx = @import("stdx"); const Compiler = @import("../Compiler.zig"); -const meta = @import("../meta.zig"); +const meta = @import("zml/meta"); const mlirx = @import("../mlirx.zig"); const Shape = @import("../shape.zig").Shape; const Sharding = @import("../Sharding.zig"); diff --git a/zml/pjrtx.zig b/zml/pjrtx.zig index 824d2bd1..3185b608 100644 --- a/zml/pjrtx.zig +++ b/zml/pjrtx.zig @@ -1,11 +1,11 @@ const std = @import("std"); +const meta = @import("zml/meta"); const mlir = @import("mlir"); const pjrt = @import("pjrt"); const stablehlo = @import("mlir/dialects/stablehlo"); pub const DataType = @import("dtype.zig").DataType; -const meta = @import("meta.zig"); const Shape = @import("shape.zig").Shape; const Tensor = @import("tensor.zig").Tensor; diff --git a/zml/platform.zig b/zml/platform.zig index 54fb90e4..03acd864 100644 --- a/zml/platform.zig +++ b/zml/platform.zig @@ -2,11 +2,11 @@ const std = @import("std"); const builtin = @import("builtin"); const c = @import("c"); +const constants = @import("zml/constants"); const pjrt = @import("pjrt"); const stdx = @import("stdx"); pub const Target = @import("platforms").Platform; -const constants = @import("constants.zig"); const Exe = @import("exe.zig").Exe; const flashinfer_cutlass_contract = @import("kernels/moe/flashinfer_cutlass/contract.zig"); const flashinfer_cutlass_runtime = @import("kernels/moe/flashinfer_cutlass/runtime.zig"); diff --git a/zml/shape.zig b/zml/shape.zig index 386b594e..dddcdf63 100644 --- a/zml/shape.zig +++ b/zml/shape.zig @@ -2,9 +2,9 @@ const std = @import("std"); const testing = std.testing; const builtin = @import("builtin"); +const constants = @import("zml/constants"); const stdx = @import("stdx"); -const constants = @import("constants.zig"); const DataType = @import("dtype.zig").DataType; const Sharding = @import("Sharding.zig"); diff --git a/zml/slice.zig b/zml/slice.zig index 9451165b..8b593bd2 100644 --- a/zml/slice.zig +++ b/zml/slice.zig @@ -1,12 +1,12 @@ const std = @import("std"); +const builtin = @import("builtin"); +const constants = @import("zml/constants"); const stdx = @import("stdx"); -const constants = @import("constants.zig"); const DataType = @import("dtype.zig").DataType; const floats = @import("floats.zig"); const Shape = @import("shape.zig").Shape; -const builtin = @import("builtin"); pub fn isBytes(comptime T: type) bool { const type_info = @typeInfo(T); diff --git a/zml/tensor.zig b/zml/tensor.zig index ee084835..53c4ffe7 100644 --- a/zml/tensor.zig +++ b/zml/tensor.zig @@ -1,17 +1,17 @@ const std = @import("std"); const builtin = @import("builtin"); +const constants = @import("zml/constants"); +const meta = @import("zml/meta"); const mlir = @import("mlir"); const shardy = @import("mlir/dialects/shardy"); const stablehlo = @import("mlir/dialects/stablehlo"); const stdx = @import("stdx"); const Compiler = @import("Compiler.zig"); -const constants = @import("constants.zig"); const DataType = @import("dtype.zig").DataType; const mem = @import("mem.zig"); const Memory = @import("platform.zig").Memory; -const meta = @import("meta.zig"); const mlirx = @import("mlirx.zig"); const ops = @import("ops.zig"); const Platform = @import("platform.zig").Platform; diff --git a/zml/zml.zig b/zml/zml.zig index dafc3a0f..c6a18fa3 100644 --- a/zml/zml.zig +++ b/zml/zml.zig @@ -8,16 +8,16 @@ const std = @import("std"); pub const bazel = @import("bazel"); const c = @import("c"); +pub const constants = @import("zml/constants"); +pub const meta = @import("zml/meta"); pub const pjrt = @import("pjrt"); const runfiles = @import("runfiles"); pub const stdx = @import("stdx"); pub const tokenizer = @import("zml/tokenizer"); pub const attention = @import("attention/attention.zig"); -pub const paged_attention = @import("kernels/paged_attention/paged_attention.zig"); pub const Buffer = @import("buffer.zig").Buffer; pub const Compiler = @import("Compiler.zig"); -pub const constants = @import("constants.zig"); pub const dtype = @import("dtype.zig"); pub const Data = dtype.Data; pub const DataType = dtype.DataType; @@ -27,12 +27,12 @@ pub const FnExe = exe.FnExe; pub const floats = @import("floats.zig"); pub const io = @import("io.zig"); pub const kernel = @import("kernel/kernel.zig"); +pub const moe = @import("kernels/moe/moe.zig"); +pub const paged_attention = @import("kernels/paged_attention/paged_attention.zig"); pub const logo = @import("logo.zig"); pub const mem = @import("mem.zig"); pub const Bufferized = mem.Bufferized; -pub const meta = @import("meta.zig"); pub const mlir = @import("mlirx.zig"); -pub const moe = @import("kernels/moe/moe.zig"); pub const nn = @import("nn.zig"); pub const ops = @import("ops.zig"); pub const pjrtx = @import("pjrtx.zig"); From 7281f75e82caa72eeb09e0b99b47dc9e5c99f172 Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Fri, 13 Nov 2026 10:28:09 +0000 Subject: [PATCH 2/8] zml: introduce `zml/profiling` module --- zml/BUILD.bazel | 29 ++++++++++++++++++++++++----- zml/Compiler.zig | 2 +- zml/exe.zig | 2 +- zml/io.zig | 2 +- zml/platform.zig | 2 +- zml/profiling/profiling.zig | 2 ++ zml/zml.zig | 2 +- 7 files changed, 31 insertions(+), 10 deletions(-) create mode 100644 zml/profiling/profiling.zig diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index 5f8b93f1..b3d9a006 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -88,6 +88,29 @@ zig_library( visibility = ["//visibility:public"], ) +zig_library( + name = "profiling", + srcs = [ + "profiling/profiler.zig", + "profiling/tracer.zig", + ], + import_name = "zml/profiling", + main = "profiling/profiling.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + zigopts = ["-lc"], + deps = [ + ":profiler_options", + ":profiling_traceme_lib", + "//ffi:zig", + "//pjrt", + "//platforms", + "//stdx", + "//tools/xspace_to_perfetto:xspace_to_perfetto_lib", + "//upb", + ], +) + zig_library( name = "zml", srcs = [ @@ -117,8 +140,6 @@ zig_library( "ops/manual_computation.zig", "pjrtx.zig", "platform.zig", - "profiling/profiler.zig", - "profiling/tracer.zig", "quantization.zig", "safetensors.zig", "shape.zig", @@ -162,8 +183,7 @@ zig_library( ":constants", ":meta", ":posix", - ":profiler_options", - ":profiling_traceme_lib", + ":profiling", ":xla_compile_options_upb", ":xla_data_upb", "//bazel", @@ -188,7 +208,6 @@ zig_library( "//platforms", "//platforms/tpu:ragged_paged", "//stdx", - "//tools/xspace_to_perfetto:xspace_to_perfetto_lib", "//upb", "//vfs", "//zml/tokenizer", diff --git a/zml/Compiler.zig b/zml/Compiler.zig index 73b5057a..1bf994cc 100644 --- a/zml/Compiler.zig +++ b/zml/Compiler.zig @@ -8,6 +8,7 @@ const pjrt = @import("pjrt"); const shardy = @import("mlir/dialects/shardy"); const stablehlo = @import("mlir/dialects/stablehlo"); const stdx = @import("stdx"); +const tracer = @import("zml/profiling").tracer; const upb = @import("upb"); const zio = @import("zio"); @@ -19,7 +20,6 @@ const mlirx = @import("mlirx.zig"); const ops = @import("ops.zig"); const pjrtx = @import("pjrtx.zig"); const Platform = @import("platform.zig").Platform; -const tracer = @import("profiling/tracer.zig"); const Shape = @import("shape.zig").Shape; const Sharding = @import("Sharding.zig"); const Tensor = @import("tensor.zig").Tensor; diff --git a/zml/exe.zig b/zml/exe.zig index 93895b85..e370c708 100644 --- a/zml/exe.zig +++ b/zml/exe.zig @@ -4,12 +4,12 @@ const builtin = @import("builtin"); const meta = @import("zml/meta"); const pjrt = @import("pjrt"); const stdx = @import("stdx"); +const tracer = @import("zml/profiling").tracer; const Buffer = @import("buffer.zig").Buffer; const Compiler = @import("Compiler.zig"); const mem = @import("mem.zig"); const Platform = @import("platform.zig").Platform; -const tracer = @import("profiling/tracer.zig"); const Shape = @import("shape.zig").Shape; const Sharding = @import("Sharding.zig"); const Tensor = @import("tensor.zig").Tensor; diff --git a/zml/io.zig b/zml/io.zig index 35501213..15e6c21d 100644 --- a/zml/io.zig +++ b/zml/io.zig @@ -3,6 +3,7 @@ const std = @import("std"); const meta = @import("zml/meta"); const pjrt = @import("pjrt"); const stdx = @import("stdx"); +const tracer = @import("zml/profiling").tracer; pub const VFS = @import("vfs"); const Buffer = @import("buffer.zig").Buffer; @@ -13,7 +14,6 @@ const mem = @import("mem.zig"); const Memory = @import("platform.zig").Memory; const pjrtx = @import("pjrtx.zig"); const Platform = @import("platform.zig").Platform; -const tracer = @import("profiling/tracer.zig"); const safetensors = @import("safetensors.zig"); const Shape = @import("shape.zig").Shape; const Sharding = @import("Sharding.zig"); diff --git a/zml/platform.zig b/zml/platform.zig index 03acd864..7fb5c3d2 100644 --- a/zml/platform.zig +++ b/zml/platform.zig @@ -4,6 +4,7 @@ const builtin = @import("builtin"); const c = @import("c"); const constants = @import("zml/constants"); const pjrt = @import("pjrt"); +const profiler_ = @import("zml/profiling").profiler; const stdx = @import("stdx"); pub const Target = @import("platforms").Platform; @@ -11,7 +12,6 @@ const Exe = @import("exe.zig").Exe; const flashinfer_cutlass_contract = @import("kernels/moe/flashinfer_cutlass/contract.zig"); const flashinfer_cutlass_runtime = @import("kernels/moe/flashinfer_cutlass/runtime.zig"); const pjrtx = @import("pjrtx.zig"); -const profiler_ = @import("profiling/profiler.zig"); const Sharding = @import("Sharding.zig"); const zml = @import("zml.zig"); diff --git a/zml/profiling/profiling.zig b/zml/profiling/profiling.zig new file mode 100644 index 00000000..018f0e0c --- /dev/null +++ b/zml/profiling/profiling.zig @@ -0,0 +1,2 @@ +pub const profiler = @import("profiler.zig"); +pub const tracer = @import("tracer.zig"); diff --git a/zml/zml.zig b/zml/zml.zig index c6a18fa3..89c6e5f5 100644 --- a/zml/zml.zig +++ b/zml/zml.zig @@ -14,6 +14,7 @@ pub const pjrt = @import("pjrt"); const runfiles = @import("runfiles"); pub const stdx = @import("stdx"); pub const tokenizer = @import("zml/tokenizer"); +pub const tracer = @import("zml/profiling").tracer; pub const attention = @import("attention/attention.zig"); pub const Buffer = @import("buffer.zig").Buffer; @@ -40,7 +41,6 @@ pub const platform = @import("platform.zig"); pub const Memory = platform.Memory; pub const Platform = platform.Platform; pub const Target = platform.Target; -pub const tracer = @import("profiling/tracer.zig"); pub const quantization = @import("quantization.zig"); pub const Quantization = quantization.Quantization; pub const safetensors = @import("safetensors.zig"); From 3b5d66913a3b02262a3b206939c6af9781917824 Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Fri, 13 Nov 2026 10:37:22 +0000 Subject: [PATCH 3/8] zml: introduce `zml/core` module --- zml/BUILD.bazel | 104 ++++++++++------ zml/Sharding.zig | 2 +- zml/buffer.zig | 2 +- zml/buffer/HostAccessible.zig | 6 +- zml/core.zig | 82 +++++++++++++ zml/io.zig | 2 +- zml/kernel/fly/test.zig | 2 +- zml/kernel/metal/test.zig | 2 +- zml/kernel/tcl/test.zig | 2 +- .../flash_attention/metal/flash_attn.zig | 2 +- zml/kernels/moe/api.zig | 2 +- .../moe/flashinfer_cutlass/BUILD.bazel | 6 +- .../flashinfer_cutlass/flashinfer_cutlass.zig | 4 +- zml/kernels/moe/weights.zig | 4 +- .../paged_attention/metal/paged_attn.zig | 2 +- zml/kernels/paged_attention/options.zig | 2 +- zml/nn.zig | 2 +- zml/ops.zig | 22 ++-- zml/ops/manual_computation.zig | 6 +- zml/platform.zig | 2 +- zml/quantization.zig | 2 +- zml/tensor.zig | 72 +++++------ zml/testing.zig | 2 +- zml/zml.zig | 115 +++++++----------- 24 files changed, 272 insertions(+), 177 deletions(-) create mode 100644 zml/core.zig diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index b3d9a006..f5e8c79c 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -112,27 +112,17 @@ zig_library( ) zig_library( - name = "zml", + name = "core", srcs = [ "Compiler.zig", "Sharding.zig", - "attention/Options.zig", - "attention/attention.zig", "buffer.zig", "buffer/HostAccessible.zig", "dtype.zig", "exe.zig", "floats.zig", "io.zig", - "kernels/flash_attention/flash_attention.zig", - "kernels/flash_attention/tests.zig", - "kernels/moe/api.zig", - "kernels/moe/moe.zig", - "kernels/moe/tests.zig", - "kernels/moe/weights.zig", - "kernels/paged_attention/options.zig", - "kernels/paged_attention/paged_attention.zig", - "logo.zig", + "//zml/kernel", "mem.zig", "mlirx.zig", "nn.zig", @@ -146,8 +136,71 @@ zig_library( "slice.zig", "tensor.zig", "testing.zig", + "//zml/kernels/moe/flashinfer_cutlass:runtime_srcs", + ], + import_name = "zml/core", + main = "core.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + zigopts = [ + "-lc", + "-freference-trace=20", + ], + deps = [ + ":constants", + ":meta", + ":posix", + ":profiling", + ":xla_compile_options_upb", + ":xla_data_upb", + "//bazel", + "//dsl/cuda_tile:builder", + "//dsl/cute:builder", + "//dsl/fly:builder", + "//dsl/metal:builder", + "//dsl/mosaic_tpu:builder", + "//dsl/tcl:builder", + "//dsl/triton:builder", + "//ffi:zig", + "//mlir", + "//mlir/dialects/func", + "//mlir/dialects/mosaic_tpu", + "//mlir/dialects/shardy", + "//mlir/dialects/stablehlo", + "//pjrt", + "//platforms", + "//stdx", + "//upb", + "//vfs", + "@zio", + ] + select({ + "//platforms:neuron.enabled": [ + "//platforms/neuron:nki_kernel", + "//platforms/neuron:topology", + ], + "//conditions:default": [], + }) + select({ + "//platforms:cuda.enabled": [ + "//platforms/cuda/flashinfer_cutlass_moe", + ], + "//conditions:default": [], + }), +) + +zig_library( + name = "zml", + srcs = [ + "attention/Options.zig", + "attention/attention.zig", + "kernels/flash_attention/flash_attention.zig", + "kernels/flash_attention/tests.zig", + "kernels/moe/api.zig", + "kernels/moe/moe.zig", + "kernels/moe/tests.zig", + "kernels/moe/weights.zig", + "kernels/paged_attention/options.zig", + "kernels/paged_attention/paged_attention.zig", "zml.zig", - "//zml/kernel", "//zml/kernels/flash_attention/cute", "//zml/kernels/flash_attention/metal", "//zml/kernels/flash_attention/nki", @@ -180,43 +233,22 @@ zig_library( "-freference-trace=20", ], deps = [ - ":constants", - ":meta", - ":posix", - ":profiling", - ":xla_compile_options_upb", - ":xla_data_upb", - "//bazel", - "//dsl/cuda_tile:builder", - "//dsl/cute:builder", - "//dsl/fly:builder", - "//dsl/metal:builder", + ":core", + ":logo", "//dsl/mosaic_tpu:builder", "//dsl/tcl:builder", - "//dsl/triton:builder", - "//ffi:zig", "//mlir", - "//mlir/dialects/func", "//mlir/dialects/llvm", - "//mlir/dialects/mosaic_tpu", "//mlir/dialects/nvvm", - "//mlir/dialects/shardy", - "//mlir/dialects/stablehlo", "//mlir/dialects/ttir", "//mlir/dialects/vector", - "//pjrt", "//platforms", "//platforms/tpu:ragged_paged", "//stdx", - "//upb", - "//vfs", "//zml/tokenizer", - "@rules_zig//zig/runfiles", - "@zio", ] + select({ "//platforms:neuron.enabled": [ "//platforms/neuron:nki_kernel", - "//platforms/neuron:topology", ], "//conditions:default": [], }) + select({ diff --git a/zml/Sharding.zig b/zml/Sharding.zig index 040216bc..1f05b4df 100644 --- a/zml/Sharding.zig +++ b/zml/Sharding.zig @@ -3249,7 +3249,7 @@ test "GSPMD attributes preserve folded logical axis order" { test "GSPMD executes a reduction across a folded logical axis" { if (comptime !Target.cpu.isEnabled()) return error.SkipZigTest; - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const io = std.testing.io; const allocator = std.testing.allocator; diff --git a/zml/buffer.zig b/zml/buffer.zig index 70be7c83..81112de9 100644 --- a/zml/buffer.zig +++ b/zml/buffer.zig @@ -376,7 +376,7 @@ pub const Buffer = struct { }; test "device round-trip" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const io = std.testing.io; const allocator = std.testing.allocator; const platform = zml.testing.env(); diff --git a/zml/buffer/HostAccessible.zig b/zml/buffer/HostAccessible.zig index b3e82a9c..db17ae7b 100644 --- a/zml/buffer/HostAccessible.zig +++ b/zml/buffer/HostAccessible.zig @@ -1878,7 +1878,7 @@ fn expectDevicesReadShards(platform: *const Platform, shape_: Shape) !void { } test "HostAccessible executions read shared inputs on every device" { - const zml = @import("../zml.zig"); + const zml = @import("../core.zig"); const allocator = std.testing.allocator; const io = std.testing.io; const platform = testing.env(); @@ -2107,7 +2107,7 @@ test "HostAccessible.View copies across layouts, shards and replicas" { } test "HostAccessible await after executable donation permits the next host update" { - const zml = @import("../zml.zig"); + const zml = @import("../core.zig"); const allocator = std.testing.allocator; const io = std.testing.io; const platform = testing.env(); @@ -2159,7 +2159,7 @@ test "HostAccessible await after executable donation permits the next host updat } test "HostAccessible await follows an output that doesn't reuse the pinned allocation" { - const zml = @import("../zml.zig"); + const zml = @import("../core.zig"); const allocator = std.testing.allocator; const io = std.testing.io; const platform = testing.env(); diff --git a/zml/core.zig b/zml/core.zig new file mode 100644 index 00000000..65154db0 --- /dev/null +++ b/zml/core.zig @@ -0,0 +1,82 @@ +const std = @import("std"); + +pub const bazel = @import("bazel"); +pub const constants = @import("zml/constants"); +pub const meta = @import("zml/meta"); +pub const pjrt = @import("pjrt"); +pub const stdx = @import("stdx"); +pub const tracer = @import("zml/profiling").tracer; + +pub const Buffer = @import("buffer.zig").Buffer; +pub const Compiler = @import("Compiler.zig"); +pub const dtype = @import("dtype.zig"); +pub const Data = dtype.Data; +pub const DataType = dtype.DataType; +pub const exe = @import("exe.zig"); +pub const Exe = exe.Exe; +pub const FnExe = exe.FnExe; +pub const floats = @import("floats.zig"); +pub const io = @import("io.zig"); +pub const kernel = @import("kernel/kernel.zig"); +pub const mem = @import("mem.zig"); +pub const Bufferized = mem.Bufferized; +pub const mlir = @import("mlirx.zig"); +pub const nn = @import("nn.zig"); +pub const ops = @import("ops.zig"); +pub const pjrtx = @import("pjrtx.zig"); +pub const platform = @import("platform.zig"); +pub const Memory = platform.Memory; +pub const Platform = platform.Platform; +pub const Target = platform.Target; +pub const quantization = @import("quantization.zig"); +pub const Quantization = quantization.Quantization; +pub const safetensors = @import("safetensors.zig"); +pub const shape = @import("shape.zig"); +pub const Shape = shape.Shape; +pub const Sharding = @import("Sharding.zig"); +pub const Mesh = Sharding.Mesh; +pub const slice = @import("slice.zig"); +pub const Slice = slice.Slice; +pub const tensor = @import("tensor.zig"); +pub const Tensor = tensor.Tensor; +pub const testing = @import("testing.zig"); + +// Platform owns registration and runner lifetime until these are separated from core. +pub const flashinfer_cutlass = struct { + pub const contract = @import("kernels/moe/flashinfer_cutlass/contract.zig"); + pub const runtime = @import("kernels/moe/flashinfer_cutlass/runtime.zig"); +}; + +/// Deprecated, use `zml.Compiler` instead +pub const module = struct { + pub const CompilationContext = Compiler; + pub const CompileError = Compiler.Error; + pub const CompilationOptions = Compiler.Options; + + /// Deprecated, use `platform.compileFn` or `zml.Compiler.compile` + pub fn compile( + allocator: std.mem.Allocator, + io_: std.Io, + comptime func: anytype, + args: std.meta.ArgsTuple(@TypeOf(func)), + platform_: *const Platform, + opts: Compiler.Options, + ) Compiler.Error!Exe { + return Compiler.compile(allocator, io_, platform_, func, args, opts); + } +}; + +test "core" { + std.testing.refAllDecls(@This()); +} + +pub const KiB = 1024; +pub const MiB = 1024 * KiB; +pub const GiB = 1024 * MiB; +pub const TiB = 1024 * GiB; + +comptime { + // Forces zig to compile `@zml//bazel` module even when users don't depend on it even indirectly. + // Otherwise exported functions declared in `bazel` aren't compiled. + std.testing.refAllDecls(bazel); +} diff --git a/zml/io.zig b/zml/io.zig index 15e6c21d..93829541 100644 --- a/zml/io.zig +++ b/zml/io.zig @@ -7,7 +7,7 @@ const tracer = @import("zml/profiling").tracer; pub const VFS = @import("vfs"); const Buffer = @import("buffer.zig").Buffer; -const Bufferized = @import("zml.zig").Bufferized; +const Bufferized = @import("core.zig").Bufferized; const CreateOptions = @import("platform.zig").CreateOptions; const Exe = @import("exe.zig").Exe; const mem = @import("mem.zig"); diff --git a/zml/kernel/fly/test.zig b/zml/kernel/fly/test.zig index ae788d96..6b77ad3e 100644 --- a/zml/kernel/fly/test.zig +++ b/zml/kernel/fly/test.zig @@ -3,7 +3,7 @@ const std = @import("std"); const fly_builder = @import("dsl/fly/builder"); const fly = @import("fly.zig"); -const zml = @import("../../zml.zig"); +const zml = @import("../../core.zig"); /// C = A + B over (M, N) f32, 128-bit vectorized and predicated on the /// ragged edge. diff --git a/zml/kernel/metal/test.zig b/zml/kernel/metal/test.zig index 0a342af0..a184869c 100644 --- a/zml/kernel/metal/test.zig +++ b/zml/kernel/metal/test.zig @@ -1,7 +1,7 @@ const std = @import("std"); const metal = @import("metal.zig"); -const zml = @import("../../zml.zig"); +const zml = @import("../../core.zig"); /// `out[i] = a[i] * scale + b[i]` over `n` floats. const MetalAxpy = struct { diff --git a/zml/kernel/tcl/test.zig b/zml/kernel/tcl/test.zig index b9ae1875..20804b8b 100644 --- a/zml/kernel/tcl/test.zig +++ b/zml/kernel/tcl/test.zig @@ -1,6 +1,6 @@ const std = @import("std"); -const zml = @import("../../zml.zig"); +const zml = @import("../../core.zig"); const tcl = @import("tcl.zig"); /// `furiosa.tcl.examples.softmax` over f32. diff --git a/zml/kernels/flash_attention/metal/flash_attn.zig b/zml/kernels/flash_attention/metal/flash_attn.zig index de4b68da..4d584dab 100644 --- a/zml/kernels/flash_attention/metal/flash_attn.zig +++ b/zml/kernels/flash_attention/metal/flash_attn.zig @@ -4,7 +4,7 @@ const std = @import("std"); -const metal = @import("../../../kernel/kernel.zig").metal; +const metal = @import("zml/core").kernel.metal; const ArgSpec = metal.ArgSpec; const Builder = metal.Builder; diff --git a/zml/kernels/moe/api.zig b/zml/kernels/moe/api.zig index b66593c1..b11ac1d5 100644 --- a/zml/kernels/moe/api.zig +++ b/zml/kernels/moe/api.zig @@ -2,7 +2,7 @@ const std = @import("std"); const stdx = @import("stdx"); -const Tensor = @import("../../tensor.zig").Tensor; +const Tensor = @import("zml/core").Tensor; const log = std.log.scoped(.@"zml/moe"); diff --git a/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel b/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel index c9c5d9a6..d94ff51b 100644 --- a/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel +++ b/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel @@ -2,9 +2,13 @@ package(default_visibility = ["//zml:__pkg__"]) filegroup( name = "flashinfer_cutlass", + srcs = ["flashinfer_cutlass.zig"], +) + +filegroup( + name = "runtime_srcs", srcs = [ "contract.zig", - "flashinfer_cutlass.zig", "runtime.zig", ], ) diff --git a/zml/kernels/moe/flashinfer_cutlass/flashinfer_cutlass.zig b/zml/kernels/moe/flashinfer_cutlass/flashinfer_cutlass.zig index 92317c7c..715198f9 100644 --- a/zml/kernels/moe/flashinfer_cutlass/flashinfer_cutlass.zig +++ b/zml/kernels/moe/flashinfer_cutlass/flashinfer_cutlass.zig @@ -9,9 +9,9 @@ const GlobalOptions = @import("../api.zig").Options; const Activation = @import("../api.zig").Activation; const LocalRouting = @import("../api.zig").LocalRouting; const unpackedWeight = @import("../weights.zig").unpackedWeight; -const contract = @import("contract.zig"); +const contract = @import("zml/core").flashinfer_cutlass.contract; const Attributes = contract.Attributes; -const runtime = @import("runtime.zig"); +const runtime = @import("zml/core").flashinfer_cutlass.runtime; const log = std.log.scoped(.@"zml/moe/flashinfer_cutlass"); diff --git a/zml/kernels/moe/weights.zig b/zml/kernels/moe/weights.zig index 0e288856..69036523 100644 --- a/zml/kernels/moe/weights.zig +++ b/zml/kernels/moe/weights.zig @@ -1,5 +1,5 @@ -const nn = @import("../../nn.zig"); -const Tensor = @import("../../tensor.zig").Tensor; +const nn = @import("zml/core").nn; +const Tensor = @import("zml/core").Tensor; pub fn unpackedWeight(linear: nn.Linear) Tensor { const quantization = linear.quantization orelse return linear.weight; diff --git a/zml/kernels/paged_attention/metal/paged_attn.zig b/zml/kernels/paged_attention/metal/paged_attn.zig index 04f4c1ac..10a088e5 100644 --- a/zml/kernels/paged_attention/metal/paged_attn.zig +++ b/zml/kernels/paged_attention/metal/paged_attn.zig @@ -3,7 +3,7 @@ const std = @import("std"); -const metal = @import("../../../kernel/kernel.zig").metal; +const metal = @import("zml/core").kernel.metal; const ArgSpec = metal.ArgSpec; const Builder = metal.Builder; diff --git a/zml/kernels/paged_attention/options.zig b/zml/kernels/paged_attention/options.zig index 35ad4049..159da9b2 100644 --- a/zml/kernels/paged_attention/options.zig +++ b/zml/kernels/paged_attention/options.zig @@ -1,4 +1,4 @@ -const Tensor = @import("../../tensor.zig").Tensor; +const Tensor = @import("zml/core").Tensor; pub const AttentionMask = union(enum) { standard: struct { diff --git a/zml/nn.zig b/zml/nn.zig index 71474302..592efa2e 100644 --- a/zml/nn.zig +++ b/zml/nn.zig @@ -15,7 +15,7 @@ pub const Quantization = quantization.Quantization; const Shape = @import("shape.zig").Shape; const Slice = @import("slice.zig").Slice; const Tensor = @import("tensor.zig").Tensor; -const zml = @import("zml.zig"); +const zml = @import("core.zig"); const log = std.log.scoped(.@"zml/nn"); diff --git a/zml/ops.zig b/zml/ops.zig index f1b0a8bd..59f5130a 100644 --- a/zml/ops.zig +++ b/zml/ops.zig @@ -667,7 +667,7 @@ pub fn @"while"( pub const while_ = @"while"; test @"while" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const While = struct { @@ -812,7 +812,7 @@ pub fn @"if"( } test "if" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const allocator = std.testing.allocator; @@ -893,7 +893,7 @@ pub fn if2( } test if2 { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const allocator = std.testing.allocator; @@ -1107,7 +1107,7 @@ pub fn fly(inputs: anytype, outputs: anytype, opts: FlyOps) [outputs.len]Tensor } test "fly custom call, both entry ABIs" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); if (platform.target != .rocm) return error.SkipZigTest; @@ -1298,7 +1298,7 @@ pub fn neuronNki(inputs: anytype, outputs: anytype, opts: NeuronNkiOps) [outputs } test "triton" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); if (platform.target != .cuda and platform.target != .rocm and platform.target != .oneapi) return error.SkipZigTest; @@ -1617,7 +1617,7 @@ pub fn cute(inputs: anytype, outputs: anytype, opts: CuteOps) [outputs.len]Tenso } test "cute" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); if (platform.target != .cuda) return error.SkipZigTest; @@ -1682,7 +1682,7 @@ test "cute" { } test "cuda_tile" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); if (platform.target != .cuda) return error.SkipZigTest; @@ -1741,7 +1741,7 @@ test "cuda_tile" { } test "cuda_tile grid" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); if (platform.target != .cuda) return error.SkipZigTest; @@ -1808,7 +1808,7 @@ test "cuda_tile grid" { } test "cuda_tile zeroed_outputs" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); if (platform.target != .cuda) return error.SkipZigTest; @@ -2107,7 +2107,7 @@ fn scatterConfig( } test scatterConfig { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); var comp: zml.Compiler = .init(std.testing.allocator, std.testing.io, platform, .{}); @@ -2984,7 +2984,7 @@ fn customCallArgsFromPjrtCallFrame(I: type, O: type, A: type, call_frame: *pjrt. } test customCall { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const tp = zml.testing.tpMesh(); diff --git a/zml/ops/manual_computation.zig b/zml/ops/manual_computation.zig index d39ef844..68dfaccf 100644 --- a/zml/ops/manual_computation.zig +++ b/zml/ops/manual_computation.zig @@ -376,7 +376,7 @@ const gspmd = struct { }; test manualComputation { - const zml = @import("../zml.zig"); + const zml = @import("../core.zig"); const allocator = std.testing.allocator; const io = std.testing.io; const platform = zml.testing.env(); @@ -436,7 +436,7 @@ test manualComputation { } test "manualComputation composes across logical and physical meshes" { - const zml = @import("../zml.zig"); + const zml = @import("../core.zig"); if (comptime !zml.Target.cpu.isEnabled()) return error.SkipZigTest; const allocator = std.testing.allocator; const io = std.testing.io; @@ -505,7 +505,7 @@ test "manualComputation composes across logical and physical meshes" { } test "partitionSpecs preserves optional tensors and active cache variants" { - const zml = @import("../zml.zig"); + const zml = @import("../core.zig"); const Logical = Sharding.Partitioning.Logical; const Inputs = struct { layers: []const Tensor, diff --git a/zml/platform.zig b/zml/platform.zig index 7fb5c3d2..f4547988 100644 --- a/zml/platform.zig +++ b/zml/platform.zig @@ -13,7 +13,7 @@ const flashinfer_cutlass_contract = @import("kernels/moe/flashinfer_cutlass/cont const flashinfer_cutlass_runtime = @import("kernels/moe/flashinfer_cutlass/runtime.zig"); const pjrtx = @import("pjrtx.zig"); const Sharding = @import("Sharding.zig"); -const zml = @import("zml.zig"); +const zml = @import("core.zig"); const log = std.log.scoped(.zml); diff --git a/zml/quantization.zig b/zml/quantization.zig index db20619a..5c616080 100644 --- a/zml/quantization.zig +++ b/zml/quantization.zig @@ -3,7 +3,7 @@ const std = @import("std"); const stdx = @import("stdx"); -const zml = @import("zml.zig"); +const zml = @import("core.zig"); const DataType = @import("dtype.zig").DataType; const platform_mod = @import("platform.zig"); diff --git a/zml/tensor.zig b/zml/tensor.zig index 53c4ffe7..686f9683 100644 --- a/zml/tensor.zig +++ b/zml/tensor.zig @@ -322,7 +322,7 @@ pub const Tensor = struct { } test toMemory { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const io = std.testing.io; @@ -479,7 +479,7 @@ pub const Tensor = struct { } test reuseBuffer { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const io = std.testing.io; @@ -617,7 +617,7 @@ pub const Tensor = struct { } test fmod { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const inputs: [2][6]f32 = .{ .{ -3.0, -2, -1, 1, 2, 3 }, .{ 1, 2, 3, 4, 5, -5 } }; @@ -799,7 +799,7 @@ pub const Tensor = struct { } test "Tensor.fft IRFFT restores RFFT last dimension" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const rfft_input_len: i64 = 10; @@ -909,7 +909,7 @@ pub const Tensor = struct { } test uniform { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const Stats = struct { const Stats = @This(); @@ -1007,7 +1007,7 @@ pub const Tensor = struct { } test gumbel { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const Stats = struct { const Stats = @This(); @@ -1382,7 +1382,7 @@ pub const Tensor = struct { test "convert f32 -> f4e2m1" { const floats = @import("floats.zig"); - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const x_f32 = [_]f32{ 0.0, 0.5, 1, 1.5, 2, 3, 4, 6, -0.0, -0.5, -1, -1.5, -2, -3, -4, -6 }; var x_f4: [x_f32.len / 2]floats.Float4E2M1.Packed = undefined; @@ -1415,7 +1415,7 @@ pub const Tensor = struct { } test "convert f32 -> f8e3m4" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const x = [_]f32{ 1.1 / 4.0, 1.1 / 8.0, 1.1 / 16.0, 1.1 / 32.0, 1.1 / 64.0, 1.1 / 128.0 }; @@ -1446,7 +1446,7 @@ pub const Tensor = struct { } test "convert u2 -> u8" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const x_u2: [2]stdx.Packed(u2) = .{ .pack(0, 1, 2, 3), .pack(3, 2, 1, 0) }; comptime std.debug.assert(@sizeOf(@TypeOf(x_u2)) == 2); @@ -1476,7 +1476,7 @@ pub const Tensor = struct { test "convert f4e2m1 -> f32" { const floats = @import("floats.zig"); - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const x_f4_packed = [_]floats.Float4E2M1.Packed{ .fromF32(0, 0.5), .fromF32(1, 1.5), .fromF32(2, 3), .fromF32(4, 6) }; @@ -1570,7 +1570,7 @@ pub const Tensor = struct { } test dot { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); inline for (.{ @@ -1719,7 +1719,7 @@ pub const Tensor = struct { } test leakyReLU { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const input: Tensor = .init(.{2}, .f32); @@ -1757,7 +1757,7 @@ pub const Tensor = struct { } test swiglu { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const input: Tensor = .init(.{ .d = 4 }, .f32); @@ -2030,7 +2030,7 @@ pub const Tensor = struct { } test cumulativeSum { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -2338,7 +2338,7 @@ pub const Tensor = struct { } test slice { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const x: Tensor = .init(.{ 2, 5 }, .f32); @@ -2378,7 +2378,7 @@ pub const Tensor = struct { } test "dynamic slices" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -2498,7 +2498,7 @@ pub const Tensor = struct { } test repeat1d { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -2561,7 +2561,7 @@ pub const Tensor = struct { } test stutter1d { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -2684,7 +2684,7 @@ pub const Tensor = struct { } test arange { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const exe = try zml.module.compile( @@ -2770,7 +2770,7 @@ pub const Tensor = struct { } test scalar { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -3063,7 +3063,7 @@ pub const Tensor = struct { } test gather { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -3217,7 +3217,7 @@ pub const Tensor = struct { } test gatherSlices { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -3426,7 +3426,7 @@ pub const Tensor = struct { } test scatterSlices { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -3648,7 +3648,7 @@ pub const Tensor = struct { } test argMax { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const allocator = std.testing.allocator; const ArgMaxTest = struct { @@ -3720,7 +3720,7 @@ pub const Tensor = struct { } test argsort { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -3991,7 +3991,7 @@ pub const Tensor = struct { } test chunkExact { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); // Only test shapes @@ -4044,7 +4044,7 @@ pub const Tensor = struct { } test chunkAllowTrailing { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); // Only test shapes @@ -4102,7 +4102,7 @@ pub const Tensor = struct { } test split { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -4236,7 +4236,7 @@ pub const Tensor = struct { } test dynamicUpdateSlice { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); { @@ -4432,7 +4432,7 @@ pub const Tensor = struct { } test toDiagonal { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -4485,7 +4485,7 @@ pub const Tensor = struct { } test triangular { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { @@ -4663,7 +4663,7 @@ pub const Tensor = struct { } test cartesianProduct { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const x: Tensor = .init(.{6}, .i32); @@ -4741,7 +4741,7 @@ pub const Tensor = struct { } test cartesianProductStacked { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const x: Tensor = .init(.{6}, .i32); const y: Tensor = .init(.{4}, .i32); @@ -4887,7 +4887,7 @@ fn getComparisonType(ctx: *mlir.Context, dtype: DataType) *const stablehlo.Compa } test "Tensor.maxPool1d" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const MaxPool = struct { @@ -4929,7 +4929,7 @@ test "Tensor.maxPool1d" { } test "Tensor.maxPool2d" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const MaxPool = struct { @@ -5038,7 +5038,7 @@ test transposeIsJustAReshape { } test "unused tensor" { - const zml = @import("zml.zig"); + const zml = @import("core.zig"); const platform = zml.testing.env(); const Local = struct { diff --git a/zml/testing.zig b/zml/testing.zig index 5e3d6333..b2671935 100644 --- a/zml/testing.zig +++ b/zml/testing.zig @@ -6,7 +6,7 @@ const stdx = @import("stdx"); const Platform = @import("platform.zig").Platform; const Sharding = @import("Sharding.zig"); const Slice = @import("slice.zig").Slice; -const zml = @import("zml.zig"); +const zml = @import("core.zig"); const log = std.log.scoped(.@"zml/testing"); diff --git a/zml/zml.zig b/zml/zml.zig index 89c6e5f5..2649eb31 100644 --- a/zml/zml.zig +++ b/zml/zml.zig @@ -5,85 +5,62 @@ // Namespaces const std = @import("std"); +const core = @import("zml/core"); -pub const bazel = @import("bazel"); -const c = @import("c"); -pub const constants = @import("zml/constants"); -pub const meta = @import("zml/meta"); -pub const pjrt = @import("pjrt"); -const runfiles = @import("runfiles"); -pub const stdx = @import("stdx"); +pub const bazel = core.bazel; +pub const constants = core.constants; +pub const meta = core.meta; +pub const pjrt = core.pjrt; +pub const stdx = core.stdx; pub const tokenizer = @import("zml/tokenizer"); -pub const tracer = @import("zml/profiling").tracer; +pub const tracer = core.tracer; pub const attention = @import("attention/attention.zig"); -pub const Buffer = @import("buffer.zig").Buffer; -pub const Compiler = @import("Compiler.zig"); -pub const dtype = @import("dtype.zig"); -pub const Data = dtype.Data; -pub const DataType = dtype.DataType; -pub const exe = @import("exe.zig"); -pub const Exe = exe.Exe; -pub const FnExe = exe.FnExe; -pub const floats = @import("floats.zig"); -pub const io = @import("io.zig"); -pub const kernel = @import("kernel/kernel.zig"); +pub const Buffer = core.Buffer; +pub const Compiler = core.Compiler; +pub const dtype = core.dtype; +pub const Data = core.Data; +pub const DataType = core.DataType; +pub const exe = core.exe; +pub const Exe = core.Exe; +pub const FnExe = core.FnExe; +pub const floats = core.floats; +pub const io = core.io; +pub const kernel = core.kernel; pub const moe = @import("kernels/moe/moe.zig"); pub const paged_attention = @import("kernels/paged_attention/paged_attention.zig"); -pub const logo = @import("logo.zig"); -pub const mem = @import("mem.zig"); -pub const Bufferized = mem.Bufferized; -pub const mlir = @import("mlirx.zig"); -pub const nn = @import("nn.zig"); -pub const ops = @import("ops.zig"); -pub const pjrtx = @import("pjrtx.zig"); -pub const platform = @import("platform.zig"); -pub const Memory = platform.Memory; -pub const Platform = platform.Platform; -pub const Target = platform.Target; -pub const quantization = @import("quantization.zig"); -pub const Quantization = quantization.Quantization; -pub const safetensors = @import("safetensors.zig"); -pub const shape = @import("shape.zig"); -pub const Shape = shape.Shape; -pub const Sharding = @import("Sharding.zig"); -pub const Mesh = Sharding.Mesh; -pub const slice = @import("slice.zig"); -pub const Slice = slice.Slice; -pub const tensor = @import("tensor.zig"); -pub const Tensor = tensor.Tensor; -pub const testing = @import("testing.zig"); +pub const logo = @import("zml/logo"); +pub const mem = core.mem; +pub const Bufferized = core.Bufferized; +pub const mlir = core.mlir; +pub const nn = core.nn; +pub const ops = core.ops; +pub const pjrtx = core.pjrtx; +pub const platform = core.platform; +pub const Memory = core.Memory; +pub const Platform = core.Platform; +pub const Target = core.Target; +pub const quantization = core.quantization; +pub const Quantization = core.Quantization; +pub const safetensors = core.safetensors; +pub const shape = core.shape; +pub const Shape = core.Shape; +pub const Sharding = core.Sharding; +pub const Mesh = core.Mesh; +pub const slice = core.slice; +pub const Slice = core.Slice; +pub const tensor = core.tensor; +pub const Tensor = core.Tensor; +pub const testing = core.testing; /// Deprecated, use `zml.Compiler` instead -pub const module = struct { - pub const CompilationContext = Compiler; - pub const CompileError = Compiler.Error; - pub const CompilationOptions = Compiler.Options; - - /// Deprecated, use `platform.compileFn` or `zml.Compiler.compile` - pub fn compile( - allocator: std.mem.Allocator, - io_: std.Io, - comptime func: anytype, - args: std.meta.ArgsTuple(@TypeOf(func)), - platform_: *const Platform, - opts: Compiler.Options, - ) Compiler.Error!Exe { - return Compiler.compile(allocator, io_, platform_, func, args, opts); - } -}; +pub const module = core.module; test "zml" { std.testing.refAllDecls(@This()); } -pub const KiB = 1024; -pub const MiB = 1024 * KiB; -pub const GiB = 1024 * MiB; -pub const TiB = 1024 * GiB; - -comptime { - // Forces zig to compile `@zml//bazel` module even when users don't depend on it even indirectly. - // Otherwise exported functions declared in `bazel` aren't compiled. - std.testing.refAllDecls(bazel); -} +pub const KiB = core.KiB; +pub const MiB = core.MiB; +pub const GiB = core.GiB; +pub const TiB = core.TiB; From ac2cb2fd740dbe86478c1d0826b04de0ccbf6a4c Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Fri, 13 Nov 2026 10:42:33 +0000 Subject: [PATCH 4/8] zml: introduce `zml/nn` and `zml/quantization` modules --- zml/BUILD.bazel | 33 +++++++++++++++++++++++++++++++-- zml/core.zig | 3 --- zml/kernels/moe/weights.zig | 2 +- zml/nn.zig | 23 ++++++++++++----------- zml/quantization.zig | 10 +++++----- zml/zml.zig | 6 +++--- 6 files changed, 52 insertions(+), 25 deletions(-) diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index f5e8c79c..25323615 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -125,12 +125,10 @@ zig_library( "//zml/kernel", "mem.zig", "mlirx.zig", - "nn.zig", "ops.zig", "ops/manual_computation.zig", "pjrtx.zig", "platform.zig", - "quantization.zig", "safetensors.zig", "shape.zig", "slice.zig", @@ -187,6 +185,35 @@ zig_library( }), ) +zig_library( + name = "quantization", + import_name = "zml/quantization", + main = "quantization.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + ":core", + "//stdx", + ], +) + +zig_library( + name = "nn", + import_name = "zml/nn", + main = "nn.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + ":constants", + ":core", + ":meta", + ":quantization", + "//mlir", + "//mlir/dialects/stablehlo", + "//stdx", + ], +) + zig_library( name = "zml", srcs = [ @@ -235,6 +262,8 @@ zig_library( deps = [ ":core", ":logo", + ":nn", + ":quantization", "//dsl/mosaic_tpu:builder", "//dsl/tcl:builder", "//mlir", diff --git a/zml/core.zig b/zml/core.zig index 65154db0..521e4c1b 100644 --- a/zml/core.zig +++ b/zml/core.zig @@ -21,15 +21,12 @@ pub const kernel = @import("kernel/kernel.zig"); pub const mem = @import("mem.zig"); pub const Bufferized = mem.Bufferized; pub const mlir = @import("mlirx.zig"); -pub const nn = @import("nn.zig"); pub const ops = @import("ops.zig"); pub const pjrtx = @import("pjrtx.zig"); pub const platform = @import("platform.zig"); pub const Memory = platform.Memory; pub const Platform = platform.Platform; pub const Target = platform.Target; -pub const quantization = @import("quantization.zig"); -pub const Quantization = quantization.Quantization; pub const safetensors = @import("safetensors.zig"); pub const shape = @import("shape.zig"); pub const Shape = shape.Shape; diff --git a/zml/kernels/moe/weights.zig b/zml/kernels/moe/weights.zig index 69036523..fd3c9e82 100644 --- a/zml/kernels/moe/weights.zig +++ b/zml/kernels/moe/weights.zig @@ -1,4 +1,4 @@ -const nn = @import("zml/core").nn; +const nn = @import("zml/nn"); const Tensor = @import("zml/core").Tensor; pub fn unpackedWeight(linear: nn.Linear) Tensor { diff --git a/zml/nn.zig b/zml/nn.zig index 592efa2e..94347552 100644 --- a/zml/nn.zig +++ b/zml/nn.zig @@ -7,15 +7,16 @@ const mlir = @import("mlir"); const stablehlo = @import("mlir/dialects/stablehlo"); const stdx = @import("stdx"); -const DataType = @import("dtype.zig").DataType; -const mlirx = @import("mlirx.zig"); -const ops = @import("ops.zig"); -const quantization = @import("quantization.zig"); +const zml = @import("zml/core"); +const quantization = @import("zml/quantization"); + +const DataType = zml.DataType; +const mlirx = zml.mlir; +const ops = zml.ops; pub const Quantization = quantization.Quantization; -const Shape = @import("shape.zig").Shape; -const Slice = @import("slice.zig").Slice; -const Tensor = @import("tensor.zig").Tensor; -const zml = @import("core.zig"); +const Shape = zml.Shape; +const Slice = zml.Slice; +const Tensor = zml.Tensor; const log = std.log.scoped(.@"zml/nn"); @@ -229,7 +230,7 @@ test "block128 scaled dot layouts" { const platform = zml.testing.env(); // FIXME: Add rocm when we have a PJRT plugin with native fp8 dot support (by the end of Sept 2026) if (platform.target != .cuda and platform.target != .furiosa) return error.SkipZigTest; - const dtype: DataType = if (platform.target == .rocm and @import("platform.zig").rocm.computeCapability(platform) == .gfx942) .f8e4m3fnuz else .f8e4m3fn; + const dtype: DataType = if (platform.target == .rocm and zml.platform.rocm.computeCapability(platform) == .gfx942) .f8e4m3fnuz else .f8e4m3fn; const Local = struct { const Outputs = struct { actual: Tensor, expected: Tensor, linear: Tensor, linear_expected: Tensor }; @@ -631,7 +632,7 @@ pub fn rope(x: Tensor, pos_idx: ?Tensor, opts: RopeOpts) Tensor { const rotary_dim: u32 = opts.scaling.partialRotaryDim(head_dim); stdx.debug.assert(rotary_dim > 0 and @mod(rotary_dim, 2) == 0, "partial rope expects a even head dim (.hd), got {d}", .{rotary_dim}); - const x_real, const x_imag, const x_pass = zml.nn.splitRealImgPass(x, opts.layout, rotary_dim); + const x_real, const x_imag, const x_pass = splitRealImgPass(x, opts.layout, rotary_dim); const inv_freq = invFreq(head_dim, opts).withTags(.{.hd}); // compute sin and cos in f32 before downcasting to x type. @@ -644,7 +645,7 @@ pub fn rope(x: Tensor, pos_idx: ?Tensor, opts: RopeOpts) Tensor { const y_real = x_real.mul(cos).sub(x_imag.mul(sin)); const y_imag = x_real.mul(sin).add(x_imag.mul(cos)); - return zml.nn.mergeRealImgPass(y_real, y_imag, x_pass, opts.layout); + return mergeRealImgPass(y_real, y_imag, x_pass, opts.layout); } pub fn splitRealImg(x: Tensor, layout: RopeOpts.Layout) [2]Tensor { diff --git a/zml/quantization.zig b/zml/quantization.zig index 5c616080..70576db5 100644 --- a/zml/quantization.zig +++ b/zml/quantization.zig @@ -3,13 +3,13 @@ const std = @import("std"); const stdx = @import("stdx"); -const zml = @import("core.zig"); +const zml = @import("zml/core"); -const DataType = @import("dtype.zig").DataType; -const platform_mod = @import("platform.zig"); +const DataType = zml.DataType; +const platform_mod = zml.platform; const Platform = platform_mod.Platform; -const Shape = @import("shape.zig").Shape; -const Tensor = @import("tensor.zig").Tensor; +const Shape = zml.Shape; +const Tensor = zml.Tensor; pub const nvfp4_block_size = 16; pub const mx_block_size = 32; diff --git a/zml/zml.zig b/zml/zml.zig index 2649eb31..2363705d 100644 --- a/zml/zml.zig +++ b/zml/zml.zig @@ -33,15 +33,15 @@ pub const logo = @import("zml/logo"); pub const mem = core.mem; pub const Bufferized = core.Bufferized; pub const mlir = core.mlir; -pub const nn = core.nn; +pub const nn = @import("zml/nn"); pub const ops = core.ops; pub const pjrtx = core.pjrtx; pub const platform = core.platform; pub const Memory = core.Memory; pub const Platform = core.Platform; pub const Target = core.Target; -pub const quantization = core.quantization; -pub const Quantization = core.Quantization; +pub const quantization = @import("zml/quantization"); +pub const Quantization = quantization.Quantization; pub const safetensors = core.safetensors; pub const shape = core.shape; pub const Shape = core.Shape; From 7915ab6e05312754efb190b8fe5fda62321c57ba Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Fri, 13 Nov 2026 12:47:53 +0000 Subject: [PATCH 5/8] zml: make modules be actual packages --- bin/zml-smi/tui/BUILD.bazel | 6 +- zml/BUILD.bazel | 224 +----------------- zml/constants/BUILD.bazel | 13 + zml/{ => constants}/constants.zig | 0 zml/core/BUILD.bazel | 101 ++++++++ zml/{ => core}/Compiler.zig | 0 zml/{ => core}/Sharding.zig | 0 zml/{ => core}/buffer.zig | 0 zml/{ => core}/buffer/HostAccessible.zig | 0 zml/{ => core}/core.zig | 4 +- zml/{ => core}/dtype.zig | 0 zml/{ => core}/exe.zig | 0 .../flashinfer_cutlass/contract.zig | 0 .../flashinfer_cutlass/runtime.zig | 2 +- zml/{ => core}/floats.zig | 0 zml/{ => core}/io.zig | 0 zml/core/kernel/BUILD.bazel | 15 ++ zml/{ => core}/kernel/cuda_tile/BUILD.bazel | 2 +- zml/{ => core}/kernel/cuda_tile/cuda_tile.zig | 0 zml/{ => core}/kernel/cuda_tile/test.zig | 0 zml/{ => core}/kernel/cute/BUILD.bazel | 2 +- zml/{ => core}/kernel/cute/cute.zig | 0 zml/{ => core}/kernel/cute/test.zig | 0 zml/{ => core}/kernel/fly/BUILD.bazel | 2 +- zml/{ => core}/kernel/fly/fly.zig | 0 zml/{ => core}/kernel/fly/test.zig | 0 zml/{ => core}/kernel/kernel.zig | 0 zml/{ => core}/kernel/metal/BUILD.bazel | 2 +- zml/{ => core}/kernel/metal/metal.zig | 0 zml/{ => core}/kernel/metal/test.zig | 0 zml/{ => core}/kernel/mosaic_tpu/BUILD.bazel | 2 +- .../kernel/mosaic_tpu/mosaic_tpu.zig | 0 zml/{ => core}/kernel/tcl/BUILD.bazel | 2 +- zml/{ => core}/kernel/tcl/tcl.zig | 0 zml/{ => core}/kernel/tcl/test.zig | 0 zml/{ => core}/kernel/triton/BUILD.bazel | 2 +- zml/{ => core}/kernel/triton/triton.zig | 0 zml/{ => core}/mem.zig | 0 zml/{ => core}/mlirx.zig | 0 zml/{ => core}/ops.zig | 0 zml/{ => core}/ops/manual_computation.zig | 0 zml/{ => core}/pjrtx.zig | 0 zml/{ => core}/platform.zig | 4 +- zml/{ => core}/posix.h | 0 zml/{ => core}/safetensors.zig | 0 zml/{ => core}/shape.zig | 0 zml/{ => core}/slice.zig | 0 zml/{ => core}/tensor.zig | 0 zml/{ => core}/testing.zig | 0 zml/kernel/BUILD.bazel | 15 -- .../moe/flashinfer_cutlass/BUILD.bazel | 8 - zml/logo/BUILD.bazel | 14 ++ zml/{ => logo}/logo.zig | 0 zml/meta/BUILD.bazel | 14 ++ zml/{ => meta}/meta.zig | 0 zml/nn/BUILD.bazel | 23 ++ zml/{ => nn}/nn.zig | 0 zml/profiling/BUILD.bazel | 77 ++++++ zml/profiling/profiling.zig | 10 + zml/quantization/BUILD.bazel | 18 ++ zml/{ => quantization}/quantization.zig | 0 61 files changed, 305 insertions(+), 257 deletions(-) create mode 100644 zml/constants/BUILD.bazel rename zml/{ => constants}/constants.zig (100%) create mode 100644 zml/core/BUILD.bazel rename zml/{ => core}/Compiler.zig (100%) rename zml/{ => core}/Sharding.zig (100%) rename zml/{ => core}/buffer.zig (100%) rename zml/{ => core}/buffer/HostAccessible.zig (100%) rename zml/{ => core}/core.zig (94%) rename zml/{ => core}/dtype.zig (100%) rename zml/{ => core}/exe.zig (100%) rename zml/{kernels/moe => core}/flashinfer_cutlass/contract.zig (100%) rename zml/{kernels/moe => core}/flashinfer_cutlass/runtime.zig (99%) rename zml/{ => core}/floats.zig (100%) rename zml/{ => core}/io.zig (100%) create mode 100644 zml/core/kernel/BUILD.bazel rename zml/{ => core}/kernel/cuda_tile/BUILD.bazel (63%) rename zml/{ => core}/kernel/cuda_tile/cuda_tile.zig (100%) rename zml/{ => core}/kernel/cuda_tile/test.zig (100%) rename zml/{ => core}/kernel/cute/BUILD.bazel (60%) rename zml/{ => core}/kernel/cute/cute.zig (100%) rename zml/{ => core}/kernel/cute/test.zig (100%) rename zml/{ => core}/kernel/fly/BUILD.bazel (60%) rename zml/{ => core}/kernel/fly/fly.zig (100%) rename zml/{ => core}/kernel/fly/test.zig (100%) rename zml/{ => core}/kernel/kernel.zig (100%) rename zml/{ => core}/kernel/metal/BUILD.bazel (61%) rename zml/{ => core}/kernel/metal/metal.zig (100%) rename zml/{ => core}/kernel/metal/test.zig (100%) rename zml/{ => core}/kernel/mosaic_tpu/BUILD.bazel (53%) rename zml/{ => core}/kernel/mosaic_tpu/mosaic_tpu.zig (100%) rename zml/{ => core}/kernel/tcl/BUILD.bazel (60%) rename zml/{ => core}/kernel/tcl/tcl.zig (100%) rename zml/{ => core}/kernel/tcl/test.zig (100%) rename zml/{ => core}/kernel/triton/BUILD.bazel (50%) rename zml/{ => core}/kernel/triton/triton.zig (100%) rename zml/{ => core}/mem.zig (100%) rename zml/{ => core}/mlirx.zig (100%) rename zml/{ => core}/ops.zig (100%) rename zml/{ => core}/ops/manual_computation.zig (100%) rename zml/{ => core}/pjrtx.zig (100%) rename zml/{ => core}/platform.zig (99%) rename zml/{ => core}/posix.h (100%) rename zml/{ => core}/safetensors.zig (100%) rename zml/{ => core}/shape.zig (100%) rename zml/{ => core}/slice.zig (100%) rename zml/{ => core}/tensor.zig (100%) rename zml/{ => core}/testing.zig (100%) delete mode 100644 zml/kernel/BUILD.bazel create mode 100644 zml/logo/BUILD.bazel rename zml/{ => logo}/logo.zig (100%) create mode 100644 zml/meta/BUILD.bazel rename zml/{ => meta}/meta.zig (100%) create mode 100644 zml/nn/BUILD.bazel rename zml/{ => nn}/nn.zig (100%) create mode 100644 zml/profiling/BUILD.bazel create mode 100644 zml/quantization/BUILD.bazel rename zml/{ => quantization}/quantization.zig (100%) diff --git a/bin/zml-smi/tui/BUILD.bazel b/bin/zml-smi/tui/BUILD.bazel index 29f4824c..1a0b7f5d 100644 --- a/bin/zml-smi/tui/BUILD.bazel +++ b/bin/zml-smi/tui/BUILD.bazel @@ -2,8 +2,6 @@ load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") zig_library( name = "tui", - import_name = "zml-smi/tui", - main = "tui.zig", srcs = [ "data.zig", "image_cache.zig", @@ -40,12 +38,14 @@ zig_library( "assets/nvidia.png", "assets/tpu.png", ], + import_name = "zml-smi/tui", + main = "tui.zig", visibility = ["//visibility:public"], deps = [ "//bazel/stamp:zig", "//bin/zml-smi/info", "//bin/zml-smi/utils:double_buffer", - "//zml:logo", + "//zml/logo", "@libvaxis//:vaxis", ] + select({ "@platforms//os:macos": ["//bin/zml-smi/platforms/macos"], diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index 25323615..53d3121d 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -1,219 +1,5 @@ -load("@com_google_protobuf//bazel:upb_c_proto_library.bzl", "upb_c_proto_library") -load("@rules_cc//cc:defs.bzl", "cc_library") load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") -upb_c_proto_library( - name = "xla_data_upb", - tags = ["manual"], - deps = ["@xla//xla:xla_data_proto"], -) - -upb_c_proto_library( - name = "xla_compile_options_upb", - tags = ["manual"], - deps = ["@xla//xla/pjrt/proto:compile_options_proto"], -) - -upb_c_proto_library( - name = "profiler_options", - tags = ["manual"], - deps = ["@tsl//tsl/profiler/protobuf:profiler_options_proto"], -) - -cc_library( - name = "posix", - hdrs = ["posix.h"], - tags = ["manual"], -) - -cc_library( - name = "profiling_traceme_lib", - srcs = ["profiling/traceme_lib.cc"], - hdrs = ["profiling/traceme.h"], - defines = select({ - "//platforms:cuda.enabled": ["ZML_RUNTIME_CUDA"], - "//conditions:default": [], - }) + select({ - "//platforms:rocm.enabled": ["ZML_RUNTIME_ROCM"], - "//conditions:default": [], - }), - linkopts = select({ - "//platforms:rocm.enabled": ["-ldl"], - "//conditions:default": [], - }), - tags = ["manual"], - visibility = ["//visibility:public"], - deps = [ - "//ffi:cc", - "@tsl//tsl/profiler/lib:traceme", - "@tsl//tsl/profiler/protobuf:xplane_proto_cc", - "@xla//xla/tsl/profiler/backends/cpu:host_tracer_utils", - "@xla//xla/tsl/profiler/backends/cpu:traceme_recorder", - "@xla//xla/tsl/profiler/convert:post_process_single_host_xplane", - "@xla//xla/tsl/profiler/utils:time_utils", - "@xla//xla/tsl/profiler/utils:xplane_utils", - ] + select({ - "//platforms:cuda.enabled": [ - "//platforms/cuda:cuda_nvtx_headers", - ], - "//conditions:default": [], - }) + select({ - "//platforms:rocm.enabled": [ - "@amdrocm-profiler-base//:roctx_headers", - ], - "//conditions:default": [], - }), -) - -zig_library( - name = "logo", - srcs = ["logo.zig"], - import_name = "zml/logo", - main = "logo.zig", - visibility = ["//visibility:public"], -) - -zig_library( - name = "meta", - import_name = "zml/meta", - main = "meta.zig", - visibility = ["//visibility:public"], - deps = ["//stdx"], -) - -zig_library( - name = "constants", - import_name = "zml/constants", - main = "constants.zig", - visibility = ["//visibility:public"], -) - -zig_library( - name = "profiling", - srcs = [ - "profiling/profiler.zig", - "profiling/tracer.zig", - ], - import_name = "zml/profiling", - main = "profiling/profiling.zig", - tags = ["manual"], - visibility = ["//visibility:public"], - zigopts = ["-lc"], - deps = [ - ":profiler_options", - ":profiling_traceme_lib", - "//ffi:zig", - "//pjrt", - "//platforms", - "//stdx", - "//tools/xspace_to_perfetto:xspace_to_perfetto_lib", - "//upb", - ], -) - -zig_library( - name = "core", - srcs = [ - "Compiler.zig", - "Sharding.zig", - "buffer.zig", - "buffer/HostAccessible.zig", - "dtype.zig", - "exe.zig", - "floats.zig", - "io.zig", - "//zml/kernel", - "mem.zig", - "mlirx.zig", - "ops.zig", - "ops/manual_computation.zig", - "pjrtx.zig", - "platform.zig", - "safetensors.zig", - "shape.zig", - "slice.zig", - "tensor.zig", - "testing.zig", - "//zml/kernels/moe/flashinfer_cutlass:runtime_srcs", - ], - import_name = "zml/core", - main = "core.zig", - tags = ["manual"], - visibility = ["//visibility:public"], - zigopts = [ - "-lc", - "-freference-trace=20", - ], - deps = [ - ":constants", - ":meta", - ":posix", - ":profiling", - ":xla_compile_options_upb", - ":xla_data_upb", - "//bazel", - "//dsl/cuda_tile:builder", - "//dsl/cute:builder", - "//dsl/fly:builder", - "//dsl/metal:builder", - "//dsl/mosaic_tpu:builder", - "//dsl/tcl:builder", - "//dsl/triton:builder", - "//ffi:zig", - "//mlir", - "//mlir/dialects/func", - "//mlir/dialects/mosaic_tpu", - "//mlir/dialects/shardy", - "//mlir/dialects/stablehlo", - "//pjrt", - "//platforms", - "//stdx", - "//upb", - "//vfs", - "@zio", - ] + select({ - "//platforms:neuron.enabled": [ - "//platforms/neuron:nki_kernel", - "//platforms/neuron:topology", - ], - "//conditions:default": [], - }) + select({ - "//platforms:cuda.enabled": [ - "//platforms/cuda/flashinfer_cutlass_moe", - ], - "//conditions:default": [], - }), -) - -zig_library( - name = "quantization", - import_name = "zml/quantization", - main = "quantization.zig", - tags = ["manual"], - visibility = ["//visibility:public"], - deps = [ - ":core", - "//stdx", - ], -) - -zig_library( - name = "nn", - import_name = "zml/nn", - main = "nn.zig", - tags = ["manual"], - visibility = ["//visibility:public"], - deps = [ - ":constants", - ":core", - ":meta", - ":quantization", - "//mlir", - "//mlir/dialects/stablehlo", - "//stdx", - ], -) - zig_library( name = "zml", srcs = [ @@ -260,10 +46,6 @@ zig_library( "-freference-trace=20", ], deps = [ - ":core", - ":logo", - ":nn", - ":quantization", "//dsl/mosaic_tpu:builder", "//dsl/tcl:builder", "//mlir", @@ -274,6 +56,10 @@ zig_library( "//platforms", "//platforms/tpu:ragged_paged", "//stdx", + "//zml/core", + "//zml/logo", + "//zml/nn", + "//zml/quantization", "//zml/tokenizer", ] + select({ "//platforms:neuron.enabled": [ @@ -290,5 +76,5 @@ zig_library( zig_test( name = "test", - deps = ["//zml"], + deps = [":zml"], ) diff --git a/zml/constants/BUILD.bazel b/zml/constants/BUILD.bazel new file mode 100644 index 00000000..b55a6e34 --- /dev/null +++ b/zml/constants/BUILD.bazel @@ -0,0 +1,13 @@ +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +zig_library( + name = "constants", + import_name = "zml/constants", + main = "constants.zig", + visibility = ["//visibility:public"], +) + +zig_test( + name = "test", + deps = [":constants"], +) diff --git a/zml/constants.zig b/zml/constants/constants.zig similarity index 100% rename from zml/constants.zig rename to zml/constants/constants.zig diff --git a/zml/core/BUILD.bazel b/zml/core/BUILD.bazel new file mode 100644 index 00000000..18452d0b --- /dev/null +++ b/zml/core/BUILD.bazel @@ -0,0 +1,101 @@ +load("@com_google_protobuf//bazel:upb_c_proto_library.bzl", "upb_c_proto_library") +load("@rules_cc//cc:defs.bzl", "cc_library") +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +upb_c_proto_library( + name = "xla_data_upb", + tags = ["manual"], + deps = ["@xla//xla:xla_data_proto"], +) + +upb_c_proto_library( + name = "xla_compile_options_upb", + tags = ["manual"], + deps = ["@xla//xla/pjrt/proto:compile_options_proto"], +) + +cc_library( + name = "posix", + hdrs = ["posix.h"], + tags = ["manual"], +) + +zig_library( + name = "core", + srcs = [ + "Compiler.zig", + "Sharding.zig", + "buffer.zig", + "buffer/HostAccessible.zig", + "dtype.zig", + "exe.zig", + "flashinfer_cutlass/contract.zig", + "flashinfer_cutlass/runtime.zig", + "floats.zig", + "io.zig", + "mem.zig", + "mlirx.zig", + "ops.zig", + "ops/manual_computation.zig", + "pjrtx.zig", + "platform.zig", + "safetensors.zig", + "shape.zig", + "slice.zig", + "tensor.zig", + "testing.zig", + "//zml/core/kernel", + ], + import_name = "zml/core", + main = "core.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + zigopts = [ + "-lc", + "-freference-trace=20", + ], + deps = [ + ":posix", + ":xla_compile_options_upb", + ":xla_data_upb", + "//bazel", + "//dsl/cuda_tile:builder", + "//dsl/cute:builder", + "//dsl/fly:builder", + "//dsl/metal:builder", + "//dsl/mosaic_tpu:builder", + "//dsl/tcl:builder", + "//dsl/triton:builder", + "//ffi:zig", + "//mlir", + "//mlir/dialects/func", + "//mlir/dialects/mosaic_tpu", + "//mlir/dialects/shardy", + "//mlir/dialects/stablehlo", + "//pjrt", + "//platforms", + "//stdx", + "//upb", + "//vfs", + "//zml/constants", + "//zml/meta", + "//zml/profiling", + "@zio", + ] + select({ + "//platforms:neuron.enabled": [ + "//platforms/neuron:nki_kernel", + "//platforms/neuron:topology", + ], + "//conditions:default": [], + }) + select({ + "//platforms:cuda.enabled": [ + "//platforms/cuda/flashinfer_cutlass_moe", + ], + "//conditions:default": [], + }), +) + +zig_test( + name = "test", + deps = [":core"], +) diff --git a/zml/Compiler.zig b/zml/core/Compiler.zig similarity index 100% rename from zml/Compiler.zig rename to zml/core/Compiler.zig diff --git a/zml/Sharding.zig b/zml/core/Sharding.zig similarity index 100% rename from zml/Sharding.zig rename to zml/core/Sharding.zig diff --git a/zml/buffer.zig b/zml/core/buffer.zig similarity index 100% rename from zml/buffer.zig rename to zml/core/buffer.zig diff --git a/zml/buffer/HostAccessible.zig b/zml/core/buffer/HostAccessible.zig similarity index 100% rename from zml/buffer/HostAccessible.zig rename to zml/core/buffer/HostAccessible.zig diff --git a/zml/core.zig b/zml/core/core.zig similarity index 94% rename from zml/core.zig rename to zml/core/core.zig index 521e4c1b..dfcb6388 100644 --- a/zml/core.zig +++ b/zml/core/core.zig @@ -40,8 +40,8 @@ pub const testing = @import("testing.zig"); // Platform owns registration and runner lifetime until these are separated from core. pub const flashinfer_cutlass = struct { - pub const contract = @import("kernels/moe/flashinfer_cutlass/contract.zig"); - pub const runtime = @import("kernels/moe/flashinfer_cutlass/runtime.zig"); + pub const contract = @import("flashinfer_cutlass/contract.zig"); + pub const runtime = @import("flashinfer_cutlass/runtime.zig"); }; /// Deprecated, use `zml.Compiler` instead diff --git a/zml/dtype.zig b/zml/core/dtype.zig similarity index 100% rename from zml/dtype.zig rename to zml/core/dtype.zig diff --git a/zml/exe.zig b/zml/core/exe.zig similarity index 100% rename from zml/exe.zig rename to zml/core/exe.zig diff --git a/zml/kernels/moe/flashinfer_cutlass/contract.zig b/zml/core/flashinfer_cutlass/contract.zig similarity index 100% rename from zml/kernels/moe/flashinfer_cutlass/contract.zig rename to zml/core/flashinfer_cutlass/contract.zig diff --git a/zml/kernels/moe/flashinfer_cutlass/runtime.zig b/zml/core/flashinfer_cutlass/runtime.zig similarity index 99% rename from zml/kernels/moe/flashinfer_cutlass/runtime.zig rename to zml/core/flashinfer_cutlass/runtime.zig index 028ef892..fc72f1be 100644 --- a/zml/kernels/moe/flashinfer_cutlass/runtime.zig +++ b/zml/core/flashinfer_cutlass/runtime.zig @@ -3,7 +3,7 @@ const std = @import("std"); const fi_cutlass_moe = @import("platforms/cuda/flashinfer_cutlass_moe"); const pjrt = @import("pjrt"); -const DataType = @import("../../../dtype.zig").DataType; +const DataType = @import("../dtype.zig").DataType; const contract = @import("contract.zig"); const log = std.log.scoped(.@"zml/kernels/moe/flashinfer_cutlass/runtime"); diff --git a/zml/floats.zig b/zml/core/floats.zig similarity index 100% rename from zml/floats.zig rename to zml/core/floats.zig diff --git a/zml/io.zig b/zml/core/io.zig similarity index 100% rename from zml/io.zig rename to zml/core/io.zig diff --git a/zml/core/kernel/BUILD.bazel b/zml/core/kernel/BUILD.bazel new file mode 100644 index 00000000..31638d07 --- /dev/null +++ b/zml/core/kernel/BUILD.bazel @@ -0,0 +1,15 @@ +package(default_visibility = ["//zml/core:__pkg__"]) + +filegroup( + name = "kernel", + srcs = [ + "kernel.zig", + "//zml/core/kernel/cuda_tile", + "//zml/core/kernel/cute", + "//zml/core/kernel/fly", + "//zml/core/kernel/metal", + "//zml/core/kernel/mosaic_tpu", + "//zml/core/kernel/tcl", + "//zml/core/kernel/triton", + ], +) diff --git a/zml/kernel/cuda_tile/BUILD.bazel b/zml/core/kernel/cuda_tile/BUILD.bazel similarity index 63% rename from zml/kernel/cuda_tile/BUILD.bazel rename to zml/core/kernel/cuda_tile/BUILD.bazel index 89b7977e..a3e7dc19 100644 --- a/zml/kernel/cuda_tile/BUILD.bazel +++ b/zml/core/kernel/cuda_tile/BUILD.bazel @@ -1,4 +1,4 @@ -package(default_visibility = ["//zml/kernel:__pkg__"]) +package(default_visibility = ["//zml/core/kernel:__pkg__"]) filegroup( name = "cuda_tile", diff --git a/zml/kernel/cuda_tile/cuda_tile.zig b/zml/core/kernel/cuda_tile/cuda_tile.zig similarity index 100% rename from zml/kernel/cuda_tile/cuda_tile.zig rename to zml/core/kernel/cuda_tile/cuda_tile.zig diff --git a/zml/kernel/cuda_tile/test.zig b/zml/core/kernel/cuda_tile/test.zig similarity index 100% rename from zml/kernel/cuda_tile/test.zig rename to zml/core/kernel/cuda_tile/test.zig diff --git a/zml/kernel/cute/BUILD.bazel b/zml/core/kernel/cute/BUILD.bazel similarity index 60% rename from zml/kernel/cute/BUILD.bazel rename to zml/core/kernel/cute/BUILD.bazel index 7a613072..73c8c128 100644 --- a/zml/kernel/cute/BUILD.bazel +++ b/zml/core/kernel/cute/BUILD.bazel @@ -1,4 +1,4 @@ -package(default_visibility = ["//zml/kernel:__pkg__"]) +package(default_visibility = ["//zml/core/kernel:__pkg__"]) filegroup( name = "cute", diff --git a/zml/kernel/cute/cute.zig b/zml/core/kernel/cute/cute.zig similarity index 100% rename from zml/kernel/cute/cute.zig rename to zml/core/kernel/cute/cute.zig diff --git a/zml/kernel/cute/test.zig b/zml/core/kernel/cute/test.zig similarity index 100% rename from zml/kernel/cute/test.zig rename to zml/core/kernel/cute/test.zig diff --git a/zml/kernel/fly/BUILD.bazel b/zml/core/kernel/fly/BUILD.bazel similarity index 60% rename from zml/kernel/fly/BUILD.bazel rename to zml/core/kernel/fly/BUILD.bazel index 57203521..11fea497 100644 --- a/zml/kernel/fly/BUILD.bazel +++ b/zml/core/kernel/fly/BUILD.bazel @@ -1,4 +1,4 @@ -package(default_visibility = ["//zml/kernel:__pkg__"]) +package(default_visibility = ["//zml/core/kernel:__pkg__"]) filegroup( name = "fly", diff --git a/zml/kernel/fly/fly.zig b/zml/core/kernel/fly/fly.zig similarity index 100% rename from zml/kernel/fly/fly.zig rename to zml/core/kernel/fly/fly.zig diff --git a/zml/kernel/fly/test.zig b/zml/core/kernel/fly/test.zig similarity index 100% rename from zml/kernel/fly/test.zig rename to zml/core/kernel/fly/test.zig diff --git a/zml/kernel/kernel.zig b/zml/core/kernel/kernel.zig similarity index 100% rename from zml/kernel/kernel.zig rename to zml/core/kernel/kernel.zig diff --git a/zml/kernel/metal/BUILD.bazel b/zml/core/kernel/metal/BUILD.bazel similarity index 61% rename from zml/kernel/metal/BUILD.bazel rename to zml/core/kernel/metal/BUILD.bazel index 4007beb4..d0a2d380 100644 --- a/zml/kernel/metal/BUILD.bazel +++ b/zml/core/kernel/metal/BUILD.bazel @@ -1,4 +1,4 @@ -package(default_visibility = ["//zml/kernel:__pkg__"]) +package(default_visibility = ["//zml/core/kernel:__pkg__"]) filegroup( name = "metal", diff --git a/zml/kernel/metal/metal.zig b/zml/core/kernel/metal/metal.zig similarity index 100% rename from zml/kernel/metal/metal.zig rename to zml/core/kernel/metal/metal.zig diff --git a/zml/kernel/metal/test.zig b/zml/core/kernel/metal/test.zig similarity index 100% rename from zml/kernel/metal/test.zig rename to zml/core/kernel/metal/test.zig diff --git a/zml/kernel/mosaic_tpu/BUILD.bazel b/zml/core/kernel/mosaic_tpu/BUILD.bazel similarity index 53% rename from zml/kernel/mosaic_tpu/BUILD.bazel rename to zml/core/kernel/mosaic_tpu/BUILD.bazel index ba3b6b66..ae2d346d 100644 --- a/zml/kernel/mosaic_tpu/BUILD.bazel +++ b/zml/core/kernel/mosaic_tpu/BUILD.bazel @@ -1,4 +1,4 @@ -package(default_visibility = ["//zml/kernel:__pkg__"]) +package(default_visibility = ["//zml/core/kernel:__pkg__"]) filegroup( name = "mosaic_tpu", diff --git a/zml/kernel/mosaic_tpu/mosaic_tpu.zig b/zml/core/kernel/mosaic_tpu/mosaic_tpu.zig similarity index 100% rename from zml/kernel/mosaic_tpu/mosaic_tpu.zig rename to zml/core/kernel/mosaic_tpu/mosaic_tpu.zig diff --git a/zml/kernel/tcl/BUILD.bazel b/zml/core/kernel/tcl/BUILD.bazel similarity index 60% rename from zml/kernel/tcl/BUILD.bazel rename to zml/core/kernel/tcl/BUILD.bazel index bc7a0aa2..6a1229c1 100644 --- a/zml/kernel/tcl/BUILD.bazel +++ b/zml/core/kernel/tcl/BUILD.bazel @@ -1,4 +1,4 @@ -package(default_visibility = ["//zml/kernel:__pkg__"]) +package(default_visibility = ["//zml/core/kernel:__pkg__"]) filegroup( name = "tcl", diff --git a/zml/kernel/tcl/tcl.zig b/zml/core/kernel/tcl/tcl.zig similarity index 100% rename from zml/kernel/tcl/tcl.zig rename to zml/core/kernel/tcl/tcl.zig diff --git a/zml/kernel/tcl/test.zig b/zml/core/kernel/tcl/test.zig similarity index 100% rename from zml/kernel/tcl/test.zig rename to zml/core/kernel/tcl/test.zig diff --git a/zml/kernel/triton/BUILD.bazel b/zml/core/kernel/triton/BUILD.bazel similarity index 50% rename from zml/kernel/triton/BUILD.bazel rename to zml/core/kernel/triton/BUILD.bazel index 1e992352..0eface24 100644 --- a/zml/kernel/triton/BUILD.bazel +++ b/zml/core/kernel/triton/BUILD.bazel @@ -1,4 +1,4 @@ -package(default_visibility = ["//zml/kernel:__pkg__"]) +package(default_visibility = ["//zml/core/kernel:__pkg__"]) filegroup( name = "triton", diff --git a/zml/kernel/triton/triton.zig b/zml/core/kernel/triton/triton.zig similarity index 100% rename from zml/kernel/triton/triton.zig rename to zml/core/kernel/triton/triton.zig diff --git a/zml/mem.zig b/zml/core/mem.zig similarity index 100% rename from zml/mem.zig rename to zml/core/mem.zig diff --git a/zml/mlirx.zig b/zml/core/mlirx.zig similarity index 100% rename from zml/mlirx.zig rename to zml/core/mlirx.zig diff --git a/zml/ops.zig b/zml/core/ops.zig similarity index 100% rename from zml/ops.zig rename to zml/core/ops.zig diff --git a/zml/ops/manual_computation.zig b/zml/core/ops/manual_computation.zig similarity index 100% rename from zml/ops/manual_computation.zig rename to zml/core/ops/manual_computation.zig diff --git a/zml/pjrtx.zig b/zml/core/pjrtx.zig similarity index 100% rename from zml/pjrtx.zig rename to zml/core/pjrtx.zig diff --git a/zml/platform.zig b/zml/core/platform.zig similarity index 99% rename from zml/platform.zig rename to zml/core/platform.zig index f4547988..44df3c47 100644 --- a/zml/platform.zig +++ b/zml/core/platform.zig @@ -9,8 +9,8 @@ const stdx = @import("stdx"); pub const Target = @import("platforms").Platform; const Exe = @import("exe.zig").Exe; -const flashinfer_cutlass_contract = @import("kernels/moe/flashinfer_cutlass/contract.zig"); -const flashinfer_cutlass_runtime = @import("kernels/moe/flashinfer_cutlass/runtime.zig"); +const flashinfer_cutlass_contract = @import("flashinfer_cutlass/contract.zig"); +const flashinfer_cutlass_runtime = @import("flashinfer_cutlass/runtime.zig"); const pjrtx = @import("pjrtx.zig"); const Sharding = @import("Sharding.zig"); const zml = @import("core.zig"); diff --git a/zml/posix.h b/zml/core/posix.h similarity index 100% rename from zml/posix.h rename to zml/core/posix.h diff --git a/zml/safetensors.zig b/zml/core/safetensors.zig similarity index 100% rename from zml/safetensors.zig rename to zml/core/safetensors.zig diff --git a/zml/shape.zig b/zml/core/shape.zig similarity index 100% rename from zml/shape.zig rename to zml/core/shape.zig diff --git a/zml/slice.zig b/zml/core/slice.zig similarity index 100% rename from zml/slice.zig rename to zml/core/slice.zig diff --git a/zml/tensor.zig b/zml/core/tensor.zig similarity index 100% rename from zml/tensor.zig rename to zml/core/tensor.zig diff --git a/zml/testing.zig b/zml/core/testing.zig similarity index 100% rename from zml/testing.zig rename to zml/core/testing.zig diff --git a/zml/kernel/BUILD.bazel b/zml/kernel/BUILD.bazel deleted file mode 100644 index 61ab44f8..00000000 --- a/zml/kernel/BUILD.bazel +++ /dev/null @@ -1,15 +0,0 @@ -package(default_visibility = ["//zml:__pkg__"]) - -filegroup( - name = "kernel", - srcs = [ - "kernel.zig", - "//zml/kernel/cuda_tile", - "//zml/kernel/cute", - "//zml/kernel/fly", - "//zml/kernel/metal", - "//zml/kernel/mosaic_tpu", - "//zml/kernel/tcl", - "//zml/kernel/triton", - ], -) diff --git a/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel b/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel index d94ff51b..ada90e9f 100644 --- a/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel +++ b/zml/kernels/moe/flashinfer_cutlass/BUILD.bazel @@ -4,11 +4,3 @@ filegroup( name = "flashinfer_cutlass", srcs = ["flashinfer_cutlass.zig"], ) - -filegroup( - name = "runtime_srcs", - srcs = [ - "contract.zig", - "runtime.zig", - ], -) diff --git a/zml/logo/BUILD.bazel b/zml/logo/BUILD.bazel new file mode 100644 index 00000000..1a7af734 --- /dev/null +++ b/zml/logo/BUILD.bazel @@ -0,0 +1,14 @@ +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +zig_library( + name = "logo", + srcs = ["logo.zig"], + import_name = "zml/logo", + main = "logo.zig", + visibility = ["//visibility:public"], +) + +zig_test( + name = "test", + deps = [":logo"], +) diff --git a/zml/logo.zig b/zml/logo/logo.zig similarity index 100% rename from zml/logo.zig rename to zml/logo/logo.zig diff --git a/zml/meta/BUILD.bazel b/zml/meta/BUILD.bazel new file mode 100644 index 00000000..a795993a --- /dev/null +++ b/zml/meta/BUILD.bazel @@ -0,0 +1,14 @@ +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +zig_library( + name = "meta", + import_name = "zml/meta", + main = "meta.zig", + visibility = ["//visibility:public"], + deps = ["//stdx"], +) + +zig_test( + name = "test", + deps = [":meta"], +) diff --git a/zml/meta.zig b/zml/meta/meta.zig similarity index 100% rename from zml/meta.zig rename to zml/meta/meta.zig diff --git a/zml/nn/BUILD.bazel b/zml/nn/BUILD.bazel new file mode 100644 index 00000000..4fa4c325 --- /dev/null +++ b/zml/nn/BUILD.bazel @@ -0,0 +1,23 @@ +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +zig_library( + name = "nn", + import_name = "zml/nn", + main = "nn.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + "//mlir", + "//mlir/dialects/stablehlo", + "//stdx", + "//zml/constants", + "//zml/core", + "//zml/meta", + "//zml/quantization", + ], +) + +zig_test( + name = "test", + deps = [":nn"], +) diff --git a/zml/nn.zig b/zml/nn/nn.zig similarity index 100% rename from zml/nn.zig rename to zml/nn/nn.zig diff --git a/zml/profiling/BUILD.bazel b/zml/profiling/BUILD.bazel new file mode 100644 index 00000000..86675b54 --- /dev/null +++ b/zml/profiling/BUILD.bazel @@ -0,0 +1,77 @@ +load("@com_google_protobuf//bazel:upb_c_proto_library.bzl", "upb_c_proto_library") +load("@rules_cc//cc:defs.bzl", "cc_library") +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +upb_c_proto_library( + name = "profiler_options", + tags = ["manual"], + deps = ["@tsl//tsl/profiler/protobuf:profiler_options_proto"], +) + +cc_library( + name = "profiling_traceme_lib", + srcs = ["traceme_lib.cc"], + hdrs = ["traceme.h"], + defines = select({ + "//platforms:cuda.enabled": ["ZML_RUNTIME_CUDA"], + "//conditions:default": [], + }) + select({ + "//platforms:rocm.enabled": ["ZML_RUNTIME_ROCM"], + "//conditions:default": [], + }), + linkopts = select({ + "//platforms:rocm.enabled": ["-ldl"], + "//conditions:default": [], + }), + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + "//ffi:cc", + "@tsl//tsl/profiler/lib:traceme", + "@tsl//tsl/profiler/protobuf:xplane_proto_cc", + "@xla//xla/tsl/profiler/backends/cpu:host_tracer_utils", + "@xla//xla/tsl/profiler/backends/cpu:traceme_recorder", + "@xla//xla/tsl/profiler/convert:post_process_single_host_xplane", + "@xla//xla/tsl/profiler/utils:time_utils", + "@xla//xla/tsl/profiler/utils:xplane_utils", + ] + select({ + "//platforms:cuda.enabled": [ + "//platforms/cuda:cuda_nvtx_headers", + ], + "//conditions:default": [], + }) + select({ + "//platforms:rocm.enabled": [ + "@amdrocm-profiler-base//:roctx_headers", + ], + "//conditions:default": [], + }), +) + +zig_library( + name = "profiling", + srcs = [ + "profiler.zig", + "tracer.zig", + ], + import_name = "zml/profiling", + main = "profiling.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + zigopts = ["-lc"], + deps = [ + ":profiler_options", + ":profiling_traceme_lib", + "//bazel", + "//ffi:zig", + "//pjrt", + "//platforms", + "//stdx", + "//tools/xspace_to_perfetto:xspace_to_perfetto_lib", + "//upb", + ], +) + +zig_test( + name = "test", + deps = [":profiling"], +) diff --git a/zml/profiling/profiling.zig b/zml/profiling/profiling.zig index 018f0e0c..41bf94f9 100644 --- a/zml/profiling/profiling.zig +++ b/zml/profiling/profiling.zig @@ -1,2 +1,12 @@ pub const profiler = @import("profiler.zig"); pub const tracer = @import("tracer.zig"); + +test { + @import("std").testing.refAllDecls(@This()); +} + +comptime { + // Forces zig to compile `@zml//bazel` module even when users don't depend on it even indirectly. + // Otherwise exported functions declared in `bazel` aren't compiled. + @import("std").testing.refAllDecls(@import("bazel")); +} diff --git a/zml/quantization/BUILD.bazel b/zml/quantization/BUILD.bazel new file mode 100644 index 00000000..8e0bd565 --- /dev/null +++ b/zml/quantization/BUILD.bazel @@ -0,0 +1,18 @@ +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +zig_library( + name = "quantization", + import_name = "zml/quantization", + main = "quantization.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + "//stdx", + "//zml/core", + ], +) + +zig_test( + name = "test", + deps = [":quantization"], +) diff --git a/zml/quantization.zig b/zml/quantization/quantization.zig similarity index 100% rename from zml/quantization.zig rename to zml/quantization/quantization.zig From 245813a98d55c2677137444963ef417f5524d404 Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Fri, 13 Nov 2026 12:56:06 +0000 Subject: [PATCH 6/8] zml: cleanup imports Use direct import instead of re-exporting from `zml/core` --- platforms/neuron/BUILD.bazel | 5 ++++- zml/BUILD.bazel | 5 +++++ zml/core/core.zig | 7 +------ zml/core/platform.zig | 2 +- zml/core/testing.zig | 9 +++++---- zml/zml.zig | 12 ++++++------ 6 files changed, 22 insertions(+), 18 deletions(-) diff --git a/platforms/neuron/BUILD.bazel b/platforms/neuron/BUILD.bazel index ad537191..b1f0fd30 100644 --- a/platforms/neuron/BUILD.bazel +++ b/platforms/neuron/BUILD.bazel @@ -134,7 +134,10 @@ zig_library( import_name = "platforms/neuron/nki_kernel", main = "nki_kernel.zig", tags = ["manual"], - visibility = ["//zml:__pkg__"], + visibility = [ + "//zml:__pkg__", + "//zml/core:__pkg__", + ], deps = [ ":neuron", "//bazel", diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index 53d3121d..6680fd65 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -46,6 +46,7 @@ zig_library( "-freference-trace=20", ], deps = [ + "//bazel", "//dsl/mosaic_tpu:builder", "//dsl/tcl:builder", "//mlir", @@ -53,12 +54,16 @@ zig_library( "//mlir/dialects/nvvm", "//mlir/dialects/ttir", "//mlir/dialects/vector", + "//pjrt", "//platforms", "//platforms/tpu:ragged_paged", "//stdx", + "//zml/constants", "//zml/core", "//zml/logo", + "//zml/meta", "//zml/nn", + "//zml/profiling", "//zml/quantization", "//zml/tokenizer", ] + select({ diff --git a/zml/core/core.zig b/zml/core/core.zig index dfcb6388..4ec2bea4 100644 --- a/zml/core/core.zig +++ b/zml/core/core.zig @@ -1,11 +1,6 @@ const std = @import("std"); -pub const bazel = @import("bazel"); -pub const constants = @import("zml/constants"); -pub const meta = @import("zml/meta"); -pub const pjrt = @import("pjrt"); -pub const stdx = @import("stdx"); -pub const tracer = @import("zml/profiling").tracer; +const bazel = @import("bazel"); pub const Buffer = @import("buffer.zig").Buffer; pub const Compiler = @import("Compiler.zig"); diff --git a/zml/core/platform.zig b/zml/core/platform.zig index 44df3c47..9c9b85a9 100644 --- a/zml/core/platform.zig +++ b/zml/core/platform.zig @@ -1041,7 +1041,7 @@ fn printCallbackInner(call_frame: *pjrt.ffi.CallFrame) !?*pjrt.ffi.Error { .device = device, .layout = .{ .tiled = .{ - .minor_to_major = zml.constants.minorToMajor(shape.rank()), + .minor_to_major = constants.minorToMajor(shape.rank()), .tile_dims = &.{}, .tile_dims_sizes = &.{}, }, diff --git a/zml/core/testing.zig b/zml/core/testing.zig index b2671935..c4258f56 100644 --- a/zml/core/testing.zig +++ b/zml/core/testing.zig @@ -2,6 +2,7 @@ const std = @import("std"); const builtin = @import("builtin"); const stdx = @import("stdx"); +const meta = @import("zml/meta"); const Platform = @import("platform.zig").Platform; const Sharding = @import("Sharding.zig"); @@ -366,7 +367,7 @@ pub fn expectEqualShapes(expected: zml.Shape, actual: zml.Shape) error{TestExpec } fn BufferizedWithArgs(comptime T: type) type { - return zml.meta.MapType(zml.Tensor, zml.Buffer).map(T); + return meta.MapType(zml.Tensor, zml.Buffer).map(T); } fn countWithPrefix(store: zml.io.TensorStore.View, prefix: []const u8) usize { @@ -418,7 +419,7 @@ pub fn testLayer( }; const input_name = try std.fmt.allocPrint(arena.allocator(), "{s}.in", .{name}); - const input_count = zml.meta.count(zml.Tensor, &args); + const input_count = meta.count(zml.Tensor, &args); const expected_input_count = countWithPrefix(activation_store, input_name); if (input_count != expected_input_count) { log.warn("Reference models uses {d} inputs, but implementation uses {d}", .{ expected_input_count, input_count }); @@ -426,7 +427,7 @@ pub fn testLayer( const store_input = activation_store.withPrefix(input_name); var ctx = LocalContext{ .activation_store = store_input }; - try zml.meta.visit(struct { + try meta.visit(struct { fn cb(ctx_: *LocalContext, tensor: *zml.Tensor) !void { var buffer: [256]u8 = undefined; const subkey = std.fmt.bufPrint(&buffer, "{d}", .{ctx_.index}) catch unreachable; @@ -454,7 +455,7 @@ pub fn testLayer( defer exe_results.deinit(allocator); var args_buffers = try zml.io.load(ArgsT, &args, allocator, io, platform, activation_store.store, .auto); - defer zml.meta.visit(struct { + defer meta.visit(struct { fn cb(_: void, b: *zml.Buffer) void { b.deinit(); } diff --git a/zml/zml.zig b/zml/zml.zig index 2363705d..43cb0ecc 100644 --- a/zml/zml.zig +++ b/zml/zml.zig @@ -7,13 +7,13 @@ const std = @import("std"); const core = @import("zml/core"); -pub const bazel = core.bazel; -pub const constants = core.constants; -pub const meta = core.meta; -pub const pjrt = core.pjrt; -pub const stdx = core.stdx; +pub const bazel = @import("bazel"); +pub const constants = @import("zml/constants"); +pub const meta = @import("zml/meta"); +pub const pjrt = @import("pjrt"); +pub const stdx = @import("stdx"); pub const tokenizer = @import("zml/tokenizer"); -pub const tracer = core.tracer; +pub const tracer = @import("zml/profiling").tracer; pub const attention = @import("attention/attention.zig"); pub const Buffer = core.Buffer; From 5d7a687a5586e4d744f60ad9e7b2b2c15b8b9b58 Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Fri, 13 Nov 2026 13:41:12 +0000 Subject: [PATCH 7/8] zml/kernels/flash_attention: convert to package --- platforms/neuron/BUILD.bazel | 2 +- zml/BUILD.bazel | 19 ++----------- zml/attention/attention.zig | 6 ++--- zml/attention/options/BUILD.bazel | 8 ++++++ zml/attention/{ => options}/Options.zig | 0 zml/kernels/flash_attention/BUILD.bazel | 27 +++++++++++++++++++ zml/kernels/flash_attention/cute/BUILD.bazel | 23 ++++++++++++---- .../flash_attention/cute/attention.zig | 2 +- zml/kernels/flash_attention/cute/cute.zig | 2 +- .../flash_attention/flash_attention.zig | 18 ++++++------- zml/kernels/flash_attention/metal/BUILD.bazel | 20 ++++++++++---- zml/kernels/flash_attention/metal/metal.zig | 7 ++--- zml/kernels/flash_attention/nki/BUILD.bazel | 22 ++++++++++++--- zml/kernels/flash_attention/nki/nki.zig | 8 +++--- zml/kernels/flash_attention/tests.zig | 4 +-- 15 files changed, 113 insertions(+), 55 deletions(-) create mode 100644 zml/attention/options/BUILD.bazel rename zml/attention/{ => options}/Options.zig (100%) create mode 100644 zml/kernels/flash_attention/BUILD.bazel diff --git a/platforms/neuron/BUILD.bazel b/platforms/neuron/BUILD.bazel index b1f0fd30..a4aa29db 100644 --- a/platforms/neuron/BUILD.bazel +++ b/platforms/neuron/BUILD.bazel @@ -135,8 +135,8 @@ zig_library( main = "nki_kernel.zig", tags = ["manual"], visibility = [ - "//zml:__pkg__", "//zml/core:__pkg__", + "//zml/kernels/flash_attention/nki:__pkg__", ], deps = [ ":neuron", diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index 6680fd65..ff5457e3 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -3,10 +3,7 @@ load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") zig_library( name = "zml", srcs = [ - "attention/Options.zig", "attention/attention.zig", - "kernels/flash_attention/flash_attention.zig", - "kernels/flash_attention/tests.zig", "kernels/moe/api.zig", "kernels/moe/moe.zig", "kernels/moe/tests.zig", @@ -14,9 +11,6 @@ zig_library( "kernels/paged_attention/options.zig", "kernels/paged_attention/paged_attention.zig", "zml.zig", - "//zml/kernels/flash_attention/cute", - "//zml/kernels/flash_attention/metal", - "//zml/kernels/flash_attention/nki", "//zml/kernels/moe/cute", "//zml/kernels/moe/flashinfer_cutlass", "//zml/kernels/moe/fly", @@ -32,12 +26,6 @@ zig_library( "//zml/kernels/paged_attention/tcl", "//zml/kernels/paged_attention/triton", ], - data = select({ - "//platforms:neuron.enabled": [ - "//zml/kernels/flash_attention/nki:attention_kernel", - ], - "//conditions:default": [], - }), main = "zml.zig", tags = ["manual"], visibility = ["//visibility:public"], @@ -58,8 +46,10 @@ zig_library( "//platforms", "//platforms/tpu:ragged_paged", "//stdx", + "//zml/attention/options", "//zml/constants", "//zml/core", + "//zml/kernels/flash_attention", "//zml/logo", "//zml/meta", "//zml/nn", @@ -67,11 +57,6 @@ zig_library( "//zml/quantization", "//zml/tokenizer", ] + select({ - "//platforms:neuron.enabled": [ - "//platforms/neuron:nki_kernel", - ], - "//conditions:default": [], - }) + select({ "//platforms:cuda.enabled": [ "//platforms/cuda/flashinfer_cutlass_moe", ], diff --git a/zml/attention/attention.zig b/zml/attention/attention.zig index edd9b4ca..c7829966 100644 --- a/zml/attention/attention.zig +++ b/zml/attention/attention.zig @@ -1,7 +1,9 @@ const std = @import("std"); +const flash_attention = @import("zml/kernels/flash_attention"); +pub const Options = @import("zml/attention/options"); + const zml = @import("../zml.zig"); -const flash_attention = @import("../kernels/flash_attention/flash_attention.zig"); test { std.testing.refAllDecls(@This()); @@ -93,8 +95,6 @@ pub const Metadata = union(BackendType) { } }; -pub const Options = @import("Options.zig"); - pub const Partitioning = struct { const Logical = zml.Sharding.Partitioning.Logical; diff --git a/zml/attention/options/BUILD.bazel b/zml/attention/options/BUILD.bazel new file mode 100644 index 00000000..8cb07d4a --- /dev/null +++ b/zml/attention/options/BUILD.bazel @@ -0,0 +1,8 @@ +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +zig_library( + name = "options", + import_name = "zml/attention/options", + main = "Options.zig", + visibility = ["//visibility:public"], +) diff --git a/zml/attention/Options.zig b/zml/attention/options/Options.zig similarity index 100% rename from zml/attention/Options.zig rename to zml/attention/options/Options.zig diff --git a/zml/kernels/flash_attention/BUILD.bazel b/zml/kernels/flash_attention/BUILD.bazel new file mode 100644 index 00000000..a14ad201 --- /dev/null +++ b/zml/kernels/flash_attention/BUILD.bazel @@ -0,0 +1,27 @@ +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") + +zig_library( + name = "flash_attention", + import_name = "zml/kernels/flash_attention", + main = "flash_attention.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + "//stdx", + "//zml/attention/options", + "//zml/core", + "//zml/kernels/flash_attention/cute", + "//zml/kernels/flash_attention/metal", + "//zml/kernels/flash_attention/nki", + "//zml/nn", + ], +) + +zig_test( + name = "integration_test", + main = "tests.zig", + deps = [ + ":flash_attention", + "//zml", + ], +) diff --git a/zml/kernels/flash_attention/cute/BUILD.bazel b/zml/kernels/flash_attention/cute/BUILD.bazel index b83a642e..b34e4534 100644 --- a/zml/kernels/flash_attention/cute/BUILD.bazel +++ b/zml/kernels/flash_attention/cute/BUILD.bazel @@ -1,9 +1,22 @@ -package(default_visibility = ["//zml:__pkg__"]) +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") -filegroup( +zig_library( name = "cute", - srcs = [ - "attention.zig", - "cute.zig", + srcs = ["attention.zig"], + import_name = "zml/kernels/flash_attention/cute", + main = "cute.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + "//mlir", + "//mlir/dialects/llvm", + "//mlir/dialects/vector", + "//stdx", + "//zml/core", ], ) + +zig_test( + name = "test", + deps = [":cute"], +) diff --git a/zml/kernels/flash_attention/cute/attention.zig b/zml/kernels/flash_attention/cute/attention.zig index ec0fce16..189edd54 100644 --- a/zml/kernels/flash_attention/cute/attention.zig +++ b/zml/kernels/flash_attention/cute/attention.zig @@ -3,7 +3,7 @@ const mlir = @import("mlir"); const llvm = @import("mlir/dialects/llvm"); const vector = @import("mlir/dialects/vector"); -const zml = @import("../../../zml.zig"); +const zml = @import("zml/core"); const cute = zml.kernel.cute; const B = cute.Builder; const Value = cute.Value; diff --git a/zml/kernels/flash_attention/cute/cute.zig b/zml/kernels/flash_attention/cute/cute.zig index 36e0953b..7bf1cd16 100644 --- a/zml/kernels/flash_attention/cute/cute.zig +++ b/zml/kernels/flash_attention/cute/cute.zig @@ -2,7 +2,7 @@ const std = @import("std"); const stdx = @import("stdx"); -const zml = @import("../../../zml.zig"); +const zml = @import("zml/core"); const kernel = @import("attention.zig"); test { diff --git a/zml/kernels/flash_attention/flash_attention.zig b/zml/kernels/flash_attention/flash_attention.zig index 3fb898db..883d5c40 100644 --- a/zml/kernels/flash_attention/flash_attention.zig +++ b/zml/kernels/flash_attention/flash_attention.zig @@ -1,16 +1,16 @@ const std = @import("std"); const stdx = @import("stdx"); +const nn = @import("zml/nn"); -pub const cute = @import("cute/cute.zig"); -pub const metal = @import("metal/metal.zig"); -pub const nki = @import("nki/nki.zig"); -const zml = @import("../../zml.zig"); -const Options = @import("../../attention/Options.zig"); +pub const cute = @import("zml/kernels/flash_attention/cute"); +pub const metal = @import("zml/kernels/flash_attention/metal"); +pub const nki = @import("zml/kernels/flash_attention/nki"); +const zml = @import("zml/core"); +const Options = @import("zml/attention/options"); test { std.testing.refAllDecls(@This()); - _ = @import("tests.zig"); } pub fn isAvailable(platform: *const zml.Platform) bool { @@ -129,11 +129,11 @@ pub const Metadata = union(Backend) { /// - .k is the number of keys /// - .hd is the head dimension pub fn attention(q: zml.Tensor, k: zml.Tensor, v: zml.Tensor, token_index: zml.Tensor, metadata: Metadata, parameters: Parameters, opts: Options) zml.Tensor { - zml.stdx.debug.assert(zml.Compiler.current().manual_computation_depth > 0, "Attention kernels require an explicit manualComputation boundary", .{}); + stdx.debug.assert(zml.Compiler.current().manual_computation_depth > 0, "Attention kernels require an explicit manualComputation boundary", .{}); return switch (parameters) { .cute => cute.attention(q, k, v, token_index, opts.causal), // The NKI and Metal kernels are causal only. - .nki => if (opts.causal) nki.attention(q, k, v, token_index, parameters.nki) else zml.nn.sdpa(q, k, v, .{}), - .metal => if (opts.causal) metal.attention(q, k, v, token_index, metadata.metal) else zml.nn.sdpa(q, k, v, .{}), + .nki => if (opts.causal) nki.attention(q, k, v, token_index, parameters.nki) else nn.sdpa(q, k, v, .{}), + .metal => if (opts.causal) metal.attention(q, k, v, token_index, metadata.metal) else nn.sdpa(q, k, v, .{}), }; } diff --git a/zml/kernels/flash_attention/metal/BUILD.bazel b/zml/kernels/flash_attention/metal/BUILD.bazel index f82ade45..84ab38fb 100644 --- a/zml/kernels/flash_attention/metal/BUILD.bazel +++ b/zml/kernels/flash_attention/metal/BUILD.bazel @@ -1,9 +1,19 @@ -package(default_visibility = ["//zml:__pkg__"]) +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") -filegroup( +zig_library( name = "metal", - srcs = [ - "flash_attn.zig", - "metal.zig", + srcs = ["flash_attn.zig"], + import_name = "zml/kernels/flash_attention/metal", + main = "metal.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + "//zml/core", + "//zml/nn", ], ) + +zig_test( + name = "test", + deps = [":metal"], +) diff --git a/zml/kernels/flash_attention/metal/metal.zig b/zml/kernels/flash_attention/metal/metal.zig index bdfb00c0..ee0b02d3 100644 --- a/zml/kernels/flash_attention/metal/metal.zig +++ b/zml/kernels/flash_attention/metal/metal.zig @@ -1,6 +1,7 @@ const std = @import("std"); -const zml = @import("../../../zml.zig"); +const zml = @import("zml/core"); +const nn = @import("zml/nn"); const flash_attn = @import("flash_attn.zig"); pub const Metadata = struct { @@ -28,9 +29,9 @@ pub fn attention(q: zml.Tensor, k: zml.Tensor, v: zml.Tensor, token_index: zml.T const head_dim = q.dim(.hd); if (!((dtype == .bf16 or dtype == .f16) and k.dtype() == dtype and v.dtype() == dtype and flash_attn.FaTiled.tileConfig(head_dim) != null)) { const seq_len = k.dim(.k); - const mask = zml.nn.causalAttnMask(.{ .q = seq_len, .k = seq_len }, dtype, null) + const mask = nn.causalAttnMask(.{ .q = seq_len, .k = seq_len }, dtype, null) .gatherSlices(zml.Shape.init(.{ .q = q.dim(.q) }, dtype), token_index.appendAxes(.{.coord}), .{}); - return zml.nn.sdpa(q, k, v, .{ .attn_mask = mask }); + return nn.sdpa(q, k, v, .{ .attn_mask = mask }); } const batched = q.shape().hasTag(.b) != null; diff --git a/zml/kernels/flash_attention/nki/BUILD.bazel b/zml/kernels/flash_attention/nki/BUILD.bazel index f8e4f470..60134177 100644 --- a/zml/kernels/flash_attention/nki/BUILD.bazel +++ b/zml/kernels/flash_attention/nki/BUILD.bazel @@ -1,15 +1,29 @@ load("@rules_python//python:py_binary.bzl", "py_binary") - -package(default_visibility = ["//zml:__pkg__"]) +load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") filegroup( name = "attention_kernel", srcs = ["attention.py"], ) -filegroup( +zig_library( name = "nki", - srcs = ["nki.zig"], + data = select({ + "//platforms:neuron.enabled": [":attention_kernel"], + "//conditions:default": [], + }), + import_name = "zml/kernels/flash_attention/nki", + main = "nki.zig", + tags = ["manual"], + visibility = ["//visibility:public"], + deps = [ + "//platforms", + "//stdx", + "//zml/core", + ] + select({ + "//platforms:neuron.enabled": ["//platforms/neuron:nki_kernel"], + "//conditions:default": [], + }), ) py_binary( diff --git a/zml/kernels/flash_attention/nki/nki.zig b/zml/kernels/flash_attention/nki/nki.zig index f98a545d..429cb8f3 100644 --- a/zml/kernels/flash_attention/nki/nki.zig +++ b/zml/kernels/flash_attention/nki/nki.zig @@ -1,7 +1,7 @@ const platforms = @import("platforms"); -const zml = @import("../../../zml.zig"); -const stdx = zml.stdx; +const zml = @import("zml/core"); +const stdx = @import("stdx"); const KernelSpec = struct { name: []const u8, @@ -24,14 +24,14 @@ pub const Parameters = struct { .trn1, .inf2, .trn1n, .trn2, .trn2n, .trn3 => .{ .name = "nki_attention_trn1_decode", .entrypoint = "decode", - .source_path = "zml/zml/attention/nki/attention.py", + .source_path = "zml/zml/kernels/flash_attention/nki/attention.py", }, }, .prefill_kernel = switch (compiler_target) { .trn1, .inf2, .trn1n, .trn2, .trn2n, .trn3 => .{ .name = "nki_attention_trn1_prefill", .entrypoint = "prefill", - .source_path = "zml/zml/attention/nki/attention.py", + .source_path = "zml/zml/kernels/flash_attention/nki/attention.py", }, }, }; diff --git a/zml/kernels/flash_attention/tests.zig b/zml/kernels/flash_attention/tests.zig index c3c3dca2..b86326fe 100644 --- a/zml/kernels/flash_attention/tests.zig +++ b/zml/kernels/flash_attention/tests.zig @@ -1,7 +1,7 @@ const std = @import("std"); -const zml = @import("../../zml.zig"); -const flash_attention = @import("flash_attention.zig"); +const zml = @import("zml"); +const flash_attention = @import("zml/kernels/flash_attention"); test "attention: q=1,qh=64,kh=8" { try testAttention( From 168d5e6f2f2d621dad95484350d15b77cdb22ede Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Mon, 16 Nov 2026 16:08:03 +0000 Subject: [PATCH 8/8] zml/attention: review feedback --- zml/BUILD.bazel | 4 ++-- zml/attention/BUILD.bazel | 14 ++++++++++++++ zml/attention/{options => }/Options.zig | 0 zml/attention/options/BUILD.bazel | 8 -------- zml/kernels/flash_attention/BUILD.bazel | 2 +- 5 files changed, 17 insertions(+), 11 deletions(-) create mode 100644 zml/attention/BUILD.bazel rename zml/attention/{options => }/Options.zig (100%) delete mode 100644 zml/attention/options/BUILD.bazel diff --git a/zml/BUILD.bazel b/zml/BUILD.bazel index ff5457e3..25a2ef0d 100644 --- a/zml/BUILD.bazel +++ b/zml/BUILD.bazel @@ -3,7 +3,6 @@ load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") zig_library( name = "zml", srcs = [ - "attention/attention.zig", "kernels/moe/api.zig", "kernels/moe/moe.zig", "kernels/moe/tests.zig", @@ -11,6 +10,7 @@ zig_library( "kernels/paged_attention/options.zig", "kernels/paged_attention/paged_attention.zig", "zml.zig", + "//zml/attention", "//zml/kernels/moe/cute", "//zml/kernels/moe/flashinfer_cutlass", "//zml/kernels/moe/fly", @@ -46,7 +46,7 @@ zig_library( "//platforms", "//platforms/tpu:ragged_paged", "//stdx", - "//zml/attention/options", + "//zml/attention:options", "//zml/constants", "//zml/core", "//zml/kernels/flash_attention", diff --git a/zml/attention/BUILD.bazel b/zml/attention/BUILD.bazel new file mode 100644 index 00000000..b9fbcc62 --- /dev/null +++ b/zml/attention/BUILD.bazel @@ -0,0 +1,14 @@ +load("@rules_zig//zig:defs.bzl", "zig_library") + +zig_library( + name = "options", + import_name = "zml/attention/options", + main = "Options.zig", + visibility = ["//visibility:public"], +) + +filegroup( + name = "attention", + srcs = ["attention.zig"], + visibility = ["//zml:__pkg__"], +) diff --git a/zml/attention/options/Options.zig b/zml/attention/Options.zig similarity index 100% rename from zml/attention/options/Options.zig rename to zml/attention/Options.zig diff --git a/zml/attention/options/BUILD.bazel b/zml/attention/options/BUILD.bazel deleted file mode 100644 index 8cb07d4a..00000000 --- a/zml/attention/options/BUILD.bazel +++ /dev/null @@ -1,8 +0,0 @@ -load("@rules_zig//zig:defs.bzl", "zig_library", "zig_test") - -zig_library( - name = "options", - import_name = "zml/attention/options", - main = "Options.zig", - visibility = ["//visibility:public"], -) diff --git a/zml/kernels/flash_attention/BUILD.bazel b/zml/kernels/flash_attention/BUILD.bazel index a14ad201..0a52bbb1 100644 --- a/zml/kernels/flash_attention/BUILD.bazel +++ b/zml/kernels/flash_attention/BUILD.bazel @@ -8,7 +8,7 @@ zig_library( visibility = ["//visibility:public"], deps = [ "//stdx", - "//zml/attention/options", + "//zml/attention:options", "//zml/core", "//zml/kernels/flash_attention/cute", "//zml/kernels/flash_attention/metal",