From 2f06a525fb33528b858aaeec734250e54461c89b Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Thu, 26 Sep 2024 21:22:10 +0000 Subject: [PATCH 1/2] imports: cleaned dialect related imports We were creating useless struct to reexpose `dialect.stablehlo`. --- zml/ops.zig | 4 +--- zml/pjrtx.zig | 1 + zml/tensor.zig | 4 +--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/zml/ops.zig b/zml/ops.zig index 35765cec..b324a24f 100644 --- a/zml/ops.zig +++ b/zml/ops.zig @@ -14,9 +14,7 @@ const DataType = @import("dtype.zig").DataType; const Buffer = buffer.Buffer; const EnumLiteral = @TypeOf(.enum_literal); -const dialect = struct { - const stablehlo = @import("mlir/dialects").stablehlo; -}; +const dialect = @import("mlir/dialects"); const assert = std.debug.assert; const log = std.log.scoped(.zml_tensor); diff --git a/zml/pjrtx.zig b/zml/pjrtx.zig index 96457e7f..d7d6da30 100644 --- a/zml/pjrtx.zig +++ b/zml/pjrtx.zig @@ -2,6 +2,7 @@ const builtin = @import("builtin"); const std = @import("std"); const mlir = @import("mlir"); +const dialect = @import("mlir/dialects"); const pjrt = @import("pjrt"); const dtype = @import("dtype.zig"); const meta = @import("meta.zig"); diff --git a/zml/tensor.zig b/zml/tensor.zig index 4cde57e7..2d331ce8 100644 --- a/zml/tensor.zig +++ b/zml/tensor.zig @@ -19,9 +19,7 @@ const DataType = @import("dtype.zig").DataType; const Platform = @import("platform.zig").Platform; const EnumLiteral = @TypeOf(.enum_literal); -const dialect = struct { - const stablehlo = @import("mlir/dialects").stablehlo; -}; +const dialect = @import("mlir/dialects"); const scoped_log = std.log.scoped(.zml_tensor); From 860c9526ea529bcc7fe2d29c73668d66134b868f Mon Sep 17 00:00:00 2001 From: Corentin Godeau Date: Mon, 30 Sep 2024 15:52:53 +0200 Subject: [PATCH 2/2] misc: review feedback --- zml/pjrtx.zig | 1 - 1 file changed, 1 deletion(-) diff --git a/zml/pjrtx.zig b/zml/pjrtx.zig index d7d6da30..96457e7f 100644 --- a/zml/pjrtx.zig +++ b/zml/pjrtx.zig @@ -2,7 +2,6 @@ const builtin = @import("builtin"); const std = @import("std"); const mlir = @import("mlir"); -const dialect = @import("mlir/dialects"); const pjrt = @import("pjrt"); const dtype = @import("dtype.zig"); const meta = @import("meta.zig");