From aff30e36bd392acead10883f15172fff61c65063 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sat, 24 Oct 2026 02:46:23 +0900 Subject: [PATCH] fix(svelte-query-devtools): stop defaulting the 'theme' prop to 'system' so the theme chosen in the devtools settings applies when the prop is omitted (#12313) --- .changeset/svelte-devtools-theme-preference.md | 5 +++++ packages/svelte-query-devtools/src/Devtools.svelte | 2 +- .../svelte-query-devtools/tests/Devtools.svelte.test.ts | 9 +++++++++ 3 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .changeset/svelte-devtools-theme-preference.md diff --git a/.changeset/svelte-devtools-theme-preference.md b/.changeset/svelte-devtools-theme-preference.md new file mode 100644 index 0000000000..e129061718 --- /dev/null +++ b/.changeset/svelte-devtools-theme-preference.md @@ -0,0 +1,5 @@ +--- +'@tanstack/svelte-query-devtools': patch +--- + +fix(svelte-query-devtools): stop defaulting the 'theme' prop to 'system' so the theme chosen in the devtools settings applies when the prop is omitted diff --git a/packages/svelte-query-devtools/src/Devtools.svelte b/packages/svelte-query-devtools/src/Devtools.svelte index 62bde7d0b5..a78e4caf98 100644 --- a/packages/svelte-query-devtools/src/Devtools.svelte +++ b/packages/svelte-query-devtools/src/Devtools.svelte @@ -67,7 +67,7 @@ styleNonce = undefined, shadowDOMTarget = undefined, hideDisabledQueries = false, - theme = 'system', + theme, }: DevtoolsOptions = $props() let ref: HTMLDivElement diff --git a/packages/svelte-query-devtools/tests/Devtools.svelte.test.ts b/packages/svelte-query-devtools/tests/Devtools.svelte.test.ts index c7f12a8f55..d56732e28d 100644 --- a/packages/svelte-query-devtools/tests/Devtools.svelte.test.ts +++ b/packages/svelte-query-devtools/tests/Devtools.svelte.test.ts @@ -113,6 +113,15 @@ describe('SvelteQueryDevtools', () => { expect(setThemeMock).toHaveBeenCalledWith('dark') }) + it('should forward an undefined "theme" to the devtools instance when the prop is omitted', async () => { + render(SvelteQueryDevtools, { + props: { client: queryClient }, + }) + + await vi.dynamicImportSettled() + expect(setThemeMock).toHaveBeenCalledWith(undefined) + }) + it('should forward a "position" change to the devtools instance after mount', async () => { const { rerender } = render(SvelteQueryDevtools, { props: { client: queryClient, position: 'bottom' },