From cdbe8cb00242ec00c33917ecc05ff33afb41ef5a Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Wed, 9 Sep 2026 10:54:07 +0900 Subject: [PATCH] test(svelte-query/createMutation): add tests for parallel 'mutateAsync' calls and concurrent 'mutate' calls (#11450) * test(svelte-query/createMutation): add tests for parallel 'mutateAsync' calls and concurrent 'mutate' calls * test(svelte-query/createMutation): assert rendered 'data'/'status' alongside per-call 'onSuccess' mock --- .../createMutation/ConcurrentMutate.svelte | 30 ++++++++ .../createMutation/ParallelMutateAsync.svelte | 58 +++++++++++++++ .../createMutation.svelte.test.ts | 72 +++++++++++++++++++ 3 files changed, 160 insertions(+) create mode 100644 packages/svelte-query/tests/createMutation/ConcurrentMutate.svelte create mode 100644 packages/svelte-query/tests/createMutation/ParallelMutateAsync.svelte diff --git a/packages/svelte-query/tests/createMutation/ConcurrentMutate.svelte b/packages/svelte-query/tests/createMutation/ConcurrentMutate.svelte new file mode 100644 index 0000000000..e8a4f94447 --- /dev/null +++ b/packages/svelte-query/tests/createMutation/ConcurrentMutate.svelte @@ -0,0 +1,30 @@ + + + + +
data: {mutation.data ?? 'null'}, status: {mutation.status}
diff --git a/packages/svelte-query/tests/createMutation/ParallelMutateAsync.svelte b/packages/svelte-query/tests/createMutation/ParallelMutateAsync.svelte new file mode 100644 index 0000000000..a25b15a313 --- /dev/null +++ b/packages/svelte-query/tests/createMutation/ParallelMutateAsync.svelte @@ -0,0 +1,58 @@ + + + + +
result: {result}
diff --git a/packages/svelte-query/tests/createMutation/createMutation.svelte.test.ts b/packages/svelte-query/tests/createMutation/createMutation.svelte.test.ts index 7195054194..786224272b 100644 --- a/packages/svelte-query/tests/createMutation/createMutation.svelte.test.ts +++ b/packages/svelte-query/tests/createMutation/createMutation.svelte.test.ts @@ -13,6 +13,8 @@ import SuccessContext from './SuccessContext.svelte' import InvalidateFromContext from './InvalidateFromContext.svelte' import PerCallSuccess from './PerCallSuccess.svelte' import MutationFnContext from './MutationFnContext.svelte' +import ParallelMutateAsync from './ParallelMutateAsync.svelte' +import ConcurrentMutate from './ConcurrentMutate.svelte' describe('createMutation', () => { let queryClient: QueryClient @@ -257,4 +259,74 @@ describe('createMutation', () => { expect(perCallOnSuccess).toHaveBeenCalledTimes(1) expect(perCallOnSuccess.mock.calls[0]?.[3].client).toBe(queryClient) }) + + it('should be able to run multiple mutateAsync calls in parallel with Promise.all', async () => { + const rendered = render(ParallelMutateAsync, { + props: { queryClient, strategy: 'all' }, + }) + + fireEvent.click(rendered.getByRole('button', { name: /upload all/i })) + await vi.advanceTimersByTimeAsync(11) + + expect( + rendered.getByText( + 'result: uploaded: file1, uploaded: file2, uploaded: file3', + ), + ).toBeInTheDocument() + }) + + it('should handle Promise.all rejection when one parallel mutateAsync call fails', async () => { + const rendered = render(ParallelMutateAsync, { + props: { queryClient, strategy: 'all', failOn: 'file2' }, + }) + + fireEvent.click(rendered.getByRole('button', { name: /upload all/i })) + await vi.advanceTimersByTimeAsync(11) + + expect( + rendered.getByText('result: error: upload failed'), + ).toBeInTheDocument() + }) + + it('should handle partial failure in parallel mutateAsync calls with Promise.allSettled', async () => { + const rendered = render(ParallelMutateAsync, { + props: { queryClient, strategy: 'allSettled', failOn: 'file2' }, + }) + + fireEvent.click(rendered.getByRole('button', { name: /upload all/i })) + await vi.advanceTimersByTimeAsync(11) + + expect( + rendered.getByText( + 'result: uploaded: file1, error: upload failed, uploaded: file3', + ), + ).toBeInTheDocument() + }) + + it('should only fire the per-call onSuccess for the last mutate() call', async () => { + const onSuccessPerCall = vi.fn() + + const rendered = render(ConcurrentMutate, { + props: { queryClient, onSuccessPerCall }, + }) + + expect(rendered.getByText('data: null, status: idle')).toBeInTheDocument() + + fireEvent.click(rendered.getByRole('button', { name: /mutate1/i })) + fireEvent.click(rendered.getByRole('button', { name: /mutate2/i })) + + await vi.advanceTimersByTimeAsync(11) + + expect( + rendered.getByText('data: Todo 2, status: success'), + ).toBeInTheDocument() + + expect(onSuccessPerCall).toHaveBeenCalledTimes(1) + expect(onSuccessPerCall).toHaveBeenCalledWith( + 'Todo 2', + 'Todo 2', + undefined, + expect.anything(), + ) + }) })