0
Fork 0
mirror of https://github.com/TanStack/query.git synced 2026-11-16 22:50:20 +00:00
Commit graph

79 commits

Author SHA1 Message Date
Dominik Dorfmeister 🔮
267154cf6b
chore: tsup -> tsdown (#11222)
* chore: tsup -> tsdown

* revert size-limit and fix the build instead

* fix angular and devtools build

* fix nextJs builds

* more solid related things

* fix: import order
2026-08-18 15:19:43 +02:00
Yogesh Kumar
1a779e585d
fix(scripts): make the docs link check work on Windows (#11181)
'relativeLinkExists' builds the target path with 'path.resolve', which
uses the platform separator, but then matches it against '/examples/'
and rewrites it with a regex written in forward slashes.

On Windows the resolved path uses backslashes, so neither pattern
matches. Every documentation link that points at an example is looked up
as a markdown file under 'docs/framework/<name>/examples/' instead of a
directory under 'examples/<name>/', and 'pnpm test:docs' reports 27
broken links that are fine on CI.

Normalize the separators before the two comparisons. Node accepts
forward slashes on Windows, so the resolved path stays usable.

Co-authored-by: Yogesh Kumar <webdev1@futeservices.com>
Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
2026-08-17 09:16:11 +02:00
Wonsuk Choi
ed5e1d3a87
chore(generate-docs): hide redundant TypeDoc page title heading (#11194) 2026-08-16 21:53:52 +09:00
Wonsuk Choi
63d425bdba
fix(scripts): sort 'readFile' before 'readdir' in 'generate-docs' to satisfy 'sort-imports' (#10946) 2026-06-14 22:41:31 +09:00
Gaurav
4082894509
feat: lit query adapter
* feat lit-query: add initial lit-query package

* remove internal docs from initial PR

* fix review issues

* align scripts with monorepo Nx targets and use workspace:* for query-core

* feat(lit-query): fix type inference and monorepo integration

  - Fix createQueriesController tuple type inference with recursive types
  - Add DataTag support to queryOptions
  - Fix build config and vitest custom-condition resolution
  - Fix example install scripts for standalone bootstrap

* fix(lit-query): polish package validation and examples

* ci: apply automated fixes

* lit-query: preserve provider handshake ordering in BaseController

* Update .changeset/lemon-memes-divide.md

Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>

* removing prettier config from adapter, so that global config from the monorepo is used

* removed the package local format scripts so formatting stays centralized at the monorepo root

* removing like other adapters keep build and test:build as separate targets

* Compared against the other adapters and removed the lit-query-only aliases/gates, keeping the standard Nx target names so root CI can pick them up consistently

* package:check has been removed. The CJS smoke check is still needed because lit-query publishes custom CJS output/types

* fix(lit-query): align lit examples and integration with monorepo conventions

* chore(lit-query): clean up stale package checks

* fix(lit-query): address review feedback for lit examples and lifecycle tests

* chore: fix lockfile

* fix: add customCondition

* docs(lit-query): add Lit docs and generated reference

* docs(lit-query): fix Lit docs review comment and align examples

---------

Co-authored-by: gauravchugh <gauravchugh@servicenow.com>
Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-05-08 15:18:50 +02:00
Birk Skyum
e79176a72b
ci: align publishing to router with main/-pre/-maint (#10283) 2026-03-19 22:01:19 +01:00
Dominik Dorfmeister 🔮
67cf8b60d9
ref: ts cutoff (#10253)
* ref: update typescript versions

* check for tsgo

* drop 5.2 and 5.3

* docs

* ref: fix tsup config

* ref: use built-in NoInfer

* ci: apply automated fixes

* fix tsup config

* Revert "ref: use built-in NoInfer"

This reverts commit 45d428ce71.

# Conflicts:
#	packages/preact-query/src/useQuery.ts

* ref: remove tsgo for now

* fix builds

* fix: update svelte-check

* fix: svelte-check still needs ts 5.9

* fix: knip + ts rewrite

* ci: apply automated fixes

* fix: make ts 5.9 the tscurrent version

* fix custom conditions

* fix: coderabbit comments

* fix: lockfile

* revert docs

* fix: override eslint to 8.56.1

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-03-09 08:12:35 +01:00
vedanta
8f0d834382
feat: Preact Adapter (#9935)
* initial setup -- duplicated + package.json edited

* simple preact updations

* missed a React.ReactNode

* testing grunt work (preact library + other small issues + ErrorBoundary custom implementation)

* missed a few

* Adds ErrorBoundary (from react-error-boundary, but scaled down for preact) -- fixes a lot of tests, which expect react-related functionality

* useSuspenseQueries left -- removed the useQuery.promise tests

* forgot the console logs

* useSuspenseQueries 2 resolved; tests done

* ci: apply automated fixes

* fix: example

* fix: configs should be symlinks

* fix: sync versions for npm-run-all2

* ref: re-sync runall2

* ref: go back to 5.0.0

* ref: remove changelog

* react-query -> preact-query

* remove use client directive + added the useSyncExternalStore (decoupled from compat)

* remove the react remnants

* generate docs

* typescript eslint

* docs

* vite config fix

* docs now reference react docs (most of them atleast)

* code-rabbit issues addressed

* <div/> lol

* fix: docs

* ci: apply automated fixes

* fix: lockfile

* fix: duplicated versions

* lockfile (I cooked or am I cooked)

* ci: apply automated fixes

* Making small edits to fix versioning, warnings, and lock

* unhandled error compat

* Fixing CI

* Fixed the CI errors

* ci: apply automated fixes

* Prettier format

* Update changeset for Preact Adapter feature

---------

Co-authored-by: TkDodo <office@dorfmeister.cc>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-02-10 12:02:20 +01:00
Lachlan Collins
5ad78fc4ad
docs: correct local relative links (#9947)
* docs: correct local relative links

* Update links

* Slight tweaks

* String
2025-12-05 22:39:25 +11:00
Lachlan Collins
7f4939c624
ci: sync config between projects (#9931)
* ci: update typedoc

* Remove old check
2025-11-29 19:55:40 +11:00
Lachlan Collins
b7b452e407
ci: remove @tanstack/publish-config (#9930)
* ci: remove @tanstack/publish-config

* Update imports
2025-11-29 16:22:35 +11:00
Lachlan Collins
2a15f36576
ci: introduce changesets (#9502)
* ci: introduce changesets

* Avoid using changesets/action

* Remove PR permission

* Update PR template

* Update link
2025-09-26 17:32:23 +10:00
Arnoud
e75a5f9d55
feat(angular-query): move devtools to conditional sub-paths (#9270)
* feat(angular-query-devtools): move devtools to conditional sub-paths, improves tree shaking and dependency injection

* Fix compatibility with moduleResolution node

* ci: apply automated fixes

* fix preview release for angular-query

* Fix angular-query preview release

* Revert some changes made obsolete by better Vite based alternative

* Update export paths

* Fix production exports and publishconfig

* knip config

* remove postpack

* Generate API reference docs

* type declarations in correct directory

* Update documentation

* knip config

* Optional core devtools dependency

* ci: apply automated fixes

* regenerate api reference docs

* ci: apply automated fixes

* ci: apply automated fixes (attempt 2/3)

* regenerate api reference docs

* formatting

* apply coderabbit suggestions

* Improve unit tests

* docs

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-16 00:07:53 +02:00
Lachlan Collins
3cc59be4c6
ci: add labeler script from router (#9503)
* ci: add labeler script from router

* Move to root

* Format
2025-07-26 21:46:39 +10:00
Lachlan Collins
a3f49cf17f
ci: replace fast-glob with tinyglobby (#9501)
* ci: replace fast-glob with tinyglobby

* Add back cipublish
2025-07-26 18:16:10 +10:00
Jonghyeon Ko
b766d07963
chore: update documentation generation and publishing scripts (#9296)
- Changed documentation generation script from JavaScript to TypeScript.
- Added new TypeScript script for publishing packages with configuration for different branches.
2025-06-21 13:48:19 +02:00
Jonghyeon Ko
cdab6e2b2b
ci: add link verification step to PR workflow (#9267) 2025-06-19 01:28:16 +09:00
autofix-ci[bot]
20c36c8bf3
ci: apply automated fixes 2025-05-24 06:48:59 +00:00
Tanner Linsley
afc6302dbf docs: fix links
commit 113eb6ba963534fe80b3e96193d767bf769c8bff
Author: Tanner Linsley <tannerlinsley@gmail.com>
Date:   Fri May 23 23:16:11 2025 -0600

    docs: fix: only transform generated reference

commit d1d084ed9026e31ba746e1bb87d5c19183a7d148
Author: Tanner Linsley <tannerlinsley@gmail.com>
Date:   Fri May 23 23:12:07 2025 -0600

    docs: fix broken links

commit 0df59ea7d8afb16be86ae917fc46900b6e999351
Author: Tanner Linsley <tannerlinsley@gmail.com>
Date:   Fri May 23 15:54:19 2025 -0600

    fix: rewrite type doc links to be directory-relative

commit 81e4c71f1c9250005f164b7e585837ee0ad14e23
Author: Tanner Linsley <tannerlinsley@gmail.com>
Date:   Fri May 23 15:14:51 2025 -0600

    fix: initial fix for ./ => ../
2025-05-24 00:47:55 -06:00
Omer Gronich
967c231d2a
feat(angular-query): add angular-persist-query-client
* feat(angular-query):
- Created isRestoring injection token and provider
- handled restoration phase in create-base-query.ts
- handled restoration phase in

* feat(angular-query): created package for experimental persistence support, and the withPersistQueryClient feature

* test(persistQuery): add tests for withPersistQueryClient

* docs(angular-query): add basic persister example

* fix(angular-query): synced angular versions in new package

* fix(angular-query): commit before ng update

* feat(angular-query): updated example to v18

* fix(angular-query): fixed project name to basic-persister

* feat(angular-query): updated example basic-persister to v19

* feat(angular-query): included back the persister package after angular migration

* feat(angular-query): migrate to provideEnvironmentInitializer

* fix(angular-query): fix eslint issues in inject-queries.ts

* Revert "feat(angular-query): migrate to provideEnvironmentInitializer"

This reverts commit af5b47b31511dd2db180abfd92f08541f29532d4.

* fix(angular-query): only track the isRestoring in the effect

* fix(angular-query): removed conditional _isRestoring

* ci: apply automated fixes

* fix(angular-query): used effect onCleanup instead of destroy ref

* Update examples/angular/basic-persister/.devcontainer/devcontainer.json

Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>

* Update examples/angular/basic-persister/package.json

Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>

* Update examples/angular/basic-persister/src/index.html

Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>

* Update examples/angular/basic-persister/tsconfig.json

Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>

* Update examples/angular/basic-persister/tsconfig.json

Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>

* Update examples/angular/basic-persister/tsconfig.json

Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>

* Update packages/angular-query-experimental/src/inject-is-restoring.ts

Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>

* fix(angular-query): fixed lock file

* fix(angular-query): aligned package.json versions

* added missing dep from basic-persister example

* Added a more complex example for persistence. This examples demonstrates how to selectively persist queries to different persisters.

* fix(angular-query) bumped versions to 5.62.4

* refactor(angular-query) refactored to implicit return

* fix(angular-query) bump angular persister package and examples version

* fix(angular-query) fixed eslint errors

* refactor(angular-query) set initial `isRestoring` to true to match the React adapter logic

* Revert "refactor(angular-query) set initial `isRestoring` to true to match the React adapter logic"

This reverts commit 235bbabebf.

* fix(angular-query) fixed formatting of JSDOC comment ruined by eslint

* update build configs

* zoneless unit tests

* replace deprecated injectQueryClient

* createBaseQuery is always run in injection context, remove inject(Injector)

* remove api extractor config

* update example dependencies

* comment out from publish script for now

* refactor(persist-query-client): simplify configuration by removing array structure for persistOptions

* refactor(angular-query-persist-client): removed experimental from package name and updated configurations

* fix example

* fix outdated comment

* exclude from preview for now

* mark package as private instead

* configure injectIsRestoring injector through options object

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
2025-04-13 19:42:49 +02:00
Lachlan Collins
c4afce47ed
chore: use "moduleResolution": "Bundler" at root level (#9002)
* Change to bunlder at root

* Update Next defaults

* Remove moduleResolution from packages

* Remove from scripts

* Unify moduleResolution

* ci: apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-04-12 11:03:59 +10:00
Tyler
0c229f4cf0
Revert "chore(paths): use customConditions to define internal imports… (#8973)
* Revert "chore(paths): use customConditions to define internal imports (#8935)"

This reverts commit 8e0c6b7639.

* fix export

* refactor: make test:lib depend on compile again

---------

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
2025-04-09 15:58:33 +02:00
Tyler
8e0c6b7639
chore(paths): use customConditions to define internal imports (#8935)
* fix(paths): use customConditions to define internal imports

* the rest of the changes

* publint and vitest fixes

* order matters!

thanks https://colinhacks.com/essays/live-types-typescript-monorepo

* upgrade publint to get customCondition support

added here: b34ea9433f

* remove dynamicAliases

* remove getViteAliases

* try without references?

* Revert "try without references?"

This reverts commit b18bc946e8.

---------

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
2025-04-04 21:24:15 +02:00
Dominik Dorfmeister
97f55448b8
chore: composite monorepo (#8560)
* chore: query-query, react-query and persist-core to composite setup

* fix: self contain packages by having shared configs as symlinks

* fix: add tsConfigPaths to vite config

so that tests can pick up the path aliases

* chore: set outDir, rootDir and baseUrl for all packages

* chore: make legacy tsconfig extend regular tsconfig

* fix: tsc --build

* feat: setup project references

* fix: legacy configs also need references

* fix: oops

* fix: tsup related builds

we need to turn off composite builds for tsup

* fix: set rootDir for tsup builds

so that it can include all files it needs

* fix: remove dependencies on ^build

we no longer need builds to run tests / type checks

* fix: add separate out dir for tsc

* fix: include root eslint config in globals

* refactor: create compile task to depend on

* fix: typo

* fix: dynamic alisases for vitest

* chore: try to fix knip

* fix: make compile a cacheable task

* chore: temporary disable tests against older TS versions

* fix: ts doesn't like string return types

* fix(vue-query-devtools): fix build

* fix: test types

* Revert "chore: temporary disable tests against older TS versions"

This reverts commit 10ef560eb5.

* fix: make legacy ts builds output to their own directory

* chore: remove test:types from examples as they need a build step

* chore: fix knip

* chore: remove test:types from all examples

* Revert "Revert "chore: temporary disable tests against older TS versions""

This reverts commit d6daded7da.

* fix: outputs for compile task

* chore: remove test:types from integrations

* Revert "Revert "Revert "chore: temporary disable tests against older TS versions"""

This reverts commit 79b4844785.

---------

Co-authored-by: Damian Osipiuk <osipiukd+git@gmail.com>
2025-01-27 15:58:10 +01:00
Lachlan Collins
e4e65be850
docs(typedoc): Use generateReferenceDocs function (#7765)
* docs(typedoc): Use generateReferenceDocs function

* Fix type
2024-07-19 21:20:21 +10:00
Lachlan Collins
144d3a8d90
docs(typedoc): Update output filename (#7764)
* docs: Update typedoc output filename

* Run prettier
2024-07-19 19:52:50 +10:00
Lachlan Collins
b189e3137c ci: Enable autofix on push to release branch 2024-07-19 19:06:20 +10:00
Lachlan Collins
d02e610ff3
docs(typedoc): Add frontmatter (#7753)
* docs(typedoc): Add frontmatter

* Update knip.json
2024-07-18 15:42:53 +10:00
Lachlan Collins
13817e9537
docs(svelte-query): Auto-generate reference docs (#7751)
* docs(svelte-query): Auto-generate reference docs

* Fix knip, update exclude
2024-07-18 12:40:19 +10:00
Lachlan Collins
45a21d4146
ci: simplify publish script (#7719) 2024-07-11 20:00:06 +10:00
Lachlan Collins
15e42ba445
ci: Add tests for TS 4.7, 4.8, 4.9 (#7618)
* ci: Add tests for TS 4.7, 4.8, 4.9

* Capitalise
2024-06-25 21:18:27 +10:00
Lachlan Collins
caa2916766
chore: Downgrade Nx to v17.3.1 (#6830)
Bug is impairing detection of target scripts
2024-02-04 14:00:40 +11:00
Lachlan Collins
df089941a1
chore: Fix incorrect npm tag for previous version release (#6658) 2024-01-07 08:04:49 +11:00
Lachlan Collins
8f4aa64fb1
fix: Correctly exit publish script (#6647)
* fix: Correctly exit publish script

* Remove ts-expect-error
2024-01-05 21:51:22 +11:00
Lachlan Collins
422cbed783
ci: Use publish function from @tanstack/config (#6643)
* ci: Use publish function from @tanstack/config

* Remove type-fest
2024-01-05 12:01:37 +11:00
Lachlan Collins
eb25c7b386
chore: Remove entries field from script config (#6615) 2023-12-30 14:20:14 +11:00
Lachlan Collins
1340d590a2
chore: Update to Nx v17 (#6581)
* chore: Update to Nx v17

* Fix pnpm lockfile
2023-12-23 23:24:16 +11:00
Dominik Dorfmeister
4e8a6c5acc
fix: angular release process (#6468)
RELEASE_ALL

* fix: make sure there is only one package.json after build

* fix: angular release

we cannot publish out of the build directory because pnpm doesn't see it as a workspace, so it won't replace workspace dependencies. To fix this, we:

- make the publish script point to the root directory (config.js)
- make sure our top-level package.json has types and exports and that they point to ./build
- make sure to remove the build/package.json after the build script ran

* chore: use rimraf

* chore: specify files to limit what we include

* chore: fix relative workspace dependencies

* chore: fix ci.json

* fix: package.json path
2023-12-01 16:30:04 +01:00
Arnoud
46034aada2
feat: experimental angular query adapter (#6195)
* feat(angular-query): add Angular Query

* feat(angular-query): integration test

* fix(angular-query): PR feedback on QueryClientService injection

* fix(angular-query): PR feedback

* chore(angular-query): update unit tests

* feat(angular-query): custom inject functions

* feat(angular-query): docs

* fix(angular-query): replace React context mention with Angular injector

* fix(angular-query): re-add missing angular-query-experimental package config

* feat: updated angular version

* feat: code improvements, DX improvements, fixed small doc example to use http client,

* Update docs/angular/overview.md

* version fixes

* feat: use proxy object to create single signals (computed) for query fields instead of query itself being a signal and improved types

* fix: docs

* Update packages/angular-query-experimental/src/query-proxy.ts

Co-authored-by: Chau Tran <nartc7789@gmail.com>

* Update packages/angular-query-experimental/src/query-proxy.ts

Co-authored-by: Chau Tran <nartc7789@gmail.com>

* fix: add missing import

* revert: use helper method for injectQueryClient

* Add Angular-CLI apps for testing

* fix: useValue instead of useFactory

* fix(angular-query): examples

* chore(angular-query): remove build script from angular 17 integration

* fix(angular-query): add sandbox config

* build working for angular-query-devtools-experimental

* fix(angular-query): improve development workflow

* fix(angular-query): downgrade vitest

* fix(angular-query): eslint and unit test typing fix

* fix(angular-query): test:ci fixes

* fix(angular-query): relative workspace path to build dir

* fix(angular-query): configure workspaces for top directories only

* chore(angular-query): remove dead code found by Knip

---------

Co-authored-by: Enea Jahollari <jahollarienea14@gmail.com>
Co-authored-by: Chau Tran <nartc7789@gmail.com>
Co-authored-by: Tomasz Ducin <tomasz@ducin.it>
Co-authored-by: Tomasz Ducin <tomasz.ducin@gmail.com>
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
2023-12-01 14:09:39 +01:00
Lars Kappert
5d29f8ff47
chore: introduce Knip as dead-code removal tool (#6368)
* Add knip with inital config

* Rename vite.config.js → vite.config.js (`__dirname` not in ESM scope)

* chore: upgrade to knip v3

* chore(knip): remove duplicate exports

* chore(knip): remove unused types from query devtools

* chore(knip): do not export unused types

* chore(knip): run knip in ci

* chore(knip): ignore certain .d.ts files

* chore(knip): remove unused file

* chore(knip): use devtools in next integration

so the dependency doesn't show up as unused

* chore(knip): remove unused dependencies

* chore(knip): remove unused exports

* chore(knip): add unlisted dependencies

* chore(knip): remove unnecessary scope-manager dependency

* Update knip to 3.3.0

* Update knip to 3.3.1

* chore: ignore custom deps, remove unneeded file

* chore: remove unused util

* chore: remove esbuild dep as it's not directly used

* chore: bump tsup to match esbuild types with the plugin

* chore: remove unused peer deps

* chore: remove unneeded deps

---------

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
Co-authored-by: Damian Osipiuk <osipiukd+git@gmail.com>
2023-11-29 15:58:02 +01:00
Damian Osipiuk
634b6dac32
feat(vue-query): component based vue devtools - Vue3 only (#6255) 2023-11-07 09:41:53 +01:00
Damian Osipiuk
7a9d2d080c
chore: add v4 branch to release scripts (#6247) 2023-10-26 10:17:47 +02:00
Aryan Deora
b832b0693a
feat(solid-query-devtools): Add Devtools (#6130)
* feat(solid-query-devtools): Add Devtools

Adds the devtools for @tanstack/solid-query package
2023-10-10 18:11:57 -04:00
Aadit Olkar
34ad882746
feat: Svelte implementation of client persistence (#5928)
Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com>
2023-09-13 17:46:10 +10:00
Damian Osipiuk
79632e3d2f
Merge remote-tracking branch 'origin/main' into beta 2023-09-07 11:37:32 +02:00
Aadit Olkar
f97742ef36
feat(solid-query-persist-client): Solid.js implementation of client persistence (#5858)
* added solid-query-persist-client package

* isRestoring context

* convert persistence logic to solid

* modify tests for Solid

* modify test for increased reactivity

* fix Provider

* fix jest for Solid

* add isRestoring logic

* prettier + lint

* make fixes to pass tests

* change testing to vitest

* add isRestoring check

* update test

* fix staleTime test

* add unsubscribe condition

* formatting

* update createBaseQuery to refetch after hydration

* refetch on hydration

* formatting and build test fix

* T[] -> Array<T>

* changed useQueryClient to return a signal

* keep queryClient reactive, without breaking API
2023-08-29 11:31:45 -04:00
Dominik Dorfmeister
13b17ee45d
chore(eslint): set array-type lint rule to generic (#5899)
* chore(eslint): set array-type lint rule to generic

* chore: fix prettier
2023-08-22 14:18:01 +02:00
Dominik Dorfmeister
1d3ee672d2
feat: beta release (#5771)
* release: v5.0.0-alpha.11

* refactor(core): unify hydration options (#5131)

* refactor: unify hydration options

* docs: update hydration docs

* migration guide

* refactor: use shouldDehydrate... syntax

* Update docs/react/guides/migrating-to-v5.md

Co-authored-by: Fredrik Höglund <fredrik.hoglund@gmail.com>

* Apply suggestions from code review

* chore: fix tests

* chore: fix tests

* Update docs/react/reference/hydration.md

---------

Co-authored-by: Fredrik Höglund <fredrik.hoglund@gmail.com>

* release: v5.0.0-alpha.12

* release: v5.0.0-alpha.13

* chore: remove unused devDependencies (#5211)

* refactor(react-query-devtools): move devtools components in files (#5150)

* refactor(react-query-devtools): move QueryStatusCount header to subdirectory

* refactor(react-query-devtools): move QueryRow to subdirectory

* refactor(react-query-devtools): move ActiveQuery to subdirectory

* refactor(react-query-devtools): move Cache Panel to subdirectory

* lint

* refactor: add display names

* fix: typo

* release: v5.0.0-alpha.14

* fix(solid-query): SSR fixes - Inconsistent state (#5093)

* fix(solid-query): do not call unsubscribe on the server

* fix(solid-query): prefer val from queryResource if

it is available there

* chore: add hydration debugger to solid ssr example

* bump minimum solid-js version

* chore: pnpm i

* chore: fix rollup babel typings

Result of this change upstream that types the “targets” property -> https://github.com/DefinitelyTyped/DefinitelyTyped/pull/63927/files#diff-a4da813bfdc10bbb7d4d9ee9b811309e7e2a16c0484b9a334752db84be4b0f31

Signed-off-by: marbemac <marbemac@gmail.com>

* replace void 0

Signed-off-by: marbemac <marbemac@gmail.com>

* chore: remove uncessary onMount

Signed-off-by: marbemac <marbemac@gmail.com>

* chore: skip this onComputed on first render

Signed-off-by: marbemac <marbemac@gmail.com>

* fix: copy state properties over for ssr hydration

Signed-off-by: marbemac <marbemac@gmail.com>

---------

Signed-off-by: marbemac <marbemac@gmail.com>

* release: v5.0.0-alpha.15

* fix(solid-query): Fix non hydrating queries (#5229)

* release: v5.0.0-alpha.16

* release: v5.0.0-alpha.17

* docs(react): fix typo in TypeScript.md (#5239)

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* fix: do not mutate input (#5240)

* fix: do not mutate input

params passed to function from consumers should be treated as readonly and thus shouldn't be modified

* test: remove unexpected `exact` props from find methods

---------

Co-authored-by: Damian Osipiuk <osipiukd+git@gmail.com>

* release: v5.0.0-alpha.18

* docs: update migrating-to-v5 (#5274)

I think the rocket emoji is causing a visual bug too but since I edited this through GitHub's UI, I couldn't confirm.

* fix(query-core): correct placeholderData prevData value with select fn (#5227)

* fix(query-core): correct placeholderData prevData

* fix(query-core): preserves correct prevQueryResult

This commit preserves the correct previous result between rerenders.

* test(react-query): Test with placeholder & select

* fix(query-core): Add lastDefinedQueryData property

* fix(query-core): Remove console.log

* fix(query-core): Add react-query test

* release: v5.0.0-alpha.19

* feat(solid-query): Add `reconcile` option (#5287)

* feat(solid-query): Add `reconcile` option

* feat(solid-query): Add `reconcile` callback test

* release: v5.0.0-alpha.20

* chore: adapt tests to v5 syntax after merge

* feat: remove callbacks from QueryObserver (#5282)

* feat: remove callbacks from QueryObserver

types are passing now

* test: remove some more callback related tests

* docs: migration guide for removed callbacks

* chore: fix broken lock file

* chore: remove unused variables

those were only needed on main for keepPreviousData, which doesn't exist anymore

* release: v5.0.0-alpha.21

* fix(solid-query): Remove unserializable values (#5326)

* release: v5.0.0-alpha.22

* feat: rename throwErrors to throwOnError (#5318)

* feat: rename throwErrors to throwOnError

to be aligned with the options we already have on imperative methods, like `invalidateQueries`

* docs: fix outdated code reference

* chore: rename type

* fix: let the refetchInterval function also return undefined

and fall back to false if it does

* release: v5.0.0-alpha.23

* docs: remove duplicated `isInitialLoading` (#5327)

* fix: make sure codemods are included in react-query (#5340)

* chore: fix pr pipeline (#5345)

* chore: remove unneeded script

* chore: fix syntax error after merging

* Empty-Commit

* chore: update to node18 to hopefully fix CI issues

see: https://github.com/vitest-dev/vitest/issues/1191#issuecomment-1192798501

* chore: don't throw error if build dir already exists

* release: v5.0.0-alpha.24

* feat: queryOptions helper function (#5153)

* feat: queryOptions helper function

so that we can define and share options outside of useQuery, but still get the type inference

* docs: queryOptions

* docs: remove reference to onError

* docs: update migration guide

* release: v5.0.0-alpha.25

* chore: remove createStore option (#5352)

having the option to customize the internal store sound nice, but the problem is that the store holds Query instances, not data. So, the setter is only called once, not on every data update. This makes it relatively useless - every time we thought we could leverage createStore, it fell short of our requirements because of this.

The better way is usually to subscribe to the QueryCache directly

* docs: remove callbacks from useQuery

* fix(core): make sure refetching multiple queries imperatively works offline (#5249)

* fix(core): make sure refetching multiple queries imperatively works offline

* test: add another test for different networkMode

* fix: always catch promises even if we don't return them because we are offline

* release: v5.0.0-alpha.26

* chore: svelte-query tests, validatePackages changes

* feat(devtools): Add framework agnostic devtools (#5347)

* feat(devtools): Add framework agnostic devtools draft

* Fix test

* Move query-devtools build before react-query-devtools

* Fix dimensions bug & add isInitialOpen props

* Fix isOpen state

* Add devtools cutom errorTypes option

* Add explicit close button

* Add keyboard focus for tooltips

* Add query-core to query-devtools peerDependencies

* Update pnpm lock file

* Add overflow hidden to hide filters on top view

* Revert overflow hidden - causing other issues

* Update documentation

* Fix validate-packages script

---------

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>

* fix(query-devtools): Add query-core to devDependencies (#5360)

* fix(query-devtools): Add query-core to devDependencies

* Fix pnpm-lock.yaml

* release: v5.0.0-alpha.27

* feat(solid-query): `queryOptions` helper for solid-query (#5355)

* feat: queryOptions helper for solid-query

* add tests

* fix imports

* release: v5.0.0-alpha.28

* feat(svelte-query-devtools): Svelte Adapter for new Devtools (#5362)

* Implement working devtools component

* Fix pnpm-lock.yaml

* Update workspace config

* Always a prettier error

* Fix eslint error

* Fix test:types

* Add svelte-query to deps

* Use esm-env to block loading in prod

* Remove example changes

* Simpler export

* Allow dynamically editing props

* Run prettier

* fix(devtools): Update ESM export extension (#5364)

* fix(devtools): Update ESM export extension

* Update Svelte devtools types error

* Fix svelte-query-devtools types error

* release: v5.0.0-alpha.29

* feat(devtools): Make queryclient reactive (#5366)

* release: v5.0.0-alpha.30

* Revert changes to svelte-query build

* fix(svelte-query-devtools): Fix tsconfig paths

* fix(svelte-query-devtools): Fix issue parsing JSX (#5372)

* feat(query-core): Add previousQuery to placeholderFn (#5358)

* feat(query-core): Add previousQuery to placeholderFn

* Add query-core and react-query tests

* Remove unused query type

---------

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>

* release: v5.0.0-alpha.31

* docs: Update dependent-queries.md (#5391)

I believe `isLoading` has been renamed to `isPending`

* refactor: unwrap listeners

* chore: relax eslint for tests

* release: v5.0.0-alpha.32

* docs: new docs for placeholderData

* feat(useQueries): combine (#5219)

* attempt at adding combine on observer level (doesn't work)

* feat(useQueries): combine

adapt getOptimisticResult to return both the result array and a combined result getter

* feat(useQueries): combine

make sure combinedResult stays in sync with result

* feat(vue-query): combine results for useQueries hook

* Add new options to svelte-query

* Add new options to solid-query

* fix: enable property tracking for useQueries

* fix: move property tracking to react layer

* chore: remove logging

* chore: remove unnecessary type assertion

* test: tests for combined data

* docs: combine

---------

Co-authored-by: Damian Osipiuk <osipiukd+git@gmail.com>
Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com>
Co-authored-by: Aryan Deora <adeora@iu.edu>

* docs: combine

* chore: setup fallback base to origin/main

if we trigger a release manually via github, this value might not be filled

* release: v5.0.0-alpha.34

* docs: update installation

* chore: Improve eslint/tsconfig setup in svelte packages (#5438)

* fix(types): fix TError generic on queryOptions

* release: v5.0.0-alpha.35

* release: v5.0.0-alpha.36

* chore: Bump eslint version to 8.34.0 (#5439)

* feat(svelte-query): Simplify types (#5442)

* release: v5.0.0-alpha.37

* chore: Update dev dependencies (#5466)

* chore: Replace cp with cpy-cli (#5441)

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>

* fix: Update typescript-eslint (#5467)

* release: v5.0.0-alpha.38

* chore: More package updates (#5468)

* chore: Link examples to workspace packages (#5469)

* feat(svelte-query): Switch to moduleResolution bundler (#5471)

* fix: Downgrade chalk to v4 (#5472)

* release: v5.0.0-alpha.39

* docs: change Hydrate->HydrationBoundary (#5455)

* updated docs on SSR
Hydrate -> HydrationBoundary

* docs(ssr): change Hydrate->HydrationBoundary

change Hydrate->HydrationBoundary to remove deprecated component

* docs(ssr): rename all Hydrate->HydrationBoundary

rename all Hydrate instances ->HydrationBoundary for consistency

* feat(react-query-persist-client): await onuccess (#5473)

* fix: have `onSuccess` return a promise too so that we can await it

that way, invalidation or mutations that run in onSuccess will still keep isRestoring to be false, which avoids race conditions

* test: test for awaiting onSuccess

* docs: onSuccess

* release: v5.0.0-alpha.40

* release: v5.0.0-alpha.41

* chore: Regenerate alpha lockfile (#5477)

* docs(solid-query): Fix API signature in overview.md (#5470)

* docs(svelte-query): Add svelte-query-devtools to examples (#5478)

* chore: Clean-up eslint config (#5481)

* chore: More eslint improvements (#5482)

* feat: Convert rollup config to ESM (#5484)

* chore: Migrate scripts to ESM (#5486)

* feat: Split rollup config for Nx caching (#5487)

* fix: Fix CJS/ESM issue with @commitlint/parse

I can't believe these issues still exist, see https://github.com/evanw/esbuild/issues/1719

* chore: Update prettier, eslint, rollup, scripts (#5490)

* chore: Fix prettierignore

* release: v5.0.0-alpha.42

* fix: Update @commitlint/parse (#5491)

See https://github.com/conventional-changelog/commitlint/pull/3614

* release: v5.0.0-alpha.43

* chore: Add eslint-plugin-compat (#5495)

* Fix workspace links

* Add eslint-plugin-compat

* Update nx.json

* fix: Improve workspace tsconfig (#5497)

* release: v5.0.0-alpha.44

* fix: Move deps/devDeps/peerDeps to appropriate location (#5498)

* chore: Extend base tsconfig for svelte packages (#5501)

* release: v5.0.0-alpha.45

* chore: Make test:types have no Nx output (#5500)

* feat: Remove svelte field from package.json (#5504)

* release: v5.0.0-alpha.46

* feat: Add explicit package.json `type` field (#5505)

* release: v5.0.0-alpha.47

* chore: Fix nx affected (#5509)

* fix: Fix ESLint warnings (#5510)

* release: v5.0.0-alpha.48

* chore: Update to Nx 16.3.1 (#5514)

* chore: Update to nx 16.3.1

* Update pnpm-lock.yaml

* chore: Update Nx cloud workflow (#5515)

* feat: Drop legacy webpack v4 support (#5507)

* release: v5.0.0-alpha.49

* feat: Remove UMD build output (#5517)

* release: v5.0.0-alpha.50

* chore: Rework rollup externals (#5519)

* feat: Refactor package exports (#5520)

* chore: Remove publint error temporarily

* release: v5.0.0-alpha.51

* fix: Publint error in solid-query (#5522)

* release: v5.0.0-alpha.52

* fix: Simplify exports in solidjs packages (#5523)

* release: v5.0.0-alpha.53

* chore: Improve Nx task separation (#5524)

* Fix ci workflow

nx run-many doesn't use --base

* feat(query-devtools): Lazyload Query Devtools Core (#5527)

* release: v5.0.0-alpha.54

* fix(query-devtools): Broken package.json exports (#5528)

* Make publint throw errors

* Rewrite CJS files to use .cjs extension

* Add concurrency option to PR workflow

* Fix export extensions

* release: v5.0.0-alpha.55

* chore: Re-enable Nx Distributed Task Execution (#5518)

* fix(query-devtools): inform onlineManager when offline mode is simulated (#5534)

* release: v5.0.0-alpha.56

* docs: make returning a promise for optimistic updates more explicit (#5485)

* fix(codemod): do not mark the `buildMessage` method as private (#5546)

* fix(codemod): do not mark the `buildMessage` method as private

It might fail because of the lack of support.

* chore(codemod): add missing `filePath` parameter to the docblock

* release: v5.0.0-alpha.57

* fix(query-devtools): Fix getSidedProp bug (#5551)

* release: v5.0.0-alpha.58

* chore: Update publish script (#5559)

* fix(query-devtools): Add chunkFileNames option (#5560)

* release: v5.0.0-alpha.59

* fix: Change `svelte-package` output directory (#5561)

* release: v5.0.0-alpha.60

* release: v5.0.0-alpha.61

* chore: try to stabilize test

* fix(solid-query): Use rollup-preset-solid (#5565)

* release: v5.0.0-alpha.62

* feat: Add legacy rollup builds (#5570)

* release: v5.0.0-alpha.63

* docs: Add `"private": true` to examples (#5578)

* release: v5.0.0-alpha.64

* fix(useIsMutating): fix vue warning (#5453)

onScopeDispose() is called when there is no active effect scope to be associated with

* release: v5.0.0-alpha.65

* feat(infiniteQuery): allow prefetching arbitrary amounts of pages (#5440)

* refactor: combine fetching first page with refetching

as it's the same condition

* feat(infiniteQuery): allow prefetching arbitrary amounts of pages

* test prefetching

* fix: make sure that pages and getNextPageParam are passed in tandem to (pre)fetchInfiniteQuery

* docs: prefetching

* chore: try to stabilize test

* docs: migration guide

* release: v5.0.0-alpha.66

* refactor: move queryOptions to its own file (#5480)

* refactor: remove 'use client' from non-components

* refactor: move queryOptions to its own file

where we don't have a 'use client' directive, because we can call this function on the server as well

* Revert "refactor: remove 'use client' from non-components"

This reverts commit 8ecac6688b.

* refactor: rename isRestoring file

* chore: fix import

* release: v5.0.0-alpha.67

* fix: Update eslint-plugin-query build config (#5601)

* fix: Use pnpm workspace protocol (#5600)

* release: v5.0.0-alpha.68

* chore: Use nx watch command (#5605)

* fix(solid-query): revert package.json typo (#5615)

* release: v5.0.0-alpha.69

* release: v5.0.0-alpha.70

* release: v5.0.0-alpha.71

* chore: Fix Nx parallelisation for vue-query tests (#5635)

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>

* fix(devtools): padding for action buttons (#5608)

global `button` styles would otherwise affect buttons

* release: v5.0.0-alpha.72

* feat: Support Svelte v4 (#5659)

* feat: Support svelte v4

* Downgrade @testing-library/svelte

* Upgrade @testing-library/svelte to 4.0.3

* Refactor onMount dynamic import

* release: v5.0.0-alpha.73

* fix(eslint-plugin-query): Use tsup to generate types (#5666)

* release: v5.0.0-alpha.74

* fix: Skip queryClient context lookup if client passed directly (#5669)

* release: v5.0.0-alpha.75

* feat: Accept all svelte stores as options (#5672)

* refactor: Accept stores other than writable

* Cleanup Readable type import

* Add tests

* Stricter isSvelteStore check

* Update docs

* Fix input bind

* Add testing-library cleanup

* release: v5.0.0-alpha.76

* fix(svelte-query): Fix staleTime reactivity bug (#5682)

* release: v5.0.0-alpha.77

* chore(svelte-query): Update reactivity docs and tests (#5683)

* fix(query-devtools): Bundle all dependencies (#5684)

* release: v5.0.0-alpha.78

* release: v5.0.0-alpha.79

* feat: react-query-next-experimental package (#5598)

* chore: fix a copy-paste error

* chore: bootstrap package

* chore: setup package

* chore: allow passing with no tests

* fix: remove 'use client' from index bundle

* chore: cleanup copy/paste error

* chore: fix prettier

* refactor: replace ref with direct props access

* fix: do not write to refs during render

* refactor: inline function into useEffect to avoid useCallback

* fix: eslint no-shadow

* refactor: namespace id

* refactor: removed pointless check

* fix: set to empty array on cleanup

* fix: adapt for v5 changes

* chore: fix build

* docs: add streaming example

* chore: fix outdated lockfile

* chore: fix prettier

* refactor: remove isSubscribed ref

* refactor: re-arrange comment

* chore: remove comments

* chore: fix broken lock file

* feat: allow customization of hydrate / dehydrate options

and make sure we fall back to the defaultShouldDehydrate function, which only dehydrates successful queries

* release: v5.0.0-alpha.80

* docs: fix nextjs-streaming example

* fix(core) : sync Observer 'current' properties when optimistic reading occurs (#5611)

* fix-5538 : sync Observer 'current' properties when optimistic reading occurs

* Flip test on currentResult with placeholderData's order & add test

* Fix tests using the same queryKey

* remove options.placeHolderData from deciding whether to assign observer current properties, use equalitycheck on v5

* maybe fix for vue reactivity cbs

* test(vue-query): test persister with useQuery

* Force line terminator to \\n on codemods tests

* Revert " Force line terminator to \\n on codemods tests"

This reverts commit 6f0a469f51.

---------

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
Co-authored-by: Damian Osipiuk <osipiukd+git@gmail.com>

* chore: Force line terminator to \\n on codemods tests (#5664)

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>

* chore: stabilize a flaky test

* release: v5.0.0-alpha.81

* docs: remove devtools from example

because they currently don't work

* fix(query-devtools): Force publish package (#5715)

* release: v5.0.0-alpha.82

* docs: re-enable devtools

* fix: Update dev dependencies (#5718)

* release: v5.0.0-alpha.83

* chore: Add vite to root package.json (#5722)

* refactor: Add new eslint sorting from main (#5723)

* release: v5.0.0-alpha.84

* chore: Update vite and vitest (#5724)

* chore: Remove eslint-plugin-compat (#5732)

* feat: include meta in query and mutation hydration (#5733)

* feat: include `meta` in query and mutation hydration

* test: tests for meta hydration

* chore: stabilize a flaky test

* chore: stabilize another flaky test

* release: v5.0.0-alpha.85

* fix(onlineManager): always initialize with `online: true` (#5714)

* fix(onlineManager): always initialize with `online: true`

instead of relying on navigator.onLine, because that indicator is broken AF in chrome

https://bugs.chromium.org/p/chromium/issues/list?q=navigator.online

* docs: document subscribe methods

* docs

* test: fix types in tests

setting to undefined is now illegal, so we have to reset to `true`, which is the default now

* fix(tests): switch from mocking navigator.onLine to mocking onlineManager.isOnline

* fix: offline toggle in devtools

it should now be enough to set online to true / false, without firing the event, because we always set & respect that value. we don't override the event handler, so real online / offline events might interfere here

* chore: fix tests

with the implementation of onlineManager, where we default to `true`, we need an explicit `'offline'` event to get it to false; otherwise, switching back to true doesn't change the state, so subscribers are not informed

* chore: prettier write

* chore: fix eslint

* chore: delete an old, flaky test that doesn't test much

* release: v5.0.0-alpha.86

* docs: use bundlejs for bundle-size

* docs: fix link

* feat: Replace rollup with tsup/esbuild (#5597)

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
Co-authored-by: Aryan Deora <adeora@iu.edu>

* release: v5.0.0-alpha.87

* chore: Simplify tsconfig (#5745)

* fix: Simplify devDependencies (#5747)

* fix: Fix tsconfig "include" setting (#5750)

* release: v5.0.0-alpha.88

* docs: fix potential typo (#5748)

* fix potential typo

* Update docs/react/guides/queries.md

---------

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>

* fix: Add missing extensions to ESM imports (#5751)

* chore: Bundler integration tests (#5756)

* Add react-cra5 test

* Add react-cra4 test

* Add react-vite test

* Add svelte-vite test

* Add solid-vite test

* Run prettier

* Rename script to test:bundle

* Add vue-vite test

* Run prettier

* fix(query-devtools): Fix Devtools Build Issues (#5768)

* release: v5.0.0-alpha.89

* feat(codemod): add codemod that renames the `Hydrate` component usages to `HydrationBoundary` usages (#5761)

* feat(codemod): add codemod that renames the `cacheTime` and `useErrorBoundary` object properties and TypeScript property signatures (#5765)

* feat(react-query): useSuspenseQuery (#5739)

* feat: useSuspenseQuery

* feat: infiniteQueryOptions

* fix: add exports

* feat: useSuspenseInfiniteQuery

* feat: initialData overloads for useInfiniteQuery

* fix: types

* chore: stabilize test

we sometimes get failureCount: 2, but it doesn't matter here (timing issue)

* fix: types for useSuspenseQuery (#5755)

* docs: suspense

* docs: api reference

* docs: useSuspenseQuery in examples

* fix: types for useSuspenseInfiniteQuery (#5766)

---------

Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>

* release: v5.0.0-alpha.90

* chore: fix prettier

* chore: fix tests

* release: v5.0.0-alpha.91

---------

Signed-off-by: marbemac <marbemac@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Tanner Linsley <tannerlinsley@users.noreply.github.com>
Co-authored-by: Fredrik Höglund <fredrik.hoglund@gmail.com>
Co-authored-by: Gabriel Pichot <gabriel.pichot@gmail.com>
Co-authored-by: Marc MacLeod <marbemac@gmail.com>
Co-authored-by: Aryan Deora <adeora@iu.edu>
Co-authored-by: Eng Zer Jun <engzerjun@gmail.com>
Co-authored-by: Damian Osipiuk <osipiukd+git@gmail.com>
Co-authored-by: Arthur Denner <arthurdenner7@gmail.com>
Co-authored-by: Ilya <marchukilya@gmail.com>
Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com>
Co-authored-by: OrJDev <91349014+OrJDev@users.noreply.github.com>
Co-authored-by: Enguerrand des Vaux <enguerrand@des-vaux.fr>
Co-authored-by: Dennis kinuthia <denniskinuthiaw@gmail.com>
Co-authored-by: Yuji Sugiura <leader22@users.noreply.github.com>
Co-authored-by: Yaroslav Lapin <jlarky@gmail.com>
Co-authored-by: Balázs Máté Petró <petrobalazsmate@gmail.com>
Co-authored-by: Aleksandr Semenov <juvirez@gmail.com>
Co-authored-by: Matthew Salsamendi <matthewsalsamendi@gmail.com>
Co-authored-by: Speros Kokenes <skokenes@users.noreply.github.com>
Co-authored-by: EL AYADI Mohamed <moh.el.ayadi@gmail.com>
Co-authored-by: Dale Seo <5466341+DaleSeo@users.noreply.github.com>
Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>
2023-07-24 11:59:07 +02:00
Lachlan Collins
14c7b1efdd
chore: Merge more workspace changes from alpha (#5564) 2023-06-12 18:26:44 +10:00
Lachlan Collins
7226d5064a
chore: Merge select workspace changes from alpha (#5563) 2023-06-12 17:55:04 +10:00