* chore: tsup -> tsdown
* revert size-limit and fix the build instead
* fix angular and devtools build
* fix nextJs builds
* more solid related things
* fix: import order
* refactor(eslint-plugin-query): remove unused ast-utils helpers
Remove five unused helpers from the ASTUtils object in ast-utils.ts:
getNestedIdentifiers, getNestedReturnStatements, getClosestVariableDeclarator,
mapKeyNodeToText and mapKeyNodeToBaseText.
None are referenced by any rule or other module, and ASTUtils is not part of
the package's public API (it is not exported from index.ts). knip does not flag
them because ASTUtils is exported as a single object, so member-level dead code
slips past it.
All 1709 tests pass and ast-utils.ts line coverage rises from 41% to 95%.
* chore: add changeset for unused ast-utils helper removal
---------
Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
* fix(eslint-plugin-query): detect rest destructuring on custom query hooks
Adds an opportunistic type-aware path to no-rest-destructuring. When
TypeScript parser services are available, the rule resolves the call
expression's return type and reports rest destructuring on custom hooks
that return a TanStack Query result. Untyped projects keep the existing
AST-only behavior unchanged.
Closes#8951
* perf(eslint-plugin-query): gate type lookup behind cheap binding check
Only run the type checker on non-direct hook calls when the binding can
actually report (rest destructure or identifier), avoiding type lookups on
every variable declarator. Add tests for cross-statement rest destructuring
and interface-typed (non-alias) query results.
* ci: apply automated fixes
---------
Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* fix(eslint-plugin-query): handle array-destructured useQueries results in no-unstable-deps
The `collectVariableNames` function in the `no-unstable-deps` rule only
handled `Identifier` patterns. When users array-destructure `useQueries`
or `useSuspenseQueries` results (e.g. `const [q1, q2] = useQueries(...)`),
the individual variables were not tracked as unstable. This meant passing
them directly to React hook dependency arrays was never flagged.
Extend `collectVariableNames` to also handle `ArrayPattern` — including
plain identifier elements and rest elements.
Fixes#10746
* ci: apply automated fixes
---------
Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* fix(eslint-plugin): normalize whitespace in allowList variable matching
When a member expression spans multiple lines (e.g. `ignored\n .run()`),
`sourceCode.getText()` preserves the newline. The root segment extracted
by splitting on `.'` then becomes `'ignored\n '`, which never matches
the allowlisted variable name `'ignored'`.
Fix: extend `normalizeChain` to also collapse all whitespace, so
multi-line chains produce the same identifier path as single-line ones.
Fixes#10334
* changeset
---------
Co-authored-by: Maks Pikov <mixelburg@users.noreply.github.com>
Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
* fix(build): exclude config files from production DTS rollup
The `experimentalDts` option in tsup respects the tsconfig `include`
array to determine which files are in scope for DTS generation. Each
package's `tsconfig.json` includes `*.config.*` for IDE support, and
`tsconfig.prod.json` inherited this without overriding it. This caused
`vite.config.ts` and `tsup.config.ts` to be swept into the DTS rollup,
leaking `import { UserConfig } from 'vite'` into published types. Since
vite references `@types/node`, this globally overrides the DOM
`setTimeout` return type from `number` to `NodeJS.Timeout` for all
consumers.
Add `"include": ["src"]` (and `"exclude": ["src/__tests__"]` where
applicable) to all `tsconfig.prod.json` files that were missing it,
matching the pattern already used by query-core, react-query,
preact-query, and solid-query.
* chore: add changeset for DTS type pollution fix
* test(build): add regression test for build tool type leaks in .d.ts files
Adds scripts/verify-dts-imports.ts that scans all published .d.ts files
for forbidden imports from build tools (vite, tsup, vitest) and
`/// <reference types="node" />`. Wired into test:pr and test:ci to
run after the build completes.
* fix(build): fail fast when no .d.ts files found in verify-dts-imports
* chore: add exclude for consistency in react-query-next-experimental
* chore: fix log message to mention both .d.ts and .d.cts files
* ci: apply automated fixes
* chore: remove verify-dts-imports script and related package.json changes
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
The existing tests only exercised useQuery. The rule checks any object
property named queryFn, so it applies equally to useInfiniteQuery,
useSuspenseQuery, queryOptions(), and queryClient.fetchQuery(). Add
valid + invalid cases for each to document and lock in that behavior.
Co-authored-by: Wonsuk Choi <sukvvon@gmail.com>