This website requires JavaScript.
About
Status
₊˚⊹Discord
Explore
Register
Sign in
Reference in a new issue
Blame
Copy permalink
Reference in a new issue
Copy permalink
TanStack
/
router
Star
0
Fork
You've already forked router
0
mirror of
https://github.com/TanStack/router.git
synced
2026-11-16 19:38:07 +00:00
Code
Issues
Releases
Packages
Activity
@tanstack/solid-start@2.0.0-rc.4
router
/
.changeset
/
solid-usehead-registry.md
19 lines
902 B
Raw
Permalink
Normal View
History
feat(solid-router): adopt Solid 2's useHead registry for head management (#8080) * feat(solid-router): register head tags through Solid's useHead registry HeadContent now feeds the route-derived tags (useTags output, semantics unchanged) to Solid's head registry as one reactive group instead of rendering <Asset> elements in-tree. The registry owns head emission on both runtimes: SSR splices/streams resolved winners into <head>, the client patches document.head reactively — replacing the manual relocate-into-head, imperative script injection, and document.title syncing that Asset.tsx carried for head tags. The dev-only dev-styles handling (filter DEV_STYLES_ATTR links post hydration) is a no-op in production, so it folds into the single HeadContent — retiring HeadContent.dev.tsx, index.dev.tsx, and the package's development export conditions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(solid-start): pin SSR'd lazy() modulepreload hints and hydration asset map The client-assets manifest wiring (99756c0710) gives SSR'd lazy() components three observable outputs in the served HTML: modulepreload hints for the lazy chunk and its static imports in the initial <head>, the chunk's stylesheet link, and the serialized boundary→chunk asset map that gates client hydration on those imports. The start-manifest e2e only asserted the stylesheet side, so a silent regression to the route-keyed manifest fallback would keep the suite green while losing hints and hydration gating. Two request-level tests against the built app pin the rest: direct SSR entry to /lazy-css-lazy emits exactly one head modulepreload for the lazy chunk and one for its statically imported widget chunk (and none of them on routes that never render the component), and the hydration payload's _assets map points at the same chunk URL the head hinted. Co-authored-by: Cursor <cursoragent@cursor.com> * refactor(solid-router): lean on the head registry for tag lifecycle Drop the pieces of the head pipeline that existed only for the old in-tree render path: the reference-reuse memo and replaceEqualTags (DOM node stability for a <For> that no longer exists) and the dev-styles post-hydration filtering (HeadContent is now a pure useHead registration). Add the changeset for the useHead adoption. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: apply automated fixes * fix(solid-router): stable head-registry identities for inline tags + CI repairs Inline scripts and styles get a stable content-derived key in toHeadTags: the registry otherwise assigns per-runtime unique identities that can never match between server and client, so hydration appended a client copy next to the server-rendered tag (caught by the solid-start basic script-duplication e2e). The ssr head benchmark's sanity assertion now counts name="…" attribute occurrences instead of raw substring hits — the registry writes the identity into data-dh on the same element, which doubled the old count. remountDeps tests migrate onMount to Solid 2's onSettled (pre-existing branch failure; the API was removed in the rc line). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(solid-router): make route-boundary resets converge (issue 7986 + background recovery) Two compounding defects kept a captured route error from retrying cleanly on Solid 2: - CatchBoundary's reset effect re-ran on every recompute of the reset key, not only on value changes, so any store write recreated the retried subtree while it settled. The effect is now gated on the key value. The reset handle deliberately stays un-consumed: a reset applied at the wrong moment can no-op (the boundary stays errored and the fallback never re-runs), and only a repeated attempt on a later key change recovers it — consuming the handle at apply time or at children re-render both proved to lose exactly that retry (verified against the background-recovery test). - Match keyed its boundary on the whole matches store, so every unrelated transition fired a premature reset that re-threw the still-stale error and flapped the error UI. The key is now scoped to the guarded match and its descendants (whose errors bubble here when they have no errorComponent), mirroring react-router's per-match keying, as a value string because the store emits fresh objects for content-equal writes. The issue-7986 pending assertion queries fresh under waitFor: the retried subtree renders the pending fallback from two nested slots in quick succession (Show fallback, then the Loading boundary once the child suspends), so a cached element handle can go stale across the swap. First fully green unit run on this branch: 59 files, 864 tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Ryan Carniato <ryansolid@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-08-19 10:58:15 -05:00