From 4a8a60df14a7c8a1980ee3febe08020978cd55fe Mon Sep 17 00:00:00 2001 From: Sheraff Date: Wed, 7 Oct 2026 14:11:58 +0200 Subject: [PATCH] test(router-plugin): regroup compiler regression tests by behaviour Dissolve the ported-* and code-splitter edge-case files into behaviour files (dead code, imports/exports, module state, pragmas, route options, scope), drop duplicate cases and vacuous assertions, and replace the five real Vite builds with one. Co-Authored-By: Claude Opus 5.5 (1M context) --- ...code-splitter-ambient-declarations.test.ts | 90 --- .../tests/code-splitter-dead-code.test.ts | 435 +++++++++++++++ .../tests/code-splitter-edge-cases.test.ts | 292 ---------- .../code-splitter-exported-bindings.test.ts | 80 --- .../code-splitter-imports-exports.test.ts | 322 +++++++++++ .../code-splitter-js-comparison-chain.test.ts | 25 - .../tests/code-splitter-jsx-pragmas.test.ts | 99 ---- .../tests/code-splitter-module-state.test.ts | 249 +++++++++ .../code-splitter-output-validity.test.ts | 153 ----- .../code-splitter-plugin-pipeline.test.ts | 111 ++-- .../tests/code-splitter-pragmas.test.ts | 124 +++++ .../tests/code-splitter-real-world.test.ts | 243 -------- .../tests/code-splitter-route-options.test.ts | 116 ++++ .../code-splitter-route-references.test.ts | 98 ---- .../tests/code-splitter-scope.test.ts | 339 ++++++++++++ .../tests/ported-babel-dce.test.ts | 305 ---------- .../tests/ported-nextjs-ssg.test.ts | 397 ------------- .../tests/ported-qwik-optimizer.test.ts | 181 ------ .../ported-react-compiler-fixtures.test.ts | 197 ------- .../tests/ported-react-refresh.test.ts | 477 ---------------- .../ported-react-router-route-chunks.test.ts | 523 ------------------ .../tests/ported-solid-refresh.test.ts | 262 --------- .../ported-turbopack-tree-shaker.test.ts | 116 ---- .../tests/ported-vite-plugin-rsc.test.ts | 188 ------- .../react-refresh-route-components.test.ts | 325 +++++++++-- .../router-plugin/tests/regression-helpers.ts | 174 +++--- 26 files changed, 2016 insertions(+), 3905 deletions(-) delete mode 100644 packages/router-plugin/tests/code-splitter-ambient-declarations.test.ts create mode 100644 packages/router-plugin/tests/code-splitter-dead-code.test.ts delete mode 100644 packages/router-plugin/tests/code-splitter-edge-cases.test.ts delete mode 100644 packages/router-plugin/tests/code-splitter-exported-bindings.test.ts create mode 100644 packages/router-plugin/tests/code-splitter-imports-exports.test.ts delete mode 100644 packages/router-plugin/tests/code-splitter-js-comparison-chain.test.ts delete mode 100644 packages/router-plugin/tests/code-splitter-jsx-pragmas.test.ts create mode 100644 packages/router-plugin/tests/code-splitter-module-state.test.ts delete mode 100644 packages/router-plugin/tests/code-splitter-output-validity.test.ts create mode 100644 packages/router-plugin/tests/code-splitter-pragmas.test.ts delete mode 100644 packages/router-plugin/tests/code-splitter-real-world.test.ts create mode 100644 packages/router-plugin/tests/code-splitter-route-options.test.ts delete mode 100644 packages/router-plugin/tests/code-splitter-route-references.test.ts create mode 100644 packages/router-plugin/tests/code-splitter-scope.test.ts delete mode 100644 packages/router-plugin/tests/ported-babel-dce.test.ts delete mode 100644 packages/router-plugin/tests/ported-nextjs-ssg.test.ts delete mode 100644 packages/router-plugin/tests/ported-qwik-optimizer.test.ts delete mode 100644 packages/router-plugin/tests/ported-react-compiler-fixtures.test.ts delete mode 100644 packages/router-plugin/tests/ported-react-refresh.test.ts delete mode 100644 packages/router-plugin/tests/ported-react-router-route-chunks.test.ts delete mode 100644 packages/router-plugin/tests/ported-solid-refresh.test.ts delete mode 100644 packages/router-plugin/tests/ported-turbopack-tree-shaker.test.ts delete mode 100644 packages/router-plugin/tests/ported-vite-plugin-rsc.test.ts diff --git a/packages/router-plugin/tests/code-splitter-ambient-declarations.test.ts b/packages/router-plugin/tests/code-splitter-ambient-declarations.test.ts deleted file mode 100644 index b9690208ad..0000000000 --- a/packages/router-plugin/tests/code-splitter-ambient-declarations.test.ts +++ /dev/null @@ -1,90 +0,0 @@ -import { parseSync, transformWithOxc } from 'vite' -import { describe, expect, it } from 'vitest' -import { compileRouteModules } from './regression-helpers' - -/** The module record a bundler sees once TypeScript is erased. */ -async function runtimeModuleInfo(code: string) { - const { code: javascript } = await transformWithOxc(code, 'module.tsx', { - jsx: 'preserve', - typescript: { onlyRemoveTypeImports: true }, - }) - return parseSync('module.jsx', javascript, { sourceType: 'module' }).module -} - -/** - * Every value a module imports from the shared module must be exported by the - * shared module at runtime; otherwise bundlers fail with a missing export and - * browsers refuse to link the module. - */ -async function missingSharedImports(modules: Record) { - const sharedExports = new Set() - if (modules.shared) { - for (const entry of (await runtimeModuleInfo(modules.shared)) - .staticExports) { - for (const item of entry.entries) { - if (item.exportName.name) { - sharedExports.add(item.exportName.name) - } - } - } - } - const missing: Array = [] - for (const [name, code] of Object.entries(modules)) { - if (name === 'shared') { - continue - } - for (const declaration of (await runtimeModuleInfo(code)).staticImports) { - if (!declaration.moduleRequest.value.includes('tsr-shared')) { - continue - } - for (const entry of declaration.entries) { - const imported = entry.importName.name ?? 'default' - if (!entry.isType && !sharedExports.has(imported)) { - missing.push(`${name} imports ${imported}`) - } - } - } - } - return missing -} - -// Ambient declarations (`declare ...`) have no runtime binding: the value is -// provided by the environment (a