0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00

refactor(router-utils): the renderer is the walk of the region tree (design 1, step 2)

One walk per output (`OutputView.walk`) renders source text: a node renders
its place (a kept claim's placeholder, or the edit replacing it) or its text
(its edit's body, or its source with the nodes inside it); a node rendering
as its source is walked through; an insert belongs to the innermost node
strictly holding its position. The renderer (freeze), placement's reads and
the erased parts are its visitors; liveness climbs the tree with the same
text/place rules.

- Owners render their claimed region whole (`{ k: 'region', id }`); a
  generated unit names no slice. Route options written as methods claim the
  function and edit the property to `key: ` plus it (router split and HMR).
- A slice that cuts a node rewritten in the output, or that leaves the text
  its edit rewrites, is a conflict in every mode (F2-1's keep-slice cases).
- `claim()` registers its node (a claim on a unit region too) and rejects a
  second claim on one range (review of step 1, findings 1 and 2).
- Placement's region nesting is read on the tree (`parentOf`, `childrenOf`,
  `innermostAt`); `Region.parent`/`children` are gone.
- Deleted: `RenderTree`, `TreeEdit`, `tree()`, `topLevelWithin`, the copy
  guard (`editUnderCopy`, R127, and its error-severity diagnostics), the
  `exclude` lookup, verify (c), `regionReads`' edit scan, `fragReads`,
  `editRenders`, `placeholderRenders`, `overrideOf`, `decide`'s bound, the
  erased parts' `topLevelWithin` emulation and `anyHidden`.
- Scaling: the statement-start guard indexes one top-level statement per
  walk instead of walking the module per offset, and `isErasedRange` visits
  only the nodes overlapping its range (a module of 1,600 hoisted server
  functions compiled in 8.5 to 10 times one of 400; now about 4 times).
- Tests: the random trees register in shuffled order, check the derived
  output and ranges, and claim kept slices (the shape step 1 left out now
  holds); the scaling test hoists every handler; the copy-guard tests and
  the erased-parts emulation test go with their mechanisms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Sheraff 2026-11-10 21:19:34 +01:00
commit 9945237b91
No known key found for this signature in database
25 changed files with 1861 additions and 1319 deletions