mirror of
https://github.com/TanStack/router.git
synced 2026-11-16 19:38:07 +00:00
fix(router-utils): an add or a removal is never a repeat; a text without a plan drops the old plan; staleHits split
From the review of design 3 steps 0-1, before the Rsbuild host forwards every compiler's events: - The same text proves that no fact of the file moved, not that the file was there all along. A change with the text the caches read is a repeat; an add, or a removal of a file that reads back, still moves the file set (fileSetVersion, failed and shadowed resolutions asked again) without marking its facts. Fixes finding 1 (removed and created again with the same text: an importer compiled in the gap kept its failed resolution; Rspack reports the second event as a change) and step 2 item 3 (a created file reaches each compiler's make separately; the second environment's resolver answered the first add from before the file existed). The `ADDED` mark of `seen` goes: `seen` is a revision or UNKNOWN. `readChange` returns the text and whether it is the same. - A compile of a newer text that ends without a plan (untouched, empty, not parsed) drops the key's plan of the old text and its rows (finding 2: a later edit of what the old text read reported the file; Vite's liveModules reads the plan at the path). - `staleHits` counts plan hits that failed on a fact (a defect: invalidate() checks every fact); hits that failed only on a resolution or a route-registry digest, asked again at the next request by design (a tsconfig edit), are `lazyHits` (finding 3). - Property (b): a stash and pop (removed, modules requested, back with the same text, reported as add or change). 240 seeds pass; with the rule reverted, seed 24481 fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
101e517121
commit
dfdaabcd90
6 changed files with 160 additions and 70 deletions
Loading…
Add table
Add a link
Reference in a new issue