0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

335 commits

Author SHA1 Message Date
Flo
0497caeef3
perf(router): use URL.canParse for absolute URL checks (#8251)
* perf(router): use URL.canParse for absolute URL checks

* refactor(router): simplify absolute URL conditions

* perf(router): remove redundant absolute URL prechecks
2026-09-05 22:05:13 +02:00
Flo
28a5e4504e
fix(router): handle unknown error boundary values (#8209)
* fix(router): handle unknown error boundary values

* fix(router): complete unknown boundary error migration

* docs(router): keep boundary examples within skill limits

* fix(router): restore minimal boundary error display

* fix(solid-router): unify boundary errors across SSR and client
2026-09-05 14:48:44 +02:00
Flo
c18e690814
perf(router-core): avoid redundant promises for ready routes (#8244)
* test(router-core): add ready-route performance controls

* test(router-core): type throwing thenable getter explicitly

* perf(router-core): avoid redundant promises for ready routes

* test(router-core): restrict preload coverage to supported behavior

* docs(router-core): record immediate preload scheduling experiment

* perf(router-core): keep the simpler immediate chunk wrapper

* chore: remove ready-route benchmark artifacts
2026-09-05 11:24:18 +02:00
Flo
f0b5eda544
fix(router-core): retain not-found boundary during navigation (#8161)
* fix(router-core): retain not-found boundary during navigation

* chore: add changeset for not-found boundary fix

* test(react-router): cover overlapping not-found retention boundaries
2026-09-05 09:51:56 +02:00
Flo
2f9150309b
perf(router-core): avoid quadratic cache resource handoff (#8240)
* test(router-core): cover cache commit ownership and scaling

* perf(router-core): avoid quadratic cache resource handoff
2026-09-04 22:55:02 +02:00
Flo
50eafcaebb
perf(router-core): gate JSON.parse attempts behind jsonStart guard in parseSearchWith (#8142)
* perf(router-core): gate JSON.parse attempts behind jsonStart guard in parseSearchWith

* test(router-core): strengthen search parsing regression coverage

* chore(router-core): add search parsing changeset and refresh measurements

* docs: use a shell-safe parsing benchmark output path

* chore: keep search parsing measurements out of the PR
2026-09-04 22:43:10 +02:00
Flo
ee283480df
perf(router-core): replace the LRU cache with a trimmed SIEVE cache (#8230)
* perf(router-core): replace the LRU cache with a trimmed SIEVE cache

The hand-rolled doubly-linked LRU relinked the hit entry to the newest
position on every `get`. Every cache in the router (resolvePathCache,
the route tree's matchCache/singleCache/flatCache, the SSR manifest
cache) is hit-dominated: a page of links re-resolves the same handful
of paths on every navigation, so the relink was pure overhead.

SIEVE (https://cachemon.github.io/SIEVE-website/) keeps a FIFO list and
a visited bit per entry; a hit only sets the bit, and eviction sweeps a
hand from the oldest entry, clearing bits and dropping the first
unvisited one. Same API as before (`get`/`set`/`clear`, fixed `max`),
no dependency, and the old implementation's stale-`oldest` eviction
edge case is gone.

Microbenchmark (ns/op, Node 25): get-hit 17.0 -> 13.9, set-insert
64.9 -> 50.8, set-evict 79.9 -> 79.9, scan-then-return 41.0 -> 34.8,
get-miss 16.2 -> 19.3. Hit ratios on the links and route-tree-scale
client-nav traces are identical (working sets of 3-9 keys never evict).

Bundle gzip: react-router.minimal -8 B, react-router.full -15 B.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C1tX2n8xegVBsZqoJPu7iv

* perf(router-core): trim SIEVE cache nodes

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-04 20:56:39 +02:00
Flo
edf0e16ebf
perf(router-core): share settle chain between superseded navigation waiters (#8222)
perf(router-core): make superseded navigation waiters share one settle chain

`awaitCurrent` looped `await current.done` and re-read `router._tx` after
each completion. Under back-to-back navigations (anything that starts the
next navigation in the same tick as `onRendered`, including the client-nav
benchmarks) every superseded waiter woke on every successor, so a burst of
N navigations cost N²/2 microtask iterations and kept every superseded
transaction alive until the router went idle.

Each transaction's `done` promise now follows its current successor, so
every waiter on a transaction shares the same chain instead of polling
successors independently. A waiter still resolves once the router has
settled on a transaction other than its owner.

Measured in benchmarks/client-nav (react, navigations per 10s, jsdom):
baseline 15.4K -> 43K, route-tree-scale 17.9K -> 98K,
search-params 16.5K -> 55K. The instrumented baseline run showed
125.8M loop iterations for 15,867 navigations before the change.
Bundle: react-router.minimal -1 B gzip vs main.


Claude-Session: https://claude.ai/code/session_01C1tX2n8xegVBsZqoJPu7iv

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-03 15:10:53 +02:00
Cong-Cong Pan
37877da166
perf(start): optimize Rsbuild import protection reporting (#8164)
* perf(start): avoid parsing original source in Rsbuild import protection

* perf(start): avoid filesystem reads in Rsbuild import protection reporting

* perf(start): remove redundant module survival checks

* perf(start): ignore inactive Rspack import connections

* perf(start): lazily build Rsbuild import protection diagnostics

* chore: remove test case

* add changeset

* fix(start): persist Rsbuild import protection markers in buildInfo

* fix: normalize file path in getModuleResource

* fix(start): restore Rsbuild diagnostics for inactive imports

* fix(start): improve Rsbuild import protection diagnostics

* refactor(start): clarify Rsbuild violation scanner state

* update readme

* fix(start-plugin-core): avoid dependency locations in Rsbuild diagnostics

* fix(start): respect importer scope for Rsbuild markers

* refactor(start): move Rsbuild import protection transform to loader

* test(start): type Rsbuild import protection mocks

* fix(start): close Rsbuild import protection reporting gaps

* fix(start): skip errored Rsbuild import protection modules
2026-08-31 18:48:41 +02:00
Kenji Mizuguchi
0caf6b9a2b
fix: preserve shouldThrow in route-scoped hooks (#8169)
* fix(react-router): forward shouldThrow in Route.useMatch

Co-authored-by: Cursor <cursoragent@cursor.com>

* ci: apply automated fixes

* fix(react-router,solid-router,vue-router): preserve shouldThrow in route-scoped hooks

Co-authored-by: Cursor <cursoragent@cursor.com>

* test: simplify route-scoped shouldThrow coverage

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Sheraff <me@florianpellet.com>
2026-08-27 23:54:34 +02:00
github-actions[bot]
0dbb77f726
ci: Version Packages (#8177)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-27 01:33:18 +02:00
Manuel Schiller
79e35335b4
optimize query integration (#8175)
* optimize query integration

* fix
2026-08-27 01:28:24 +02:00
github-actions[bot]
a5a5bacc8f
ci: Version Packages (#8133)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-23 00:53:08 +02:00
Jiahan Chen
a0041bb36e
fix(start): migrate to Rsbuild splitChunks config (#8135) 2026-08-22 09:48:30 +02:00
Flo
cb281d70c1
fix(router-core): preserve context during reloads (#8130)
* fix(router-core): preserve context during reloads

* ci: apply automated fixes

* test(router): consolidate issue 8115 coverage

* fix(vue-router): react to provider context changes

* fix(router-core): refine context reconstruction

* bytes

* type fixes

* context + immediate UI on load

* coderabbit is happy

* no context in pending/error/notFound components

* changesets

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-08-20 23:34:06 +02:00
Manuel Schiller
fa65287281
perf(router): remove prebuilt preload locations (#8132) 2026-08-20 23:17:16 +02:00
github-actions[bot]
4fcbcde90d
ci: Version Packages (#8119)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-19 13:22:14 +02:00
Flo
3e016ac84f
perf(router-core): buildLocation optimizations (#8117) 2026-08-19 11:28:52 +02:00
github-actions[bot]
a78f2af5b4
ci: Version Packages (#8079)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-18 17:12:28 +02:00
Flo
63d2cc9155
fix(router-core): remove navigation rollback (#8092)
* fix(router-core): remove navigation rollback

* test(react-start): update failed HMR refresh expectation
2026-08-18 14:09:37 +02:00
Flo
5d3785dcc3
fix(router-core): preserve pending UI across retained routes (#8084)
* fix(router-core): preserve pending UI across retained routes

* fix(router-core): harden pending session ownership

* fix(router): align pending presentation across Solid and Vue (#8097)

fix(router): align pending presentation across frameworks

* changesets

* test: align hydration fake timers
2026-08-18 14:09:36 +02:00
Flo
f75cada017
perf(react-router): direct export of CatchBoundary class component, remove function wrapper (#8068)
bundle(react-router): direct export of CatchBoundary class component, remove function wrapper
2026-08-15 08:52:06 +02:00
github-actions[bot]
11dfc93669
ci: Version Packages (#8075)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-15 00:08:52 +02:00
Flo
bdaf73a406
perf(router-core): inline buildWithMatches inside buildLocation (#8070)
* perf(router-core): inline buildWithMatches inside buildLocation

* better cleanup
2026-08-14 22:47:45 +02:00
Flo
cf6ab178b3
perf(router-core): inline isFunction utility (#8069) 2026-08-14 21:03:47 +02:00
Flo
4c89b15dd2
perf(router-core): inline getOpenAndCloseBraces in parseSegment (#8071) 2026-08-14 21:03:20 +02:00
Flo
0fdf9ff16f
perf: inline isCtrlKey utility inside all Link components (#8073) 2026-08-14 21:02:47 +02:00
github-actions[bot]
53b63cf6fb
ci: Version Packages (#8052)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-14 14:05:28 +02:00
Flo
0c25a7b43b
fix(react-router): avoid Suspense above root documents (#8055)
* fix(react-router): avoid suspense above root documents

* test(react-start): cover root document hydration

* test(react-router): remove indirect hydration assertion

* perf(react-router): reduce suspense wrapper bundle size

* test(react-start): isolate root hydration regression

* fix(react-router): preserve root suspense in CSR

* refactor(react-router): simplify root suspense checks

* fix(react-router): preserve functional ssr classification
2026-08-14 13:34:08 +02:00
Flo
31882c7fa8
fix(router): reuse resolved lazy route components (#8054)
* fix(router): reuse resolved lazy route components

* fix vue inconsistency

* fix(router): clear resolved lazy component preload
2026-08-14 13:30:20 +02:00
Flo
38485038c5
Fix default route component remounting (#8002)
* Fix default route component remounting

* Optimize reactive Vue Link props

* fix(vue-router): address reactive Link review feedback
2026-08-12 14:53:17 +02:00
github-actions[bot]
dc5a404eb9
ci: Version Packages (#8048)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-12 11:15:35 +02:00
Flo
b0817f50cc
fix(react-router): useMatchRoute w/ React Compiler (changeset) (#8047) 2026-08-12 10:47:05 +02:00
github-actions[bot]
e15bda5c4d
ci: Version Packages (#8040)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-12 10:33:33 +02:00
Flo
f5007607d6
fix(router): warn when Outlet is rendered in fallback components (#8045) 2026-08-12 09:53:15 +02:00
Flo
aa10b6589e
fix(router): apply preload delay to viewport links (#8044)
* fix(router): apply preload delay to viewport links

* fix(router): cancel delayed viewport preloads on exit

* fix(router): process queued viewport transitions in order

* fix(router): use latest queued viewport state

* refactor(router): inline viewport observer options

* fix(router): stabilize viewport preload timers

* cleaner timeout map key
2026-08-12 09:52:36 +02:00
Flo
1aafca9b45
refactor: remove Link transition state (#8043) 2026-08-12 09:52:10 +02:00
Flo
7e93431ae9
fix(router-core): load-client can cache settled abandoned loader work without preload authority (#8039)
* fix(router-core): load-client can cache settles abandonned loader work without preload authority

* changeset

* update INTERNALS.md
2026-08-11 12:17:44 +02:00
github-actions[bot]
91a848e979
ci: Version Packages (#8021)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-09 20:43:56 +02:00
Flo
51138a824c
changeset (#8019)
* fix(router-core): handle excessive parent relative links

* changeset
2026-08-09 19:43:12 +02:00
github-actions[bot]
6f8f534bf3
ci: Version Packages (#8011)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-09 11:01:57 +02:00
Flo
44a8c3e1d2
perf(router-core): skip impossible JSON parse attempts (#8006)
* perf(router-core): skip impossible JSON parses

* perf(router-core): refine JSON parse fast path

* changeset
2026-08-08 19:43:09 +02:00
Flo
c59788ca20
perf(start-client-core): O(1) buffer drain in client frame decoder (#8009)
The frame decoder dropped consumed chunks from its buffer with
bufferList.shift(), which is O(n). When a single large frame (e.g. a big
RawStream payload) is assembled from many small network reads, the
extract loop calls shift() once per chunk, making reassembly O(n^2).

Track the first un-consumed chunk with a head pointer and advance it in
O(1) instead of shifting. Consumed slots are released for GC, and the
buffer is compacted when fully drained (O(1) reset) or once the consumed
prefix grows past a small threshold (amortized O(1) per chunk).

A micro-benchmark draining 1000 small chunks is ~11x faster.

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
2026-08-08 19:20:41 +02:00
Flo
5253e70db2
perf(router-core): faster enumerable-key collection in structural sharing (#8010)
* perf(router-core): faster enumerable-key collection in structural sharing

getEnumerableOwnKeys (used by replaceEqualDeep) called
Object.getOwnPropertyNames and then invoked propertyIsEnumerable once per
key to verify every own string prop is enumerable. Replace that O(n) loop
of JS method calls with Object.keys (native, enumerable-only) plus a
single length comparison against getOwnPropertyNames to detect
non-enumerable string props. Symbol handling is unchanged.

Behavior is identical (verified against the existing suite + fuzzing): the
function still returns the enumerable own keys in the same order and still
bails (returns false) for objects with any non-enumerable own string or
symbol property.

replaceEqualDeep runs on every selector result on every state update when
defaultStructuralSharing is enabled, so this is a hot client path for
selector-heavy apps. Measured ~1.3-1.5x faster on typical router state.

* style(router-core): address enumerable key review

---------

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
2026-08-08 19:20:08 +02:00
github-actions[bot]
2265129b40
ci: Version Packages (#7994)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-07 19:58:00 +02:00
Mat Clayton
95dec51018
perf(react-router): bail out of Link re-renders when href and active state are unchanged (#7952)
* perf(react-router): bail out of Link re-renders when href and active state are unchanged

useLinkProps subscribes to the location store with an identity selector and an
href comparator, then derives href and isActive from the published location in
downstream memos. The comparator can only ask "is this a different URL?", never
"does this link care?", so every Link on the page re-renders on every navigation.

Move the location-derived values into the selector and compare them, so a link
whose resolved href and active state are unaffected by a navigation bails out.
buildLocation still runs once per link per location change; what goes away is the
React render and the host reconciliation under it.

doPreload no longer pre-supplies _builtLocation, because the built location is no
longer kept in render state. preloadRoute already falls back to building it, which
is what handleClick has always relied on for router.navigate.

The isActive and externalLink bodies move to module-level helpers unchanged so the
selector stays readable; activeOptions is spread into its four primitive fields in
the dependency list because callers routinely pass an inline object literal.

* refactor: trim redundant comments and brace single-line bodies

The comments explained the bail-out rationale twice — once on the LinkState type
and again above the selector — and two helper docblocks restated their function
names. The rationale now appears once, where a reader meets the selector; the
detail belongs in the PR description rather than the source.

Also braces the three single-line if bodies, per the AGENTS.md rule that if/else
bodies always use curly braces.

* refactor: publish link state as a tuple

The type is erased either way, but the object literal's property names survive
minification and a tuple's positions don't — so this drops three property names
from the selector's return plus the three property reads in compareLinkState.

Measured on the unminified build: -54 bytes in dist/esm/link.js and the same in
dist/cjs/link.cjs.

* test: assert the published link state, and drop a redundant cast

The render-count assertions proved the bail-out but not that the selector still
publishes correct values, so a selector returning a constant could have passed.
The test now also asserts that the link gaining active state carries
`data-status="active"` afterwards (and does not beforehand), and that the
unaffected link keeps its href and stays inactive.

Checked by sabotaging the selector: returning a constant tuple with a wrong href
but a correct active state now fails, where previously it passed.

Also drops `as any` from `new URL(to)` in resolveExternalLink — the guard above
already narrows `to` to string.

* refactor: pass activeOptions through instead of destructuring

Depends on the four fields rather than the object, with an exhaustive-deps
disable: callers routinely pass an inline literal, which would otherwise rebuild
the selector every render. resolveIsActive reads only those four fields, so the
disable is not hiding a live dependency.

-269 bytes on each of dist/esm/link.js and dist/cjs/link.cjs (unminified).

* perf: memoize the href derivation on the built href

The `useMemo` chain this replaced keyed `getHrefOption` and the external-link
resolution on the href string, so a navigation that left a link's href alone
skipped both. Deriving everything in the selector ran them on every location
notification instead, which showed up as a ~10% regression on the client-nav
rewrites benchmark, where rewrite handling makes `getHrefOption` expensive.

Cache both on the built href inside the selector closure. Measured on a
five-link root layout, per navigation: getHrefOption drops from 5 calls back to
0, matching the pre-change profile, with buildLocation and the active-state
derivation unchanged at 5.

* perf: keep _options referentially stable while its contents are equal

Links commonly pass inline `params` / `search` object literals. Those change
identity on every parent render, which rebuilt `_options`, which changed the
store selector's identity, which discarded useSyncExternalStoreWithSelector's
memoized selection. buildLocation then ran twice per navigation: once in the
notification check and once in the render-phase selection.

Measured on a replica of the client-nav rewrites scenario (six links, root
subscribed to the pathname via useLocation), buildLocation per navigation:
base 7, before this commit 12, after 7.

* revert: drop the href memoization, it measured no benefit

Reverts 409371b. It did cut getHrefOption from 5 calls per navigation to 0,
matching the pre-change profile, but that is not where the time went: on the
rewrites scenario it moved the number by 0.05% (medians 245.33 vs 245.21 hz over
four interleaved rounds). Not worth ~15 lines of mutable closure state.

The rewrites regression is fixed by the _options stabilisation instead.

* docs: explain why useValueStable exists

Replaces a leftover scratch note.

* perf: cut the bundle cost of the link state selector

Stabilise `activeOptions` with the same helper used for `search` / `params`,
so the selector depends on one value instead of four destructured fields. That
also makes the dependency array honest, so the exhaustive-deps disable goes.

Drop the reference-equality guard in useValueStable: deepEqual already
short-circuits on `a === b`, so the guard only saved a function call that
returns immediately.

Measured with benchmarks/bundle-size against this branch's base, gzip delta
across the eight React scenarios moves from +27/-7 to +11/-24, and raw bytes go
uniformly negative (-37 to -45 on every scenario).

* perf: pass _options to preloadRoute without the shallow clone

The spread existed to add _builtLocation, which is gone, and nothing on the
preload path mutates the options object: preloadRoute only reads
opts._builtLocation, build() only reads dest fields, and the search middleware
chain only reads dest.search. Search middlewares themselves receive
{ search, next }, never dest.

Saves an object allocation per hover. Bytes are unchanged on gzip, -5 raw.

* fix: do not collapse explicit-undefined params when stabilising link options

useValueStable compared with deepEqual's default ignoreUndefined: true, which
skips undefined-valued keys on both sides, so `{}` and `{ category: undefined }`
compared equal. Those build different locations: an explicit undefined clears an
inherited optional param while an empty object inherits it. A Link whose params
changed from one to the other kept publishing the stale href, and click and
preload used the stale options too.

Compare with ignoreUndefined: false. Adds a regression test covering the
/posts/tech -> /posts transition, which fails before this commit and passes
after, and passes on the pre-PR baseline.

* chore: empty commit to re-trigger CI

* chore: add changeset

---------

Co-authored-by: Flo <me@florianpellet.com>
2026-08-07 17:37:30 +02:00
Flo
6bede65d70
perf(start): compact deferred hydration private state (#7980)
* perf(solid-start): shorten private prefetch state

* perf(start): use locals for hydration wait state

* perf(start): compact visible observer registry entries

* test(start): cover hydration private-state lifecycles

* docs: record solid hydration bundle result

* Delete RESULT-optimization-solid-hydration-private-state.md

* changeset

* ci: Version Packages (#7993) [Self-Healing CI Rerun]

---------

Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-08-07 17:30:30 +02:00
Flo
2fbc99f2c2
perf(start-client-core): compact private frame decoder result keys (#7978)
* perf(start-client-core): compact frame decoder result keys

* docs: record compact frame result evidence

* docs: record frame result attribution and e2e

* Delete RESULT-optimization-frame-decoder-compact-result.md

* changeset
2026-08-07 15:18:37 +02:00
github-actions[bot]
995bd97a9f
ci: Version Packages (#7993)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-07 13:04:38 +02:00
Flo
ea3a665d81
fix(router): retain mounted UI during revalidation (#7992)
* fix(router): retain mounted UI during revalidation

* fix(router): preserve initial pending presentation

* changeset

* test(router): make retained pending tests deterministic

* complete solid/vue suite
2026-08-07 11:57:59 +02:00