0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

14 commits

Author SHA1 Message Date
Kyle Mathews
988a9d6788
test: add invariant and property tests for code-splitter shared bindings (#6662)
* test: add invariant, property, and exhaustive tests for code-splitter shared bindings

Add 76 new tests across three layers for the shared virtual module
code-splitting logic introduced in #6659:

Layer 1 - Algebraic property tests on helper functions:
- expandTransitively: idempotence, monotonicity, cycle handling
- buildDependencyGraph: subset invariants
- removeBindingsDependingOnRoute: direct/transitive removal
- expandDestructuredDeclarations: idempotence, sibling expansion
- collectLocalBindingsFromStatement: all declaration types

Layer 2 - Invariant tests on computeSharedBindings:
- Route is never in the shared set
- Results are always real local bindings (never imports)
- Destructured siblings cohesion
- Transitive dependency inclusion
- Route-dependent binding exclusion
- Determinism across repeated calls

Layer 3 - Small-scope exhaustive tests:
- Single binding × 3 declaration kinds × 4 property patterns × 2 groupings
- Two bindings × 4 cross-group reference patterns × 2 groupings
- Transitive dependency chains (linear, 3-deep, diamond)
- Meta-invariant conformance across all shared-* fixture files

Testing approach inspired by:
https://gist.github.com/KyleAMathews/64bcea53a57f600cc3b73bc366d9ac4d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: apply automated fixes

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-02-14 18:41:23 +01:00
Manuel Schiller
523972e0df
fix: shared virtual module for code-split routes (#6659)
* fix: shared virtual module for code-split routes

When a route file has module-level bindings (variables, functions, classes) referenced by **both** split and non-split route properties, the bindings are duplicated — initialized independently in the reference file and in each virtual split file. This breaks singletons, causes double side effects, and wastes bundle size.

```tsx
const collection = { name: 'todos', preload: async () => {} }
export const Route = createFileRoute('/todos')({
  loader: async () => {
    await collection.preload()
  }, // stays in reference
  component: () => <div>{collection.name}</div>, // split to virtual
})
```
In this example, `collection` is initialized in **both** the reference file (because `loader` references it) and the `?tsr-split=component` virtual file (because the component references it). Two separate instances exist at runtime.

To solve this issue, this PR introduces a third virtual module `route.tsx?tsr-shared=1` that contains shared bindings. Both the reference and virtual files import from it.

When `sharedBindings` is empty (the common case — component-only helpers, loader-only code), no shared module exists and the system works exactly as today.

The reference transform runs first and will emit a static import of `?tsr-shared=1` **only when needed**. Since split chunks are only discovered via the reference file's emitted `import('...?tsr-split=...')`, the bundler will always process/evaluate the reference module first. Result: the shared module is evaluated once and then reused by any later-loaded split chunk.
2026-02-14 13:10:54 +01:00
Manuel Schiller
5022a60d2e
fix: only transform files in codesplitter if changes were made (#5460) 2025-10-13 01:32:01 +02:00
Sean Cassiere
b9f88c5426
test(router-plugin): split addHmr snapshot testing (#4612) 2025-07-10 19:49:47 +12:00
Manuel Schiller
d728d69900
feat: ssr setting per route (#4565)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-05 14:35:14 +02:00
Manuel Schiller
8b5accb27c
feat: Merge alpha to main (#4365)
Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
Co-authored-by: Tanner Linsley <tannerlinsley@users.noreply.github.com>
Co-authored-by: Iha Shin (신의하) <me@xiniha.dev>
Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
Co-authored-by: MoeedDar <moeed.dar@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Saša Šijak <me@ssijak.com>
Co-authored-by: Christopher Horobin <chrishorobin@hotmail.com>
Co-authored-by: Ryan Gillie <gillie.ryan@hotmail.com>
Co-authored-by: Jaga Santagostino <jagasantagostino@gmail.com>
Co-authored-by: Birk Skyum <birk.skyum@pm.me>
Co-authored-by: Yeoh Joer <yeoh.joer@outlook.com>
Co-authored-by: Dane Grant <danecando@gmail.com>
Co-authored-by: Birk Skyum <74932975+birkskyum@users.noreply.github.com>
Co-authored-by: Luis Merino <mail@luismerino.name>
Co-authored-by: ThaumRystra <9525416+ThaumRystra@users.noreply.github.com>
Co-authored-by: Adam Hunter <arhunter@gmail.com>
Co-authored-by: Leonardo Montini <lion.48m@gmail.com>
Co-authored-by: Joel Tannas <jtannas@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: Lenz Weber-Tronic <lorenz.weber-tronic@apollographql.com>
Co-authored-by: Iñaki Larramendi <30437204+ilarramendi@users.noreply.github.com>
Co-authored-by: Hiển Đào Vinh <neo.go.vn@gmail.com>
Co-authored-by: Lleyton W Morris <42259073+ViewableGravy@users.noreply.github.com>
Co-authored-by: Lleyton Morris <lmorris@nexigen.digital>
Co-authored-by: Matthew Struble <matt@vevox.io>
Co-authored-by: Matt Anderson <matt@mattdev.ca>
Co-authored-by: Chung <chungwong@users.noreply.github.com>
Co-authored-by: Maxx Coffee <josh@joshcoffee.dev>
Co-authored-by: Joshua Coffee <joshcoffee@gannett.com>
Co-authored-by: Jack Herrington <jherr@pobox.com>
Co-authored-by: Neeraj Dalal <admin@nrjdalal.com>
Co-authored-by: Thomas Marnet <thomas.marnet@gmail.com>
Co-authored-by: Vianney Carel <vcarel@users.noreply.github.com>
Co-authored-by: Vianney Carel <vianney.carel@logfuse.fr>
Co-authored-by: Diego Rincón <97266392+diegoarff@users.noreply.github.com>
Co-authored-by: Erfan Hosseini <43422324+Erfanhosseini98@users.noreply.github.com>
Co-authored-by: IderAghbal <3328396+IderAghbal@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andrew Jefferson <8148776+eastlondoner@users.noreply.github.com>
2025-06-10 23:19:32 +02:00
Sean Cassiere
e88b960702
refactor(router-plugin): code-splitting to be agnostic to support 'targets' (#3400) 2025-02-12 15:21:06 +13:00
Sean Cassiere
cf693e7353
feat(router-plugin): configurable key-based code splitting (#3355) 2025-02-09 14:09:18 +13:00
Sean Cassiere
323820b6f6
fix(router-plugin): reduce route-tree bundle size (#3354)
Currently, when using `automaticCodeSplitting`, as part of compiling the "reference" route, we add a component (named `TSRDummyComponent`) to aid with the HMR trickery.

In removing this component from the production bundle, it impacts the visitor by reducing the initial js bundle that wires the route-tree.
2025-02-07 23:42:56 +13:00
Manuel Schiller
40dd906868
fix: do not minify during code splitting (#3189)
fixes #3183
2025-01-18 08:55:48 +01:00
Sean Cassiere
68b5b528c7
refactor(router plugin): restructure the plugin's internals (#2155)
* chore(router-plugin): rename "code-splitter" to "router-code-splitter"

* refactor(router-plugin): follow unplugin standards and move lib code into "core"

* test(router-plugin): update imports
2024-08-21 00:13:07 +12:00
Sean Cassiere
bfe73c0a41
refactor(router-plugin): use babel-dead-code-elimination to handle the removal of unreferenced code (#1855)
* chore(router-plugin): add `babel-dead-code-elimination`

* feat(router-plugin): initial implementation

* chore(router-plugin): better test scripts

* test(router-plugin): check it with the new functions

* fix(start-vite-plugin): add vite

* feat(router-plugin): bump unplugin

* fix(router-plugin): making sure it works

* chore(router-plugin): cleanup

* chore(router-plugin): delete "eliminateUnreferencedIdentifiers.ts"

* fix(router-plugin): esm problems

* chore(router-plugin): restore minification for production

* chore(start-vite-plugin): undo the vite

* Bump vite

* pnpm dedupe

* test(router-plugin): bit of renaming here

---------

Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com>
2024-06-29 14:16:02 +12:00
Sean Cassiere
e5d8b815db
fix(router-plugin): inline-config should be optional (#1783)
* fix(router-plugin): package.json fields causing issues during imports

* fix: make the inlineConfig optional

* chore: trigger ci

* chore: try ci again

* chore: add a better readme

* test: just something to trigger CI honestly
2024-06-19 17:53:55 +12:00
Sean Cassiere
40043475cf
refactor: setup the @tanstack/router-plugin package using "unplugin" (#1778)
* feat: scaffold the new `@tanstack/router-plugin` package

* chore: include in the overrides

* feat: more scaffolding

* test: just a random test that'll be removed later

* build: hopefully fixes build

* style: import order

* chore: peer deps for router-plugin

* feat: setup the generator

* refactor: combined needs to be done for the individual plugin

* chore: copy all the babel stuff over from router-vite-plugin

* feat: copy the babel plugin setup from router-plugin

* feat: enfore pre

* refactor: turn the error into its own custom one

* style: eslint

* style: more eslint

* chore: update the readme
2024-06-19 15:43:31 +12:00