0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

10 commits

Author SHA1 Message Date
Jason Xie
4814d4ef90
fix(router-core): use encodeURIComponent for splat route params (#6520)
* fix(router-core): use encodeURIComponent for splat route params

Use encodeURIComponent instead of encodeURI for splat route parameters
to properly encode spaces, plus signs, and other special characters.

This fixes an SSR redirect loop that occurs when:
1. User navigates to a splat route with encoded characters (e.g., %20)
2. TanStack Router decodes params with decodeURIComponent
3. When rebuilding URL, encodeURI doesn't encode spaces/special chars
4. URL mismatch triggers redirect loop (307 redirects)

encodeURIComponent properly encodes these characters, preventing the
mismatch while still preserving forward slashes as path separators.

* update tests to use correct encoding for splat params

* use encodePathParam for splat/catch-all

* perf(router-core): add early return for URL-safe splat values

Add performance optimization that skips the split/map/join operation
when splat values only contain URL-safe characters (alphanumeric,
dash, period, underscore, tilde, exclamation, forward slash).

This avoids unnecessary processing in the hot path for common cases.

* fix(router-core): encode whitespace in encodeNonAscii

Update encodeNonAscii to also encode whitespace characters (spaces, tabs, etc.)
in addition to non-ASCII characters. This fixes SSR redirect loops where:

1. Request URL contains encoded spaces: /path/file%20name.pdf
2. parseLocation decodes pathname: /path/file name.pdf
3. buildLocation calls encodeNonAscii but spaces weren't encoded
4. URL mismatch triggers redirect loop

Now encodeNonAscii properly encodes:
- Whitespace characters (spaces become %20)
- Non-ASCII/unicode characters (including emojis)

Other ASCII special characters (parentheses, brackets, etc.) are preserved
as they are valid in URL paths.

* refactor(router-core): use regex in encodeNonAscii like original

* refactor(router-core): rename encodeNonAscii to encodePathLikeUrl

Rename the function to better reflect its expanded responsibility of
encoding paths the same way new URL() would, including:
- Whitespace characters (spaces → %20, tabs → %09)
- Non-ASCII/Unicode characters (emojis, accented characters)

The old name 'encodeNonAscii' was misleading since the function now
encodes more than just non-ASCII characters.

---------

Co-authored-by: Nico Lynzaad <nlynzaad@zylangroup.com>
Co-authored-by: Nico Lynzaad <44094871+nlynzaad@users.noreply.github.com>
2026-01-26 23:53:20 +02:00
Birk Skyum
da770787fa
fix(solid-router): setting search params with 2 parallel navigate calls (#5797) 2025-11-09 16:09:18 +01:00
Nico Lynzaad
26f23faf13
refactor(router-core): consistent Unicode handling (#5736)
* add router-core fixes and update tests

* update react-router unit tests

* update react-router e2e tests

* update solid-router unit tests

* update solid-router e2e tests

* update test description

* rename function

* rename test as per codeRabbit nitpick

* test cleanup
2025-11-06 03:35:59 +02:00
Birk Skyum
76c4f614f2
fix(solid-router): implement navigation transitions (#5691) 2025-11-04 03:51:16 +01:00
Paul Sachs
3eccdebd0a
fix(router-core): add support for handling any kind of empty _splat consistently (#5510)
* Add support for handling any kind of empty _splat consistently

* Add navigate test for empty spat

* Added useNavigate test

* Added full trailingSlash options testing matrix

* Refactored the trailing slash cases

* export trailingSlashOptions from router-core

* replicate tests for solid

* ci: apply automated fixes

* fix test name interpolation

* correct waitFor usage

* fix eslint error

---------

Co-authored-by: Nico Lynzaad <44094871+nlynzaad@users.noreply.github.com>
Co-authored-by: Nico Lynzaad <nlynzaad@zylangroup.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-21 01:13:39 +02:00
Nico Lynzaad
2df8e52ba0
fix(Relative routing): Default relative routing to current location (#4978)
When using relative routing we have 3 things to consider:

1) Is this relative to the current location? This is specifically
relevant for using `to="."` and `to=".."` in layout routes
2) Is this relative to the rendered route location?
3) Should this be relative to some other route in the tree

We have had a few issues where it hasn't been clear how relative routing
is applied in various scenarios, and where the application differs, for
example `to="."` and `to=".."` was treated differently.

This PR applies the following:
1) when no from path is specified, navigation is done from the current
location, this does not affect absolute paths but makes relative paths
more standardised.
2) other relative navigations require a from location to be specified.

This is achieved by setting Link and useNavigate to default to the
current active location instead of the rendered route location. This
also simplifies the logic in buildLocation as we no longer specifically
cater for `to="."`.

Included in this PR is the required changes to router-core
(buildLocation), react-router and solid-router (Link and useNavigate),
tests for both react-router and solid-router and an update to the docs
to clarify the usage.

This closes #4842

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added active-location hooks, origin-aware navigation helpers,
programmatic Route API for Link generation, browser-history utilities,
optional from origin for Navigate, and route fullPath exposure.

* **Bug Fixes**
* More deterministic relative navigation (., ..) resolution,
preservation of search/params, and runtime warnings for invalid origins.

* **Documentation**
  * Clarified relative-link semantics and updated examples.

* **Tests**
* Vastly expanded end-to-end coverage for relative navigation, masking,
basepath, and trailing-slash permutations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-26 19:30:31 +02:00
Jan Vollmer
785681fa05
fix(router-core): resolve with basepath if to is not supplied (#4472)
Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
2025-06-23 11:23:57 +12:00
Manuel Schiller
c9a32784ce
fix: use fullPath as from in Route/RouteApi useNavigate (#3684)
fixes #3679
2025-03-06 23:58:51 +01:00
Manuel Schiller
a638d77ac8
fix: use default from in useNavigate (#3671)
fixes #3668
2025-03-05 22:15:21 +01:00
Birk Skyum
ad20a68491
feat(solid-router): Add a SolidJS driver for TanStack Router (#3276)
* copy react-router

* update

* Move forward branch

* cleanup

* cleanup

* add publish

* bump deps

* ci: apply automated fixes

* remove unused imports

* ci: apply automated fixes

* bump  vite plugin solid

* fix imports

* ci: apply automated fixes

* remove react lint from solid-router

* fix types

* ci: apply automated fixes

* add structuralSharing

* downgrade vite plugin solid

* fix scroll-restoration in solid-router

* fix Transitioner

* fix imports from ScrollRestoration

* Fix tests

* Fix more tests

* Remove the react $$typeof

* add accessors to useLocation

* add remountDeps

* cleanup

* remove tanstack/store

* format

* add missing call to setupScrollRestoration

* format

* add optional

* align match component

* make matches a signal

* Bump vite-plugin-solid to stable

* add missing await

* Fix unknown error

* Tweak the tests to call functions

* remove unused vars

* fix lockfile

* Down to 25 failures

* Remove .only

* call search()

* remove the structuralSharing

* fix type test

* fix structuralSharing

* comment out structured sharing validation check

* fix typings

* comment out serialization check

* comment out serialization check

* cleanup

* improve types of useSearch

* fix "when setting search params with 2 parallel navigate calls"

* fix useParams

* fix types

* fix useParams types

* cleanup debug

* fix link data loader

* fix data loader signal

* fix type test

* fix Link "when navigating away from a route with a loader that errors"

* setup on() simpler

* make initial load a createRenderEffect

* Fix some link preload tests

* add accessor to UseMatchRoute

* fix: when navigating to /posts with a beforeLoad that returns context

* call parentRouteId

* re-enable invariant

* fix when navigating from /invoices to ./invoiceId and the current route is /posts/$postId/details

* use memo for prev

* remove browserhistory  workaround

* fix  "after a navigation, should have emitted the "onResolved" event twice"

* skip remount

* add types to useSearch

* fix search middleware

* don't need a getter

* sync react-router

* solid kitchen sink

* add the example to workspace

* lockfile

* fix solid kitchensink name

* add solid template

* fix example

* rename react to solid

* work on example

* add accessor

* fix type tests

* Fix login in example

* Don't destructure

* Fix stuck on pending component

* Fix where loaderData can be undefined

* Use For component

* More refactor

* Hacky way to fix loading spinner

* Fix one test

* Better MatchRoute fix

* Down to 1 failing test

* Fix last test

* cleanup subscription

* lockfile

* eslint

* ci: apply automated fixes

* fix router-core lint

* ci: apply automated fixes

* add e2e test for solid-router

* ci: apply automated fixes

* work on solid-router e2e suites

* fix comment

* use solid-virtualizer

* work on scroll-restauration

* work on scroll-restauration

* skip react-specific useRenderEffect test

* fix errorcomponent being used before it's defined

* set solid target for esbuild

* ci: apply automated fixes

* fix rspack tests

* fix query tets

* add solid-query example

* use memo for post

* add memo for posts

* fix example

* add jsx compiler flags to esbuild commands

* add esbuild-plugin-solid

* Fix some e2e

* ci: apply automated fixes

* port #3423 from react-router

* fix useLoaderData test-d

* add codeSplitGroupings

* Scroll restoration fixes

* add asset headcontent script

* remove solid-router-copy

* fix react use

* fix scroll restoration test

* skip esbuild because it's broken in react-router

* wait for timeout

* update scroll-restoration to match react

* useLocation

* use on() in match

* align useNavigate with react-router

* lockfile

* fix Scripts test

* align __TSR_SSR__ in ScriptOnce

* remove solid-router from publish

* lint

* ci: apply automated fixes

* align to react-router

* port over "exclude props from state equality check to prevent history push for equal url and state"

* align with react-router

* add shouldThrow

* fix typePrimitives

* use searchStr to fix the search middleware

* ci: add solid-router to the labeler

* use patched vite-plugin-solid

* eslint

* ci: apply automated fixes

* use vite-plugin-solid 2.11.2

* remove only modifier

* move vite-plugin-solid peerDep to router-plugin

* use latest vite-plugin-solid

* move vitest to root

* bump vitest

* revert onRendered

* lint

* add to publish

* fix scroll restoration

* ci: apply automated fixes

* align version with react-router

* sync to react-router

* sync with react-router

* sync navigate tests to react-router

* ci: apply automated fixes

* use Solid.JSX.Element consistently instead of Solid.JSXElement

* remove irrelevant test

* ci: apply automated fixes

* remove unused suite

* lint

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
2025-02-20 17:11:39 +01:00