Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Manuel Schiller <manuel.schiller@caligano.de>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
A lot of our e2e tests are querying external endpoints like
[typicode.com](https://jsonplaceholder.typicode.com) or
[example.com](https://example.com)
This is not ideal as it makes the e2e tests beholden to external factors
for example unavailability or rate limiting of these endpoints.
This PR addresses this by starting and stopping a local dummy server for
each test that needs to query external endpoints and mocks the results.
The setup and teardown have been implemented on each test package
individually so as to allow custom requirements where needed.
---------
Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
This is a follow on from #4653
This PR resolves flaky E2E tests caused by port collisions when running
tests in parallel.
Instead of deriving ports from package names (which can collide), this
new approach assigns a random, available port to each test server
instance.
Key Changes:
- Random Port Allocation: Each test server (Playwright, dummy servers)
gets a unique, random port at startup.
- File-based Sync: The server writes its assigned port to a port.txt
file in its test project directory, this is kept unique through using
the package name or another input string for the file name.
- Test Runner Sync: The test runner reads the port from that file to
build the correct URL.
- Automatic Cleanup: All port files are deleted at the start of each
test:e2e run to ensure fresh ports.
Local parallel runs (up to 10) have shown this to be stable and free of
collisions.
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
The original `@tanstack/router-devtools` package still work - it's not
touch by this PR in any way, apart from a migration note saying:
>[@tanstack/router-devtools] Warning: This package has moved to
@tanstack/react-router-devtools. Please switch to the new package, as
this package will be dropped soon.
This introduce three new packages
- @tanstack/router-devtools-core : This is a SolidJS port of the UI
And two adapters on top, that mount this solid app and forward
router/routerState into it.
- @tanstack/solid-router-devtools
- @tanstack/router-router-devtools
For use of devtools in production, a `TanStackRouterDevtoolsInProd` can
be imported instead of the standard `TanStackRouterDevtools` that'll be
tree shaken away in prod.
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com>
Picking solid-router relevant changes from
[commit](https://github.com/TanStack/router/pull/3522/commits/9eaa09ea1f95f786e9bd239fe787f10d6cb08e1c)
by @brenelz , that fixes assets handler in solid-router by using
`@solidjs/meta`.
With this, the head tags like the title will update on client
navigation.
The changes in this PR that affect most files are merely repetitions of:
- bumping solid 1.9.4 -> 1.9.5
- inserting `<HeadContent>` in the root route
- removing `<title>` from the index.html
Includes an automated test for solid-router corresponding to
- https://github.com/TanStack/router/pull/3610
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* copy react-router
* update
* Move forward branch
* cleanup
* cleanup
* add publish
* bump deps
* ci: apply automated fixes
* remove unused imports
* ci: apply automated fixes
* bump vite plugin solid
* fix imports
* ci: apply automated fixes
* remove react lint from solid-router
* fix types
* ci: apply automated fixes
* add structuralSharing
* downgrade vite plugin solid
* fix scroll-restoration in solid-router
* fix Transitioner
* fix imports from ScrollRestoration
* Fix tests
* Fix more tests
* Remove the react $$typeof
* add accessors to useLocation
* add remountDeps
* cleanup
* remove tanstack/store
* format
* add missing call to setupScrollRestoration
* format
* add optional
* align match component
* make matches a signal
* Bump vite-plugin-solid to stable
* add missing await
* Fix unknown error
* Tweak the tests to call functions
* remove unused vars
* fix lockfile
* Down to 25 failures
* Remove .only
* call search()
* remove the structuralSharing
* fix type test
* fix structuralSharing
* comment out structured sharing validation check
* fix typings
* comment out serialization check
* comment out serialization check
* cleanup
* improve types of useSearch
* fix "when setting search params with 2 parallel navigate calls"
* fix useParams
* fix types
* fix useParams types
* cleanup debug
* fix link data loader
* fix data loader signal
* fix type test
* fix Link "when navigating away from a route with a loader that errors"
* setup on() simpler
* make initial load a createRenderEffect
* Fix some link preload tests
* add accessor to UseMatchRoute
* fix: when navigating to /posts with a beforeLoad that returns context
* call parentRouteId
* re-enable invariant
* fix when navigating from /invoices to ./invoiceId and the current route is /posts/$postId/details
* use memo for prev
* remove browserhistory workaround
* fix "after a navigation, should have emitted the "onResolved" event twice"
* skip remount
* add types to useSearch
* fix search middleware
* don't need a getter
* sync react-router
* solid kitchen sink
* add the example to workspace
* lockfile
* fix solid kitchensink name
* add solid template
* fix example
* rename react to solid
* work on example
* add accessor
* fix type tests
* Fix login in example
* Don't destructure
* Fix stuck on pending component
* Fix where loaderData can be undefined
* Use For component
* More refactor
* Hacky way to fix loading spinner
* Fix one test
* Better MatchRoute fix
* Down to 1 failing test
* Fix last test
* cleanup subscription
* lockfile
* eslint
* ci: apply automated fixes
* fix router-core lint
* ci: apply automated fixes
* add e2e test for solid-router
* ci: apply automated fixes
* work on solid-router e2e suites
* fix comment
* use solid-virtualizer
* work on scroll-restauration
* work on scroll-restauration
* skip react-specific useRenderEffect test
* fix errorcomponent being used before it's defined
* set solid target for esbuild
* ci: apply automated fixes
* fix rspack tests
* fix query tets
* add solid-query example
* use memo for post
* add memo for posts
* fix example
* add jsx compiler flags to esbuild commands
* add esbuild-plugin-solid
* Fix some e2e
* ci: apply automated fixes
* port #3423 from react-router
* fix useLoaderData test-d
* add codeSplitGroupings
* Scroll restoration fixes
* add asset headcontent script
* remove solid-router-copy
* fix react use
* fix scroll restoration test
* skip esbuild because it's broken in react-router
* wait for timeout
* update scroll-restoration to match react
* useLocation
* use on() in match
* align useNavigate with react-router
* lockfile
* fix Scripts test
* align __TSR_SSR__ in ScriptOnce
* remove solid-router from publish
* lint
* ci: apply automated fixes
* align to react-router
* port over "exclude props from state equality check to prevent history push for equal url and state"
* align with react-router
* add shouldThrow
* fix typePrimitives
* use searchStr to fix the search middleware
* ci: add solid-router to the labeler
* use patched vite-plugin-solid
* eslint
* ci: apply automated fixes
* use vite-plugin-solid 2.11.2
* remove only modifier
* move vite-plugin-solid peerDep to router-plugin
* use latest vite-plugin-solid
* move vitest to root
* bump vitest
* revert onRendered
* lint
* add to publish
* fix scroll restoration
* ci: apply automated fixes
* align version with react-router
* sync to react-router
* sync with react-router
* sync navigate tests to react-router
* ci: apply automated fixes
* use Solid.JSX.Element consistently instead of Solid.JSXElement
* remove irrelevant test
* ci: apply automated fixes
* remove unused suite
* lint
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>