0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

43 commits

Author SHA1 Message Date
chorobin
581f1e56a6 tests and examples fixed 2025-08-28 23:07:23 +02:00
chorobin
c145e397d8 serialization pls 2025-08-28 00:02:09 +02:00
Nico Lynzaad
d56aa42a8a Merge branch 'relative-routing-to-current-location' into alpha 2025-08-26 23:45:03 +02:00
chorobin
b54d056109 "serialization rulez" second attempt 2025-08-24 23:24:19 +02:00
Manuel Schiller
1ab8d26826 Merge remote-tracking branch 'origin/main' into HEAD 2025-08-20 18:32:40 +02:00
autofix-ci[bot]
452f876729
ci: apply automated fixes 2025-08-19 03:32:37 +00:00
Nico Lynzaad
8f41f218f5 cleanup tests 2025-08-19 00:12:47 +02:00
Nico Lynzaad
0c9b67a0fb apply code rabbit suggestions 2025-08-17 22:06:44 +02:00
Nico Lynzaad
d5701da026 Merge branch 'main' into relative-routing-to-current-location
# Conflicts:
#	packages/router-core/src/router.ts
2025-08-17 21:16:53 +02:00
Flo
642964e4e3
refactor(router-core): reduce buildLocation object allocations (#4981)
When we can (and it's reasonable), it's always beneficial to reduce the
number of objects we create in JS, so as to minimize the memory pressure
and the GC work.

`buildLocation` gets called pretty often, so removing a few object
allocations can be very beneficial (especially inside loops).

Also, from a purely "immediate performance" point of view,
`Object.assign` tends to be faster than `{...foo}`.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Route parameter and search handling now use in-place updates to reduce
allocations and streamline iteration/control flow; behavior and public
API remain unchanged.
* **Tests**
* Updated tests to capture cloned parameter objects and assert on exact
values rather than relying on mock call history, preventing
mutation-related flakiness.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-17 18:35:45 +02:00
autofix-ci[bot]
44ad37c868
ci: apply automated fixes 2025-08-17 13:50:59 +00:00
Nico Lynzaad
745107c9bc replicate changes to Solid 2025-08-17 15:23:55 +02:00
Manuel Schiller
bcfe15e676 Merge remote-tracking branch 'origin/main' into HEAD 2025-08-16 19:14:18 +02:00
Flo
d6a77e1d6b
refactor(router-core): flatten loadMatches (#4961)
This PR *should* be a no-op. Just restructuring the code to have all the
functions used by `loadMatches` at the same level, instead of nested
callbacks. In order to still have access to the data that was previously
in scope because of nesting, we use a `innerLoadContext` object, which
is basically just the arguments of `loadMatches`, and a few mutables.

However, in order to do so, we have to rearrange promises in an area
that is sensitive to any microtask order change, and we did change some
of them. So this is not *really* a no-op, even though this does not
attempt any optimization.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- New Features
- Smoother navigations with predictable pending states and minimum
display durations.
  - More consistent head/meta updates after route loading.
- Bug Fixes
- More reliable redirects and 404 handling, including during preloading
and SSR.
  - Reduced UI flicker by refining pending and preloading behavior.
- Refactor
- Reworked the routing load pipeline for improved performance,
stability, and SSR behavior.
- Streamlined before-load steps for clearer, more consistent execution.
- Tests
  - Updated tests to reflect the new loading flow.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-08-15 23:19:56 +02:00
Sean Cassiere
63c6df8d13
test(solid-router): add test from #4930 (#4941) 2025-08-13 13:36:12 +12:00
Manuel Schiller
fa7a554c49 don't reexport invariant/warning 2025-08-09 01:00:47 +02:00
Manuel Schiller
3c6633a705
chore: silence error in test (#4794)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-26 23:05:17 +02:00
Jaen
e83199310a
feat(react-router): add disableGlobalCatchBoundary option (#4765)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Manuel Schiller <manuel.schiller@caligano.de>
2025-07-26 22:45:20 +02:00
wookhyung
7c6d4c1325
fix(router-core): reset statusCode to 200 on navigation start (#4664)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-18 00:25:35 +02:00
Flo
89c7b5d660
test(react-router,solid-router): test re-render for preload='viewport' (#4672) 2025-07-17 19:15:11 +12:00
Indrek Ardel
db1331f9b8
tests(solid-router): enable ClientOnly SSR test (#4666) 2025-07-16 19:58:35 +02:00
Indrek Ardel
ba590c2111
fix(solid-router): prevent client effects running on server (#4621) 2025-07-15 22:19:37 +02:00
Nico Lynzaad
96032358b2
fix: buildLocation check for non changing routes - consider trailing slashes (#4581)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-06 18:22:11 +02:00
Brenley Dueck
eb8a5f0773
fix(solid-router): loaders being called twice during SSR (#4574)
Basically my understanding is that the `load` function gets called once
during SSR but right now our `Transitioner` calls it again as it appears
`createRenderEffect` run on the server too where as the `useEffect` in
React doesn't.

The fix is just to bail out if its running on the server. Feels kinda
hacky but it works.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-06 07:54:13 +02:00
Felipe Stanzani
ceec4f2102
feat: Add style to HeadContent (#4559)
Currently Route HeadContent don't have support to inline style tags.

After a contribution proposition made by @schiller-manuel in the Discord
Group I have decided to implement this.

I also have used this in the basic example for react-start and
solid-start and added style and style w/loader test cases to both
modules.

---------

Co-authored-by: Flo <fpellet@ensc.fr>
2025-07-02 00:28:12 +02:00
Naoya Shimizu(Shimmy)
980159ae10
refactor(history): use TSR_key namespace in state for hash (#4356)
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
2025-06-23 14:48:54 +12:00
Jan Vollmer
785681fa05
fix(router-core): resolve with basepath if to is not supplied (#4472)
Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
2025-06-23 11:23:57 +12:00
wookhyung
adc5d5ce94
fix(react-router, solid-router): make head function scripts load properly (#4323) 2025-06-18 22:03:06 +02:00
Karolis Užkuraitis
c75daad9ea
fix(solid-router): Change <Link/>, <Block/> properties to be reactive (#4314)
Change <Link/> and <Block/> elements to use `createMemo` and
`splitProps` to preserve reactivity.
Render children only once / Remove props spreading

#4209

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-06-11 20:47:39 +02:00
Manuel Schiller
8b5accb27c
feat: Merge alpha to main (#4365)
Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
Co-authored-by: Tanner Linsley <tannerlinsley@users.noreply.github.com>
Co-authored-by: Iha Shin (신의하) <me@xiniha.dev>
Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
Co-authored-by: MoeedDar <moeed.dar@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Saša Šijak <me@ssijak.com>
Co-authored-by: Christopher Horobin <chrishorobin@hotmail.com>
Co-authored-by: Ryan Gillie <gillie.ryan@hotmail.com>
Co-authored-by: Jaga Santagostino <jagasantagostino@gmail.com>
Co-authored-by: Birk Skyum <birk.skyum@pm.me>
Co-authored-by: Yeoh Joer <yeoh.joer@outlook.com>
Co-authored-by: Dane Grant <danecando@gmail.com>
Co-authored-by: Birk Skyum <74932975+birkskyum@users.noreply.github.com>
Co-authored-by: Luis Merino <mail@luismerino.name>
Co-authored-by: ThaumRystra <9525416+ThaumRystra@users.noreply.github.com>
Co-authored-by: Adam Hunter <arhunter@gmail.com>
Co-authored-by: Leonardo Montini <lion.48m@gmail.com>
Co-authored-by: Joel Tannas <jtannas@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: Lenz Weber-Tronic <lorenz.weber-tronic@apollographql.com>
Co-authored-by: Iñaki Larramendi <30437204+ilarramendi@users.noreply.github.com>
Co-authored-by: Hiển Đào Vinh <neo.go.vn@gmail.com>
Co-authored-by: Lleyton W Morris <42259073+ViewableGravy@users.noreply.github.com>
Co-authored-by: Lleyton Morris <lmorris@nexigen.digital>
Co-authored-by: Matthew Struble <matt@vevox.io>
Co-authored-by: Matt Anderson <matt@mattdev.ca>
Co-authored-by: Chung <chungwong@users.noreply.github.com>
Co-authored-by: Maxx Coffee <josh@joshcoffee.dev>
Co-authored-by: Joshua Coffee <joshcoffee@gannett.com>
Co-authored-by: Jack Herrington <jherr@pobox.com>
Co-authored-by: Neeraj Dalal <admin@nrjdalal.com>
Co-authored-by: Thomas Marnet <thomas.marnet@gmail.com>
Co-authored-by: Vianney Carel <vcarel@users.noreply.github.com>
Co-authored-by: Vianney Carel <vianney.carel@logfuse.fr>
Co-authored-by: Diego Rincón <97266392+diegoarff@users.noreply.github.com>
Co-authored-by: Erfan Hosseini <43422324+Erfanhosseini98@users.noreply.github.com>
Co-authored-by: IderAghbal <3328396+IderAghbal@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andrew Jefferson <8148776+eastlondoner@users.noreply.github.com>
2025-06-10 23:19:32 +02:00
Christopher Horobin
f6be2df066
perf: improve ts perf for Route.Link (#4104) 2025-05-07 01:31:10 +02:00
Christopher Horobin
5eeb123381
feat: add bindings for Route.Link and routeApi.Link (#4095)
This allows `Route.Link` and `routeApi.Link` bindings instead of manual
`from`.

We never used to be able to do this due to circular issues but it seems
this is no longer an issue since all the changes to the types

---------

Co-authored-by: TkDodo <office@dorfmeister.cc>
2025-05-06 21:47:14 +02:00
Zac Rosenbauer
f0138f80b0
feat(react-router): Export ClientOnly (#3969)
Exposes the `ClientOnly` component for preventing rendering & hydration
errors.

## Background

When you attempt to prevent content from rendering using something like
`typeof document !== 'undefined'` as that type of conditional will cause
hydration errors.

## API

```tsx
import { ClientOnly, createRoute } from '@tanstack/react-router'
import { Charts, FallbackCharts } from './charts-that-break-server-side-rendering'

const Route = createRoute({
  // ... other route options
  path: '/dashboard',
  component: Dashboard,
})

function Dashboard() {
  return (
    <div>
      <p>Dashboard</p>
      <ClientOnly fallback={<FallbackCharts />}>
        <Charts />
      </ClientOnly>
    </div>
  )
}
```

> [!NOTE]
> This component as is (other than I removed the `children` as a
`function`) in production on [joggr.io](https://joggr.io)

---------

Co-authored-by: Sean Cassiere <33615041+SeanCassiere@users.noreply.github.com>
Co-authored-by: Ahmed Abdelbaset <A7med3bdulBaset@gmail.com>
Co-authored-by: Birk Skyum <birk.skyum@pm.me>
2025-04-13 10:50:44 +02:00
Manuel Schiller
c9a32784ce
fix: use fullPath as from in Route/RouteApi useNavigate (#3684)
fixes #3679
2025-03-06 23:58:51 +01:00
Manuel Schiller
a638d77ac8
fix: use default from in useNavigate (#3671)
fixes #3668
2025-03-05 22:15:21 +01:00
Christopher Horobin
7ef5d87096
refactor(router-core): move AnyRoute and AnyRouter to router-core (#3640) 2025-03-04 21:48:58 +01:00
Manuel Schiller
7eaa4a2888
fix: allow relative navigate without from (#3654)
if `from` is not specified, it defaults to the leaf match
2025-03-04 10:11:48 +01:00
Birk Skyum
409cdf114f
fix(solid-router): make HeadContent work for client navigation (#3616)
Picking solid-router relevant changes from
[commit](https://github.com/TanStack/router/pull/3522/commits/9eaa09ea1f95f786e9bd239fe787f10d6cb08e1c)
by @brenelz , that fixes assets handler in solid-router by using
`@solidjs/meta`.

With this, the head tags like the title will update on client
navigation.

The changes in this PR that affect most files are merely repetitions of:
- bumping solid 1.9.4 -> 1.9.5
- inserting `<HeadContent>` in the root route
- removing `<title>` from the index.html

Includes an automated test for solid-router corresponding to 
- https://github.com/TanStack/router/pull/3610

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-03-01 13:10:44 +01:00
Birk Skyum
4a9d7717dd
chore: add react-router tests to solid-router (#3558) 2025-02-25 23:36:34 +13:00
Christopher Horobin
844b66c795
refactor(router-core): migrate matches and route options to core (#3552)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-02-24 23:17:58 +01:00
Christopher Horobin
72b505c5d3
refactor(router-core): begin migrating types from react-router and solid-router to router-core (#3538)
Migrates many types over but there is still a lot to do D:

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-02-23 23:18:16 +01:00
Manuel Schiller
cca6a806ee
fix(react-router, solid-router): do not strip search params if search validation fails (#3496) 2025-02-21 00:32:45 +01:00
Birk Skyum
ad20a68491
feat(solid-router): Add a SolidJS driver for TanStack Router (#3276)
* copy react-router

* update

* Move forward branch

* cleanup

* cleanup

* add publish

* bump deps

* ci: apply automated fixes

* remove unused imports

* ci: apply automated fixes

* bump  vite plugin solid

* fix imports

* ci: apply automated fixes

* remove react lint from solid-router

* fix types

* ci: apply automated fixes

* add structuralSharing

* downgrade vite plugin solid

* fix scroll-restoration in solid-router

* fix Transitioner

* fix imports from ScrollRestoration

* Fix tests

* Fix more tests

* Remove the react $$typeof

* add accessors to useLocation

* add remountDeps

* cleanup

* remove tanstack/store

* format

* add missing call to setupScrollRestoration

* format

* add optional

* align match component

* make matches a signal

* Bump vite-plugin-solid to stable

* add missing await

* Fix unknown error

* Tweak the tests to call functions

* remove unused vars

* fix lockfile

* Down to 25 failures

* Remove .only

* call search()

* remove the structuralSharing

* fix type test

* fix structuralSharing

* comment out structured sharing validation check

* fix typings

* comment out serialization check

* comment out serialization check

* cleanup

* improve types of useSearch

* fix "when setting search params with 2 parallel navigate calls"

* fix useParams

* fix types

* fix useParams types

* cleanup debug

* fix link data loader

* fix data loader signal

* fix type test

* fix Link "when navigating away from a route with a loader that errors"

* setup on() simpler

* make initial load a createRenderEffect

* Fix some link preload tests

* add accessor to UseMatchRoute

* fix: when navigating to /posts with a beforeLoad that returns context

* call parentRouteId

* re-enable invariant

* fix when navigating from /invoices to ./invoiceId and the current route is /posts/$postId/details

* use memo for prev

* remove browserhistory  workaround

* fix  "after a navigation, should have emitted the "onResolved" event twice"

* skip remount

* add types to useSearch

* fix search middleware

* don't need a getter

* sync react-router

* solid kitchen sink

* add the example to workspace

* lockfile

* fix solid kitchensink name

* add solid template

* fix example

* rename react to solid

* work on example

* add accessor

* fix type tests

* Fix login in example

* Don't destructure

* Fix stuck on pending component

* Fix where loaderData can be undefined

* Use For component

* More refactor

* Hacky way to fix loading spinner

* Fix one test

* Better MatchRoute fix

* Down to 1 failing test

* Fix last test

* cleanup subscription

* lockfile

* eslint

* ci: apply automated fixes

* fix router-core lint

* ci: apply automated fixes

* add e2e test for solid-router

* ci: apply automated fixes

* work on solid-router e2e suites

* fix comment

* use solid-virtualizer

* work on scroll-restauration

* work on scroll-restauration

* skip react-specific useRenderEffect test

* fix errorcomponent being used before it's defined

* set solid target for esbuild

* ci: apply automated fixes

* fix rspack tests

* fix query tets

* add solid-query example

* use memo for post

* add memo for posts

* fix example

* add jsx compiler flags to esbuild commands

* add esbuild-plugin-solid

* Fix some e2e

* ci: apply automated fixes

* port #3423 from react-router

* fix useLoaderData test-d

* add codeSplitGroupings

* Scroll restoration fixes

* add asset headcontent script

* remove solid-router-copy

* fix react use

* fix scroll restoration test

* skip esbuild because it's broken in react-router

* wait for timeout

* update scroll-restoration to match react

* useLocation

* use on() in match

* align useNavigate with react-router

* lockfile

* fix Scripts test

* align __TSR_SSR__ in ScriptOnce

* remove solid-router from publish

* lint

* ci: apply automated fixes

* align to react-router

* port over "exclude props from state equality check to prevent history push for equal url and state"

* align with react-router

* add shouldThrow

* fix typePrimitives

* use searchStr to fix the search middleware

* ci: add solid-router to the labeler

* use patched vite-plugin-solid

* eslint

* ci: apply automated fixes

* use vite-plugin-solid 2.11.2

* remove only modifier

* move vite-plugin-solid peerDep to router-plugin

* use latest vite-plugin-solid

* move vitest to root

* bump vitest

* revert onRendered

* lint

* add to publish

* fix scroll restoration

* ci: apply automated fixes

* align version with react-router

* sync to react-router

* sync with react-router

* sync navigate tests to react-router

* ci: apply automated fixes

* use Solid.JSX.Element consistently instead of Solid.JSXElement

* remove irrelevant test

* ci: apply automated fixes

* remove unused suite

* lint

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: SeanCassiere <33615041+SeanCassiere@users.noreply.github.com>
2025-02-20 17:11:39 +01:00