0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

84 commits

Author SHA1 Message Date
Brenley Dueck
ebe104c01c
Upgrade solidjs beta 19 (#7813)
* chore: upgrade Solid v2 packages to 2.0.0-beta.16

Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.15
to 2.0.0-beta.16 across packages, examples, e2e apps, benchmarks, and
the pnpm overrides in pnpm-workspace.yaml.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore: upgrade Solid v2 packages to 2.0.0-beta.17

Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.16
to 2.0.0-beta.17 across packages, examples, e2e apps, and benchmarks.

The scoped babel-preset-solid overrides in pnpm-workspace.yaml are
removed instead of bumped: vite-plugin-solid@3.0.0-next.5 and
@rsbuild/plugin-solid@2.0.0-beta.0 both declare
'>=2.0.0-beta.0 <2.0.0-experimental.0', which resolves to the newest
v2 beta on its own, while Solid 1.x consumers keep babel-preset-solid
1.x. A stale override here silently kept the beta.16 compiler (with
its broken omitLastClosingTag marker handling) in the build pipeline.

The @dom-expressions/* scope is added to minimumReleaseAgeExclude,
covering the renamed compiler package (@dom-expressions/babel-plugin-jsx,
formerly babel-plugin-jsx-dom-expressions).

Two unrelated loose specs are pinned to their locked versions because
re-resolving the lockfile pulled broken releases: @platformatic/flame
1.7.0 fails pnpm's trust-downgrade policy, and the nitro-nightly
'latest' tag depends on an unpublished h3 version.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(solid-router): suspend on the match loadPromise only during SSR

On the client, returning the loadPromise from MatchInner's pending
branch keeps a live async source in the tree whenever a match is
pending. Since Solid 2.0.0-beta.16, that routes every signal write
into a transition hold for the rest of the flush, which breaks
router-core's synchronous write-then-load flows: invalidate() on a
notFound match never re-ran the loader, and writes to unrelated
signals were held too.

SSR keeps the suspension so the streaming engine waits for the match
to settle; the client now renders just the pending component.

Verified on beta.17: without this, "re-runs loaders that throw
notFound() when invalidated via HMR filter" and "keeps rendering a
route notFoundComponent when loader returns notFound() after
invalidate" fail.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(lockfile): restore all @rspack/binding@2.0.8 platform binaries

The lockfile entry for @rspack/binding@2.0.8 only listed the
darwin-arm64 binding, so linux CI runners had no matching native
binding and rspack fell back to a hoisted 2.0.0 binary, crashing the
bundle-size benchmark with a core/binding version mismatch.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore: add changesets for solid-js beta.17 upgrade and SSR-only match suspension

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(examples): replace broken nitro-nightly pin with nitro beta in start-rscs

The pinned nitro-nightly@4.0.0-20251010 self-imports 'nitro/runtime/meta',
which under pnpm's isolated layout resolves to the hoisted nitro 3.x beta
and crashes vite config loading. Mirrors upstream fix e65f0c84c1 (#7809).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore: upgrade vite-plugin-solid to next.7

* fix(solid-router): retain manifest stylesheets across navigation

* chore: upgrade Solid v2 packages to 2.0.0-beta.18 and vite-plugin-solid to next.8

Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.17
to 2.0.0-beta.18 and vite-plugin-solid from 3.0.0-next.7 to 3.0.0-next.8
(which pins @dom-expressions/jsx-compiler to 0.50.0-next.21) across
packages, examples, e2e apps, and benchmarks.

vite-plugin-solid is added to minimumReleaseAgeExclude: Solid publishes
plugin prereleases in lockstep with the runtime betas, often minutes
before we bump, and pnpm's 24h release-age gate otherwise filters the
new version with a misleading NO_MATCHING_VERSION error.

Verified: solid-router unit tests (client + server modes), solid-start
basic e2e (80 passed), solid-router basic-file-based e2e (120 passed),
and all 17 bundle-size benchmark scenarios build cleanly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(start-plugin-core): select client entry chunk by facade module instead of asserting a single entry

vite-plugin-solid >= 3.0.0-next.6 emits a facade chunk for every
dynamically imported project module during SSR client builds (to keep
its own manifest lookups stable), and emitted chunks are flagged
`isEntry` just like the configured entry. The start manifest capture
plugin asserted the client bundle contains exactly one entry chunk, so
every solid-start app failed to build with "multiple entries detected".

The capture plugin now receives the resolved client entry path and picks
the entry chunk whose facadeModuleId matches it; other entry-flagged
chunks are treated as ordinary chunks. When no chunk matches, a single
entry is still accepted as before, and the multiple-entries error now
lists every entry chunk with its facade module to ease diagnosis.

Verified with fresh package builds: previously failing memory-server
solid benchmark targets, all 17 bundle-size scenarios, solid-start basic
build + e2e (80 passed), react-start basic build, and the
start-plugin-core unit suite (494 tests).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci: apply automated fixes

* test(start-plugin-core): pass getClientEntry to startManifestPlugin in dev manifest test

Fixes the type tests after startManifestPlugin gained a required
getClientEntry option.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Revert "fix(start-plugin-core): select client entry chunk by facade module instead of asserting a single entry"

This reverts commit d0f4926ec0.

* chore: upgrade vite-plugin-solid to 3.0.0-next.10

next.10 ships the fix for the lazy facade entry reclassification under
rolldown-vite (solidjs/vite-plugin-solid#269): assigning isEntry = false
instead of deleting the property, so the reclassification actually
propagates through rolldown's bundle proxies and downstream plugins no
longer see every lazy facade chunk as an application entry. This is the
proper replacement for the reverted start-plugin-core workaround
(see a1ee1638f5) — the strict single-entry assertion now holds again.

Verified: e2e/solid-start/basic build + e2e suite (80 passed),
solid-router test:unit client (814) + server (2) modes,
start-plugin-core unit tests (486).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11

vite-plugin-solid 3.0.0-next.11 peer-requires solid-js and @solidjs/web
>=2.0.0-beta.19, so the Solid v2 packages are bumped in lockstep across
all workspace pins (packages, examples, e2e, benchmarks).

Verified: e2e/solid-start/basic build succeeds — no "multiple entries
detected" error from start-manifest-capture-client-build; solid-router
test:unit client (814 passed) + server (2 passed) modes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11 [Self-Healing CI Rerun]

* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11 [Self-Healing CI Rerun]

* fix(e2e): make prerender builds hermetic to deflake build:vite:prerender

The prerender crawl runs inside `vite build` and SSRs /posts and every
crawled /posts/$postId. The `import.meta.env.VITE_NODE_ENV === 'test'`
switch to the local dummy server was inlined away at build time because
Playwright only sets that env for the test-time webServer, never for the
nx build target — so build-time SSR fetched the real
jsonplaceholder.typicode.com from CI. When that public API stalled, the
page never sent headers and the build died after undici's 5-minute
headers timeout (UND_ERR_HEADERS_TIMEOUT).

Fix, applied to the react/solid/vue basic apps alike:
- Resolve the posts/users API base URL at request time from process.env
  (same pattern users.tsx already used) instead of build-time inlining,
  so the built app honors whatever dummy server the harness is running.
- Add e2eStartDummyServerForBuild() to @tanstack/router-e2e-utils and
  call it from the apps' vite configs in prerender mode: it starts the
  dummy server on a free port for the lifetime of the build, exposes it
  via VITE_NODE_ENV/VITE_EXTERNAL_PORT, and unrefs everything so the
  build process can exit.

Verified: nx run tanstack-solid-start-e2e-basic:build:vite:prerender
passes (47 pages prerendered, dummy server used, tsc clean), prerendered
posts/index.html contains the expected content, and the server bundle
now keeps the runtime env check instead of a hardcoded external URL.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci: apply automated fixes

* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11 [Self-Healing CI Rerun]

* fix(e2e): harden prerender-build dummy server and log fetch targets

CI still hit UND_ERR_HEADERS_TIMEOUT during build:vite:prerender after
de2132af1b. The failure pattern (fetch logs print instantly, then a
5-minute stall) means the posts fetches still reached the real external
API in that run: the dummy server resolves in milliseconds in-process,
and a non-listening port would fail instantly with ECONNREFUSED.

One way that can happen: e2eStartDummyServerForBuild() early-returned
whenever VITE_EXTERNAL_PORT was already present in the environment,
skipping both the server start AND setting VITE_NODE_ENV — leaving the
runtime URL check pointing at jsonplaceholder. Guard on a globalThis
flag instead and always set both env vars.

Also, to make the next failure diagnosable and survivable:
- fetchPost/fetchPosts (react/solid/vue basic) now log the base URL they
  fetch from, so CI output shows whether the dummy server was used.
- prerender configs set retryCount: 2 / retryDelay: 1000 so a transient
  hang retries instead of failing the whole build.

Verified: nx run tanstack-solid-start-e2e-basic:build:vite:prerender
passes with "Fetching posts from http://localhost:<port>..." in the log
and 47 pages prerendered.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-07-16 16:17:49 +02:00
Collin Dillinger
9809a0619d
fix(router-core): preserve percent-encoded URL-unsafe chars in decodeSegment (#7695)
* fix(router-core): preserve percent-encoded URL-unsafe chars in decodeSegment

Replace sanitizePathSegment (which stripped control characters) with a
re-encode step that keeps WHATWG path percent-encode set characters and
control characters in their encoded form after decodeURI.

This preserves the existing decodeURI-based approach which correctly
handles multi-byte UTF-8 sequences, while fixing the mismatch between
the original request URL and the router's internal representation that
caused infinite 307 redirect loops on paths containing these characters.

Fixes #7587.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: apply automated fixes

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Flo <me@florianpellet.com>
2026-06-30 23:27:21 +02:00
Elecmonkey
e499164c72
feat(start-plugin-core): support Rsbuild preview SSR middleware (#7372)
* fix(start-plugin-core): support rsbuild preview SSR

* fix(start-plugin-core): always install rsbuild SSR middleware in preview

Preview is the only SSR handler in `rsbuild preview`, so gate the opt-out
to dev only and keep the option named `installDevServerMiddleware`.
2026-06-16 10:30:39 +02:00
Manuel Schiller
9bebf8dc9f
rename inputValidator to validator (#7566)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-06-06 23:05:56 +02:00
Ulrich Stark
1d113f0a30
fix(examples): make isRoot check work (#7547) 2026-06-04 22:11:30 +02:00
Manuel Schiller
9cb7a003e6
feat(rsbuild): add RSC support (#7509)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-05-30 15:16:10 +02:00
Manuel Schiller
2f5374945e
fix: fix primitive beforeLoad errors (#7505)
* fix: fix primitive beforeLoad errors

* ci: apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-05-30 01:29:42 +02:00
Manuel Schiller
72805df675
chore: stabilize tests (#7503)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-05-29 02:17:35 +02:00
Manuel Schiller
90adda91aa
fix: bundled dev support for vite (#7482) 2026-05-24 22:08:23 +02:00
Manuel Schiller
51a97a167f
feat(start): support rsbuild iife client output (#7477) 2026-05-24 02:02:05 +02:00
Flo
697c66b337
chore: update express and webpack-dev-server (#7443)
* chore: update express to v5.2.1

* chore: update webpack-dev-server to v5.2.4
2026-05-20 10:58:22 +02:00
Flo
9f6258f23e
chore: update zod to v4.4.3 (#7441)
* chore: update zod to v4.4.3

* fix(start): preserve route path defaults

* fix(examples): resolve zod 4 build failures
2026-05-20 08:41:45 +02:00
Manuel Schiller
056337ef02
fix: fix plain TypeScript parser handling (#7342) 2026-05-05 01:57:21 +02:00
neverland
a5385dbd90
chore(deps): update Rsbuild related deps to v2.0.1 (#7245) 2026-04-24 22:41:31 +02:00
Manuel Schiller
91a708989d
rsbuild plugin (#7228)
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
Co-authored-by: Keven Arroyo <dake.3601@gmail.com>
2026-04-24 03:26:03 +02:00
Nicolas Beaussart
bd97d092ef
chore: unify react-start basic e2e mode projects (#7206) 2026-04-18 22:52:56 +02:00
Manuel Schiller
f920527e8d
efp (#7144)
Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
2026-04-11 01:43:05 +02:00
Nico Lynzaad
30835cb8e9
fix(router-core): align calculation of publicHref in parseLocation and buildLocation (#7069)
* align publicHref

* add tests

* ci: apply automated fixes

* revert changes

* revert changes

* ci: apply automated fixes [Self-Healing CI Rerun]

* ci: apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-03-30 00:57:24 +02:00
Nicolas Beaussart
a556afa0f0
test: share React Start basic mode e2e suite (#7060)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-03-28 11:30:05 +01:00
Birk Skyum
b1c0f4602d
chore: upgrade tooling to typescript 6 (#7024) 2026-03-23 22:59:52 +01:00
Birk Skyum
aaf764bcee
docs: @tailwindcss/vite to 4.2.2 in examples (#6974) 2026-03-18 17:40:04 +01:00
Birk Skyum
3b8ab0fa6b
docs: add devcontainer.json to all e2e/examples (#6972) 2026-03-18 15:43:14 +01:00
Birk Skyum
7d936c6c36
docs: update examples/e2e to vite 8 (#6958) 2026-03-17 20:37:11 +01:00
Birk Skyum
2f35f93312
chore: bump h3 and srvx (#6869)
* bump h3 v2 to rc 16

* bump srvx to 0.11.9

* lockfile
2026-03-09 12:50:41 +01:00
Manuel Schiller
9c81d5ac57
fix: handle beforeLoad throwing notFound correctly (#6811) 2026-03-04 21:34:28 +01:00
Birk Skyum
965d95f3b8
chore: bump srvx 0.11.2 -> 0.11.7 (#6705)
srvx 0.11.7
2026-02-19 21:41:56 +01:00
Manuel Schiller
5d667aa436 fix test 2026-02-16 20:17:27 +01:00
Manuel Schiller
27a563ea1d
fix: script hydration (#6681) 2026-02-16 19:22:09 +01:00
홍규진
067951fcf0
fix(react-router): remove async/defer attributes during hydration to prevent warnings (#6479)
* fix(react-router): prevent hydration warning for async/defer scripts

Strip async, defer, and src attributes from script tags during client-side hydration to match the server-rendered output and prevent React hydration mismatch warnings.

* test(react-router): add unit and e2e tests for async script hydration

Adds unit tests to verify server output includes async/defer attributes, and e2e tests to verify no hydration warnings occur on the client.

---------

Co-authored-by: Manuel Schiller <manuel.schiller@caligano.de>
2026-02-15 02:31:46 +01:00
Birk Skyum
88161bd480
chore: update srvx to 0.11.2 and h3-v2 to rc.14 (#6608) 2026-02-07 03:28:50 +01:00
Nico Lynzaad
40ed6832c6
fix(start-server-core): redirect misinterpreted protocol-relative URLs (#6600)
* add test to verify redirect

* handle redirect

* update tests

* cleanup unused code in decodePath

* use 308 instead of 302

* redirect is not relevant in spa mode
2026-02-07 02:00:19 +02:00
Philippe Serhal
6ff1190bdc
chore: add source() to Tailwind v4 imports to ensure consistent hashing (#6459)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-24 01:49:12 +01:00
Birk Skyum
19a92c5d87
update h3 nitro srvx seroval (#6449) 2026-01-22 02:14:13 +01:00
Nico Lynzaad
60a30fc59a
fix(react-start): Apply Link active properties correctly on SSR when including hash (#6421)
* react: fix link active hash reactivity on SSR

* update and align tests

* remove unnecessary change

* better address react re-renders and update tests

* add tests for vue

* react: add comment on reason for useSyncExternalStore usage

* solid: revert prior fix and update tests

* react: revert unnecessary change

* react: use useHydrated

* react: cleanup
2026-01-22 00:55:28 +02:00
Nico Lynzaad
3da0227067
fix: encoded url hash fragment matching (#6416)
* decode hash

* ci: apply automated fixes

* cleanup

* revert change to basic-rsc

* add note in docs about hash fragment

* ci: apply automated fixes

* code rabbit suggestion

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-01-19 16:39:48 +02:00
Nico Lynzaad
9196ae45b7
fix(start): normalize path encoding (#6389)
* fix encoding and update tests

rework fix and tests

* refine solution

* revert unnecessary change

* fix tests

* resolve pre-render test issues

* refine comment on normalization requirement

* cleanup: remove unnecessary imports

* code rabbit suggestions

* revert merge issues in createStartHandler.ts

* Avoid decoding query/hash

* apply solution to router-ssr also

* add test for getNormalizedURL to handle URLs correctly

* enhance getNormalizedURL tests

* handle malformed paths

* build pathname using url parts

* handle backslash encoding in URL normalization

* additional tests

* refine match error handling
2026-01-18 20:10:11 +02:00
Manuel Schiller
2d9193c25c
chore: bump deps (#6408)
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
2026-01-18 02:14:48 +01:00
Manuel Schiller
b42f84a4f6
fix: fullpath handling (#6404)
* fix: fullpath handling

fixes #6403
fixes #2675
fixes #4892

* add type test

* preserve / for index routes

* fix  #3005

* fix tests
2026-01-17 17:21:10 +01:00
Manuel Schiller
538285cb79
fix: dev style with non runnable dev environments and basepath support (#6348) 2026-01-10 14:51:33 +01:00
Manuel Schiller
04e6d7b064
fix: open redirect (#6309) 2026-01-05 20:07:19 +01:00
Nico Lynzaad
fb88aadd63
tests(react-start-basic): wait for results to be available before validating raw stream results (#6307)
wait for results to be available before testing
2026-01-05 19:50:12 +02:00
Birk Skyum
5438653d7e
bump srvx 0.10.0 (#6257)
* bump srvx 0.10.0

* adjust types

* lint
2025-12-30 17:36:17 +01:00
Manuel Schiller
680671cce8
feat: RawStream (#6231)
* feat: RawStream

* framed json response is not newline split

* avoid code duplication in tests

* actually defer promise

* fix empty stream

* hardening

* optimization

* stream counter

* fix cancellation

* lint

* fix test

* stabilize tests

* stabilize tests

* fix(e2e): add hydration delay for SSR mixed stream test

In CI, hydration takes longer so reader.read() can hang if called
before seroval's stream factory connects callbacks. 100ms delay
ensures stream is ready to be consumed.

* skip test when prerendering
2025-12-27 15:57:16 +01:00
Manuel Schiller
7f0b79cb83
refactor: consolidate start compiler (#6210) 2025-12-24 23:39:46 +01:00
Manuel Schiller
c504bd2c4d
fix: compiler handles type-only exports (#6199) 2025-12-23 08:53:47 +01:00
Manuel Schiller
97d9f30c69
feat: remove ClientOnly children from server build (#6193) 2025-12-23 08:40:43 +01:00
Manuel Schiller
3c994c47a8
fix: serial head execution (#6093) 2025-12-23 03:21:30 +01:00
Ulrich Stark
948c4fb045
refactor(router-core): deprecate json function in favor of standard Response.json function (#6181) 2025-12-22 19:44:04 +01:00
Birk Skyum
6839bfb1a0
docs: move to tailwind 4 w/ vite (#6168) 2025-12-21 04:13:49 +01:00
Manuel Schiller
11d26ad0f5
fix: bump srvx (#6128)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-12-17 21:04:54 +01:00