Fixes#3661
I tested this in my own codebase. With this change, the warnings are
gone.
Rollup plugin docs specifically say that you should return `null` if you
didn't transform anything. Vite follows rollup's API.
This PR adds viewTransition documentation to the NavigateOptionsType,
giving users more info on how they can use the viewTransition API in
Links and Navigates.
Will follow up in the next day or so with an example as well.
`parseLocation` in `createHashHistory` failed to parse search params when they appeared before the hash. This PR updates the parsing logic so that search params are correctly extracted and processed, regardless of their position.
fixes#3595
Fixes#3634
Simply checking the type of `window.sessionStorage` is apparently enough to trigger `SecurityError`. To address it we use try/catch and set the variable to true only if it's indeed available.
Follow up to
- https://github.com/TanStack/router/pull/3611
Port this test suite from react-start to solid-start
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
when client navigating, the react-router doesn't update the head meta
tags, such as the title
---------
Co-authored-by: Manuel Schiller <manuel.schiller@caligano.de>
Reverts #3631 - it's relying on peer Deps of react v18 or v19, so it
might be a problem if we use v19-only features.
There is work underway that'll uncouple this - but it's not in yet
_Agnostic devtools step 1 of plan_
This merely move some components into own files, as internal change in
router-devtools, so it's easier to keep an overview of imports.
This is a more similar structure to the query-devtools
-
https://github.com/TanStack/query/tree/main/packages/query-devtools/src
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This PR introduce support for Solid to be used with TanStack Start.
There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.
### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration
### Ongoing refactors
Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171
Refactor to make start packages (aka. server features) more agnostic:
- #3546
- #3563
- #3565
### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616
### Passing E2E test suites
- [x] basic
- [x] website
- [x] scroll-restoration
- [x] server-functions
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>
Co-authored-by: Iha Shin <me@xiniha.dev>
Co-authored-by: Brenley Dueck <brenley@crowdbotics.com>
Picking solid-router relevant changes from
[commit](https://github.com/TanStack/router/pull/3522/commits/9eaa09ea1f95f786e9bd239fe787f10d6cb08e1c)
by @brenelz , that fixes assets handler in solid-router by using
`@solidjs/meta`.
With this, the head tags like the title will update on client
navigation.
The changes in this PR that affect most files are merely repetitions of:
- bumping solid 1.9.4 -> 1.9.5
- inserting `<HeadContent>` in the root route
- removing `<title>` from the index.html
Includes an automated test for solid-router corresponding to
- https://github.com/TanStack/router/pull/3610
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Example
```
import { createMiddleware } from "@tanstack/react-start";
export const middleware = createMiddleware();
```
Issue
```
The inferred type of middleware cannot be named without a reference to ../../../../node_modules/@tanstack/react-start-client/dist/esm/createServerFn . This is likely not portable. A type annotation is necessary.
```
Solution
exporting `ServerFnResponseType` resolves this.