* feat(solid-router): register head tags through Solid's useHead registry
HeadContent now feeds the route-derived tags (useTags output, semantics
unchanged) to Solid's head registry as one reactive group instead of
rendering <Asset> elements in-tree. The registry owns head emission on
both runtimes: SSR splices/streams resolved winners into <head>, the
client patches document.head reactively — replacing the manual
relocate-into-head, imperative script injection, and document.title
syncing that Asset.tsx carried for head tags.
The dev-only dev-styles handling (filter DEV_STYLES_ATTR links post
hydration) is a no-op in production, so it folds into the single
HeadContent — retiring HeadContent.dev.tsx, index.dev.tsx, and the
package's development export conditions.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test(solid-start): pin SSR'd lazy() modulepreload hints and hydration asset map
The client-assets manifest wiring (99756c0710) gives SSR'd lazy()
components three observable outputs in the served HTML: modulepreload
hints for the lazy chunk and its static imports in the initial <head>,
the chunk's stylesheet link, and the serialized boundary→chunk asset map
that gates client hydration on those imports. The start-manifest e2e
only asserted the stylesheet side, so a silent regression to the
route-keyed manifest fallback would keep the suite green while losing
hints and hydration gating.
Two request-level tests against the built app pin the rest: direct SSR
entry to /lazy-css-lazy emits exactly one head modulepreload for the
lazy chunk and one for its statically imported widget chunk (and none of
them on routes that never render the component), and the hydration
payload's _assets map points at the same chunk URL the head hinted.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(solid-router): lean on the head registry for tag lifecycle
Drop the pieces of the head pipeline that existed only for the old
in-tree render path: the reference-reuse memo and replaceEqualTags (DOM
node stability for a <For> that no longer exists) and the dev-styles
post-hydration filtering (HeadContent is now a pure useHead
registration). Add the changeset for the useHead adoption.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* ci: apply automated fixes
* feat(solid-router): delegate lazyRouteComponent to Solid's lazy()
Route components now render through solid-js lazy(): the importer wrapper
selects the configured export and forwards the module's $$moduleUrl (the
bundler's SSR transform appends it), so SSR'd route chunks get client
asset resolution — stylesheet links, modulepreload hints, and hydration
gating — through the same client-assets manifest seam as any other
lazy() component, with positional hydration as the fallback.
Carries an interim pnpm patch for solid-js 2.0.0-rc.0 (to be upstreamed,
same play as the vite-plugin-solid isEntry patch): lazy() no longer
caches a rejected module promise, so a failed chunk download is retried
by the next preload or render instead of being sealed in for the page's
lifetime — this is what lets TanStack's download-retry contract ride on
lazy() directly instead of wrapping it in a retry state machine. The
patch also fixes an unhandled-rejection leak (lazy's internal .then had
no rejection handler) and, on the server, stops a transient import
failure from poisoning every later SSR request.
Retry semantics improve: a failed hover-preload is retried at render
(previously the recorded error was thrown without re-attempting the
import); the error boundary + route-reload retry flow is unchanged when
the render-time attempt also fails. preload() keeps its contract — a
memoized Promise<void> that never rejects, cleared on failure so a later
preload retries, one import per server. The module-not-found reload-once
dance is unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(solid-router): stable head-registry identities for inline tags + CI repairs
Inline scripts and styles get a stable content-derived key in toHeadTags:
the registry otherwise assigns per-runtime unique identities that can
never match between server and client, so hydration appended a client
copy next to the server-rendered tag (caught by the solid-start basic
script-duplication e2e).
The ssr head benchmark's sanity assertion now counts name="…" attribute
occurrences instead of raw substring hits — the registry writes the
identity into data-dh on the same element, which doubled the old count.
remountDeps tests migrate onMount to Solid 2's onSettled (pre-existing
branch failure; the API was removed in the rc line).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(solid-router): make route-boundary resets converge (issue 7986 + background recovery)
Two compounding defects kept a captured route error from retrying
cleanly on Solid 2:
- CatchBoundary's reset effect re-ran on every recompute of the reset
key, not only on value changes, so any store write recreated the
retried subtree while it settled. The effect is now gated on the key
value. The reset handle deliberately stays un-consumed: a reset
applied at the wrong moment can no-op (the boundary stays errored and
the fallback never re-runs), and only a repeated attempt on a later
key change recovers it — consuming the handle at apply time or at
children re-render both proved to lose exactly that retry (verified
against the background-recovery test).
- Match keyed its boundary on the whole matches store, so every
unrelated transition fired a premature reset that re-threw the
still-stale error and flapped the error UI. The key is now scoped to
the guarded match and its descendants (whose errors bubble here when
they have no errorComponent), mirroring react-router's per-match
keying, as a value string because the store emits fresh objects for
content-equal writes.
The issue-7986 pending assertion queries fresh under waitFor: the
retried subtree renders the pending fallback from two nested slots in
quick succession (Show fallback, then the Loading boundary once the
child suspends), so a cached element handle can go stale across the
swap.
First fully green unit run on this branch: 59 files, 864 tests.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(solid-router): hydrate lazy route components correctly; scope route assets to TanStack's manifest
Extends the interim solid-js patch with two hydration-critical fixes
(both upstream candidates, same play as the retry fix it already
carries):
- lazy()'s preloaded-module hydration shortcut (_$HY.modules) now only
applies when the callsite has a bundler-injected moduleUrl. The
shortcut assumes the registered chunk's default export is the
component; for wrappers selecting a named export it silently rendered
undefined, never claimed the SSR'd DOM, and navigation later couldn't
dispose it — 20 basic-suite e2e failures (orphaned route content
stacking up across navigations).
- $$moduleUrl: null on a lazy()-resolved module is an explicit opt-out
of per-module asset registration, without the server warning that
undefined draws.
lazyRouteComponent uses that opt-out: route chunks bundle many routes,
so registering the chunk emitted the union of their CSS on every route
and broke per-route stylesheet isolation (4 start-manifest e2e
failures). Route assets stay on TanStack's route-keyed manifest, which
is per-route precise; hydration is synchronous because preload() warms
lazy()'s component cache before the router renders. User-level lazy()
components inside routes remain fully registered — the opt-out is
scoped to the route-component wrapper.
Verified: solid-start basic e2e 80 passed (was 60/20); start-manifest
10 passed (including the previously failing lazy-to-static shared-CSS
navigation); unit suites green apart from the four pre-existing
failures fixed on the useHead branch.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(solid-router): route chunks opt in to Solid's client-assets manifest
With the head registry (useHead branch) underneath, lazyRouteComponent
forwards the module's real $$moduleUrl: split route modules have
per-module client-manifest entries (the query is part of the module
identity), so server-side lazy() registers exactly the route's own CSS
and modulepreload hints, and the registry's URL-keyed resource dedupe
absorbs the overlap with TanStack's route-keyed manifest links — the
duplicate-stylesheet failures that forced the earlier $$moduleUrl null
opt-out were double emission between Solid's channel and TanStack's
in-tree links, which the registry now reconciles.
The now-unused null opt-out hunk is dropped from the solid-js patch,
leaving exactly the two upstream-tracked fixes (rejection retry:
solidjs/solid#2999, fixed on next in 3c68ab21; hydration-shortcut
moduleUrl gate: solidjs/solid#3011).
Verified on the stack: unit 59 files / 865 tests all green (first fully
green combination), solid-start basic e2e 80 passed, start-manifest 12
passed including the ported modulepreload-hint and hydration asset-map
tests.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(solid-router): adopt lazy()'s { export } option via upstream backport
Upstream resolvedsolidjs/solid#3011 with first-class named-export
support instead of the fallback gate this patch carried: lazy(fn,
{ export }, moduleUrl?) names which export of the resolved module is
the component, as a call-site literal available on both runtimes —
so hydration claims the component synchronously from the preloaded
module namespace, and runtime wrappers that pick an export inside the
import thunk fail loudly in dev instead of silently orphaning SSR'd
DOM.
The solid-js patch is now a faithful backport of solidjs/solid@56ca6470
(which also carries the #2999 rejection-retry fix in its final
load-inside-memo shape) onto the rc.0 dists, plus one deliberate
deviation: lazy() still accepts the legacy string second argument
(moduleUrl) that rc.0's bundler transform injects, normalizing it to
the third position, until the updated transform (dom-expressions
0856717a) ships. Type declarations carry the new overloads.
lazyRouteComponent takes its final upstream-aligned shape: the module
namespace passes through untouched ($$moduleUrl included, so route
chunks keep registering their real client assets), { export } selects
the component, and only the module-not-found reload dance and the
memoized never-rejecting preload contract remain as wrapper logic.
When an rc ships with both upstream commits, the migration is deleting
the patch.
Verified: unit 59 files / 865 tests green; solid-start basic e2e 80
passed; start-manifest 12 passed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(solid): bump to solid-js 2.0.0-rc.1 and drop the solid-js patch
rc.1 ships everything the interim patch carried: the lazy() rejection
retry fix (solidjs/solid#2999, 3c68ab21) and the { export } option with
its loud-in-dev hydration guard (solidjs/solid#3011, 56ca6470 +
dom-expressions 0856717a — the updated transform arrives through
babel-preset-solid 2.0.0-rc.1 via @solidjs/vite-plugin 3.0.0-next.30).
patches/ and the patchedDependencies entry are deleted;
lazyRouteComponent is unchanged, already in its final shape against the
real API.
Monorepo-wide range bump: solid-js and @solidjs/web ^2.0.0-rc.0 →
^2.0.0-rc.1, @solidjs/vite-plugin ^3.0.0-next.28 → ^3.0.0-next.30.
Verified on vanilla rc.1: unit 59 files / 865 tests green; solid-start
basic e2e 80 passed; start-manifest 12 passed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* feat(solid-router): register head tags through Solid's useHead registry
HeadContent now feeds the route-derived tags (useTags output, semantics
unchanged) to Solid's head registry as one reactive group instead of
rendering <Asset> elements in-tree. The registry owns head emission on
both runtimes: SSR splices/streams resolved winners into <head>, the
client patches document.head reactively — replacing the manual
relocate-into-head, imperative script injection, and document.title
syncing that Asset.tsx carried for head tags.
The dev-only dev-styles handling (filter DEV_STYLES_ATTR links post
hydration) is a no-op in production, so it folds into the single
HeadContent — retiring HeadContent.dev.tsx, index.dev.tsx, and the
package's development export conditions.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test(solid-start): pin SSR'd lazy() modulepreload hints and hydration asset map
The client-assets manifest wiring (99756c0710) gives SSR'd lazy()
components three observable outputs in the served HTML: modulepreload
hints for the lazy chunk and its static imports in the initial <head>,
the chunk's stylesheet link, and the serialized boundary→chunk asset map
that gates client hydration on those imports. The start-manifest e2e
only asserted the stylesheet side, so a silent regression to the
route-keyed manifest fallback would keep the suite green while losing
hints and hydration gating.
Two request-level tests against the built app pin the rest: direct SSR
entry to /lazy-css-lazy emits exactly one head modulepreload for the
lazy chunk and one for its statically imported widget chunk (and none of
them on routes that never render the component), and the hydration
payload's _assets map points at the same chunk URL the head hinted.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(solid-router): lean on the head registry for tag lifecycle
Drop the pieces of the head pipeline that existed only for the old
in-tree render path: the reference-reuse memo and replaceEqualTags (DOM
node stability for a <For> that no longer exists) and the dev-styles
post-hydration filtering (HeadContent is now a pure useHead
registration). Add the changeset for the useHead adoption.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* ci: apply automated fixes
* fix(solid-router): stable head-registry identities for inline tags + CI repairs
Inline scripts and styles get a stable content-derived key in toHeadTags:
the registry otherwise assigns per-runtime unique identities that can
never match between server and client, so hydration appended a client
copy next to the server-rendered tag (caught by the solid-start basic
script-duplication e2e).
The ssr head benchmark's sanity assertion now counts name="…" attribute
occurrences instead of raw substring hits — the registry writes the
identity into data-dh on the same element, which doubled the old count.
remountDeps tests migrate onMount to Solid 2's onSettled (pre-existing
branch failure; the API was removed in the rc line).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(solid-router): make route-boundary resets converge (issue 7986 + background recovery)
Two compounding defects kept a captured route error from retrying
cleanly on Solid 2:
- CatchBoundary's reset effect re-ran on every recompute of the reset
key, not only on value changes, so any store write recreated the
retried subtree while it settled. The effect is now gated on the key
value. The reset handle deliberately stays un-consumed: a reset
applied at the wrong moment can no-op (the boundary stays errored and
the fallback never re-runs), and only a repeated attempt on a later
key change recovers it — consuming the handle at apply time or at
children re-render both proved to lose exactly that retry (verified
against the background-recovery test).
- Match keyed its boundary on the whole matches store, so every
unrelated transition fired a premature reset that re-threw the
still-stale error and flapped the error UI. The key is now scoped to
the guarded match and its descendants (whose errors bubble here when
they have no errorComponent), mirroring react-router's per-match
keying, as a value string because the store emits fresh objects for
content-equal writes.
The issue-7986 pending assertion queries fresh under waitFor: the
retried subtree renders the pending fallback from two nested slots in
quick succession (Show fallback, then the Loading boundary once the
child suspends), so a cached element handle can go stale across the
swap.
First fully green unit run on this branch: 59 files, 864 tests.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
`vite-plugin-solid` has been renamed to `@solidjs/vite-plugin`. Its final
release under the old name (`3.0.0-next.27`) is a re-export shim over the new
package, and `next.28`+ ships only under the new name.
The rename and the `rc` bump are forced together: `@solidjs/vite-plugin@3.0.0-next.28`
peer-requires `solid-js`/`@solidjs/web` `^2.0.0-rc.0`.
- solid-js, @solidjs/web, babel-preset-solid: 2.0.0-beta.32 -> ^2.0.0-rc.0
- vite-plugin-solid ^3.0.0-next.23 -> @solidjs/vite-plugin ^3.0.0-next.28
- @tanstack/solid-query + solid-query-devtools -> ^6.0.0-rc.0
(solid-query rc.0 peer-requires solid-js >=2.0.0-rc.0)
- @tanstack/query-core converged on 5.101.4: solid-query depends on query-core
5.101.0, which previously resolved to a stale 5.99.0 and produced two
structurally incompatible `QueryClient` types, failing
@tanstack/solid-router-ssr-query's build
`packages/router-devtools-core` intentionally stays on `vite-plugin-solid@^2.11.10`
— it builds against Solid 1.9.12 and `@solidjs/vite-plugin` has no 2.x line.
`@tanstack/router-plugin` is intentionally untouched: it detects the Solid JSX
plugin by its Vite plugin name (`solid`), which the renamed package still
registers, and its `vite-plugin-solid` peer is optional — so it keeps working
for both Solid 1 and Solid 2 consumers without a change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
onMount is gone in Solid 2 — record the pending/target mount events via
onSettled instead. Also picks up routeTree.gen.ts regeneration churn.
Verified with the selective-ssr e2e suite (11/11 passing).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Use the Start storage context for request cancellation and focused server entrypoints to keep unrelated route dependencies out of the RSC module graph. Add emitted-build regression coverage for the boundary.
fixes#7938
* Upgrade solidjs beta 29
Upgrade `solid-js`, `@solidjs/web` and `babel-preset-solid` to
`2.0.0-beta.29`, and `vite-plugin-solid` to `3.0.0-next.20`
(peer-requires `>=2.0.0-beta.28`).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* Upgrade vite-plugin-solid to 3.0.0-next.21
Peer-requires `>=2.0.0-beta.29` (already satisfied) and ships
`@dom-expressions/compiler@0.50.0-next.34`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* Upgrade @tanstack/solid-query to 6.0.0-beta.7
Bump `@tanstack/solid-query` and `@tanstack/solid-query-devtools` to
`6.0.0-beta.7`. The devtools package peer-requires
`@tanstack/solid-query: ^6.0.0-beta.7`, so the two must move together.
`@tanstack/solid-query` is pinned through the `catalog:` entry in
pnpm-workspace.yaml and forced repo-wide via `overrides`, so the catalog
value is bumped alongside the package.json ranges — editing the
package.json ranges alone has no effect on resolution.
Both packages are added to `minimumReleaseAgeExclude`; the repo gates on
`minimumReleaseAge: 1440` and these betas are newer than that.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Upgrade `solid-js`, `@solidjs/web` and `babel-preset-solid` to
`2.0.0-beta.27`, and `vite-plugin-solid` to `3.0.0-next.17`
(peer-requires `>=2.0.0-beta.26`).
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
* chore: upgrade Solid v2 packages to 2.0.0-beta.20
Bumps solid-js and @solidjs/web from 2.0.0-beta.19 to 2.0.0-beta.20 and
vite-plugin-solid from 3.0.0-next.11 to 3.0.0-next.13 across packages,
examples, e2e apps, and benchmarks.
vite-plugin-solid 3.0.0-next.13 defaults to the new native JSX backend
(@dom-expressions/compiler), which is an incomplete milestone build that
cannot compile components with element children yet ("Only text and
expression component children are implemented in the AST-native
milestone"). Every vite-plugin-solid call site now passes
compiler: 'babel' to keep the babel-preset-solid pipeline until the
native compiler matures.
Also fixes two pins that had gone stale: the quickstart-webpack example's
direct babel-preset-solid pin (stuck on beta.18) and
@rsbuild/plugin-solid's babel-preset-solid lockfile resolution (also
beta.18), so the compiler and runtime are in lockstep everywhere.
Verified with solid-router test:unit (client + server modes) and
e2e/solid-start/basic (pnpm build + test:e2e:local).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: use the native JSX compiler (vite-plugin-solid default)
Removes the compiler: 'babel' escape hatch from all vite-plugin-solid
call sites, returning to next.13's default native backend
(@dom-expressions/compiler).
The native compiler's only unimplemented construct that this repo used
was a fragment passed as a component's child (dom mode only). The single
instance — the redundant <>{props.children}</> wrapper in solid-router's
ClientOnly — is removed; props.children is a valid JSX child on its own.
Verified: solid-router test:unit (client + server), e2e/solid-start/basic
(pnpm build + test:e2e:local), and a direct scan of all 1353 solid
.tsx/.jsx files in the repo through @dom-expressions/compiler in both
dom and ssr modes with zero failures.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* chore: upgrade Solid v2 packages to 2.0.0-beta.16
Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.15
to 2.0.0-beta.16 across packages, examples, e2e apps, benchmarks, and
the pnpm overrides in pnpm-workspace.yaml.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: upgrade Solid v2 packages to 2.0.0-beta.17
Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.16
to 2.0.0-beta.17 across packages, examples, e2e apps, and benchmarks.
The scoped babel-preset-solid overrides in pnpm-workspace.yaml are
removed instead of bumped: vite-plugin-solid@3.0.0-next.5 and
@rsbuild/plugin-solid@2.0.0-beta.0 both declare
'>=2.0.0-beta.0 <2.0.0-experimental.0', which resolves to the newest
v2 beta on its own, while Solid 1.x consumers keep babel-preset-solid
1.x. A stale override here silently kept the beta.16 compiler (with
its broken omitLastClosingTag marker handling) in the build pipeline.
The @dom-expressions/* scope is added to minimumReleaseAgeExclude,
covering the renamed compiler package (@dom-expressions/babel-plugin-jsx,
formerly babel-plugin-jsx-dom-expressions).
Two unrelated loose specs are pinned to their locked versions because
re-resolving the lockfile pulled broken releases: @platformatic/flame
1.7.0 fails pnpm's trust-downgrade policy, and the nitro-nightly
'latest' tag depends on an unpublished h3 version.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(solid-router): suspend on the match loadPromise only during SSR
On the client, returning the loadPromise from MatchInner's pending
branch keeps a live async source in the tree whenever a match is
pending. Since Solid 2.0.0-beta.16, that routes every signal write
into a transition hold for the rest of the flush, which breaks
router-core's synchronous write-then-load flows: invalidate() on a
notFound match never re-ran the loader, and writes to unrelated
signals were held too.
SSR keeps the suspension so the streaming engine waits for the match
to settle; the client now renders just the pending component.
Verified on beta.17: without this, "re-runs loaders that throw
notFound() when invalidated via HMR filter" and "keeps rendering a
route notFoundComponent when loader returns notFound() after
invalidate" fail.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(lockfile): restore all @rspack/binding@2.0.8 platform binaries
The lockfile entry for @rspack/binding@2.0.8 only listed the
darwin-arm64 binding, so linux CI runners had no matching native
binding and rspack fell back to a hoisted 2.0.0 binary, crashing the
bundle-size benchmark with a core/binding version mismatch.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: add changesets for solid-js beta.17 upgrade and SSR-only match suspension
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(examples): replace broken nitro-nightly pin with nitro beta in start-rscs
The pinned nitro-nightly@4.0.0-20251010 self-imports 'nitro/runtime/meta',
which under pnpm's isolated layout resolves to the hoisted nitro 3.x beta
and crashes vite config loading. Mirrors upstream fix e65f0c84c1 (#7809).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: upgrade vite-plugin-solid to next.7
* fix(solid-router): retain manifest stylesheets across navigation
* chore: upgrade Solid v2 packages to 2.0.0-beta.18 and vite-plugin-solid to next.8
Bumps solid-js, @solidjs/web, and babel-preset-solid from 2.0.0-beta.17
to 2.0.0-beta.18 and vite-plugin-solid from 3.0.0-next.7 to 3.0.0-next.8
(which pins @dom-expressions/jsx-compiler to 0.50.0-next.21) across
packages, examples, e2e apps, and benchmarks.
vite-plugin-solid is added to minimumReleaseAgeExclude: Solid publishes
plugin prereleases in lockstep with the runtime betas, often minutes
before we bump, and pnpm's 24h release-age gate otherwise filters the
new version with a misleading NO_MATCHING_VERSION error.
Verified: solid-router unit tests (client + server modes), solid-start
basic e2e (80 passed), solid-router basic-file-based e2e (120 passed),
and all 17 bundle-size benchmark scenarios build cleanly.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(start-plugin-core): select client entry chunk by facade module instead of asserting a single entry
vite-plugin-solid >= 3.0.0-next.6 emits a facade chunk for every
dynamically imported project module during SSR client builds (to keep
its own manifest lookups stable), and emitted chunks are flagged
`isEntry` just like the configured entry. The start manifest capture
plugin asserted the client bundle contains exactly one entry chunk, so
every solid-start app failed to build with "multiple entries detected".
The capture plugin now receives the resolved client entry path and picks
the entry chunk whose facadeModuleId matches it; other entry-flagged
chunks are treated as ordinary chunks. When no chunk matches, a single
entry is still accepted as before, and the multiple-entries error now
lists every entry chunk with its facade module to ease diagnosis.
Verified with fresh package builds: previously failing memory-server
solid benchmark targets, all 17 bundle-size scenarios, solid-start basic
build + e2e (80 passed), react-start basic build, and the
start-plugin-core unit suite (494 tests).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* ci: apply automated fixes
* test(start-plugin-core): pass getClientEntry to startManifestPlugin in dev manifest test
Fixes the type tests after startManifestPlugin gained a required
getClientEntry option.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Revert "fix(start-plugin-core): select client entry chunk by facade module instead of asserting a single entry"
This reverts commit d0f4926ec0.
* chore: upgrade vite-plugin-solid to 3.0.0-next.10
next.10 ships the fix for the lazy facade entry reclassification under
rolldown-vite (solidjs/vite-plugin-solid#269): assigning isEntry = false
instead of deleting the property, so the reclassification actually
propagates through rolldown's bundle proxies and downstream plugins no
longer see every lazy facade chunk as an application entry. This is the
proper replacement for the reverted start-plugin-core workaround
(see a1ee1638f5) — the strict single-entry assertion now holds again.
Verified: e2e/solid-start/basic build + e2e suite (80 passed),
solid-router test:unit client (814) + server (2) modes,
start-plugin-core unit tests (486).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11
vite-plugin-solid 3.0.0-next.11 peer-requires solid-js and @solidjs/web
>=2.0.0-beta.19, so the Solid v2 packages are bumped in lockstep across
all workspace pins (packages, examples, e2e, benchmarks).
Verified: e2e/solid-start/basic build succeeds — no "multiple entries
detected" error from start-manifest-capture-client-build; solid-router
test:unit client (814 passed) + server (2 passed) modes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11 [Self-Healing CI Rerun]
* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11 [Self-Healing CI Rerun]
* fix(e2e): make prerender builds hermetic to deflake build:vite:prerender
The prerender crawl runs inside `vite build` and SSRs /posts and every
crawled /posts/$postId. The `import.meta.env.VITE_NODE_ENV === 'test'`
switch to the local dummy server was inlined away at build time because
Playwright only sets that env for the test-time webServer, never for the
nx build target — so build-time SSR fetched the real
jsonplaceholder.typicode.com from CI. When that public API stalled, the
page never sent headers and the build died after undici's 5-minute
headers timeout (UND_ERR_HEADERS_TIMEOUT).
Fix, applied to the react/solid/vue basic apps alike:
- Resolve the posts/users API base URL at request time from process.env
(same pattern users.tsx already used) instead of build-time inlining,
so the built app honors whatever dummy server the harness is running.
- Add e2eStartDummyServerForBuild() to @tanstack/router-e2e-utils and
call it from the apps' vite configs in prerender mode: it starts the
dummy server on a free port for the lifetime of the build, exposes it
via VITE_NODE_ENV/VITE_EXTERNAL_PORT, and unrefs everything so the
build process can exit.
Verified: nx run tanstack-solid-start-e2e-basic:build:vite:prerender
passes (47 pages prerendered, dummy server used, tsc clean), prerendered
posts/index.html contains the expected content, and the server bundle
now keeps the runtime env check instead of a hardcoded external URL.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* ci: apply automated fixes
* chore: upgrade solid-js/@solidjs/web to 2.0.0-beta.19 and vite-plugin-solid to 3.0.0-next.11 [Self-Healing CI Rerun]
* fix(e2e): harden prerender-build dummy server and log fetch targets
CI still hit UND_ERR_HEADERS_TIMEOUT during build:vite:prerender after
de2132af1b. The failure pattern (fetch logs print instantly, then a
5-minute stall) means the posts fetches still reached the real external
API in that run: the dummy server resolves in milliseconds in-process,
and a non-listening port would fail instantly with ECONNREFUSED.
One way that can happen: e2eStartDummyServerForBuild() early-returned
whenever VITE_EXTERNAL_PORT was already present in the environment,
skipping both the server start AND setting VITE_NODE_ENV — leaving the
runtime URL check pointing at jsonplaceholder. Guard on a globalThis
flag instead and always set both env vars.
Also, to make the next failure diagnosable and survivable:
- fetchPost/fetchPosts (react/solid/vue basic) now log the base URL they
fetch from, so CI output shows whether the dummy server was used.
- prerender configs set retryCount: 2 / retryDelay: 1000 so a transient
hang retries instead of failing the whole build.
Verified: nx run tanstack-solid-start-e2e-basic:build:vite:prerender
passes with "Fetching posts from http://localhost:<port>..." in the log
and 47 pages prerendered.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
* fix(solid-router): resolve defaultNotFoundComponent at render time to avoid hydration desync
Previously defaultNotFoundComponent was applied by lazily mutating the
boundary route's options.notFoundComponent when a notFound was handled.
Route objects are module singletons shared across server requests, so
once the server handled any 404, later SSRs of valid URLs wrapped the
match in a CatchNotFound boundary the freshly-hydrating client doesn't
render, shifting hydration keys and leaving the subtree unclaimed
(visible but inert DOM).
Resolve defaultNotFoundComponent at render time in Match.tsx so the
boundary structure is deterministic on both server and client, and add
an e2e regression test.
* ci: apply automated fixes
* chore: add changeset for defaultNotFoundComponent hydration fix
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* fix(router-core): preserve percent-encoded URL-unsafe chars in decodeSegment
Replace sanitizePathSegment (which stripped control characters) with a
re-encode step that keeps WHATWG path percent-encode set characters and
control characters in their encoded form after decodeURI.
This preserves the existing decodeURI-based approach which correctly
handles multi-byte UTF-8 sequences, while fixing the mismatch between
the original request URL and the router's internal representation that
caused infinite 307 redirect loops on paths containing these characters.
Fixes#7587.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* ci: apply automated fixes
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Flo <me@florianpellet.com>
Bump solid-js and @solidjs/web from 2.0.0-beta.14 to 2.0.0-beta.15
across all packages, examples, and e2e apps.
- Pin solid-js as an explicit devDependency in @tanstack/solid-router
(it previously only declared a floating peer range, so pnpm kept it
on beta.14).
- Update the scoped vite-plugin-solid babel-preset-solid override to
beta.15 and add a matching scoped override for @rsbuild/plugin-solid.
- Add minimumReleaseAgeExclude for the freshly published solid betas.
- router-devtools-core intentionally stays on Solid v1.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* fix(start-plugin-core): support rsbuild preview SSR
* fix(start-plugin-core): always install rsbuild SSR middleware in preview
Preview is the only SSR handler in `rsbuild preview`, so gate the opt-out
to dev only and keep the option named `installDevServerMiddleware`.