0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

6,614 commits

Author SHA1 Message Date
github-actions[bot]
84bde660a1
ci: Version Packages (#8457) release-2026-09-16-2153 @tanstack/react-router@1.170.38 @tanstack/react-start-client@1.168.36 @tanstack/react-start-rsc@0.1.55 @tanstack/react-start-server@1.167.43 @tanstack/react-start@1.168.56 @tanstack/router-cli@1.167.38 @tanstack/router-core@1.171.32 @tanstack/router-generator@1.167.38 @tanstack/router-plugin@1.168.40 @tanstack/router-vite-plugin@1.167.40 @tanstack/solid-router@1.170.36 @tanstack/solid-start-client@1.168.35 @tanstack/solid-start-server@1.167.42 @tanstack/solid-start@1.168.54 @tanstack/start-client-core@1.170.32 @tanstack/start-plugin-core@1.171.46 @tanstack/start-server-core@1.169.37 @tanstack/start-static-server-functions@1.167.37 @tanstack/start-storage-context@1.167.34 @tanstack/vue-router@1.170.35 @tanstack/vue-start-client@1.167.38 @tanstack/vue-start-server@1.167.42 @tanstack/vue-start@1.168.53
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-09-16 23:34:45 +02:00
Flo
ce10dcd4d9
perf(router-core): reduce replaceEqualDeep allocations (#8411)
* perf(router-core): reuse key buffers in replaceEqualDeep

* perf(router-core): reuse unchanged incoming objects

* perf(router-core): reuse existing search objects
2026-09-16 23:12:37 +02:00
Manuel Schiller
bbd2336b84
perf(router-core): split replaceEqualDeep into an equality scan and a copy phase (#8389)
* perf(router-core): split replaceEqualDeep into an equality scan and a copy phase

`replaceEqualDeep` compared and copied in one loop. Every entry, also on
the common all-equal path, paid for the copy bookkeeping (`copy ??=`,
`if (copy) copy[key] = n`), an `equal` flag and — for objects — a
`hasOwn.call(prev, key)` lookup, while arrays and objects shared the
same keyed accesses through `array ? i : keys[i]`, so every access site
saw both element and named keys.

The function now runs in two phases:

- Scan: walk `next` up to the first difference, sharing equal children
  on the way. Arrays and objects have their own loop, so each keyed
  access only ever sees one kind of key and nothing is allocated while
  entries keep matching. A key at the same position of both key lists
  is proven to be `prev`'s own key; only reordered keys still need
  `hasOwn`. When everything matched and the key counts agree, `prev` is
  returned.
- Copy: equality is ruled out, so the loop only builds the result. The
  scanned prefix is shared from `prev`, the first differing entry keeps
  the value the scan already computed, and the rest is resolved without
  any equality bookkeeping.

Only an object entry of `prev` can share anything, so the recursion is
guarded by a single `typeof` check; `null` and mismatched types return
`next`'s entry through the entry checks. `isPlainArray` is no longer
used here: the array check reuses the `Object.keys` result that the
scan needs anyway. Semantics are unchanged: pass-through for
non-enumerable keys and for symbol keys on `next`, null-prototype
copies, the depth limit and the SSR early return all stay as they were,
and the tests pass against both implementations.

Bundle size (`benchmark:bundle-size`, gzip): react-router.minimal -1 B,
react-router.full -18 B, all 18 scenarios net -110 B (13 down, 5 up,
max +20 B on react-start.full for identical code).

Paired runs against the previous version (hz medians of 3 runs,
1000 calls per iteration; the machine was under load, so single-digit
differences are noise):

  equal flat search                          5.96k -> 6.98k  (+17%)
  equal nested search                        2.47k -> 2.83k  (+14%)
  equal array of objects                       524 ->   579  (+10%)
  equal long primitive array (1024)             49 ->    69  (+39%)
  long primitive array, last item changed       37 ->    41  (+11%)
  wider flat object (64 keys), last changed    218 ->   229   (+5%)
  flat search, one changed leaf              5.31k -> 5.59k   (+5%)
  array of objects, one changed item           483 ->   513   (+6%)
  flat search, all leaves changed            5.29k -> 5.35k   (+1%)
  array of shared objects, one changed       1.61k -> 1.44k  (-10%, ±29%)

Entries that change between an object and a primitive now pay one
recursive call instead of an inline four-way type check; guarding both
sides costs more bundle bytes than this branch is worth.

Adds tests for the scan/copy boundary (equal children and next-only
keys after the first difference, reordered keys, object/primitive
transitions, shorter and longer arrays, a change in the last of 1024
entries, the depth limit) and bench cases for the shapes that told the
candidate implementations apart.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix(router-core): keep sparse arrays with extra keys opaque in replaceEqualDeep

The plain-array check compares `Object.keys(array).length` with
`array.length`. A hole and an extra enumerable key cancel out in that
count, so `Object.assign([1, ,], { extra: 'x' })` was admitted: the
index-based copy dropped `extra` and turned the hole into an explicit
`undefined`, and an index-wise equal `prev` was returned for it. The
same blind spot exists in the exported `isPlainArray`, which the
previous implementation used for this check.

Extra string keys always sort after the index keys, so once the count
matches, `next` is a dense index-only array exactly when its last key
is its last index. That is one string comparison per array instead of
a per-key validation, and it stays inline with the existing count
check. `prev` keeps the count check only: a result is either a copy
built from `next`'s entries or `prev` itself, which the caller already
holds.

Symbol keys on arrays stay admitted, as before this stack: checking
them costs an `Object.getOwnPropertySymbols` call per array pair, which
measured ~8% on the equal nested search shape (a record holding a
four-element array), and `react-router.minimal` +3 B on top of the
+13 B gzip of this fix.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-16 23:12:36 +02:00
Manuel Schiller
01035782e5
perf(router-core): skip symbol enumeration for plain replaceEqualDeep inputs (#8364)
Every object pair `replaceEqualDeep` visited paid for three native key
lookups per side: `Object.keys`, `Object.getOwnPropertyNames` (to detect
non-enumerable props) and `Object.getOwnPropertySymbols`. Measured on a
4-key literal the first two cost 7.6 ns and 10 ns, the symbol lookup
34 ns — 31 ns even on `{}` — so two thirds of the enumeration cost went
into a key type that router data never carries. (`Reflect.ownKeys` as a
single replacement call was tried and is 100 ns.)

Symbol keys and non-enumerable keys still have to be handled correctly:
Apollo's `preloadQuery` refs carry symbol keys and broke under
`defaultStructuralSharing` when copies dropped them (#4237). Instead of
comparing and copying such objects key by key, they are now opaque: an
object with non-enumerable own keys on either side, or symbol keys on
`next`, makes `next` pass through untouched. That keeps both guarantees
that matter — no partial copy, no stale `prev` returned for it — and only
gives up structural sharing for those objects.

`prev` is not scanned for symbols on purpose. It is normally an earlier
`next`, so a symbol-carrying `prev` meets a symbol-carrying `next` and the
`next` check fires; a symbol-carrying `prev` with a symbol-free, otherwise
equal `next` returns `prev` (covered by a test). Plain objects are now
compared and copied by `Object.keys` alone, and `getEnumerableOwnKeys`
is gone.

Paired runs against the previous version (hz, 1000 calls per iteration):

  equal empty objects             14.8k -> 18.3k  (+24%)
  equal empty null-proto objects   5.1k ->  6.3k  (+24%)
  equal flat search                7.3k ->  8.2k  (+12%)
  flat, one changed leaf           6.1k ->  6.9k  (+12%)
  equal nested search              3.0k ->  3.1k   (+4%)
  nested, sharing subtrees         2.6k ->  2.7k   (+7%)
  equal array of objects            609 ->   729  (+20%)
  array, one changed item           551 ->   640  (+16%)
  wide (12 keys) changed, null-proto 1.8k -> 2.0k  (+9%)

Tests now document the pass-through contract for symbol-keyed objects,
including the deliberate `prev`-only asymmetry.
2026-09-16 23:12:36 +02:00
Manuel Schiller
cecae5440b
perf(router-core): check plain objects by constructor (#8363)
* perf(router-core): check plain objects by constructor

`isPlainObject` gates every recursion step of `replaceEqualDeep` and
`deepEqual`, so it runs at least twice per object pair, on every nested
level, on every navigation and Link build. The previous implementation
(copied from `is-plain-object`) called `Object.prototype.toString` on the
value and again on its constructor's prototype, plus a `hasOwnProperty`
lookup: up to four `toString` dispatches per compared pair, most of them
spent confirming that `{}` is a plain object.

The check is now a single expression:

  !!o && typeof o === 'object' && (o.constructor ?? Object) === Object

Object literals, `JSON.parse` output and `Object.create(literal)` inherit
`Object` as their constructor; `Object.create(null)` objects (the router's
search and params objects) have none, which `?? Object` accepts. Class
instances, arrays, `Map`, `Date`, functions and primitives fail it, as
before. The only accept-set differences are objects from another realm
(an iframe's `Object` is not `===` ours) and objects with a custom
`Symbol.toStringTag`; neither occurs in router state.

Paired runs against the previous version (hz, 1000 calls per iteration):

  deepEqual equal empty objects         25.6k -> 59.4k  (+132%)
  deepEqual nested, one changed leaf    11.3k -> 22.8k  (+102%)
  deepEqual equal flat (partial)        23.0k -> 39.7k   (+73%)
  replaceEqualDeep equal empty objects  10.6k -> 14.9k   (+40%)
  replaceEqualDeep equal array of objs    489 ->   604   (+24%)
  replaceEqualDeep equal nested          2.4k ->  2.8k   (+19%)
  replaceEqualDeep equal flat search     6.0k ->  7.0k   (+17%)

Adds an accept/reject table for `isPlainObject` and checks that class
instances stay opaque to structural sharing while null-prototype and
literal objects compare as equal.

* fix(router-core): keep records with a constructor key plain

`?constructor=foo` decodes to an own `constructor` data key on the
null-prototype search record, and `(o.constructor ?? Object) === Object`
read that key. Such records (and the `{ ...search }` copies of them) were
classified as non-plain, so `replaceEqualDeep` handed back `next` without
sharing and `deepEqual` reported them unequal.

Keep the constructor comparison as the fast accept: it is an inline-cache
load for literals and null-prototype records and is what the PR's speedup
comes from. When `constructor` is anything else, consult the actual
prototype instead of rejecting: `null` or one whose `constructor` is
`Object` means a record, anything else a class instance. The prototype
lookup is a builtin call (~6ns in megamorphic optimized code), so running
it unconditionally would return most of the gain: median hz over 3
rotated rounds, `replaceEqualDeep` equal empty 10.9k -> 8.6k (-21%),
equal array of objects 470 -> 386 (-18%), `deepEqual` equal empty
58.0k -> 35.9k (-38%). With the fallback only on the mismatch path the
hot cases stay within noise of the shortcut and the constructor-key
cases now do the sharing work at the same cost as other null-prototype
records. `react-router.minimal` gzip is +15 B against the shortcut and
still 44 B below the `toString` implementation.

Benchmarks the predicate directly (literal, null-prototype record, record
with a constructor key, class instance) and sharing of a search record
that carries a constructor key. Tests both record shapes and parser
output, all `constructor` value types, and that a class instance with an
own `constructor` key stays opaque.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-16 23:12:35 +02:00
Manuel Schiller
84936cc045
perf(router-core): allocate replaceEqualDeep copies lazily (#8362)
`replaceEqualDeep` runs on every navigation and Link build: search,
params, state and loader data all go through it, and in the common case
`next` turns out to be deeply equal to `prev`. Until now the function
still allocated the result object (or array) up front and filled it key
by key while comparing, only to throw it away and return `prev`.

The copy is now created at the first difference. Everything compared
before that point is known to be equal and is taken from `prev` in one
pass (`copyItems`), so unchanged subtrees are shared exactly as before.
When nothing differs, nothing is allocated; when only the key sets
differ, the copy is built after the loop.

Smaller changes in the same function:

- deep equality is a single `equal` flag instead of a matched-key count
  compared against the sizes afterwards; once unequal, the `hasOwn`
  check for keys that only `next` has is skipped
- `nullReplaceEqualDeep` passes a boolean instead of an object factory,
  so the plain variant no longer evaluates a default `() => ({})` per
  call and the copy site has no indirect call
- an overload signature keeps the generic return type without the
  `_next` alias in the emitted code
- `getEnumerableOwnKeys` loops over `getOwnPropertySymbols` directly;
  an empty loop needs no early return

`tests/replace-equal-deep.bench.ts` was added first, with the shapes the
router feeds these helpers. Paired runs against the previous version
(hz, 1000 calls per iteration):

  equal empty objects        10.0k -> 10.6k   (+6%)
  equal flat search           5.3k ->  5.9k  (+12%)
  equal nested search         2.2k ->  2.4k  (+13%)
  equal array of objects       445 ->   485   (+9%)
  flat, one changed leaf      5.4k ->  5.2k   (-3%)
  wide (12 keys) changed      2.4k ->  2.2k  (-11%)

The equal paths win and allocate nothing; the copy paths pay for the
extra call and the per-key `copy` check.
2026-09-16 23:12:34 +02:00
github-actions[bot]
de023a7533
ci: Version Packages (#8429) release-2026-09-16-2114 @tanstack/react-router-ssr-query@1.167.3 @tanstack/react-router@1.170.37 @tanstack/react-start-client@1.168.35 @tanstack/react-start-rsc@0.1.54 @tanstack/react-start-server@1.167.42 @tanstack/react-start@1.168.55 @tanstack/router-cli@1.167.37 @tanstack/router-core@1.171.31 @tanstack/router-generator@1.167.37 @tanstack/router-plugin@1.168.39 @tanstack/router-ssr-query-core@1.169.3 @tanstack/router-vite-plugin@1.167.39 @tanstack/solid-router-ssr-query@1.167.3 @tanstack/solid-router@1.170.35 @tanstack/solid-start-client@1.168.34 @tanstack/solid-start-server@1.167.41 @tanstack/solid-start@1.168.53 @tanstack/start-client-core@1.170.31 @tanstack/start-plugin-core@1.171.45 @tanstack/start-server-core@1.169.36 @tanstack/start-static-server-functions@1.167.36 @tanstack/start-storage-context@1.167.33 @tanstack/vue-router-ssr-query@1.167.3 @tanstack/vue-router@1.170.34 @tanstack/vue-start-client@1.167.37 @tanstack/vue-start-server@1.167.41 @tanstack/vue-start@1.168.52
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-09-16 23:07:33 +02:00
Manuel Schiller
cbbfbe37ab
optimize streaming (#8204) 2026-09-16 22:38:25 +02:00
Manuel Schiller
1ca361ba52
refactor(router-core): parse masked locations without mutating shared state (#8421)
* refactor(router-core): parse masked locations without mutating shared state

`parseLocation` built the presented location of a masked entry by parsing
the stored `__tempLocation` and then patching and `delete`-ing keys on the
resulting `state`, which `replaceEqualDeep` may have shared with the
previous location, before spreading the result once more. The inner parser
now takes the state to use, so the masked branch passes the intended state
up front and assigns `maskedLocation` on the fresh object.

The slow parsing path only runs the input rewrite when one is configured,
and `resolvePathWithBase` is inlined into its two callers.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit cc6159628cd22faf9c16e6e432cb35093b2826a8)

* refactor(router-core): remove redundant input rewrite guard

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-16 00:42:50 +02:00
Manuel Schiller
a1c8d1aa75
perf(router-core): pass resolvePath arguments positionally (#8419)
`resolvePath(base, to, trailingSlash?, cache?)` replaces the options object,
so `resolvePathWithBase` — called from `buildLocation` and `matchRoute` —
no longer allocates per path resolution. `resolvePath` is an internal
helper. react-router.minimal shrinks by 17 B gzip (60 raw).


(cherry picked from commit de7bc72a952aaf77bbedfd4453a4d12edadaad53)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-16 00:42:50 +02:00
Manuel Schiller
a0b2ad99ae
perf(router-core): parse the location once in update and build rewrites without arrays (#8422)
* perf(router-core): parse the location once in update and build rewrites without arrays

- update(): compute the basepath/rewrite before the single updateLatestLocation
  call; the first update always saw basepathWasUnset, so every router
  construction parsed the location twice and re-published to a store created
  from the same location.
- invalidate(): fill the id set in one pass instead of spread/flat/filter/map.
- rewriteBasepath(basepath, caseSensitive?) takes positional arguments (it is
  internal) and the output rewrite uses cleanPath on a template string instead
  of joinPaths' array/filter/join.
- parseLocation(): inline the single-use fullPath local.

react-router.minimal 86019 -> 85989 gzip, react-router.full 89605 -> 89561 gzip.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 64978a1c8a8b5926c53797edcb528159c70ab093)

* perf(router-core): parse the location once in update and build rewrites without arrays [Self-Healing CI Rerun]

* test(router-core): cover basepath rewrite composition and updates

* perf(router-core): specialize internal basepath rewrites

* fix(router-core): key server route caches by case sensitivity

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-09-15 23:57:16 +02:00
Manuel Schiller
83895f1272
test(router-core): add a Link-like buildLocation benchmark (#8423)
Mirrors what useLinkProps does on every location publication: 32 links, each
with a stable dest object, pointing _fromLocation at a fresh location and
calling router.buildLocation inside their selector. Covers the static-cache
hit, search updaters (with and without middleware), relative destinations,
inherited params and masks. Baseline (Node 24.8, hz, mean of two runs):

  static cache hit         1,928,000   search updater   41,600
  + retainSearchParams        30,850   relative         29,800
  params: true                35,050   masked           20,500


(cherry picked from commit d4787b65e25e0817f747fc3c6dc0209889ffe174)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-15 22:48:37 +02:00
Manuel Schiller
856cfcd05a
agents (#8258)
* agents

* update

* docs: require upstream fixes for dependency issues
2026-09-15 22:36:13 +02:00
Manuel Schiller
8e164d28f9
refactor(react-router): drop the useLinkProps pass-through wrapper (#8420)
`useLinkPropsFor` existed only to keep the `host` argument off the public
`useLinkProps` signature. Fold it into `useLinkProps` behind an `@internal`
overload; `stripInternal` removes that overload from the published
declarations, so the public signature stays `(options, forwardedRef?)`.
react-router.full shrinks by 24 B gzip.


(cherry picked from commit 918d3050850815abc8ae49518befda61cb29bf7b)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-14 23:30:50 +02:00
Manuel Schiller
e561fa1d71
perf(router-core): pass deepEqual flags positionally (#8418)
`deepEqual(a, b, partial?, explicitUndefined?)` replaces the options
object. The hot callers (Link option stabilization and active-state checks,
matchRoute) no longer allocate `{ partial }` / `{ ignoreUndefined: false }`
per comparison, and the comparator reads two booleans instead of an options
parameter that saw four object shapes. `explicitUndefined` (falsy default)
replaces `ignoreUndefined: false` and reuses the `activeOptions` vocabulary.

deepEqual is an internal helper; two-argument callers are unaffected.

react-router.minimal shrinks by 48 B gzip (129 raw) on top of the previous
commit; the Link stabilization micro-benchmark improves by ~10% and the
paired Link component runner resolves three cases as faster.


(cherry picked from commit d6f2c1ca55a4900b33868cfc115ac7120d68d26b)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-14 20:42:14 +02:00
Manuel Schiller
bc80866f6d
perf(router-core): skip recursion for identical array elements in deepEqual (#8417)
Compare array elements by identity before recursing, count the exact
comparison down with a single counter, and drop the `typeof` early exit,
which `Array.isArray`/`isPlainObject` already imply. Behavior, key
enumeration and getter read order are unchanged (pinned by the new contract
test).

Measured in one mixed-mode process (all option modes share the function's
type feedback, which is how the router uses it): equal numeric arrays ~+65%,
flat records +7-9%, nested records and mismatches +7-8%; every case
improves. Identity guards inside the object loops were rejected: they grow
the recursive function past what V8 keeps inlining and cost -31% on a
single-key mismatch. react-router.minimal shrinks by 4 B gzip.


(cherry picked from commit cb23ed54757255540cb203081c3423524d6483ca)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-14 20:42:13 +02:00
Harry Whorlow
34bb302c09
chore(netlify): bump vite plugin and update trust policy (#8414) 2026-09-14 17:05:02 +02:00
github-actions[bot]
a768f66c2f
ci: Version Packages (#8413) release-2026-09-14-0945 @tanstack/react-start-rsc@0.1.53 @tanstack/react-start@1.168.54 @tanstack/solid-start@1.168.52 @tanstack/start-plugin-core@1.171.44 @tanstack/vue-start@1.168.51
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-09-14 11:40:25 +02:00
Flo
5facdbfe3d
test: fix Nx sandbox violations in CI tasks (#8400)
* test: declare remaining Nx sandbox inputs and outputs

* test: declare the ESLint Start build configuration input

* test: match generated route fixtures in Nx outputs

* ci: apply automated fixes

* test: keep mutable fixtures out of Nx cache replay

* test: declare inputs found in the latest Nx sandbox audit

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-09-14 10:54:23 +02:00
Flo
fda8a77405
test(e2e): let Playwright manage application servers (#8357) 2026-09-14 10:54:23 +02:00
Flo
e8b0701420
test(e2e): replace dummy APIs with MSW fixtures (#8402)
* test(e2e): replace dummy APIs with MSW fixtures

* test(e2e): require Node with native type stripping

* Merge branch 'codex/e2e-playwright-cache' into codex/e2e-runtime-fixtures [Self-Healing CI Rerun]

---------

Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-09-14 10:54:22 +02:00
Flo
702d9efe8b
fix(e2e): serialize Playwright runners per Nx agent (#8356)
fix(e2e): adopt upstream Playwright cache validation
2026-09-14 10:54:22 +02:00
Flo
ab99818225
chore(deps): upgrade Rsbuild to 2.2.5 (#8397)
* chore: upgrade Rsbuild to 2.2.5

* fix(rsbuild): preserve flags in watch exclusions

* Merge branch 'main' into codex/rsbuild-upgrade [Self-Healing CI Rerun]

---------

Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-09-14 10:54:21 +02:00
github-actions[bot]
6954a370a7
ci: Version Packages (#8355) release-2026-09-13-1319 @tanstack/history@1.162.4 @tanstack/react-router-devtools@1.167.2 @tanstack/react-router@1.170.36 @tanstack/react-start-client@1.168.34 @tanstack/react-start-rsc@0.1.52 @tanstack/react-start-server@1.167.41 @tanstack/react-start@1.168.53 @tanstack/router-cli@1.167.36 @tanstack/router-core@1.171.30 @tanstack/router-devtools-core@1.168.2 @tanstack/router-devtools@1.167.2 @tanstack/router-generator@1.167.36 @tanstack/router-plugin@1.168.38 @tanstack/router-vite-plugin@1.167.38 @tanstack/solid-router-devtools@1.167.2 @tanstack/solid-router@1.170.34 @tanstack/solid-start-client@1.168.33 @tanstack/solid-start-server@1.167.40 @tanstack/solid-start@1.168.51 @tanstack/start-client-core@1.170.30 @tanstack/start-plugin-core@1.171.43 @tanstack/start-server-core@1.169.35 @tanstack/start-static-server-functions@1.167.35 @tanstack/start-storage-context@1.167.32 @tanstack/vue-router-devtools@1.167.2 @tanstack/vue-router@1.170.33 @tanstack/vue-start-client@1.167.36 @tanstack/vue-start-server@1.167.40 @tanstack/vue-start@1.168.50
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-09-13 15:13:54 +02:00
Manuel Schiller
bc57fa3f12
fix(router-core): review follow-ups for Link stack (#8410)
* chore(benchmarks): remove TSR_LINK_PERF opt-in flag

The router-core Link/path benchmarks and the react-link-performance
project are never part of the CodSpeed matrix or the client-nav/SSR
aggregate projects, so the env-var gate only added friction. Rely on
standard vitest name filtering (-t) to narrow runs instead.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix(router-core): treat 0 and false as provided _splat values

Splat interpolation used a falsy check, so _splat: 0 was omitted like a
missing param while $id: 0 interpolated to '/0'. Only undefined, null,
and '' now omit a splat segment, matching how other path params are
stringified.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test(router-core): use path-derived ids in original-param-names fixtures

The matcher only uses route ids as routesById keys and for the pathless
'_' check, so unrelated ids worked but never occur in a real router.
Align the fixtures with the sibling test file's convention where each
id mirrors its fullPath.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(solid-router): shorten conditional Link class and style spreads

Spread `cond && { value }` instead of `cond ? { value } : undefined`,
matching the neighbouring `active && STATIC_ACTIVE_ATTRIBUTES` spread.
Falsy operands spread to nothing, so the emitted props are unchanged.

Measured with the bundle-size benchmark on solid-router.full:
gzip 39205 -> 39198 (-7), raw -12, brotli -33.

Covered by the existing `six-adults-open` changeset.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test(router-core): drop the unused server axis from interpolatePath tests

The `interpolatePath (server: $server)` block never read its `server`
argument since interpolation stopped taking a server flag, so it ran every
case twice under a misleading label. The remaining diff is re-indentation;
review with `git show -w`.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test(router-core): interpolate paths through the production API in tests

`interpolateTestPath` only survived as a compatibility layer from the
segment-reuse refactor: it emulated the removed
`(path, params, decoder, usedParams, keys, metadata)` signature by parsing
the template, re-implementing the param-name loop and folding
`hasMissingPathParams` into a metadata flag.

Call the real functions instead. Tests now parse templates with
`parseSegments(false, { fullPath }, 0)` exactly like `buildLocation` does
for templates without a processed route, pass the segments to
`interpolatePath`, and read names and availability from `getParamNames`
and `hasMissingPathParams`. The prepared-route tests compare route-owned
segments against that standalone parse directly, and the interpolation
bench derives its reference values the same way.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:08 +02:00
Manuel Schiller
1e6d9c8062
perf(router-core): match the current location lazily in buildLocation (#8406)
`buildLocation` matched the current location up front for every build,
although the result is only read by relative destinations, inherited
params, `search: true` or updater functions and search middlewares. An
absolute destination with its params given, on a branch without search
middlewares, never reads it, yet still paid three store reads and a
WeakMap lookup per call. The match is now computed on first read, and the
destination template is scanned for `$` once instead of twice.

Server `buildLocation` of `/items/$itemId` with params on a middleware-free
tree: 399 -> 382 ns per call (-4%). Builds that read the current match are
unchanged. react-router.minimal gzip +4 (86008 -> 86012, the stack base).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:08 +02:00
Manuel Schiller
92719bd586
perf(react-router): memoize Link and forward refs without an effect (#8405)
* perf(react-router): memoize Link and forward refs without an effect

When a layout re-renders on navigation, for instance because it reads
`useLocation`, every Link below it re-renders too. Profiling 200 mounted
Links showed that re-render dominated by React's per-hook update work, the
element creation and the anchor's prop diff, not by the Link's own logic.
A Link's output depends only on its props, the router context and the
location store, all of which React tracks for memoized components, so
`Link` is now wrapped in `React.memo`. Router options are compared by
value, because destinations are usually inline object literals; element
props are compared by reference, since they may hold arbitrary, even
cyclic, user data. The comparator reuses `ROUTER_OPTION_KEYS`.

The memo adds one fiber per Link. To pay for it, `useForwardedRef` goes:
its `useImperativeHandle` was the only layout effect on a Link and ran for
every Link although most never receive a ref. The link keeps a plain
`useRef`; when a ref is forwarded, one callback fills both. The hook had no
other consumer. `enqueuePreload` no longer doubles as the cleanup path: the
preload effect cancels the intent timer directly.

Measurements (macOS arm64, Node 24.8.0, local, against the previous commit):
- Link client paired runner, 200 Links under a re-rendering layout
  (3 repeats): shared-params CPU -54%, masks -56%, rewrites -60%; links
  whose props can never compare equal (updater functions, inline
  `activeProps` functions) param-updaters +2.5% [-5.2, 10.9],
  location-updaters -1.0%, active -2.0%, all inconclusive.
- retained heap per mounted app 2782 -> 2738 KB; mount unchanged within
  noise (the memo fiber and the removed layout effect cancel out).
- react-router.minimal gzip 85968 -> 86008 (+40); the branch stays 4 bytes
  under the stack base.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix(react-router): memoize the Link's merged ref callback

The merged ref that fills a forwarded ref alongside the link's own ref was
an inline closure, so every Link render produced a new callback and React
detached and re-attached it: a consumer's callback ref was called with
`null` and then the element again on each location-driven re-render
(3 calls after one navigation instead of 1), and an object ref was cleared
and refilled inside the commit. `useImperativeHandle(ref, ..., [])` on main
only re-ran when the consumer's ref changed.

The callback is now memoized with `useCallback` on the forwarded ref, which
restores that contract: the consumer is notified on mount, when their ref
changes and on unmount. A cleanup returned by a consumer callback is still
passed through to React. Nothing reads `innerRef.current` after a detach
without a re-attach, so the wrapper that would clear it on cleanup is left
out (+19 gzip for no observable behavior).

`areLinkPropsEqual` keeps the same rule but states it in two steps, since
the nested condition read as if `children` were deep-compared: element
props (`children`, handlers, `style`, ...) only match by reference, and
only router options fall through to `deepEqual`.

Tests pin all three: a stable callback ref stays at one call across a
location change and is released when swapped, a returned cleanup runs on
unmount instead of a `null` call, and a new JSX child or a cyclic element
prop re-renders the Link instead of being compared deeply. The ref test
fails on the previous commit with `expected 1 call, got 3`.

Measurements (local: macOS arm64, Node 24.8.0, production React 19.2.3):

- `react-router.minimal` gzip 86008 -> 86004 (-4). The comparator
  restructure alone is -2; `useCallback` without the cleanup wrapper is
  neutral, the wrapper would have been +19.
- Mount of the 200-Link benchmark app, medians of 60 runs: 4.97 ms with
  `useImperativeHandle` (main's mechanism on top of this branch), 4.71 ms
  with the inline callback, 4.69 ms memoized. Retained heap per mounted app:
  -23 KB against `useImperativeHandle` (its layout effect keeps an effect
  node, a bound function and two deps arrays per fiber pair).
- Paired client runner, 3 repeats, memoized vs `useImperativeHandle`: 12/13
  workloads inconclusive, `rewrites` -4.6% [-9.0, -0.2]. Memoized vs the
  inline callback: +2.5% [1.4, 3.7] on `param-updaters` and +1.4% [0.4, 2.5]
  on `relative`, where every Link re-renders per navigation and pays the
  extra hook; the other 11 workloads are inconclusive.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:07 +02:00
Manuel Schiller
d740d8bf2d
perf(react-router): fewer hooks per Link (#8404)
A Link render ran about 25 hook slots. React allocates a hook object per
slot per render, plus a deps array for every memo, callback and effect, so
the slots set both the re-render cost and the retained fiber memory of a
mounted Link. Five of them did not need to exist:

- The three `useValueStable` refs for `search`, `params` and `activeOptions`
  become one `useStableValues` ref that replaces each entry only when its
  own contents change, so identities behave exactly as before.
- `_options` and its `dest` copy come out of one memo instead of two.
- `doPreload` is a module function, `preloadLink(router, options)`; the
  callback existed only to give the effects a stable identity.
- The IntersectionObserver effect and the render-preload effect merge into
  one preload effect whose cleanup also cancels a pending intent timer, as
  the observer hook's cleanup did. `useIntersectionObserver` had no other
  consumer and is removed.

`hasRenderFetched` stays: without it a link with an updater-function
`search` would preload on every render.

Measurements (macOS arm64, Node 24.8.0, local, 200 mounted Links):
- retained heap per mounted app 2949 -> 2782 KB (-6%, about -0.8 KB per Link)
- mount (router creation + first render) median 2.05 -> 1.90 ms
- Link client paired runner (4 repeats): shared-params CPU -3.0%
  [-5.3, -0.6], active -3.3% [-8.4, 2.1]
- react-router.minimal gzip 85984 -> 85968 (-16)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:07 +02:00
Manuel Schiller
f2ff324b7a
refactor(react-router): one key set and one assembly path for Link props (#8401)
The client and the server each kept their own copy of the 35 option names:
the client as an object-rest destructure, the server as a Set. The two
paths then assembled the result differently, with an eleven-spread external
return and a fourteen-entry literal on the client and a fill-in-place
sequence on the server.

Both now share two helpers. `collectElementProps` copies every option the
router does not consume, using one `ROUTER_OPTION_KEYS` set plus the two
host rules (`Link` hosts never render `type`, an anchor has no `disabled`).
`applyLinkState` finishes a router-controlled link: the selected state
props, then the routing attributes and the merged class and style. It is
the one place that defines precedence and absorbs `resolveStateProps`. The
client adds its composed handlers between the two; the server adds
nothing. External links return the collected props with `ref` and `href`.

Element props therefore pass through as given instead of being stripped
and re-added: external links forward them verbatim, falsy values included,
and `useLinkProps` returns `children` for router-controlled links as it
already did for external ones. Class and style are assigned only when the
link or its state props provide one, so links without them carry no
`undefined` keys and empty strings are still dropped.

Measurements (macOS arm64, Node 24.8.0, local, against the previous commit):
- react-router.minimal gzip 86019 -> 85984 (-35); -28 against the stack
  base, which this branch previously exceeded by 7.
- Link client paired runner (3 repeats): shared-params CPU -13.8%,
  unique-params -11.4%, middleware -8.6%, encoding -13.2%, active -16.9%,
  all "faster". A 35-key object rest costs about 440 ns per call, the key
  set copy about 50 ns.
- Link SSR paired runner (6 repeats): +0.4% to +1.5%, inside the runner's
  +/-4% noise floor measured head-against-head. SSR bundle 189850 -> 189523.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:07 +02:00
Manuel Schiller
b747fb8891
perf(router): keep the location cache client-only and slim Link SSR (#8390)
* perf(router): keep the location cache client-only and slim Link SSR

The per-options location cache from the location-reuse changes only ever
hits on the client: server renders never repeat an options object, yet
every server build still created the WeakMap, looked it up per build, and
Solid/Vue server Links stored an entry per render. All three sites are now
guarded by `!(isServer ?? this.isServer)`. `isServer` is a per-bundle
constant, so server bundles contain no cache at all (the Link SSR bundle
has zero references); client bundles keep it unchanged.

Rendering a React Link on the server copied its props four times: `Link`
split off `_asChild`, `useLinkProps` split the router options off with an
object rest, the result was assembled with spreads, and `Link` copied once
more to drop `type` and `disabled`. Profiling showed the object rest alone
was 85% of the hook's self time: V8 checks every key against the whole
35-entry exclusion list (about 470 ns per call versus 95 ns for a key-set
copy).

`useLinkProps` is now a wrapper over `useLinkPropsFor(options, ref, host)`.
`Link` passes its host (`'a'` or the `createLink` component), so the hook
omits `disabled` for anchors and `type` for both, and `Link` passes the
result straight to `createElement`. The server branch is a separate
`getServerLinkProps` referenced only inside the `isServer` check, so it and
its key set are dropped from client bundles; it reads the few options it
needs, splits element props with the key set, fills the props object in
place with the same precedence and attribute order as before, and no
longer runs `useForwardedRef` (moved after the server return). The client
keeps its rest destructure; the host handling costs a few bytes there,
mostly paid back by the folded router-core guards (numbers below).

`encodePathLikeUrl` tests with one merged character class
(`/[\s\u0080-\uFFFF]/`), which matches exactly the same code units as the
alternation it replaces and is about 10% cheaper.

Measurements (macOS arm64, Node 24.8.0, local):
- Link SSR paired runner (ABBA, 4 fresh processes per case) against the
  previous stack top: all 13 cases faster, CPU -19.5% to -40.3%.
- Link client paired runner: all 13 cases faster, CPU -4.6% to -9.2%.
- Start SSR request loop (benchmarks/ssr, react), interleaved builds:
  3.120 -> 2.890 ms per loop (-7.4%), 320.5 -> 346.1 hz.
- Client bundle react-router.minimal gzip: 86012 -> 86021 (+9; raw +7,
  brotli -22): the router-core guards fold to -12, the Link host handling
  costs +19. The Link SSR bundle shrinks from 197832 to 189989 bytes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* refactor(react-router): one state-prop precedence rule for every Link

Active and inactive state props overrode `ref` and the event handlers on
every link except a blocked one (a destination with a disallowed scheme),
where the forwarded ref and the router's handlers won. The exception dates
from the hardening change, whose test observed the then-general "router
wins" rule on a blocked link; when state props were later allowed to
override element props, blocked links were carved out to keep that test
green rather than by design. It bought no safety: `href`, `disabled` and
`target` are assigned after the state props in both orders, which is what
actually keeps a blocked destination inert. It did make the same
`inactiveProps` attach their `ref` and `onClick` on one inactive link and
silently drop them on another, and it differed from Solid's Link, which
applies one rule.

Blocked links now follow the same precedence as every other link: state
props override element props, `ref` and handlers; the routing attributes
always win. The server branch loses its if/else, the client loses the two
conditional spreads and the `blockedLink` flag. The blocked-link test now
pins the uniform rule together with the routing attributes it already
checked.

Measurements (macOS arm64, Node 24.8.0, local, against the previous commit):
- react-router.minimal gzip 86021 -> 86019 (-2), raw -38, brotli -33.
- Link client paired runner (3 repeats): shared-params CPU -11.6%
  [-15.1, -7.9], encoding -13.2% [-20.2, -5.7].
- Link SSR paired runner: within noise. SSR bundle 189989 -> 189850 bytes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:06 +02:00
Manuel Schiller
9448caa03a
perf(router-core): keep search middleware collection optimized (#8385)
CodSpeed's memory instrument flagged the interrupted-navigations client
benchmark on the location-reuse changes (react +14.6%, vue +29.8%, solid
+10.8% peak memory). Under its worker flags (`--no-opt --predictable`,
single threaded) that benchmark's peak is set by a synchronous Maglev
compile that happens inside the measured run.

`getSearchMiddlewares` is compiled during the preparation calls and then
deoptimized on the first property load off a route's options. Before,
its only caller was the small `applySearchMiddleware`, which Maglev
compiled next and inlined it into, so the callee never tiered up again.
Since `build` calls it directly and does not inline it, it became hot
again during the measured run, and its recompilation (about four 32 KB
zone segments) set the peak.

Iterating `destRoutes` with a counted loop instead of `for...of` keeps the
function optimized once compiled: no deoptimization and no recompilation
in the measured window. Middleware order and live route-option reads are
unchanged. Hoisting the option reads alone did not help.

Local reproduction with a malloc interposer, CodSpeed's worker flags and
seven preparation calls, macOS arm64 / Node 24.8.0 (deterministic peaks):
- react: 248880 (base) -> 287760 (+15.6%) -> 248944 with this change
- vue:   256704 -> 292656 (+14.0%) -> 256640
- solid: 287408 -> 288240 (+0.3%)  -> 287632
These are local native allocations, not a new Linux CodSpeed CI run.
Bundle (react-router.minimal gzip): +8.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:06 +02:00
Manuel Schiller
6cfb1e8b56
perf(router-core): stop structurally sharing search and state in buildLocation (#8382)
`buildLocation` ran `nullReplaceEqualDeep` over the built search and
`replaceEqualDeep` over the built state against the current location on
every build. That work only affected object identity, and nothing reads
that identity from a built location:

- Links select href and isActive from the built location; active state is
  computed by value and ignores history state.
- `commitLocation` already compares state by value (`deepEqual` over
  `_getUserHistoryState`), so pre-shared children were at most a shortcut.
- The identity consumers actually rely on (selecting `location.state.user`
  or a nested search value without rerendering) comes from `parseLocation`,
  which stabilizes the committed location against the previous one. That
  sharing stays untouched, as do the `matchRoutes` sites for search, params
  and loaderDeps.

On the server `replaceEqualDeep` was already a passthrough, so client and
server builds now produce the same shapes.

Behavior changes:

- A literal `search` or `state` is returned as the caller's object. It is
  never written to: `commitLocation` and history both copy before adding
  `__hashScrollIntoViewOptions`, `__TSR_key`, `key` and the index.
- Because `replaceEqualDeep` returned the *current* search when contents
  were equal, `buildLocation` used to re-serialize the current key order.
  At `?a=1&b=2`, `buildLocation({ search: { b: 2, a: 1 } })` produced
  `?a=1&b=2`, so navigating there was a same-location no-op. It now
  produces `?b=2&a=1` and pushes a new history entry.
- A destination without `search` yields the frozen `EMPTY_RECORD`
  instead of a fresh or shared object. Nothing downstream mutates the
  built search; all consumers copy.

The `usedCurrent` tracking is unchanged: only reads through `current()` /
`currentMatch()` mark a build as location-dependent, so literal search and
state keep hitting the per-options cache.

Tests: the build-time sharing assertion (`explicit state structurally
shares unchanged nested values`) is replaced by a describe block that pins
the new contract: built search/state are the caller's objects, equal nested
references are preserved after navigation via parseLocation, `navigate`
does not mutate a plain or frozen caller state, and the key-order case is
covered at both the buildLocation and the navigation level.

Measurements (react-router.minimal, this tree):
gzip 86026 -> 86004 (-22), initial -23, raw -41, brotli +65.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:05 +02:00
Manuel Schiller
465c85a734
fix(react-router): treat Link params and search as immutable inputs (#8380)
`useValueStable` kept a shallow copy of `params` / `search` /
`activeOptions` (dac2bf249f) so that an object mutated in place would
yield a new reference on the next render. That only ever held one level
deep: a nested change such as `search.filters.page = 2` left the shared
nested reference in the copy, `deepEqual` short-circuited on it, `dest`
kept its identity and `buildLocation` served the cached location.

Detecting mutation is not a contract React lets us keep. A mutation on its
own never renders anything; the tests that exercised it needed a manual
re-render button to observe the change, which is the same situation as a
mutated `React.memo` prop or `useMemo` dependency. Rather than snapshot
deeper (measured +63 gzip bytes on react-router.minimal and a 3-5x slower
compare whenever nested references are shared, since nothing can
short-circuit), `useValueStable` stores the caller's reference again, as
on main. The reference is the router's invalidation signal: pass a new
object to change a destination.

The regression test now pins the contract that can actually break: fresh
inline literals with equal nested contents must not trigger another
`buildLocation`, and a nested value that changes through React state must
produce a new href on that render and keep it across navigations. The
accessor and in-place mutation tests are removed along with the promise
in the changeset.

Bundle (react-router.minimal gzip): 86038 -> 86026 (-12).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:05 +02:00
Manuel Schiller
e9396c9289
perf(router): reuse location-independent Link destinations (#8370)
* perf(router-core): reuse location-independent Link destinations

Most mounted Links point at a destination that does not depend on where
the user currently is: an absolute `to`, literal params for every template
key, a literal (or no) search, hash and state. Until now every navigation
rebuilt all of them anyway, because `buildLocation` always started from the
current location.

`buildLocation` now tracks whether a build read the current location at
all. Every such read goes through `current()` / `currentMatch()`, which set
one flag; a build that finishes without it depends only on its options and
the route tree. When the caller passed `_fromLocation` (what Links do) and
no mask is involved, the resulting location is kept in a WeakMap keyed by
the options object, and the next `buildLocation` with that same object
returns it directly. `update()` and `setRoutes()` replace the map, so router
option changes and HMR route-tree rebuilds invalidate everything.

To make that flag meaningful the reads became demand-driven instead of
unconditional: an absolute `to` resolves without a base path, params that
cover the template skip the inherited-params merge, a literal search/hash/
state never touches the current values, and stringifiers fetch inherited
params only when a route defines one. Structural sharing with the current
search/state stays, as it only affects identity.

Contract: the same options object yields the same location until router
options or the route tree change. Callers own invalidation by passing a new
object when their values change (the follow-up react-router commit does
that with deepEqual-stabilized copies of `params`/`search`).

Once whole locations are reused, the per-route SIEVE pathname cache
(`_pathCache`, `InterpolationPlan`, `createPathInterpolator` and its router
plumbing) is redundant and is removed; templates are interpolated directly
from the route's parsed segments.

Tests: path, route-tree-caches, path-decoder and the interpolation bench
assert canonical pathnames through `buildLocation` instead of cache
internals.

Performance (Apple M4, Node 24, fresh production bundles, 3 runs each;
measured on a tree that also carried the replaceEqualDeep changes now
proposed separately in #8362, #8363 and #8364):

- Measured alone, with the React Link still spreading a fresh options
  object per navigation so nothing hits the cache: links/react 341.3 ->
  290 hz (-15%); paired link-perf client vs stack HEAD: encoding +30%,
  splats +24% slower (HEAD's pathname cache targeted exactly those), the
  other cases within noise. This commit is the first half of a two-part
  change and regresses on its own.
- With the follow-up react-router commit (stable options object, so 160 of
  161 builds per navigation become 13 ns cache hits; a full build costs
  680-970 ns): links/react 622 hz (+82% vs stack HEAD, rme +-0.4%).
  Paired link-perf client vs origin/main: shared-params -34%, unique-params
  -36%, splats -41%, encoding -54%, active -44%, middleware -14%,
  relative -9%. SSR vs origin/main: -12..-32% on every measured case
  (encoding -23%, splats -18%); vs stack HEAD only SSR encoding is slower
  (+31%).
- Bundle (react-router.minimal gzip, this tree): 85925 -> 85992 (+67) for
  this commit, 1 byte below origin/main (85993); 86038 with the Link commit.
  With #8362, #8363 and #8364 applied as well the tree measures 85983.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(react-router): keep one options object per Link so locations are reused

`buildLocation` now returns a cached location for an options object whose
previous build never read the current location (06e4504605). The React
Link built a fresh `{ _fromLocation, ..._options }` on every navigation, so
it never hit that cache.

Each Link now owns one `dest` object, memoized on `_options`. The location
selector sets `dest._fromLocation` in place (unless the caller supplied one)
and passes the same object to `router.buildLocation`, so a Link whose
destination does not depend on the current location costs a WeakMap lookup
per navigation instead of a full build. `navigate` and `preloadRoute` still
receive `_options`, so the in-place field never reaches a navigation.

Because object identity is now the router's invalidation signal,
`useValueStable` keeps a shallow copy of `params`/`search`/`activeOptions`
rather than the caller's object. `deepEqual` therefore never short-circuits
on reference equality, and a params object that was mutated in place, or is
backed by accessors, yields a new reference (hence a new `dest`) on the
render that observes the change. A mutation that no render observes is no
longer picked up by a navigation alone; that matches how every other Link
input already behaves.

The server branch had its own inline copy of the active-state, class and
style derivation while the client used `resolveIsActive`. Both now share
`resolveIsActive` and a `resolveStateProps` helper; the results are
identical (`exactPathTest` is the same trailing-slash comparison,
`deepEqual` already treats two key-less search objects as equal, and the
hash check yields `false` on the server because it is never hydrated
there). The two `blockedLink` spreads that position state props before or
after `ref`/handlers are documented in place.

Tests (`link-destination.test.tsx`): the middleware test follows the HMR
sequence (`route.update()` then `router.setRoutes(router.buildRouteTree())`)
instead of expecting a bare `route.update()` to be observed; the test for
an impure `stringifySearch` closing over a mutable variable is dropped
along with that contract; the mutation and accessor tests re-render the
fixture and assert the updated location survives further navigations.

Performance (Apple M4, Node 24, fresh production bundles, 3 runs each;
measured on a tree that also carried the replaceEqualDeep changes now
proposed separately in #8362, #8363 and #8364):

- links/react (200 mounted Links, 8 navigations per lap): 290 -> 622 hz
  against the parent commit, +82% against stack HEAD (341 hz). 160 of the
  161 `buildLocation` calls per navigation become 13 ns cache hits; a full
  build of these Links costs 680-970 ns.
- Paired link-perf client vs the parent commit: shared-params -24%,
  splats -35%, encoding -49%, active -36%, unique-params -25% (wide
  interval), middleware unchanged (never cacheable).
- Combined with the parent, vs origin/main: client shared-params -34%,
  unique-params -36%, splats -41%, encoding -54%, active -44%,
  middleware -14%, relative -9%; SSR -12..-32% on every measured case.
- Bundle (react-router.minimal gzip, this tree): 85992 -> 86038 (+46);
  +113 vs stack HEAD, +45 vs origin/main (85993). With #8362, #8363 and
  #8364 applied as well the tree measures 85983, 10 bytes below origin/main.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* refactor: stop exporting isPlainObject and isPlainArray

Nothing in the repository imports these two helpers from a package entry
point; they are only called inside `utils.ts` by `deepEqual` and
`replaceEqualDeep`, and `isPlainArray` is unit-tested via `../src/utils`.
#8363 tightens `isPlainObject` to a constructor check that is meant
for the router's own structural sharing, so the helpers are no longer
exported from `@tanstack/router-core`, `@tanstack/react-router`,
`@tanstack/solid-router` or `@tanstack/vue-router`.

No bundle change in react-router.minimal (unused exports were already
tree-shaken): 85983 before and after.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* chore: add changesets for Link location reuse and the removed helpers

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:05 +02:00
Manuel Schiller
634da9176e
perf(router-core): streamline route initialization (#8327)
* perf(router-core): reuse parsed route segments for interpolation

Capture original template segments during the existing route-tree parse.
Interpolation only substitutes current values and produces fresh metadata;
it never reparses known routes, including first use and trailing-slash
variants. Rebuild the captured data with the tree for HMR. Parse unknown
templates once per bounded entry and reuse their segments across decoder
changes. Update Devtools and internal test consumers.

Remove internal undefined-path/server-flag compatibility and the divergent
SSR scanner. Both runtimes follow the canonical splat grammar. Keep the
128-result route cache after measuring its removal rather than adding an
unproven configuration option.

Measured against 41e42009be with frozen production bundles:
- 26 client/SSR Link cases, 4 paired replicas each: client unique params
  -3.94% CPU [95% CI -6.30,-1.52], optionals -2.58% [-4.34,-0.78].
  Other cases inconclusive; no supported end-to-end slowdown.
- 1000-route client high-cardinality interpolation -18.55..-24.83%;
  matching with fresh metadata -14.69..-19.12% (5 process samples).
- 1000-route client setup costs an extra 0.084..0.192 ms; sparse first use
  costs about 0.23..0.28 us/call. Retained segment data adds about 200..298 B
  per dynamic route in the measured fixtures.
- All 18 bundle cases add 303..392 gzip B; React minimal/full +311/+326 B.
- Cache-off saves 0.8..0.9 MiB per 1000 used routes and 1.2..1.5 MiB after
  growth, but client encoding/splat Links regress 25.31%/12.71% and SSR
  encoding/splats regress 21.76%/25.37%; retain result caching.
- Shared-value sampled allocations rise 2.18% client/5.23% SSR without that
  cache. Native Vue peaks remain effectively unchanged (macOS captures,
  not a new Linux CodSpeed CI run). Benchmark counts/JIT/GC flags unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): avoid temporary route initialization joins

Build route IDs and full paths with direct string assembly and the existing
cleanPath normalizer. Avoid temporary filter/join arrays and the second ID
normalization. Pathless layouts keep the parent's fullPath unchanged.

Add a focused construction benchmark with fresh route objects and separate
processing-only / allocation-plus-processing cases at 100/1000/10000 routes.
Document why client-nav route-tree-scale is not a construction benchmark.

Standalone attribution against 41e42009be, otherwise unchanged Uint16Array
parser, 7 fresh process replicas and 1000 routes per tree:
- Client processRouteTree+route.init CPU improves 11.48-19.57% across
  static, dynamic, nested and mixed trees (all 95% intervals below zero).
- Server CPU improves 9.39-22.29% (all 95% intervals below zero).
- React Router minimal gzip +6 bytes; the composed parse-once implementation
  is measured separately against the required original bundle budget.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): reuse stable path parameter decoders

Compare allowed-character values rather than recompiling the decoder on
every provider-style options update. Equivalent arrays retain warm route
paths; in-place edits and option removal update encoding correctly.
Publish the configuration key only after successful compilation, and
declare optional state without forcing an unused instance field.

Isolated against 3e0b23f46c with the same path-decoder.bench.ts, seven
alternating independent process pairs (200 locations per batch):
- Stable provider updates: 143.3707 -> 122.5572 us, -14.52%
  (95% process interval -15.51% to -13.52%).
- No-update control: 119.1170 -> 118.8155 us, -0.25%
  (interval -1.05% to +0.55%).
- Deliberately changing configuration every batch: 143.8213 -> 147.7340 us,
  +2.72% (interval +1.38% to +4.08%). Reconfiguration remains the cold path.

These are decoder/update mechanism measurements, not a claim about every
React Link render. Standalone React minimal gzip: 86121 -> 86142 bytes
(+21); raw +48 bytes, Brotli +10 bytes.

Add coverage for equivalent options, mutation, removal, direct overrides
and retrying failed compilation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): simplify route-owned path interpolation

Share one canonical scanner between tree processing and unknown templates.
Retain compact dynamic records and derive original parameter names lazily,
instead of reconstructing them during matching. Keep initialization/indexing
and traversal in processRouteTree, including existing nested-mask behavior.

Make pathParamsAllowedCharacters initialization-only, as requested. Compile
the readonly decoder once, remove decoder keys/stamps/update invalidation,
and keep path results on each route. Preserve the shared bounded unmatched
template cache across SSR requests; lightweight matching stays router-local.
Do not add an encoding-specific cache, router-level route map or bulk clear.

Move Devtools-only navigation availability outside the hot formatter.
Preserve legacy standalone fallback match identity and cache behavior,
including inherited params and route-tree replacement. Retain useful encoding
comments and explicit tuple-slot labels.

Final measurements (Node 24.8.0, built production JS, unchanged workloads):
- Original React client-nav Link loop versus 41e42009be, four balanced
  fresh-process pairs: CPU 2.5015016 -> 2.4370936 ms per 8-navigation batch,
  -2.57% (95% process interval -3.72% to -1.42%). Wall -2.58%.
- Fresh 1000-route client processing/init: static -12.39%, dynamic -5.34%,
  nested -6.54%, mixed -2.59%. Server static -9.12%; remaining intervals
  are reported separately and the mixed-server result is inconclusive.
- All 18 gzip fixtures are below 41e by 47-88 bytes. React minimal:
  85801 -> 85731; full: 89392 -> 89318. Raw JS -533..-697 bytes;
  Brotli varies by fixture rather than uniformly shrinking.
- Full 26-case paired client/SSR Link suite: no supported regressions;
  most small changes are inconclusive, not claimed as universal speedups.
- Warm retained path-cache heap saves about 7.8 KiB per 1000 routes in
  default/custom configurations. Native Vue peaks remain near baseline;
  peak, allocation totals and end outstanding are measured separately.

Existing literal grammar/URL/matching expectations are preserved. The
independent oracle covers 49638 segment cases and 338 matching/mask traces
within the old offset range. Initialization-only encoding deliberately
supersedes the previous live-update contract.

Detailed measurements and rejected experiments remain in uncommitted
session reports and LOG.md.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): initialize routes directly during tree processing

Remove the optional initRoute callback and unconditionally call
route.init({ originalIndex: index }) at the start of the parent-first visit,
before indexing or parsing the route. Require init on this function's input
without imposing it on masks or the shared template-scanning RouteLike type.

Remove the Router and construction-benchmark forwarding wrappers. Adapt
preinitialized matcher fixtures through one test-only helper with a
non-enumerable no-op init; do not normalize their paths/IDs or change their
expected grammar/matching results. Add real-route initialization order,
index and exactly-once coverage.

Performance versus bc71b06207, seven independent process pairs per
shape/mode using the same built-JS entry and fresh route objects:
- Server static 1000-route processing/init: 0.7781686 -> 0.7623686 ms/tree,
  CPU -2.06% (95% interval -3.26% to -0.84%); wall -2.10%.
- Other construction cells are inconclusive, with no supported slowdown.
- All 18 gzip fixtures improve by 10-26 bytes. React minimal:
  85731 -> 85712 bytes (-19). Raw -20 bytes (-59 for Rsbuild);
  Brotli remains fixture-dependent.

Object creation and forced GC are outside processing timers. The common
measurement entry's obsolete third argument is ignored by the new code,
so once-per-tree callback allocation savings are not overstated.

Full measurements and logs remain in the session's
direct-route-init-20260909 artifacts and uncommitted LOG.md.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): pass route initialization indexes directly

Change the internal initializer to route.init(originalIndex). Update the
Route interface, BaseRoute implementation, processRouteTree contract and
both production call sites, including the standalone legacy fallback.
Remove object-literal arguments without adding compatibility wrappers.

Keep route ordering and stored indexes unchanged. Cover primitive arguments,
index zero and the large legacy fallback index explicitly.

Performance versus f2c2d55f99:
- Seven independent fresh-process construction comparisons per shape/mode
  (100, 1000 and 10000 routes; static/dynamic/nested/mixed) show no
  statistically supported timing difference. Do not claim an unproven
  CPU or heap-byte improvement from the removed object literals.
- All 18 gzip fixtures improve by 7-13 bytes. React minimal:
  85712 -> 85702 (-10); full: 89303 -> 89291 (-12).
- Raw JS decreases by 46 bytes in every fixture. Brotli varies.

The same production-JS phase entry and workloads are used on both sides.
Object creation and forced GC are outside processing timers. Detailed
samples, intervals and logs remain in numeric-route-init-20260909 session
artifacts and uncommitted LOG.md.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* update route trees

* ci: apply automated fixes

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-09-13 13:55:04 +02:00
Manuel Schiller
cb8749e9fc
perf(vue-router): remove redundant match fragment (#8326)
Remove the inner Fragment around scroll restoration while retaining the
outer Fragment, script/null condition and fresh shell-slot VNodes. Cover
child state across shell updates/invalidation and SSR script selectors/nonces.

Native malloc profiling on macOS arm64, Node 24.8.0, with the existing
CodSpeed flags, seven preparation calls and three fresh final captures:
- Interrupted peak after middleware split: 733736 -> 295024 bytes (-59.79%).
- Navigation peak after middleware split: 420776 -> 420896 (+120 bytes).
- Composed vs f2530bf453: interrupted -59.79%, navigation -19.32%,
  unique-location churn effectively unchanged (-0.016%).
These are local native measurements, not a Linux CodSpeed CI result.
Navigation end-of-region outstanding malloc increases 12472 bytes versus
the middleware-only control; this endpoint is before teardown, not retained
JS heap. Total allocated native bytes decrease.

Standalone Vue canonical Link CPU: 5.32037 -> 5.30865 ms/batch,
-0.22% [-4.04%, +3.75%], inconclusive across four isolated process pairs.
Incremental gzip: Vue Router minimal/full +1/+1 byte, Vue Start 0/-2.
All four Vue bundles remove 12 raw bytes; other 14 fixtures are identical.
No benchmark flags, workload counts, public APIs or features changed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:04 +02:00
Manuel Schiller
700a714c5f
perf(router-core): reduce navigation allocations (#8325)
* perf(router-core): cache canonical interpolated pathnames

Store the existing canonical decoder's pathname in the route interpolation cache so hits do not decode it again. Keep the standalone interpolation kernel, static/leaveParams paths, non-string fallbacks, cache capacities and decoder/template invalidation unchanged. Cover cold/hit href parity, reserved encodings and coercion fallback.

Against 3905181fd4, four balanced isolated-process pairs reduced encoded-destination client CPU 13.42% (95% CI -14.50% to -12.32%) and wall 13.32% (-14.44% to -12.19%). Shared params CPU improved 1.27% (-2.39% to -0.14%); unique/miss-heavy CPU +0.49% (-0.35% to +1.33%) was inconclusive. Four paired SSR repetitions improved encoded CPU 14.13% (-19.70% to -8.18%) and wall 14.17% (-19.83% to -8.12%).

React Router minimal/full gzip +4/+5 bytes to 85791/89378. Across all 18 fixtures gzip deltas range -7 to +16 bytes. The private microbenchmark now names its normalized-output contract; its changed-scope timings are not used for the speedup claims.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): reuse lightweight raw-param snapshots

getMatchedRoutes already copies cached raw params. Reuse that owned snapshot for lightweight parsing instead of allocating another dictionary. Preserve state-param reuse and matcher cache ownership. Cover mutating/throwing live parsers and add an opt-in cold-source location benchmark.

Against ac2ac45367, the same 256-build cold-location benchmark observed client means 0.3434 to 0.2987 ms for one param, 0.7437 to 0.4638 ms for eight, and 1.8625 to 1.1565 ms for 32. Before/after RMEs were 5.15/5.47%, 8.10/4.14%, and 2.37/2.97%. These are cold-mechanism results, not a 38% application speedup; small server cases were noisy and four paired application relative/numeric cases were inconclusive.

React Router minimal/full gzip decreases 6/9 bytes to 85786/89376; raw -35. All 18 fixture gzip deltas range -11 to +1 bytes. No public API, parser behavior or cache capacity changed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): reduce middleware compilation memory

Separate search middleware collection from recursive execution so Maglev
does not build one large compiler graph for both. Preserve live route-option
reads, ordering, validation, legacy filters and the empty-search fast path.
Cover middleware replacement/removal across a previously used route branch.

Native malloc profiling on macOS arm64, Node 24.8.0, using the existing
CodSpeed flags and seven preparation calls (three fresh processes):
- Vue navigation peak: mean 521664 -> 420776 bytes (-19.34%).
- Vue interrupted-navigation peak: 733736 -> 733736 bytes (unchanged).
These are local native allocations, not a new Linux CodSpeed CI run.

Four paired React Link replicas: relative client CPU -2.79%
[-4.37%, -1.18%]; shared/updater/middleware cases are inconclusive.
Isolated SSR CPU means range -1.63% to +1.28%, all inconclusive.
React Router minimal/full gzip: +15/+16 bytes; all 18 gzip deltas -6..+20.
Keep all benchmark JIT/GC flags and operation counts unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:04 +02:00
Manuel Schiller
6387d581ea
perf(react-router): reduce Link runtime allocations (#8324)
* perf(react-router): filter native Link props once

Omit type and disabled in one rest copy for native anchors instead of copying the hook result twice. Custom components still receive disabled, and useLinkProps still returns supported type/disabled values. Add client/SSR coverage for those distinctions, refs and render-function children.

Against 6e4584e0d8, four balanced fresh-process pairs with one implementation per process reduced client parameter-updater CPU from 15.61515 to 15.14615 ms per eight-navigation batch (-3.00%, 95% CI -4.19% to -1.80%); wall -3.04% (-4.29% to -1.78%). SSR shared-param CPU fell from 1.45208 to 1.41006 ms per four-request batch (-2.89%, CI -3.80% to -1.98%); wall -2.85% (-3.84% to -1.84%). Earlier co-loaded comparisons were inconclusive.

React Router minimal gzip -5 bytes to 85773; full +1 to 89358. Other React fixtures vary -3 to +4 bytes, raw +14; Solid/Vue remain byte-identical. No public API or prop functionality removed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(react-router): stabilize hydration snapshot getters

Reuse the existing true/false snapshot functions instead of allocating them on every useHydrated render. This lets React skip unnecessary store-instance passive bookkeeping without changing hydration values or adding hooks. Cover stable identities and an actual server-render/hydrateRoot transition.

Against b6971a434a, four balanced fresh-process pairs per case (200 warmup and 500 measured eight-navigation batches) reduced parameter-updater CPU from 15.16880 to 14.99436 ms (-1.15%, 95% CI -1.84% to -0.46%); wall -1.05% (-1.62% to -0.47%). Middleware CPU fell from 15.23708 to 14.81729 ms (-2.75%, CI -4.46% to -1.01%); wall -2.79% (-4.53% to -1.01%).

React Router minimal/full gzip increases 14/15 bytes for this isolated fix, remaining below the initial branch baseline. All Solid/Vue bundle output is unchanged. Public APIs, server snapshots and client hydration transitions are preserved.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:03 +02:00
Manuel Schiller
9a356d7505
test(benchmarks): profile unmodified React Link bundles (#8323)
Keep comparison snapshots in SWC's existing node_modules exclusion so emitted JavaScript is not retranspiled and source-map positions remain valid. Preserve asynchronous ESM loading and add a failing-before source-integrity regression.

Four-replica identical-bundle calibration: client shared-params CPU +0.92% [-4.14%, +6.24%], wall +1.03% [-4.55%, +6.93%]; SSR CPU +0.17% [-6.32%, +7.11%], wall +0.15% [-6.44%, +7.21%]. Intervals include zero; no speedup is claimed. Production code is unchanged; baseline React Router gzip is 85797/89379 bytes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:03 +02:00
Manuel Schiller
d76a33284b
perf(router-core): consolidate interpolation caches (#8321)
* refactor(router-core): consolidate path interpolation

Remove the object-returning internal wrapper and keep one interpolatePath returning a pathname with optional metadata outputs. Migrate router, devtools, tests, and benchmarks while leaving parsing and cache limits unchanged.

Devtools requests only missing-param status. Tests use direct expected paths and explicit metadata; cache benchmarks no longer carry obsolete factory compatibility dispatch.

React Router minimal/full gzip are 85829/89413 bytes (+5/+4 from 8a9f57e638, still 14/4 below measured main). Full units/types/exports and 76 browser cases pass; eight paired client/SSR workloads show no supported timing change.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): keep derived caches on routes

Store branches and interpolation plans directly on route objects. Use the already-resolved destination route, remove the fixed outer limit for registered templates, and retain128 results per route. Keep a bounded32-template fallback for arbitrary templates and masks.

Build/install route-tree indexes and string caches as one bundle for existing SSR reuse. Reinitialization clears ancestor branches; interpolation plans validate their exact template and decoder without unconditional resets. Loaded match data remains request-local.

Against29509b9b98, paired core buildLocation batches over64/256 templates use40-43% less CPU; four fresh server routers generating200 hrefs each use8-9% less. Reversed import order corroborates these scoped results. Four real client/SSR Link cases remain statistically inconclusive.

All18 bundle fixtures shrink19-37 gzip bytes versus the consolidation baseline. React Router minimal/full are85797/89379 bytes,46/38 below measured main. Tests cover SSR request cleanup, route reuse, decoder/trailing variants, reparenting, result bounds and fallback capacity.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test(router-core): add opt-in matching interpolation benchmarks

Cover client/server matching with cold and Link-primed route plans, nested params, high-cardinality misses, optional params, and splats. Gate all additional cases behind TSR_LINK_PERF=1.

Evaluate six matching-cache prototypes without retaining production changes. Eager variants regress repeated misses by24-64%. Read-through reuse improves warm matching microcases but adds65 gzip bytes; all26 application Link/SSR comparisons show no supported speedup, with one relative-Link slowdown. Real HTTP SSR ABBA means differ by only -0.41%, within observed variation.

Restore production and all18 bundle metrics exactly to ec05cc6bec. Preserve detailed measurements and rejected prototypes in session artifacts and uncommitted LOG.md.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:03 +02:00
Manuel Schiller
f151ab018e
perf(router-core): compact navigation parameter resolution (#8328)
Declare the native null-prototype target once for non-inheriting parameter modes. Preserve updater isolation, native copy counts, and literal-parameter merge behavior. Group parameter resolution with search middleware without changing Link or path interpolation logic.

Official current-branch bundles shrink in all 18 scenarios by 2-30 gzip bytes versus 9c7cab48c1. React Router minimal: 85778 -> 85748 (-30); full: 89386 -> 89384 (-2).

A matched-main preview against cf166d160e measures React Router minimal at 85805 versus main 85821 (-16), and full at 89385 versus main 89398 (-13). Eight of nine matched-main React fixtures meet main; Start+Query remains +25 bytes. Small Solid overages are retained as agreed.

Eight paired client/SSR cases with four independent replicas each detected no supported timing regression or improvement. Add coverage for fresh updater copies, null prototypes, inheritance, and clearing.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:02 +02:00
Manuel Schiller
873c830ccb
refactor(router-core): clarify segment interpolation (#8319)
Organize the generic interpolation loop into static, wildcard, and named-parameter behavior blocks. Keep one shared key lookup, one encoding step, and one prefix/value/suffix assembly. Name affix boundaries and keep optional/missing wildcard behavior local to its segment type.

Replace the self-clearing onMissing callback with an optional metadata result object. The public interpolatePath wrapper reuses its existing result object; pathname-only callers still allocate no metadata. Preserve one parameter read, the reusable parser buffer, absent optional cache keys, canonical and legacy splat metadata, and public return values. Fast-path empty splat strings before the URL-safe regex so sharing the encoding step does not penalize omitted values.

Final official gzip measurements versus 5017a72614:
- React minimal: 85771 -> 85769 (-2 bytes).
- React full: 89384 -> 89382 (-2 bytes).
- All 18 fixtures range from -4 to +8 bytes; no unrelated source changes compensate for interpolation cost.

Added mixed-type/affix metadata coverage and direct pathname-kernel benchmarks. Paired fixed-seed CPU measurements of the real parent/current modules show effectively flat required client pathname interpolation (+0.04%) and 0.37-4.14% lower time in the other sampled required/optional/splat/mixed/missing client/server combinations. These are focused kernel diagnostics, not a broad application speedup claim.

Preserve the experiments, rejected larger variants, full fixture metrics, and raw benchmark output in uncommitted LOG.md and session artifacts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:02 +02:00
Manuel Schiller
9b2adaf8c3
perf(router): optimize Link state props across frameworks (#8318)
* perf(router): compact Solid and Vue Link state props

Port the React Link bundle-size reductions to Solid and Vue: share exact/fuzzy pathname normalization, resolve only the selected active/inactive props, concatenate classes without temporary arrays, and avoid style allocation when neither source supplies styles. Vue forwards and visits one selected props object in both client and SSR paths.

Keep framework-specific behavior: Solid retains its default-styling fast path and base href/handler precedence; Vue retains state-prop overrides and zero-argument callbacks. Both keep style snapshots so mutable Solid stores and Vue proxies remain reactive, including additions to empty style objects. No public API or unrelated production code changes.

Official gzip measurements versus d4cc307869:
- Solid minimal: 34017 -> 33973 (-44 bytes).
- Solid full: 38973 -> 38930 (-43 bytes).
- Vue minimal: 50731 -> 50646 (-85 bytes).
- Vue full: 56484 -> 56395 (-89 bytes).
All nine Solid/Vue Router/Start fixtures shrink by 26-104 gzip bytes; all nine React fixtures remain byte-identical.

Independent hunk attribution: active pathname checks save 36/41 Solid and 37/34 Vue bytes. State-prop changes alone save 0/2 Solid and 46/53 Vue bytes. Combined gzip deltas are not additive.

Existing 200-Link/eight-navigation workloads were compared with frozen parent, props-only, and final bundles. Standalone wall-time runs were too variable for a speed claim. Interleaved fixed-seed checks, repeated with reversed module order, showed effectively flat rendering cost: Solid mean CPU -1.49% / +0.33%, Vue -0.23% / -0.29%; corresponding wall changes -1.81% / +0.50% and -0.12% / -0.33%. No incremental rendering speedup is claimed. Raw results and experiments remain in uncommitted LOG.md and session artifacts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix(router): honor Link state props and Vue class bindings

Apply selected active/inactive props after ordinary base props in Solid and React, including React server output. Preserve the dedicated class concatenation and style merge handling. Add client/server regressions for supported refs and event handlers; do not widen the state-prop API to router navigation options.

Keep Vue object and nested-array class values intact instead of interpolating them into strings. Compose base/state values with Vue-compatible arrays, retain omitted-class behavior, and clone props at VNode creation because Vue normalizes class values in place. This preserves cached bindings and later reactive class changes. Vue ordinary state-attribute precedence was already correct and is left unchanged.

The regressions were run on the pre-fix implementations and failed for the reported behaviors, then passed after the fixes. Full framework unit/type/lint/package and Chromium coverage passes. Bundle impact remains small: React/Solid raw bytes unchanged; Vue Router minimal/full are 14/10 gzip bytes smaller. Detailed red/green evidence and measurements are kept in uncommitted LOG.md and session artifacts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* fix(solid-router): preserve computed Link routing props

Restore the computed href, target, and disabled values after active/inactive state props. Keep state-prop ref/event overrides, class/style composition, and the default styling fast path unchanged for client and SSR rendering.

Reproduce the history/rewrite href failures and extend existing state-prop regressions to cover conflicting routing fields. Full validation passes 922 client tests (one skipped), 33 server tests, type/lint/export checks, and 24 Chromium cases.

The full bundle matrix adds 16/13 gzip bytes to Solid Router minimal/full and 13-17 bytes to Solid Start fixtures. React and Vue bundles are unchanged; no extra allocations or href recomputation are introduced.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:01 +02:00
Manuel Schiller
94f6c14f6b
test(router): add stable Link performance benchmarks (#8317)
* test(router): add opt-in React Link performance cases

Add 13 shared typed workloads measured through production client navigation and real SSR rendering: shared/unique params, updater functions, inheritance, relative targets, middleware chains, numeric parse/stringify, optional/splat segments, encoding, masks, rewrites, and active props with structured search and style merging.

Keep all 26 benchmarks outside the existing client-nav/SSR aggregate projects and CodSpeed build graph. The dedicated @benchmarks/react-link-performance targets require TSR_LINK_PERF=1 for discovery; disabled suites import no app. Gate tests cover explicit enablement and production environment selection.

Client batches perform eight navigations with 200 persistent measured Links. SSR batches create/load/render/dispose four fresh routers. Independent href, active-state, style, and history-state updater assertions run outside the measured loops. No production packages or dependencies change.

Compared identical sources on origin/main 28a5e4504e and captured HEAD bbaa7b3f29, with two fresh processes per ref/mode in counterbalanced order, 50 warm-up iterations, and 3-second windows. Full-suite results show lower HEAD client times for most cases (10.6% shared params, 13.2% search/hash/state updaters, 17.1% masks); SSR updater and optional cases show 14.8% and 12.4% reductions. These are whole-ref comparisons, not improvements from this benchmark-only commit.

Run-to-run noise is significant for small differences. Initial middleware and unique-param SSR slowdowns reversed in focused reruns, so they are not established regressions. Preserve both full-suite and focused data in the uncommitted experiment log and session artifacts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test(router): stabilize opt-in Link performance comparisons

Bound control navigation history with replace and assert that the measured anchors remain mounted. Share the exact setup, batch, and post-measurement assertions between normal Vitest benches and the paired comparison runner. Increase normal warm-up and measurement windows.

Add an opt-in stable runner with a fresh process per case/replica, separate router/app modules, one shared production React runtime, deterministic V8 random/hash seeds, alternating initialization order, and ABBA/BAAB fixed-work blocks. Record main-thread CPU, wall time, whole-process CPU, bundle hashes, and all raw blocks. Derive per-case 95% intervals from independent process replicas rather than correlated individual batches; require CPU and wall results to corroborate a direction.

Same-code controls exposed substantial noise in earlier methods. The selected control was centered near zero (client CPU -0.95%, SSR CPU -0.56%), with intervals still several percentage points wide. Keep unresolved measurements explicitly inconclusive instead of labeling them regressions.

Compared fixed runtime refs origin/main 28a5e4504e and bbaa7b3f29 across all 26 cases with four fresh-process replicas each: 16 cases support speedups, 10 remain inconclusive, and none support a slowdown in both metrics. Client middleware CPU: -5.95% [-13.89%, +2.73%]; SSR middleware: -16.06% [-31.65%, +3.09%]; SSR unique params: -5.08% [-14.97%, +5.96%]. These do not establish middleware or unique-param regressions.

No production package code or default CodSpeed workflow changes. Keep the complete raw matrix, calibration trials, snapshots, and detailed conclusions in uncommitted session artifacts and LOG.md.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:01 +02:00
Manuel Schiller
7e349c3071
perf(router): share Link pathname interpolation (#8252)
* perf(router-core): share pathname interpolation across Links

Reuse the existing segment parser to prepare parameter-name lists. Share pure interpolated path strings through bounded router-scoped SIEVE caches (32 templates, 128 paths per template). Avoid compound-key allocation for single-parameter templates and reuse the current template plan.

Parameter callbacks still run before interpolation. Search, hash, state, masks, rewrites, and active-state handling remain independent. Decoder changes clear the caches. No per-Link result cache, descriptor checks, new route matcher, or public API change.

React Link rendering benchmark, measured separately for this commit
and its parent using exact production builds:
- Workload: benchmarks/client-nav/scenarios/links/react/speed.bench.ts
  (200 persistent Links, eight navigations per measured batch).
- Apple M4, Node 24.20.0, Vitest 4.1.4, NODE_ENV=production.
- 8 fresh parent processes and 4 fresh processes for this commit,
  each with warmupIterations=50 and time=10000 ms;
  counterbalanced run order.
- Parent mean times (ms): 3.8767, 3.8900, 4.5507, 4.0116, 3.8297, 3.8582, 3.8879, 4.0157.
- This commit mean times (ms): 2.8824, 2.8625, 2.9597, 2.9673.
- Median run means: 3.8889 -> 2.9211 ms.
- Incremental effect: 24.89% less time; throughput change +33.13%.
- Largest within-run RME for this revision: 1.15%.

Incremental minimal/full React gzip impact: +251/+265 bytes.
Benchmark sources and commit implementation trees are unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* test(router-core): cover shared interpolation cache workloads

Cover missing optional parameters that become present, canonical splat keys, and the public usedParams shape. Add focused hit, eviction, and mixed-input benchmarks before simplifying cache metadata collection.

Current cache baseline on Node 24.20.0: repeated single-param batches average 0.0050 ms, repeated multi-param batches 0.0305 ms, result eviction 0.1568 ms, template eviction 0.0809 ms, and mixed inputs 0.0370 ms. Miss-heavy runs show outliers and require narrower comparisons. Production cache remains unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): reuse interpolation pass for cache keys

Collect cache parameter names during the existing interpolation pass instead of parsing each new template twice. Reuse the first interpolated result, compact template plans, and share required/optional/splat path assembly. Preserve public interpolation metadata, missing-param behavior, decoder invalidation, and bounded router-local caches.

Fresh existing React Link benchmark against parent cd4010d9cb, Apple M4 / Node 24.20.0 / Vitest 4.1.4 / production:
- 200 persistent Links and eight navigations per batch. Four separate processes per version, counterbalanced order, warmupIterations=50, time=10000 ms.
- Parent means: 3.0527, 2.8610, 2.8329, 2.8729 ms.
- This commit means: 3.1291, 2.8745, 2.8849, 2.8552 ms.
- Median run means: 2.8670 -> 2.8797 ms (+0.44% time, effectively flat; no incremental Link speedup claimed). Within-run RME below 1%.
- Fresh original-baseline comparisons: 4.2143 -> 2.9825 ms (-29.23%) and 4.0561 -> 2.9909 ms (-26.26%). The complete series still exceeds the original 20% target.

Focused interpolation benchmarks, same files/inputs before and after:
- Client uncached single-param batches: 90.51 -> 79.91 us (-11.7%).
- Client cached template eviction: 72.33 -> 49.74 us (-31.2%; 4-6% RME, p75 also improves).
- Client uncached mixed batches: 71.10 -> 52.41 us (-26.3%).
- Server uncached mixed batches: 61.42 -> 38.11 us (-38.0%).

Bundle size: React minimal/full -414 raw bytes each and -55/-68 gzip bytes. All 18 Router/Start fixtures shrink by 48-75 gzip bytes. Independent hunk attribution confirmed reductions for every retained group.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router): meet the original Link bundle budgets

Move the bounded pathname cache onto RouterCore and reuse one interpolation traversal for pathname generation, cache keys, and optional public metadata. Remove the factory and per-parameter metadata callbacks, preserve decoder invalidation and development server/client overrides, and simplify React Link active-state and state-prop assembly. Public APIs and routing features remain unchanged.

Official gzip measurements against parent 37bd31e4e2:
- React minimal: 86000 -> 85772 bytes (-228), equal to origin/main.
- React full: 89601 -> 89356 bytes (-245), 6 below origin/main.
- All 18 Router/Start fixtures shrink by 130-245 gzip bytes. Link remains included; fixtures and the existing Link workload are unchanged.
- Independent Link-only changes save 78/86 bytes; core-only changes save 174/169. Combined gzip effects are not additive.

Fresh existing production Link benchmark, Apple M4 / Node 24.20.0 / Vitest 4.1.4: 200 persistent Links, eight navigations per batch, 50 warm-up iterations and 10-second measurements, with separate processes in counterbalanced order.
- Parent means: 2.903316, 2.908833, 2.945163, 2.955386 ms.
- This commit means: 2.941129, 2.941699, 2.920172, 2.970072 ms.
- Median run means: 2.926998 -> 2.941414 ms (+0.49% time, near process-to-process noise; no incremental Link speedup claimed). Maximum within-run RME: 0.84%.
- Fresh original-baseline comparison: 4.283454 -> 3.016571 ms (-29.58% time). This is the whole-series improvement, not the incremental effect of this commit.

Identical focused before/after benchmarks show public helper regressions eliminated, server public families 4.68-12.85% faster, and cached mixed/missing cases 6.50-10.43% faster. Removing the redundant last-template shortcut makes isolated single-template cache hits slower (5.93 -> 7.21 us client per 200 calls; 5.99 -> 6.83 us server). The real Link workload remains effectively flat for this size-reduction step.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* perf(router-core): cache omitted optional path params

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-13 13:55:01 +02:00
Sarah Gerrard
ae68535929
perf(history): avoid generating unused location keys (#8349) 2026-09-12 13:19:37 -07:00
Flo
8fff7fa1f2
fix(history): normalize memory history hrefs (#8359) 2026-09-12 21:57:33 +02:00
Tanner Linsley
05422da535
docs(start): correct authentication server function examples (#8368)
* docs(start): correct authentication server function examples

* docs(start): prevent caching session-specific auth pages

* docs(start): guard login forms until hydration

* test(start): assert authentication behavior in SSR and SPA modes
2026-09-11 17:22:55 -06:00
Tanner Linsley
3487cf0451
docs(start): redirect obsolete Solid tutorial path (#8379) 2026-09-11 17:14:55 -06:00
Tanner Linsley
0b152a7b5e
docs(start): add production release checklist (#8373)
* docs(start): add production release checklist

* docs(start): clarify authenticated CSRF and cache checks
2026-09-11 17:14:04 -06:00