0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

6,689 commits

Author SHA1 Message Date
Manuel Schiller
ed3152af20
test: reproducer for #2547 (#7337) 2026-05-04 00:42:55 +02:00
Manuel Schiller
19f496bf6f
test: add reproducer for #2514 (#7336) 2026-05-04 00:35:10 +02:00
github-actions[bot]
15df770b56 ci: changeset release release-2026-05-03-1708 @tanstack/react-start-rsc@0.0.41 @tanstack/react-start-server@1.166.51 @tanstack/react-start@1.167.62 @tanstack/solid-start-server@1.166.50 @tanstack/solid-start@1.167.59 @tanstack/start-plugin-core@1.169.17 @tanstack/start-server-core@1.167.29 @tanstack/vue-start-server@1.166.46 @tanstack/vue-start@1.167.55 2026-05-03 17:08:04 +00:00
Zelys
afa40ef46c
fix(start-server-core): fall back to GET handler for HEAD requests (RFC 9110 §9.3.2) (#7325)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-05-03 18:54:24 +02:00
Sarah Gerrard
9902eb4c61
remove old intent artifacts (#7333) 2026-05-03 18:34:20 +02:00
Tanner Linsley
3526194849
docs(skills): address 8 agent failure modes from user feedback (#7314)
* docs(skills): address 8 agent failure modes from external feedback

Adds new start-core/auth-server-primitives skill (sessions, cookies,
OAuth+PKCE, password-reset enumeration defense, CSRF, rate limiting,
session rotation) and updates 8 existing skills + matching docs to fix
patterns where agents produce insecure or wrong-framework output.

Skill changes:
- new: start-core/auth-server-primitives (server half of auth)
- router-core/auth-and-guards: route guard != RPC guard
- start-core/server-functions: wrong import path, RPC auth required,
  Cache-Control public is a cross-tenant leak, wrong-framework patterns
- start-core/middleware: wrong import path, sendContext shape vs access
  (3-layer wrong/still-wrong/correct), authMiddleware framing
- start-core/execution-model: file markers (server-only/client-only),
  module-level process.env is undefined under Worker SSR
- start-core/deployment: cloudflare env-at-request-time
- router-core/ssr: wrong file structures (next.js, react-router-dom)
- router-core/type-safety: wrong-framework imports + structures

Docs updated to mirror each skill change so source-of-truth and the
intent-indexed skill stay in sync. New authentication-server-primitives
guide is the long-form companion to the new skill.

intent validate: 30 skill files pass (was 29).

* ci: apply automated fixes

* docs(skills): address coderabbit review feedback

- Fix internal docs links to use correct relative paths instead of an
  absolute /start/latest/... URL and missing one ../ segment
- Remove blank line inside auth-and-guards blockquote (markdownlint MD028)
- Restore overload pattern in type-safety ValidateNavigateOptions and
  ValidateRedirectOptions examples; the casts I had introduced stripped
  generic context and contradicted the skill's own no-cast rule
- Add db.sessions.revokeAllForUser before create in login rotation
  snippets so the example matches the prose
- Soften useServerFn guidance: it's required only when the server
  function throws redirect/notFound; plain-data calls work directly and
  via useMutation/useQuery

* ci: apply automated fixes

* docs(skills): compress type-safety to stay under 500-line cap

Prettier's autofix expanded my single-line overload signatures across
multiple lines, pushing the file over the 500-line limit. Drop the
redundant fetchOrRedirect example (same pattern as useDelayedNavigate)
and describe ValidateRedirectOptions usage in prose instead.

* docs(skills): CSRF origin check should compare full origin, not host alone

Comparing only new URL(origin).host against APP_HOST silently accepts a
mismatched scheme — http://example.com would pass a check meant for
https://example.com. Compare the full origin (scheme + host + port)
against APP_ORIGIN instead. Same fix in skill and docs.

* docs(skills): make useDelayedNavigate callback truly return void

The callback returned the result of setTimeout (a timer handle), not
void as the public overload's return type implied. Wrap in a block so
the example matches the declared return type.

Skipped the related nitpick to add a separate redirect example — the
existing prose already describes the same overload pattern, and a
duplicate example would push the file close to the 500-line cap that
prettier autofix has been bumping us against.

* docs(skills): fix two real bugs in auth-server-primitives examples

1. Cookie parser truncated values containing '='. Signed cookies, JWTs,
   and base64-padded values all use '='. Use indexOf to split on the
   FIRST '=' only.

2. Login example short-circuited verifyPasswordHash on user-not-found,
   contradicting the prose's "same time, same error" claim — the
   no-user branch returned instantly while wrong-password spent ~100ms
   hashing, leaking account existence over the wire. Always verify
   against a hash; use a precomputed DUMMY_PASSWORD_HASH when the user
   is missing, then combine with the user-exists bit for the final ok.

Same fixes in the SKILL.md and the docs companion.

* docs(skills): address manuel's review on react-specific guides

- middleware.md, server-functions.md: drop cross-framework <framework>
  placeholders; this is the React-specific guide, just say
  @tanstack/react-start
- execution-model.md: drop the same trailing line about solid-start /
  vue-start paths
- hosting.md: remove the Cloudflare env-handling subsection — the
  general per-request rule lives in environment-variables.md and
  doesn't need to be repeated under a specific host
- environment-variables.md: mention the cloudflare:workers env binding
  as the canonical Cloudflare way to read env (including module scope),
  per Manuel's link to the Cloudflare docs
- deployment skill: same upgrade — show the cloudflare:workers env
  pattern alongside the per-request handler approach

* docs(skills): drop redundant server-only marker in session example

The file already imports from @tanstack/react-start/server, which is
on import protection's default client-deny specifier list. The
side-effect marker is redundant — drop it. Same fix in skill and docs.

* docs(skills): drop wrong-import-path mistakes — TS already catches them

Manuel pointed out that TypeScript catches both common wrong paths:
'@tanstack/react-router' has no exported member createServerFn /
createMiddleware, and '@tanstack/start' is "Cannot find module". Skill
space is precious; the items don't earn their slot if tsc handles them.

Removed:
- Common Mistake "Wrong import path" from server-functions and
  middleware skills (renumbered the remaining mistakes)
- The matching top-of-file CRITICAL line in both skills
- The "Import path" callouts in the middleware and server-functions
  docs

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-05-02 23:11:30 -06:00
github-actions[bot]
b470b48111 ci: changeset release release-2026-05-02-2350 @tanstack/react-start-rsc@0.0.40 @tanstack/react-start-server@1.166.50 @tanstack/react-start@1.167.61 @tanstack/solid-start-server@1.166.49 @tanstack/solid-start@1.167.58 @tanstack/start-plugin-core@1.169.16 @tanstack/start-server-core@1.167.28 @tanstack/vue-start-server@1.166.45 @tanstack/vue-start@1.167.54 2026-05-02 23:50:32 +00:00
Manuel Schiller
709627f3db
feat: Link header (#7327)
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-05-03 01:25:30 +02:00
github-actions[bot]
e0fb8ec460 ci: changeset release release-2026-05-02-2139 @tanstack/react-start-rsc@0.0.39 @tanstack/react-start-server@1.166.49 @tanstack/react-start@1.167.60 @tanstack/solid-start-server@1.166.48 @tanstack/solid-start@1.167.57 @tanstack/start-plugin-core@1.169.15 @tanstack/start-server-core@1.167.27 @tanstack/vue-start-server@1.166.44 @tanstack/vue-start@1.167.53 2026-05-02 21:38:53 +00:00
Manuel Schiller
238ea4a499
feat: early hints (#7324) 2026-05-02 23:35:52 +02:00
dfedoryshchev
f08ef9db97
chore: fix duplicate "the" typo across router packages (#7323) 2026-05-02 16:38:17 +02:00
github-actions[bot]
1de2537bc1 ci: changeset release release-2026-05-02-1156 2026-05-02 11:56:01 +00:00
Manuel Schiller
5eb6911a20
Revise bug report template for clarity and requirements
Updated the bug report template to clarify the requirements for a reproducer project and modified some labels and descriptions for better clarity.
2026-05-02 13:54:40 +02:00
Tom Smithhisler
51029a0df9
fix(deps): move fetchdts from devDependencies to dependencies (#7317) 2026-05-02 08:10:18 +02:00
Abhishek Raj
d2e8c2aba2
docs: Improve key differences b/w Start Server Functions and Next.js Server Actions (#7312) 2026-05-02 00:16:31 +02:00
github-actions[bot]
12c50ed332 ci: changeset release release-2026-05-01-1910 @tanstack/react-start-rsc@0.0.38 @tanstack/react-start@1.167.59 @tanstack/router-plugin@1.167.32 @tanstack/router-vite-plugin@1.166.47 @tanstack/solid-start@1.167.56 @tanstack/start-plugin-core@1.169.14 @tanstack/vue-start@1.167.52 2026-05-01 19:09:44 +00:00
Manuel Schiller
96818b8ba5
fix(router-plugin): isolate route metadata per plugin instance (#7313) 2026-05-01 21:03:21 +02:00
github-actions[bot]
8b9ea22b5b ci: changeset release release-2026-05-01-1257 @tanstack/react-start-rsc@0.0.37 @tanstack/react-start@1.167.58 @tanstack/solid-start@1.167.55 @tanstack/start-plugin-core@1.169.13 @tanstack/vue-start@1.167.51 2026-05-01 12:56:49 +00:00
Manuel Schiller
ae453b7862
feat: rsc css (#7310)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-05-01 14:49:25 +02:00
github-actions[bot]
2c9f5c0e24 ci: changeset release release-2026-05-01-0007 @tanstack/react-router@1.169.1 @tanstack/react-start-client@1.166.47 @tanstack/react-start-rsc@0.0.36 @tanstack/react-start-server@1.166.48 @tanstack/react-start@1.167.57 @tanstack/router-cli@1.166.40 @tanstack/router-core@1.169.1 @tanstack/router-generator@1.166.39 @tanstack/router-plugin@1.167.31 @tanstack/router-vite-plugin@1.166.46 @tanstack/solid-router@1.169.1 @tanstack/solid-start-client@1.166.46 @tanstack/solid-start-server@1.166.47 @tanstack/solid-start@1.167.54 @tanstack/start-client-core@1.168.1 @tanstack/start-plugin-core@1.169.12 @tanstack/start-server-core@1.167.26 @tanstack/start-static-server-functions@1.166.40 @tanstack/start-storage-context@1.166.34 @tanstack/vue-router@1.169.1 @tanstack/vue-start-client@1.166.42 @tanstack/vue-start-server@1.166.43 @tanstack/vue-start@1.167.50 2026-05-01 00:07:18 +00:00
Manuel Schiller
4a1e63f1d1
fix: parse params union inference (#7306) 2026-05-01 02:04:12 +02:00
github-actions[bot]
e31f7aad49 ci: changeset release @tanstack/react-start-client@1.166.46 @tanstack/react-start-rsc@0.0.35 @tanstack/react-start-server@1.166.47 @tanstack/react-start@1.167.56 @tanstack/solid-start-client@1.166.45 @tanstack/solid-start-server@1.166.46 @tanstack/solid-start@1.167.53 @tanstack/start-client-core@1.168.0 @tanstack/start-plugin-core@1.169.11 @tanstack/start-server-core@1.167.25 @tanstack/start-static-server-functions@1.166.39 @tanstack/vue-start-client@1.166.41 @tanstack/vue-start-server@1.166.42 @tanstack/vue-start@1.167.49 release-2026-04-30-2158 2026-04-30 21:58:28 +00:00
Manuel Schiller
82b06132af
feat: strict: false for server functions (#7277)
* feat: `strict: false` for server functions

Add a `strict` option to `createServerFn` for type-level server function serialization checks

* feat: `strict: false` for server functions [Self-Healing CI Rerun]

---------

Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-04-30 23:52:08 +02:00
github-actions[bot]
cf5eb2f168 ci: changeset release @tanstack/react-start-rsc@0.0.34 @tanstack/react-start@1.167.55 @tanstack/solid-start@1.167.52 @tanstack/start-plugin-core@1.169.10 @tanstack/vue-start@1.167.48 release-2026-04-30-2046 2026-04-30 20:46:43 +00:00
Manuel Schiller
c4256c2c85
fix: Ignore fully type-only imports and re-exports when collecting im… (#7305)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-04-30 22:37:53 +02:00
github-actions[bot]
77b7d1002d ci: changeset release release-2026-04-30-2003 @tanstack/react-start-rsc@0.0.33 @tanstack/react-start@1.167.54 @tanstack/solid-start@1.167.51 @tanstack/start-plugin-core@1.169.9 @tanstack/vue-start@1.167.47 2026-04-30 20:03:22 +00:00
Franklin Shera
e8ef12b020
docs: remove redundant code example from query integration doc (#7298) 2026-04-30 21:50:39 +02:00
Dor Alagem
761fcc0c96
fix(start-plugin-core): sort server fn manifest entries for deterministic build output (#7287)
Co-authored-by: Dor Alagem <doralagem@MacBook-Pro-sl-Dor.local>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Manuel Schiller <meisterpink@gmail.com>
2026-04-30 21:46:30 +02:00
github-actions[bot]
dad0ec8f41 ci: changeset release release-2026-04-30-1752 @tanstack/react-router@1.169.0 @tanstack/react-start-client@1.166.45 @tanstack/react-start-rsc@0.0.32 @tanstack/react-start-server@1.166.46 @tanstack/react-start@1.167.53 @tanstack/router-cli@1.166.39 @tanstack/router-core@1.169.0 @tanstack/router-generator@1.166.38 @tanstack/router-plugin@1.167.30 @tanstack/router-vite-plugin@1.166.45 @tanstack/solid-router@1.169.0 @tanstack/solid-start-client@1.166.44 @tanstack/solid-start-server@1.166.45 @tanstack/solid-start@1.167.50 @tanstack/start-client-core@1.167.22 @tanstack/start-plugin-core@1.169.8 @tanstack/start-server-core@1.167.24 @tanstack/start-static-server-functions@1.166.38 @tanstack/start-storage-context@1.166.33 @tanstack/vue-router@1.169.0 @tanstack/vue-start-client@1.166.40 @tanstack/vue-start-server@1.166.41 @tanstack/vue-start@1.167.46 2026-04-30 17:51:48 +00:00
Manuel Schiller
c992495bf4
feat: match params (#7263) 2026-04-30 19:47:07 +02:00
Manuel Schiller
7fa0f39cab
fix: fix exports for react-start so useServerFn is available with RSC (#7292)
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
2026-04-29 22:22:15 +02:00
github-actions[bot]
a7300947bd ci: changeset release release-2026-04-29-2019 @tanstack/react-router@1.168.26 @tanstack/react-start-client@1.166.44 @tanstack/react-start-rsc@0.0.31 @tanstack/react-start-server@1.166.45 @tanstack/react-start@1.167.52 @tanstack/router-cli@1.166.38 @tanstack/router-core@1.168.18 @tanstack/router-generator@1.166.37 @tanstack/router-plugin@1.167.29 @tanstack/router-vite-plugin@1.166.44 @tanstack/solid-router@1.168.26 @tanstack/solid-start-client@1.166.43 @tanstack/solid-start-server@1.166.44 @tanstack/solid-start@1.167.49 @tanstack/start-client-core@1.167.21 @tanstack/start-plugin-core@1.169.7 @tanstack/start-server-core@1.167.23 @tanstack/start-static-server-functions@1.166.37 @tanstack/start-storage-context@1.166.32 @tanstack/vue-router@1.168.22 @tanstack/vue-start-client@1.166.39 @tanstack/vue-start-server@1.166.40 @tanstack/vue-start@1.167.45 2026-04-29 20:18:33 +00:00
Manuel Schiller
b5c4183ab8
fix: disabled topLevelVar (#7293)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-04-29 22:15:40 +02:00
github-actions[bot]
d406d1a450 ci: changeset release release-2026-04-29-1601 @tanstack/react-start-rsc@0.0.30 @tanstack/react-start@1.167.51 2026-04-29 16:00:53 +00:00
Keven Arroyo
d6decca418
fix(react-start-rsc): re-export renderable types from public entries (#7278)
* fix(react-start-rsc): re-export renderable types from public entries

* changeset - patch
2026-04-28 20:58:05 +02:00
Birk Skyum
b0024d6310
Revert "fix(solid-router): enable route component HMR for Solid"
This reverts commit b86b061253.
2026-04-27 21:18:08 +02:00
Birk Skyum
8eb951bf7a
Revert "ci: apply automated fixes"
This reverts commit 7122f28bab.
2026-04-27 21:18:03 +02:00
autofix-ci[bot]
7122f28bab
ci: apply automated fixes 2026-04-27 18:50:03 +00:00
Birk Skyum
b86b061253
fix(solid-router): enable route component HMR for Solid 2026-04-27 20:47:27 +02:00
github-actions[bot]
1285422916 ci: changeset release release-2026-04-27-0758 @tanstack/react-router@1.168.25 @tanstack/react-start-client@1.166.43 @tanstack/react-start-rsc@0.0.29 @tanstack/react-start-server@1.166.44 @tanstack/react-start@1.167.50 @tanstack/router-cli@1.166.37 @tanstack/router-core@1.168.17 @tanstack/router-generator@1.166.36 @tanstack/router-plugin@1.167.28 @tanstack/router-vite-plugin@1.166.43 @tanstack/solid-router@1.168.25 @tanstack/solid-start-client@1.166.42 @tanstack/solid-start-server@1.166.43 @tanstack/solid-start@1.167.48 @tanstack/start-client-core@1.167.20 @tanstack/start-plugin-core@1.169.6 @tanstack/start-server-core@1.167.22 @tanstack/start-static-server-functions@1.166.36 @tanstack/start-storage-context@1.166.31 @tanstack/vue-router@1.168.21 @tanstack/vue-start-client@1.166.38 @tanstack/vue-start-server@1.166.39 @tanstack/vue-start@1.167.44 2026-04-27 07:57:51 +00:00
Flo
493148bc53
fix(router-core): wildcard nodes respect DFS priority like other nodes in route matching (#7273) 2026-04-27 09:55:20 +02:00
github-actions[bot]
de980342a6 ci: changeset release @tanstack/solid-router@1.168.24 @tanstack/solid-start-client@1.166.41 @tanstack/solid-start-server@1.166.42 @tanstack/solid-start@1.167.47 release-2026-04-26-0258 2026-04-26 02:58:14 +00:00
Pavan Shinde
b515cbe1fe
docs(router): fix typo in doc (#7268) 2026-04-26 04:45:16 +02:00
Copilot
944b155896
fix(solid-router): hydration mismatch for ssr='data-only' with pendingComponent (#7266) 2026-04-26 04:43:09 +02:00
github-actions[bot]
65874cd48a ci: changeset release @tanstack/solid-start@1.167.46 release-2026-04-26-0214 2026-04-26 02:13:53 +00:00
Birk Skyum
aebf426476
fix(solid-start): bundle solid-query packages during SSR to fix duplicate QueryClientContext (#6151) (#7267) 2026-04-26 04:07:56 +02:00
github-actions[bot]
e085a0a6bd ci: changeset release release-2026-04-25-2303 @tanstack/solid-start-client@1.166.40 @tanstack/solid-start-server@1.166.41 @tanstack/solid-router@1.168.23 @tanstack/solid-start@1.167.45 2026-04-25 23:03:39 +00:00
Brenley Dueck
e054474cd1
fix: streaming when using Await component (#7264) 2026-04-26 01:00:37 +02:00
Brenley Dueck
41e37f8a9c
fix: use loader data goes undefined (#7265) 2026-04-25 23:36:25 +02:00
github-actions[bot]
2231d53f09 ci: changeset release release-2026-04-25-2039 @tanstack/react-router-ssr-query@1.166.12 @tanstack/router-ssr-query-core@1.168.0 @tanstack/solid-router-ssr-query@1.166.12 @tanstack/vue-router-ssr-query@1.166.12 2026-04-25 20:39:25 +00:00