From 77a5e7f515517050c1ace774912f4073a98dd906 Mon Sep 17 00:00:00 2001 From: Sheraff Date: Sat, 5 Sep 2026 22:36:43 +0200 Subject: [PATCH 1/4] ci: allow memory-only benchmark experiments --- .github/workflows/client-nav-benchmarks.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/client-nav-benchmarks.yml b/.github/workflows/client-nav-benchmarks.yml index 7eedc222ae..5cb261687f 100644 --- a/.github/workflows/client-nav-benchmarks.yml +++ b/.github/workflows/client-nav-benchmarks.yml @@ -20,6 +20,11 @@ on: - 'packages/**' - 'benchmarks/**' workflow_dispatch: + inputs: + memory-only: + description: Run only the memory benchmarks + type: boolean + default: false concurrency: group: client-nav-benchmarks-${{ github.ref }} @@ -45,11 +50,7 @@ jobs: - react - solid - vue - benchmark: - - client-nav - - ssr - - memory-server - - memory-client + benchmark: ${{ fromJSON(inputs.memory-only && '["memory-server", "memory-client"]' || '["client-nav", "ssr", "memory-server", "memory-client"]') }} include: - benchmark: client-nav mode: simulation From 116a8bf8528edb9ade41f544f7d4427a2ad9bc6e Mon Sep 17 00:00:00 2001 From: Sheraff Date: Sat, 5 Sep 2026 22:42:34 +0200 Subject: [PATCH 2/4] test: apply Node compiler and GC corrections to memory workers --- .github/workflows/client-nav-benchmarks.yml | 11 +--- .../react/vite.config.ts | 2 + .../solid/vite.config.ts | 2 + .../vue/vite.config.ts | 2 + .../react/vite.config.ts | 2 + .../solid/vite.config.ts | 2 + .../loader-data-retention/vue/vite.config.ts | 2 + .../mount-unmount/react/vite.config.ts | 2 + .../mount-unmount/solid/vite.config.ts | 2 + .../mount-unmount/vue/vite.config.ts | 2 + .../navigation-churn/react/vite.config.ts | 2 + .../navigation-churn/solid/vite.config.ts | 2 + .../navigation-churn/vue/vite.config.ts | 2 + .../preload-churn/react/vite.config.ts | 2 + .../preload-churn/solid/vite.config.ts | 2 + .../preload-churn/vue/vite.config.ts | 2 + .../react/vite.config.ts | 2 + .../solid/vite.config.ts | 2 + .../unique-location-churn/vue/vite.config.ts | 2 + benchmarks/memory/runtime.ts | 13 ++++ benchmarks/memory/server/package.json | 18 +++++- benchmarks/memory/server/runtime.test.ts | 62 +++++++++++++++++++ .../aborted-requests/react/vite.config.ts | 2 + .../aborted-requests/solid/vite.config.ts | 2 + .../aborted-requests/vue/vite.config.ts | 2 + .../error-paths/react/vite.config.ts | 2 + .../error-paths/solid/vite.config.ts | 2 + .../scenarios/error-paths/vue/vite.config.ts | 2 + .../peak-large-page/react/vite.config.ts | 2 + .../peak-large-page/solid/vite.config.ts | 2 + .../peak-large-page/vue/vite.config.ts | 2 + .../request-churn/react/vite.config.ts | 2 + .../request-churn/solid/vite.config.ts | 2 + .../request-churn/vue/vite.config.ts | 2 + .../react/vite.config.ts | 2 + .../solid/vite.config.ts | 2 + .../serialization-payload/vue/vite.config.ts | 2 + .../server-fn-churn/react/vite.config.ts | 2 + .../server-fn-churn/solid/vite.config.ts | 2 + .../server-fn-churn/vue/vite.config.ts | 2 + .../streaming-peak/react/vite.config.ts | 2 + .../streaming-peak/solid/vite.config.ts | 2 + .../streaming-peak/vue/vite.config.ts | 2 + benchmarks/memory/server/tsconfig.json | 7 ++- .../memory/server/vitest.unit.config.ts | 9 +++ benchmarks/memory/tsconfig.json | 7 +++ 46 files changed, 193 insertions(+), 12 deletions(-) create mode 100644 benchmarks/memory/runtime.ts create mode 100644 benchmarks/memory/server/runtime.test.ts create mode 100644 benchmarks/memory/server/vitest.unit.config.ts create mode 100644 benchmarks/memory/tsconfig.json diff --git a/.github/workflows/client-nav-benchmarks.yml b/.github/workflows/client-nav-benchmarks.yml index 5cb261687f..2045a91a0b 100644 --- a/.github/workflows/client-nav-benchmarks.yml +++ b/.github/workflows/client-nav-benchmarks.yml @@ -51,15 +51,6 @@ jobs: - solid - vue benchmark: ${{ fromJSON(inputs.memory-only && '["memory-server", "memory-client"]' || '["client-nav", "ssr", "memory-server", "memory-client"]') }} - include: - - benchmark: client-nav - mode: simulation - - benchmark: ssr - mode: simulation - - benchmark: memory-server - mode: memory - - benchmark: memory-client - mode: memory runs-on: ubuntu-latest steps: - name: Checkout @@ -81,7 +72,7 @@ jobs: uses: CodSpeedHQ/action@4296e51e7041e24dadb86d1d6e8b9320d223dbe8 # v5.0.3 timeout-minutes: 20 with: - mode: ${{ matrix.mode }} + mode: ${{ startsWith(matrix.benchmark, 'memory-') && 'memory' || 'simulation' }} run: >- WITH_INSTRUMENTATION=1 pnpm nx run diff --git a/benchmarks/memory/client/scenarios/interrupted-navigations/react/vite.config.ts b/benchmarks/memory/client/scenarios/interrupted-navigations/react/vite.config.ts index 048a9cc833..5910981796 100644 --- a/benchmarks/memory/client/scenarios/interrupted-navigations/react/vite.config.ts +++ b/benchmarks/memory/client/scenarios/interrupted-navigations/react/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client interrupted-navigations (react)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/interrupted-navigations/solid/vite.config.ts b/benchmarks/memory/client/scenarios/interrupted-navigations/solid/vite.config.ts index e710e0fd12..fbdfe6b8ea 100644 --- a/benchmarks/memory/client/scenarios/interrupted-navigations/solid/vite.config.ts +++ b/benchmarks/memory/client/scenarios/interrupted-navigations/solid/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client interrupted-navigations (solid)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/interrupted-navigations/vue/vite.config.ts b/benchmarks/memory/client/scenarios/interrupted-navigations/vue/vite.config.ts index b2912ce9d1..a9814eace8 100644 --- a/benchmarks/memory/client/scenarios/interrupted-navigations/vue/vite.config.ts +++ b/benchmarks/memory/client/scenarios/interrupted-navigations/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import vue from '@vitejs/plugin-vue' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -28,6 +29,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client interrupted-navigations (vue)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/loader-data-retention/react/vite.config.ts b/benchmarks/memory/client/scenarios/loader-data-retention/react/vite.config.ts index 555e5f5612..e0e31c1fca 100644 --- a/benchmarks/memory/client/scenarios/loader-data-retention/react/vite.config.ts +++ b/benchmarks/memory/client/scenarios/loader-data-retention/react/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client loader-data-retention (react)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/loader-data-retention/solid/vite.config.ts b/benchmarks/memory/client/scenarios/loader-data-retention/solid/vite.config.ts index 58d6b77acc..4011ff34ce 100644 --- a/benchmarks/memory/client/scenarios/loader-data-retention/solid/vite.config.ts +++ b/benchmarks/memory/client/scenarios/loader-data-retention/solid/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client loader-data-retention (solid)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/loader-data-retention/vue/vite.config.ts b/benchmarks/memory/client/scenarios/loader-data-retention/vue/vite.config.ts index bbf2fd02d8..97c5bd726b 100644 --- a/benchmarks/memory/client/scenarios/loader-data-retention/vue/vite.config.ts +++ b/benchmarks/memory/client/scenarios/loader-data-retention/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import vue from '@vitejs/plugin-vue' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -28,6 +29,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client loader-data-retention (vue)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/mount-unmount/react/vite.config.ts b/benchmarks/memory/client/scenarios/mount-unmount/react/vite.config.ts index bb0f3c2e0a..020d1115c5 100644 --- a/benchmarks/memory/client/scenarios/mount-unmount/react/vite.config.ts +++ b/benchmarks/memory/client/scenarios/mount-unmount/react/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client mount-unmount (react)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/mount-unmount/solid/vite.config.ts b/benchmarks/memory/client/scenarios/mount-unmount/solid/vite.config.ts index 5f0ab26252..94774af226 100644 --- a/benchmarks/memory/client/scenarios/mount-unmount/solid/vite.config.ts +++ b/benchmarks/memory/client/scenarios/mount-unmount/solid/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client mount-unmount (solid)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/mount-unmount/vue/vite.config.ts b/benchmarks/memory/client/scenarios/mount-unmount/vue/vite.config.ts index 0f7573a408..d5ac1a6793 100644 --- a/benchmarks/memory/client/scenarios/mount-unmount/vue/vite.config.ts +++ b/benchmarks/memory/client/scenarios/mount-unmount/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import vue from '@vitejs/plugin-vue' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -28,6 +29,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client mount-unmount (vue)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/navigation-churn/react/vite.config.ts b/benchmarks/memory/client/scenarios/navigation-churn/react/vite.config.ts index b05b999297..d2881ea8ac 100644 --- a/benchmarks/memory/client/scenarios/navigation-churn/react/vite.config.ts +++ b/benchmarks/memory/client/scenarios/navigation-churn/react/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client navigation-churn (react)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/navigation-churn/solid/vite.config.ts b/benchmarks/memory/client/scenarios/navigation-churn/solid/vite.config.ts index 6b6735891a..32b6b7b583 100644 --- a/benchmarks/memory/client/scenarios/navigation-churn/solid/vite.config.ts +++ b/benchmarks/memory/client/scenarios/navigation-churn/solid/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client navigation-churn (solid)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/navigation-churn/vue/vite.config.ts b/benchmarks/memory/client/scenarios/navigation-churn/vue/vite.config.ts index d26ce23d07..defc633ff4 100644 --- a/benchmarks/memory/client/scenarios/navigation-churn/vue/vite.config.ts +++ b/benchmarks/memory/client/scenarios/navigation-churn/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import vue from '@vitejs/plugin-vue' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -28,6 +29,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client navigation-churn (vue)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/preload-churn/react/vite.config.ts b/benchmarks/memory/client/scenarios/preload-churn/react/vite.config.ts index f9c426656b..0d792a669a 100644 --- a/benchmarks/memory/client/scenarios/preload-churn/react/vite.config.ts +++ b/benchmarks/memory/client/scenarios/preload-churn/react/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client preload-churn (react)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/preload-churn/solid/vite.config.ts b/benchmarks/memory/client/scenarios/preload-churn/solid/vite.config.ts index c86a6fcbb3..23fa994bd9 100644 --- a/benchmarks/memory/client/scenarios/preload-churn/solid/vite.config.ts +++ b/benchmarks/memory/client/scenarios/preload-churn/solid/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client preload-churn (solid)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/preload-churn/vue/vite.config.ts b/benchmarks/memory/client/scenarios/preload-churn/vue/vite.config.ts index ea7ed7b695..a2d39c12de 100644 --- a/benchmarks/memory/client/scenarios/preload-churn/vue/vite.config.ts +++ b/benchmarks/memory/client/scenarios/preload-churn/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import vue from '@vitejs/plugin-vue' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -28,6 +29,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client preload-churn (vue)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/unique-location-churn/react/vite.config.ts b/benchmarks/memory/client/scenarios/unique-location-churn/react/vite.config.ts index f424c57cef..4d6359c2ab 100644 --- a/benchmarks/memory/client/scenarios/unique-location-churn/react/vite.config.ts +++ b/benchmarks/memory/client/scenarios/unique-location-churn/react/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client unique-location-churn (react)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/unique-location-churn/solid/vite.config.ts b/benchmarks/memory/client/scenarios/unique-location-churn/solid/vite.config.ts index d4acf0019a..58abb71a63 100644 --- a/benchmarks/memory/client/scenarios/unique-location-churn/solid/vite.config.ts +++ b/benchmarks/memory/client/scenarios/unique-location-churn/solid/vite.config.ts @@ -2,6 +2,7 @@ import { fileURLToPath } from 'node:url' import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -26,6 +27,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client unique-location-churn (solid)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/client/scenarios/unique-location-churn/vue/vite.config.ts b/benchmarks/memory/client/scenarios/unique-location-churn/vue/vite.config.ts index 423126019b..edcfd3fa10 100644 --- a/benchmarks/memory/client/scenarios/unique-location-churn/vue/vite.config.ts +++ b/benchmarks/memory/client/scenarios/unique-location-churn/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import vue from '@vitejs/plugin-vue' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -28,6 +29,7 @@ export default defineConfig({ }, }, test: { + execArgv: memoryExecArgv(), name: '@benchmarks/memory-client unique-location-churn (vue)', watch: false, environment: 'jsdom', diff --git a/benchmarks/memory/runtime.ts b/benchmarks/memory/runtime.ts new file mode 100644 index 0000000000..922e59e669 --- /dev/null +++ b/benchmarks/memory/runtime.ts @@ -0,0 +1,13 @@ +/** Worker settings for the CodSpeed memory instrument. */ +export function memoryExecArgv() { + if ( + process.env.CODSPEED_ENV === undefined || + process.env.CODSPEED_RUNNER_MODE !== 'memory' + ) { + return [] + } + + // Node 24 still enables Maglev under CodSpeed's --no-opt. Compile baseline + // code eagerly and keep minor GC tied to allocations instead of tasks. + return ['--no-maglev', '--always-sparkplug', '--no-minor-gc-task'] +} diff --git a/benchmarks/memory/server/package.json b/benchmarks/memory/server/package.json index 423dde0eb3..b3774a2778 100644 --- a/benchmarks/memory/server/package.json +++ b/benchmarks/memory/server/package.json @@ -237,7 +237,7 @@ } }, "test:types": { - "executor": "nx:noop", + "executor": "nx:run-commands", "dependsOn": [ { "projects": [ @@ -265,6 +265,22 @@ ], "target": "test:types:ssr" } + ], + "options": { + "command": "tsc -p ./tsconfig.json --noEmit", + "cwd": "benchmarks/memory/server" + } + }, + "test:unit": { + "executor": "nx:run-commands", + "options": { + "command": "vitest run --config ./vitest.unit.config.ts", + "cwd": "benchmarks/memory/server" + }, + "inputs": [ + "default", + "^production", + "{workspaceRoot}/benchmarks/memory/runtime.ts" ] } } diff --git a/benchmarks/memory/server/runtime.test.ts b/benchmarks/memory/server/runtime.test.ts new file mode 100644 index 0000000000..d4bcccd745 --- /dev/null +++ b/benchmarks/memory/server/runtime.test.ts @@ -0,0 +1,62 @@ +import { execFileSync } from 'node:child_process' +import { afterEach, describe, expect, it, vi } from 'vitest' +import { resolveConfig } from 'vite' +import codspeedPlugin from '@codspeed/vitest-plugin' +import { memoryExecArgv } from '../runtime' + +afterEach(() => { + vi.unstubAllEnvs() +}) + +describe('memory worker configuration', () => { + it('preserves CodSpeed instrumentation flags in a runnable worker', async () => { + vi.stubEnv('CODSPEED_ENV', 'test') + vi.stubEnv('CODSPEED_RUNNER_MODE', 'memory') + + const config = await resolveConfig( + { + configFile: false, + plugins: [codspeedPlugin()], + test: { execArgv: memoryExecArgv() }, + }, + 'serve', + 'benchmark', + ) + const flags = config.test!.execArgv! + expect(flags).toContain('--expose-gc') + expect(flags).toContain('--predictable') + expect(flags).toContain('--hash-seed=1') + + const output = execFileSync( + process.execPath, + [ + ...flags, + '--trace-opt', + '--eval', + ` + if (typeof global.gc !== 'function') { + throw new Error('Missing GC instrumentation') + } + function hot(value) { return value + 1 } + let total = 0 + for (let index = 0; index < 100000; index++) { + total += hot(index) + } + console.log(total) + `, + ], + { encoding: 'utf8' }, + ) + expect(output).toContain('5000050000') + expect(output).not.toMatch(/MAGLEV/) + }) + + it.each([undefined, 'simulation', 'instrumentation', 'walltime'])( + 'does not change %s workers', + (mode) => { + vi.stubEnv('CODSPEED_ENV', 'test') + vi.stubEnv('CODSPEED_RUNNER_MODE', mode) + expect(memoryExecArgv()).toEqual([]) + }, + ) +}) diff --git a/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts b/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts index 2ce925e406..f10c6cd41a 100644 --- a/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/react-start/plugin/vite' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts b/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts index 5ee4e152af..3a363dd1d9 100644 --- a/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/solid-start/plugin/vite' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts b/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts index 5ccc9f5d1d..add00614f0 100644 --- a/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/vue-start/plugin/vite' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts b/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts index bc67b1cfc7..b1cbcff452 100644 --- a/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/react-start/plugin/vite' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts b/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts index 401d1e5f25..e37373bc1e 100644 --- a/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/solid-start/plugin/vite' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts b/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts index 9a0ca28a25..e4c4ecbaf8 100644 --- a/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/vue-start/plugin/vite' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts b/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts index adaacda86e..96662f978d 100644 --- a/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/react-start/plugin/vite' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts b/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts index 27d4dd65f7..ef186f2bb4 100644 --- a/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/solid-start/plugin/vite' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts b/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts index 0f238bd7f7..17cafa9dd8 100644 --- a/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/vue-start/plugin/vite' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts b/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts index 1e956958ec..838e892587 100644 --- a/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/react-start/plugin/vite' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts b/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts index fbf8df9491..fcf356782d 100644 --- a/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/solid-start/plugin/vite' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts b/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts index a551a96e2f..2f0bd3e69e 100644 --- a/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/vue-start/plugin/vite' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts b/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts index de5549de3b..e15003ab06 100644 --- a/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/react-start/plugin/vite' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts b/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts index 926646ee12..8a31f5ec5d 100644 --- a/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/solid-start/plugin/vite' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts b/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts index 41a5596adf..ceda068290 100644 --- a/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/vue-start/plugin/vite' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts b/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts index 68d9ed839b..401058bdf3 100644 --- a/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/react-start/plugin/vite' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts b/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts index 8d6d226e97..c0b01336eb 100644 --- a/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/solid-start/plugin/vite' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts b/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts index 0e249b9f3b..8e4efb3de2 100644 --- a/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/vue-start/plugin/vite' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts b/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts index 5af0f0d138..17401fc9bb 100644 --- a/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/react-start/plugin/vite' import react from '@vitejs/plugin-react' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts b/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts index 18bf5b2d04..0fd29a9b79 100644 --- a/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/solid-start/plugin/vite' import solid from 'vite-plugin-solid' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts b/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts index 7cd481da0b..ea6a2f9ec4 100644 --- a/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts @@ -3,6 +3,7 @@ import { defineConfig } from 'vitest/config' import codspeedPlugin from '@codspeed/vitest-plugin' import { tanstackStart } from '@tanstack/vue-start/plugin/vite' import vueJsx from '@vitejs/plugin-vue-jsx' +import { memoryExecArgv } from '../../../../runtime' const rootDir = fileURLToPath(new URL('.', import.meta.url)) @@ -27,6 +28,7 @@ export default defineConfig({ // and the mid-measurement recompile injects a multi-MB allocation // burst at a run-dependent time. execArgv: [ + ...memoryExecArgv(), '--no-flush-bytecode', // Pre-size the V8 heap so no space has to grow mid-measurement: // heap-growth events allocate several MB at a run-dependent moment, diff --git a/benchmarks/memory/server/tsconfig.json b/benchmarks/memory/server/tsconfig.json index 5d5dcbf825..f3e80c8b72 100644 --- a/benchmarks/memory/server/tsconfig.json +++ b/benchmarks/memory/server/tsconfig.json @@ -3,5 +3,10 @@ "compilerOptions": { "types": ["node", "vite/client", "vitest/globals"] }, - "include": ["bench-utils.ts"] + "include": [ + "bench-utils.ts", + "../runtime.ts", + "*.test.ts", + "vitest.unit.config.ts" + ] } diff --git a/benchmarks/memory/server/vitest.unit.config.ts b/benchmarks/memory/server/vitest.unit.config.ts new file mode 100644 index 0000000000..19405a6f92 --- /dev/null +++ b/benchmarks/memory/server/vitest.unit.config.ts @@ -0,0 +1,9 @@ +import { defineConfig } from 'vitest/config' + +export default defineConfig({ + test: { + watch: false, + environment: 'node', + include: ['*.test.ts'], + }, +}) diff --git a/benchmarks/memory/tsconfig.json b/benchmarks/memory/tsconfig.json new file mode 100644 index 0000000000..5a325f3b6c --- /dev/null +++ b/benchmarks/memory/tsconfig.json @@ -0,0 +1,7 @@ +{ + "extends": "../../tsconfig.json", + "compilerOptions": { + "types": ["node"] + }, + "include": ["runtime.ts"] +} From 9de9cb1e416099ef18477f1061dddf298bd86406 Mon Sep 17 00:00:00 2001 From: Sheraff Date: Sat, 5 Sep 2026 22:51:12 +0200 Subject: [PATCH 3/4] test: replace adaptive memory GC polling with fixed work --- benchmarks/memory/server/bench-utils.test.ts | 73 +++++++++++++++++ benchmarks/memory/server/bench-utils.ts | 81 ++----------------- .../scenarios/peak-large-page/shared.ts | 1 - .../scenarios/serialization-payload/shared.ts | 1 - .../server/scenarios/streaming-peak/shared.ts | 3 +- benchmarks/memory/server/tsconfig.json | 1 + 6 files changed, 81 insertions(+), 79 deletions(-) create mode 100644 benchmarks/memory/server/bench-utils.test.ts diff --git a/benchmarks/memory/server/bench-utils.test.ts b/benchmarks/memory/server/bench-utils.test.ts new file mode 100644 index 0000000000..7d4da06356 --- /dev/null +++ b/benchmarks/memory/server/bench-utils.test.ts @@ -0,0 +1,73 @@ +import { afterEach, expect, it, vi } from 'vitest' +import { runSequentialRequestLoop } from './bench-utils' + +afterEach(() => { + vi.useRealTimers() + vi.unstubAllGlobals() +}) + +it('drains each response before collecting and starting the next request', async () => { + vi.useFakeTimers() + const events: Array = [] + vi.stubGlobal('gc', () => events.push('gc')) + let index = 0 + const run = runSequentialRequestLoop( + { + fetch() { + const current = index++ + events.push(`fetch ${current}`) + return new Response( + new ReadableStream({ + start(controller) { + setTimeout(() => { + events.push(`body ${current}`) + controller.enqueue(new Uint8Array([1])) + controller.close() + }, 0) + }, + }), + ) + }, + }, + { + seed: 1, + iterations: 2, + buildRequest: () => new Request('http://localhost/'), + pinGcBetweenIterations: true, + }, + ) + await vi.runAllTimersAsync() + await run + expect(events).toEqual([ + 'fetch 0', + 'body 0', + 'gc', + 'gc', + 'fetch 1', + 'body 1', + 'gc', + 'gc', + ]) +}) + +it('releases a failed response reader and does not start another request', async () => { + const failure = new Error('stream failed') + const body = new ReadableStream({ + start(controller) { + controller.error(failure) + }, + }) + const fetch = vi.fn(() => new Response(body)) + await expect( + runSequentialRequestLoop( + { fetch }, + { + seed: 1, + iterations: 2, + buildRequest: () => new Request('http://localhost/'), + }, + ), + ).rejects.toBe(failure) + expect(body.locked).toBe(false) + expect(fetch).toHaveBeenCalledTimes(1) +}) diff --git a/benchmarks/memory/server/bench-utils.ts b/benchmarks/memory/server/bench-utils.ts index b8a09fdd8e..06fb3ac220 100644 --- a/benchmarks/memory/server/bench-utils.ts +++ b/benchmarks/memory/server/bench-utils.ts @@ -28,13 +28,6 @@ export type RunSequentialRequestLoopOptions = // only removes floating garbage, whose collection timing is the // dominant cross-run noise source. pinGcBetweenIterations?: boolean - // For peak-shape scenarios ONLY (flat inter-iteration heap floor): - // verify each pinned collection actually returned the heap to the - // floor, extending the barrier when a runner's late teardown holds the - // payload past the fixed window. Churn/abort scenarios must not set - // this: their floor legitimately drifts, so the verification caps out - // chronically and the extra collections it fires destabilize the peak. - verifyGcFloor?: boolean } export const memoryBenchOptions = { @@ -66,7 +59,7 @@ export async function drainResponse(response: Response) { } try { - while (true) { + for (;;) { const result = await reader.read() if (result.done) { @@ -87,7 +80,6 @@ export async function runSequentialRequestLoop( buildRequest, validateResponse, pinGcBetweenIterations = false, - verifyGcFloor = false, } = options const random = options.seed !== undefined @@ -103,8 +95,6 @@ export async function runSequentialRequestLoop( } }) - const gcPinState = verifyGcFloor ? createGcPinState() : undefined - for (let index = 0; index < iterations; index++) { const request = buildRequest(random, index) const response = await handler.fetch(request) @@ -114,55 +104,17 @@ export async function runSequentialRequestLoop( await drainResponse(response) if (pinGcBetweenIterations) { - await settleAndPinGc(gcPinState) + await settleAndPinGc() } } } -// Renderer/stream teardown spans several event-loop turns (React and Vue -// need more than the two turns the original barrier allowed for), and a -// too-short settle window leaks a whole payload of garbage past the -// collection point, flipping the measured peak bimodally between runs. -// The settle length is a fixed count on purpose: an adaptive exit (collect -// until the post-GC heap size stops moving) makes the collection points -// land at data-dependent turns, which re-introduces exactly the run-to-run -// variance this barrier exists to remove — heap-size readings never fully -// stabilize under the instrumented CI environment, so the exit point (and -// with it every subsequent GC point) shifted between identical runs. +// Allow trailing stream/renderer teardown to finish before each collection. +// The work is fixed; heap-size readings must not decide how many collections +// a measured workload performs. const settleTurnsBeforeGc = 16 -const maxSettleTurns = 64 -// Below every scenario's payload size, above normal inter-iteration jitter. -const settledHeapSlackBytes = 256 * 1024 -// Tracks the smallest post-collection heap size seen in a workload run: -// the inter-iteration floor the heap must return to before the next -// iteration may start. -export interface GcPinState { - floorHeapUsed: number -} - -export function createGcPinState(): GcPinState { - return { floorHeapUsed: Infinity } -} - -// Settle trailing renderer/stream teardown with a fixed number of 0ms timer -// hops (one full event-loop turn each, microtasks flushing between hops), -// then pin a collection point. The second collection one turn later picks -// up whatever the first collection's finalizers released. gc() is present -// under CodSpeed (--expose-gc); in plain smoke runs there is nothing to -// pin, so only the settle hops run. -// -// The collection is then verified against the inter-iteration heap floor: -// on some runners the response teardown holds the payload past the fixed -// settle window (released only by a later internal timer), and that one -// still-reachable payload survives the collection and bleeds into the next -// iteration's measured peak. When the post-collection heap has not returned -// to the floor, keep hopping and collecting — bounded — until the payload -// is actually released, so the barrier self-heals in exactly the case where -// the fixed-count barrier fails. A workload that genuinely accumulates -// reachable memory raises the floor as it goes (the floor is the minimum -// seen), so accumulation still measures; it only pays the turn cap. -export async function settleAndPinGc(state?: GcPinState) { +export async function settleAndPinGc() { for (let turn = 0; turn < settleTurnsBeforeGc; turn++) { await new Promise((resolve) => setTimeout(resolve, 0)) } @@ -176,25 +128,4 @@ export async function settleAndPinGc(state?: GcPinState) { gc() await new Promise((resolve) => setTimeout(resolve, 0)) gc() - - if (!state) { - return - } - - let heapUsed = process.memoryUsage().heapUsed - - for ( - let turn = settleTurnsBeforeGc; - turn < maxSettleTurns && - heapUsed > state.floorHeapUsed + settledHeapSlackBytes; - turn++ - ) { - await new Promise((resolve) => setTimeout(resolve, 0)) - gc() - heapUsed = process.memoryUsage().heapUsed - } - - if (heapUsed < state.floorHeapUsed) { - state.floorHeapUsed = heapUsed - } } diff --git a/benchmarks/memory/server/scenarios/peak-large-page/shared.ts b/benchmarks/memory/server/scenarios/peak-large-page/shared.ts index 578fc9c5a2..7d6736c470 100644 --- a/benchmarks/memory/server/scenarios/peak-large-page/shared.ts +++ b/benchmarks/memory/server/scenarios/peak-large-page/shared.ts @@ -55,7 +55,6 @@ export function createWorkloadGroup( buildRequest: buildPeakLargePageRequest, validateResponse: validatePeakLargePageResponse, pinGcBetweenIterations: true, - verifyGcFloor: true, }) return { diff --git a/benchmarks/memory/server/scenarios/serialization-payload/shared.ts b/benchmarks/memory/server/scenarios/serialization-payload/shared.ts index ce095b5e10..f353f43241 100644 --- a/benchmarks/memory/server/scenarios/serialization-payload/shared.ts +++ b/benchmarks/memory/server/scenarios/serialization-payload/shared.ts @@ -62,7 +62,6 @@ export function createWorkloadGroup( buildRequest: buildPayloadRequest, validateResponse: validatePayloadResponse, pinGcBetweenIterations: true, - verifyGcFloor: true, }) return { diff --git a/benchmarks/memory/server/scenarios/streaming-peak/shared.ts b/benchmarks/memory/server/scenarios/streaming-peak/shared.ts index 6b45470329..7a3e08f7f8 100644 --- a/benchmarks/memory/server/scenarios/streaming-peak/shared.ts +++ b/benchmarks/memory/server/scenarios/streaming-peak/shared.ts @@ -50,7 +50,7 @@ async function readStreamingBody(response: Response) { let body = '' let chunkCount = 0 - while (true) { + for (;;) { const result = await reader.read() if (result.done) { @@ -99,7 +99,6 @@ export function createWorkloadGroup( buildRequest: buildStreamingRequest, validateResponse: validateStreamingResponse, pinGcBetweenIterations: true, - verifyGcFloor: true, }) return { diff --git a/benchmarks/memory/server/tsconfig.json b/benchmarks/memory/server/tsconfig.json index f3e80c8b72..499ec37192 100644 --- a/benchmarks/memory/server/tsconfig.json +++ b/benchmarks/memory/server/tsconfig.json @@ -5,6 +5,7 @@ }, "include": [ "bench-utils.ts", + "scenarios/*/shared.ts", "../runtime.ts", "*.test.ts", "vitest.unit.config.ts" From 1602c4b61a4b8074231ef6b77830224b99c7232f Mon Sep 17 00:00:00 2001 From: Sheraff Date: Sat, 5 Sep 2026 22:56:30 +0200 Subject: [PATCH 4/4] test: control the memory worker old-generation GC budget --- benchmarks/memory/runtime.ts | 7 ++++++- .../server/scenarios/aborted-requests/react/vite.config.ts | 4 ---- .../server/scenarios/aborted-requests/solid/vite.config.ts | 4 ---- .../server/scenarios/aborted-requests/vue/vite.config.ts | 4 ---- .../server/scenarios/error-paths/react/vite.config.ts | 4 ---- .../server/scenarios/error-paths/solid/vite.config.ts | 4 ---- .../memory/server/scenarios/error-paths/vue/vite.config.ts | 4 ---- .../server/scenarios/peak-large-page/react/vite.config.ts | 4 ---- .../server/scenarios/peak-large-page/solid/vite.config.ts | 4 ---- .../server/scenarios/peak-large-page/vue/vite.config.ts | 4 ---- .../server/scenarios/request-churn/react/vite.config.ts | 4 ---- .../server/scenarios/request-churn/solid/vite.config.ts | 4 ---- .../server/scenarios/request-churn/vue/vite.config.ts | 4 ---- .../scenarios/serialization-payload/react/vite.config.ts | 4 ---- .../scenarios/serialization-payload/solid/vite.config.ts | 4 ---- .../scenarios/serialization-payload/vue/vite.config.ts | 4 ---- .../server/scenarios/server-fn-churn/react/vite.config.ts | 4 ---- .../server/scenarios/server-fn-churn/solid/vite.config.ts | 4 ---- .../server/scenarios/server-fn-churn/vue/vite.config.ts | 4 ---- .../server/scenarios/streaming-peak/react/vite.config.ts | 4 ---- .../server/scenarios/streaming-peak/solid/vite.config.ts | 4 ---- .../server/scenarios/streaming-peak/vue/vite.config.ts | 4 ---- 22 files changed, 6 insertions(+), 85 deletions(-) diff --git a/benchmarks/memory/runtime.ts b/benchmarks/memory/runtime.ts index 922e59e669..941de2dfe5 100644 --- a/benchmarks/memory/runtime.ts +++ b/benchmarks/memory/runtime.ts @@ -9,5 +9,10 @@ export function memoryExecArgv() { // Node 24 still enables Maglev under CodSpeed's --no-opt. Compile baseline // code eagerly and keep minor GC tied to allocations instead of tasks. - return ['--no-maglev', '--always-sparkplug', '--no-minor-gc-task'] + return [ + '--no-maglev', + '--always-sparkplug', + '--no-minor-gc-task', + '--initial-old-space-size=512', + ] } diff --git a/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts b/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts index f10c6cd41a..7a0d8ea3a1 100644 --- a/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/aborted-requests/react/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts b/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts index 3a363dd1d9..6729a10f5b 100644 --- a/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/aborted-requests/solid/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts b/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts index add00614f0..011e60e6a8 100644 --- a/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/aborted-requests/vue/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts b/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts index b1cbcff452..eca181b2a0 100644 --- a/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/error-paths/react/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts b/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts index e37373bc1e..73c8b6fc53 100644 --- a/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/error-paths/solid/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts b/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts index e4c4ecbaf8..3c8a1642b3 100644 --- a/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/error-paths/vue/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts b/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts index 96662f978d..202b646c03 100644 --- a/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/peak-large-page/react/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts b/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts index ef186f2bb4..6cf1cfd56d 100644 --- a/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/peak-large-page/solid/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts b/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts index 17cafa9dd8..8e18d805ed 100644 --- a/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/peak-large-page/vue/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts b/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts index 838e892587..e29fac4fe9 100644 --- a/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/request-churn/react/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts b/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts index fcf356782d..6f66d036d1 100644 --- a/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/request-churn/solid/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts b/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts index 2f0bd3e69e..7bb96efffa 100644 --- a/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/request-churn/vue/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts b/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts index e15003ab06..ea8783aa79 100644 --- a/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/serialization-payload/react/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts b/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts index 8a31f5ec5d..2d26f8c74a 100644 --- a/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/serialization-payload/solid/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts b/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts index ceda068290..f7884525ad 100644 --- a/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/serialization-payload/vue/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts b/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts index 401058bdf3..5fa9cfbb82 100644 --- a/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/server-fn-churn/react/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts b/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts index c0b01336eb..233d3ef5a3 100644 --- a/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/server-fn-churn/solid/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts b/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts index 8e4efb3de2..c264768167 100644 --- a/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/server-fn-churn/vue/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts b/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts index 17401fc9bb..11639a2665 100644 --- a/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts +++ b/benchmarks/memory/server/scenarios/streaming-peak/react/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts b/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts index 0fd29a9b79..8a47faf33a 100644 --- a/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts +++ b/benchmarks/memory/server/scenarios/streaming-peak/solid/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ], diff --git a/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts b/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts index ea6a2f9ec4..3dbe508d1c 100644 --- a/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts +++ b/benchmarks/memory/server/scenarios/streaming-peak/vue/vite.config.ts @@ -30,10 +30,6 @@ export default defineConfig({ execArgv: [ ...memoryExecArgv(), '--no-flush-bytecode', - // Pre-size the V8 heap so no space has to grow mid-measurement: - // heap-growth events allocate several MB at a run-dependent moment, - // which flips the measured peak bimodally between identical runs. - '--initial-old-space-size=64', '--min-semi-space-size=16', '--max-semi-space-size=16', ],