From 4c1421fd317032aadcffe549fd1566b28c1804be Mon Sep 17 00:00:00 2001 From: Nicolas Beaussart Date: Sat, 27 Dec 2025 20:12:28 +0100 Subject: [PATCH 1/6] get baseline timeings --- nx.json | 1 + 1 file changed, 1 insertion(+) diff --git a/nx.json b/nx.json index 4f8c811d34..3033fdecb8 100644 --- a/nx.json +++ b/nx.json @@ -4,6 +4,7 @@ "nxCloudId": "6442f7de8226a6291646a813", "useInferencePlugins": false, "parallel": 5, + "bust": 1, "tui": { "enabled": false }, From f807e8d5fb56daece4e353edaa745859d704727e Mon Sep 17 00:00:00 2001 From: Nicolas Beaussart Date: Sat, 27 Dec 2025 21:02:36 +0100 Subject: [PATCH 2/6] split up e2e targets --- e2e/react-start/basic/package.json | 2 +- e2e/solid-start/basic/package.json | 2 +- e2e/vue-start/basic/package.json | 2 +- nx.json | 26 ++++++++++++++++++++++++++ 4 files changed, 29 insertions(+), 3 deletions(-) diff --git a/e2e/react-start/basic/package.json b/e2e/react-start/basic/package.json index 5200e34402..0f6070871a 100644 --- a/e2e/react-start/basic/package.json +++ b/e2e/react-start/basic/package.json @@ -18,7 +18,7 @@ "test:e2e:ssrMode": "rm -rf port*.txt; playwright test --project=chromium", "test:e2e:prerender": "rm -rf port*.txt; MODE=prerender playwright test --project=chromium", "test:e2e:preview": "rm -rf port*.txt; MODE=preview playwright test --project=chromium", - "test:e2e": "pnpm run test:e2e:spaMode && pnpm run test:e2e:ssrMode && pnpm run test:e2e:prerender && pnpm run test:e2e:preview" + "test:e2e": "node -e \"console.log('Should be run with Nx')\"" }, "dependencies": { "@tanstack/react-router": "workspace:^", diff --git a/e2e/solid-start/basic/package.json b/e2e/solid-start/basic/package.json index 2e278ac438..ca26752076 100644 --- a/e2e/solid-start/basic/package.json +++ b/e2e/solid-start/basic/package.json @@ -18,7 +18,7 @@ "test:e2e:ssrMode": "rm -rf port*.txt; playwright test --project=chromium", "test:e2e:prerender": "rm -rf port*.txt; MODE=prerender playwright test --project=chromium", "test:e2e:preview": "rm -rf port*.txt; MODE=preview playwright test --project=chromium", - "test:e2e": "pnpm run test:e2e:spaMode && pnpm run test:e2e:ssrMode && pnpm run test:e2e:prerender && pnpm run test:e2e:preview" + "test:e2e": "node -e \"console.log('Should be run with Nx')\"" }, "dependencies": { "@tanstack/solid-router": "workspace:^", diff --git a/e2e/vue-start/basic/package.json b/e2e/vue-start/basic/package.json index 712d6f6004..d136193aad 100644 --- a/e2e/vue-start/basic/package.json +++ b/e2e/vue-start/basic/package.json @@ -18,7 +18,7 @@ "test:e2e:ssrMode": "rm -rf port*.txt; playwright test --project=chromium", "test:e2e:prerender": "rm -rf port*.txt; MODE=prerender playwright test --project=chromium", "test:e2e:preview": "rm -rf port*.txt; MODE=preview playwright test --project=chromium", - "test:e2e": "pnpm run test:e2e:spaMode && pnpm run test:e2e:ssrMode && pnpm run test:e2e:prerender && pnpm run test:e2e:preview" + "test:e2e": "node -e \"console.log('Should be run with Nx')\"" }, "dependencies": { "@tanstack/vue-router": "workspace:^", diff --git a/nx.json b/nx.json index 3033fdecb8..939c8daf19 100644 --- a/nx.json +++ b/nx.json @@ -42,6 +42,32 @@ "outputs": ["{projectRoot}/coverage"] }, "test:e2e": { + "cache": true, + "dependsOn": [ + "^build", + "test:e2e:spaMode", + "test:e2e:ssrMode", + "test:e2e:prerender", + "test:e2e:preview" + ], + "inputs": ["default", "^production"] + }, + "test:e2e:spaMode": { + "cache": true, + "dependsOn": ["^build"], + "inputs": ["default", "^production"] + }, + "test:e2e:ssrMode": { + "cache": true, + "dependsOn": ["^build"], + "inputs": ["default", "^production"] + }, + "test:e2e:prerender": { + "cache": true, + "dependsOn": ["^build"], + "inputs": ["default", "^production"] + }, + "test:e2e:preview": { "cache": true, "dependsOn": ["^build"], "inputs": ["default", "^production"] From a4cc49adcfd393cb28663b7c064ce4a588859031 Mon Sep 17 00:00:00 2001 From: Nicolas Beaussart Date: Sat, 27 Dec 2025 21:25:52 +0100 Subject: [PATCH 3/6] run e2e without parallel to try --- nx.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/nx.json b/nx.json index 939c8daf19..0b70e0fb06 100644 --- a/nx.json +++ b/nx.json @@ -53,21 +53,25 @@ "inputs": ["default", "^production"] }, "test:e2e:spaMode": { + "parallelism": false, "cache": true, "dependsOn": ["^build"], "inputs": ["default", "^production"] }, "test:e2e:ssrMode": { + "parallelism": false, "cache": true, "dependsOn": ["^build"], "inputs": ["default", "^production"] }, "test:e2e:prerender": { + "parallelism": false, "cache": true, "dependsOn": ["^build"], "inputs": ["default", "^production"] }, "test:e2e:preview": { + "parallelism": false, "cache": true, "dependsOn": ["^build"], "inputs": ["default", "^production"] From 5cd1c85fd6409b561653ebbcc622b2b92b7e57a7 Mon Sep 17 00:00:00 2001 From: Nicolas Beaussart Date: Sat, 27 Dec 2025 22:58:51 +0100 Subject: [PATCH 4/6] run lint and build in more parallel runners --- .nx/workflows/dynamic-changesets.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.nx/workflows/dynamic-changesets.yaml b/.nx/workflows/dynamic-changesets.yaml index d3536f3ba7..c91f2d6579 100644 --- a/.nx/workflows/dynamic-changesets.yaml +++ b/.nx/workflows/dynamic-changesets.yaml @@ -2,3 +2,16 @@ distribute-on: small-changeset: 3 linux-medium-js medium-changeset: 6 linux-medium-js large-changeset: 10 linux-medium-js + +assignment-rules: + - targets: + - build + run-on: + - agent: linux-large + parallelism: 5 + + - targets: + - lint + run-on: + - agent: linux-large + parallelism: 4 \ No newline at end of file From 9424caff49ba6c7515109f54ef32acc6046837d3 Mon Sep 17 00:00:00 2001 From: Nicolas Beaussart Date: Sat, 27 Dec 2025 22:59:03 +0100 Subject: [PATCH 5/6] run e2e in cascade --- nx.json | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/nx.json b/nx.json index 0b70e0fb06..a485faf609 100644 --- a/nx.json +++ b/nx.json @@ -53,25 +53,21 @@ "inputs": ["default", "^production"] }, "test:e2e:spaMode": { - "parallelism": false, "cache": true, - "dependsOn": ["^build"], + "dependsOn": ["^build", "test:e2e:ssrMode"], "inputs": ["default", "^production"] }, "test:e2e:ssrMode": { - "parallelism": false, "cache": true, - "dependsOn": ["^build"], + "dependsOn": ["^build", "test:e2e:prerender"], "inputs": ["default", "^production"] }, "test:e2e:prerender": { - "parallelism": false, "cache": true, - "dependsOn": ["^build"], + "dependsOn": ["^build", "test:e2e:preview"], "inputs": ["default", "^production"] }, "test:e2e:preview": { - "parallelism": false, "cache": true, "dependsOn": ["^build"], "inputs": ["default", "^production"] From db9d4ad4059d9ec869ad51b48107e2b2ae9371ab Mon Sep 17 00:00:00 2001 From: Nicolas Beaussart Date: Sat, 27 Dec 2025 23:08:51 +0100 Subject: [PATCH 6/6] fix assignements --- .nx/workflows/dynamic-changesets.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.nx/workflows/dynamic-changesets.yaml b/.nx/workflows/dynamic-changesets.yaml index c91f2d6579..e1bb1792fd 100644 --- a/.nx/workflows/dynamic-changesets.yaml +++ b/.nx/workflows/dynamic-changesets.yaml @@ -7,11 +7,11 @@ assignment-rules: - targets: - build run-on: - - agent: linux-large + - agent: linux-medium-js parallelism: 5 - targets: - lint run-on: - - agent: linux-large + - agent: linux-medium-js parallelism: 4 \ No newline at end of file