0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00

Compare commits

..

25 commits

Author SHA1 Message Date
Flo
0b6d4f3f6b
perf(start-plugin-core): count imported modules once in the Rsbuild manifest pass (#8926)
The static-dependency pass behind the Rsbuild Start manifest runs after
every client compilation, dev updates included. It walked every
connection of every module of every chunk and read the imported module's
chunks each time. Count an imported module once per chunk, from its
first active connection, and read a module's chunks once per
compilation (memoized on the resolver created per compilation).

The manifest is unchanged.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-13 14:28:55 +01:00
Ciarán Curley
e7358c36d8
fix(react-start-rsc): bump RSC bundler deps for RSC (#8919)
fix(react-start-rsc): bump RSC bundler deps for React Server Components advisories

Raise @vitejs/plugin-rsc to ^0.5.39 (peer >=0.5.38) and
react-server-dom-rspack to ^0.1.1 (peer >=0.1.1) so both bundled React
Flight runtimes include the fixes for GHSA-xqc2-xf4c-x3h3
(CVE-2026-126187, unauthenticated RCE) and GHSA-h3gv-c5rc-p453 (server
function DoS).

Bump the react/react-dom catalog to ~19.2.9. Stay on 19.2.x because
React 19.3 currently fails the rsc-deferred-hydration e2e suite.
2026-11-12 09:33:28 +01:00
Manuel Schiller
113b1a1f08
chore(pnpm): upgrade to pnpm 12 (#8912)
* chore(pnpm): upgrade to pnpm 12

* ci: use native pnpm 12 bootstrap for compiler jobs

* fix(benchmarks): invoke the Nx CLI directly

* refactor(benchmarks): run Nx through pnpm exec
2026-11-09 13:24:08 +01:00
Manuel Schiller
fd5b0b8fad
test(react-start): wait for SSR between HMR saves (#8913) 2026-11-09 12:57:45 +01:00
Flo
70bbd11025
fix(start-plugin-core): restore the build of the Rsbuild virtual modules (#8907)
#8889 wrote the Rsbuild dev manifest with the eager `paths.manifest`.
#8868, merged after it, replaced `paths` with the lazy `pathsOf()`, which
builds the virtual paths from the resolved root on first use. Neither PR
saw the other, so main fails to type-check with "Cannot find name 'paths'".

Read the manifest path through `pathsOf()`, like every other use.
`updateManifest` runs after a client compile, so the root is resolved by
then, and the path is the same one `manifestPath` returns for the RSC
manifest rebuild.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 18:34:35 +01:00
Flo
c156097786
fix(start-plugin-core): Rsbuild manifests list only a route's own chunks (#8876)
A chunk counted as a static dependency of a shared chunk when any one of
the shared chunk's groups had it. When two routes share a module in a
chunk of its own and a module that module imports is duplicated into each
route's chunk, the shared chunk depended on both route chunks, so each
route's manifest entry preloaded the other route's chunk and linked its
stylesheet. A chunk now counts as available only when every group of the
shared chunk (or one of its ancestors) has it.

Taken from #8817.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 11:42:43 +01:00
Flo
df6ac30406
fix(start-plugin-core): write Rsbuild virtual modules under the app's root, not the working directory (#8868)
* fix(start-plugin-core): write Rsbuild virtual modules under the app's root

The Rsbuild plugin read `resolvedStartConfig.root || process.cwd()` at
setup, before `modifyRsbuildConfig` resolves the root, so Start's virtual
modules always went under `<cwd>/node_modules/.virtual`. Run from another
directory (`rsbuild build --root <app>` from a monorepo root), the packages
those modules import did not resolve there: an RSC app failed with "Module
not found" on its serialization adapters. The virtual paths are now built
from the resolved root when the first Rspack config is built.

From #8817.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(start-plugin-core): resolve a relative Rsbuild root before building virtual paths

Rsbuild accepts a relative `root` (resolved against its `cwd`) but passes
it to `modifyRsbuildConfig` as written. Start stored it as is, so the
virtual modules' paths were relative and resolved against each importer:
the build failed with "Module not found". Take Rsbuild's resolved
`api.context.rootPath` unless the root is already absolute.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(start-plugin-core): leave the temporary working directory before removing it

`onTestFinished` callbacks run last first, so the directory was removed
while it was still the working directory, which Windows refuses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(start-plugin-core): use a canonical Rsbuild root for the virtual modules' paths

Rsbuild keeps `root` as written, trailing separator included (`/app/`,
and `rootPath` of a relative `app/`), so the virtual paths had `//` while
Rspack's module identifiers have one separator: the dev rebuild of the
server-fn resolver (substring match) skipped it. Resolve the root.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(start-plugin-core): the relative-root Rsbuild app renders its index page

The test only checked that the build finished. Render `/` through the
built server's `fetch` handler, which also reads the server manifest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 11:42:24 +01:00
Flo
2ebc0f3586
fix(start-plugin-core): refuse custom server-fn ids that never worked over HTTP, deprecate the rest outside the unreserved set (#8858)
* refactor(start-plugin-core): derive server-fn ids from the stable key, with 22-character defaults

`serverFns.generateFunctionId` now receives the server function's
stable name (`greetUser`) as `functionName` instead of the generated
handler name (`greetUser_createServerFn_handler`). Repeats of the same
variable name in one file get `#1`, `#2`, ...

Default production ids are the first 22 base64url characters of the
SHA256 of `<file>#<stable key>` instead of the full 64-character hex
digest.

Split out of #8817, which derives ids the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(start-plugin-core): keep generateFunctionId's handler-name input, reject custom ids that aren't one URL path segment

Follows #8817's current id contract:

- `generateFunctionId` receives the generated handler name again
  (`greetUser_createServerFn_handler`, `_1`, `_2`… for repeats), with
  characters outside `[A-Za-z0-9_$]` as `_`. The handler export keeps its
  name.
- The default id stays 22 base64url characters of
  `sha256("<root-relative file>#<variable name>")`, `#n` for repeats.
- A custom id outside RFC 3986's unreserved characters and `$` (or `.`,
  `..`, empty) fails the build, naming the file, the function and the id.
- The e2e id maps return to main's keys.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(start-plugin-core): a repeated server function name loses leading and doubled underscores

The generator's `functionName` for a repeated name goes through the old
increment rule, which strips leading underscores and collapses runs of
underscores (a second `_x` gets `x_createServerFn_handler_1`). Say so,
and pin it with `_x` twice and `café` then `caf_`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(start-plugin-core): names that become equal after the `_` replacement get suffixes too

`café` and `caf_` both give `caf__createServerFn_handler`, so the later
one gets `caf_createServerFn_handler_1`, like a repeated variable name.
Describe the replacement first, then the suffix rule for any resulting
duplicate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(start-plugin-core): keep main's server-fn ids; refuse custom ids that never worked over HTTP

#8817 now prints main's default ids and passes main's functionName to
generateFunctionId, so this reverts the shorter default ids, the
generator-name split and the empty-id failure. What stays is #8817's
custom-id check: an id the URL never carries whole fails the build, one
with other characters outside the unreserved set and $ builds with a
deprecation warning, and the resolver manifest escapes a `'` in an id.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 11:42:06 +01:00
Flo
3cc054c374
fix(start-plugin-core): find Start libraries from Vite's root, not the working directory (#8866)
* fix(start-plugin-core): find Start libraries from Vite's root

Start bundles the Start libraries (dependencies with a peer dependency on
Start) in the SSR build so its compiler compiles their server fns. It
crawled the working directory's package.json, so `vite build <app>` run
from another directory left them external and uncompiled: their server
fns returned undefined during SSR. Crawl Vite's root, which the plugin
already uses for its own root.

From #8817.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(start-plugin-core): resolve a relative Vite root before crawling for Start libraries

The `config` hook sees Vite's root as configured, which can be relative
(`root: '.'`, `vite build .`). vitefu then walked up from the relative
path and stopped at the working directory, missing a Start library
hoisted to a monorepo's `node_modules` above it. Resolve it as Vite does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(start-plugin-core): leave the temporary working directory before removing it

`onTestFinished` callbacks run last first, so the directory was removed
while it was still the working directory, which Windows refuses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(start-plugin-core): crawl Start libraries from the physical Vite root

A root through a symlink (`vite build "$PWD"` in a symlinked directory)
made vitefu walk up the symlink's parents and miss a Start library
hoisted above the physical app directory, where Vite resolves the app's
imports from. main crawled `process.cwd()`, which is physical. Take the
root's realpath.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(start-plugin-core): leave the symlinked directory before removing it

The symlinked-root test removed `linkParent` while the working directory
was still inside it (`onTestFinished` callbacks run last first), which
Windows refuses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 11:41:37 +01:00
github-actions[bot]
ed86c440c5
ci: Version Packages (#8891)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-11-08 10:47:39 +01:00
Manuel Schiller
f8709334ac
chore(deps): bump @rsbuild/core to 2.3.1 (#8890)
Bump the workspace catalog and every e2e, example and benchmark
devDependency to ^2.3.1 so the lockfile resolves a single Rsbuild version.
Published peer ranges are unchanged.

The newer Rspack types allow falsy entries in a rule's `use` array, so the
Rsbuild RSC SWC integration now skips them instead of treating them as
loaders.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 10:47:24 +01:00
Manuel Schiller
559c7ded6e
fix(start-plugin-core): restore CSS in Rsbuild RSC dev SSR (#8892)
fix(start-plugin-core): rebuild the Rsbuild RSC dev manifest after the client build

#8889 moved the Rsbuild dev manifest from a build-process global into the
server's manifest module. With React Server Components the client and server
compile concurrently, so the manifest is written while the server
compilation is already running, and dev SSR kept the fallback manifest
without CSS.

Run the existing RSC finishMake manifest rebuild in dev too. In dev it only
rebuilds when the manifest was written since this compiler last rebuilt it.

Add an Rsbuild dev mode to the rsc e2e app (test:e2e:dev:rsbuild). On main,
nine CSS tests fail in it; with this change the full suite passes. Also
accept Rsbuild dev's CSS module class names in the scoped-class assertion.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 10:33:30 +01:00
Manuel Schiller
3f226869e0
fix(start-plugin-core): include CSS in Rsbuild dev SSR when the server runs in workerd (#8889)
fix(start-plugin-core): write Rsbuild dev manifest into the server module

In Rsbuild dev, the start manifest was stored on the build process's
globalThis and read from there by the SSR manifest module. When the server
environment runs in another runtime, such as workerd with
rsbuild-plugin-cloudflare, that global is invisible, so SSR fell back to a
manifest without CSS and pages rendered unstyled.

Write the dev manifest into the server's manifest virtual module instead,
only when its content changes. Add rsbuild dev variants (Node and workerd)
to the css-modules e2e app to cover it.

Fixes #8886

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 09:05:42 +01:00
github-actions[bot]
7dbce0807d
ci: Version Packages (#8854)
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-11-08 02:00:36 +01:00
Manuel Schiller
bbf9b75808
fix(router-devtools-core): restore embedded panel styling (#8888)
* fix(router-devtools-core): restore embedded panel styling

All devtools size tokens are `calc(var(--tsrd-font-size) * n)`, but only the
floating devtools set `--tsrd-font-size` (via JS). The embedded
TanStackRouterDevtoolsPanel never had it defined, so every size declaration
was dropped: inherited font sizes, zero padding/gap/indentation and invisible
route status dots. Regressed in #1222 (v1.17.0).

Fall back to `1rem` when the variable is unset. Floating behavior is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(react-router): read devtools mode from a validated search param

Use root route validateSearch + useSearch instead of raw URLSearchParams,
and render the shadow DOM panel through a portal instead of mounting the
whole app in a shadow root.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(react-router): validate devtools search param with zod

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(react-router): add links to switch devtools variants

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 01:55:41 +01:00
Tanner Linsley
19037cc8c6
docs(start): troubleshoot server and client execution boundaries (#8394) 2026-11-05 21:26:23 -07:00
Tanner Linsley
78001ec0ef
docs(start): troubleshoot Cloudflare deployment config (#8396) 2026-11-05 21:26:13 -07:00
Tanner Linsley
ee7dab26e2
docs(start): record verified Query recipe versions (#8387)
* docs(start): record verified Query recipe versions

* ci: apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2026-11-05 21:26:02 -07:00
Tanner Linsley
b2ab16c22e
docs(router): clarify when Start helps with data loading (#8388)
docs(router): clarify when to use Start for data loading
2026-11-05 21:25:30 -07:00
Pujitha Paladugu
c5320d7ca2
fix(start-plugin-core): define TSS_SHELL in Rsbuild dev for SPA mode (#8805)
* fix(start-plugin-core): define TSS_SHELL in Rsbuild dev for SPA mode

In Rsbuild dev mode, `source.define` now sets `process.env.TSS_SHELL` and `import.meta.env.TSS_SHELL` from `startConfig.spa?.enabled` (`"true"` when SPA mode is enabled, `"false"` otherwise). Before this, Rsbuild dev never defined `TSS_SHELL`, so with `spa: { enabled: true }` it server-rendered the matched route and ran its loader on the server instead of serving only the shell. Build and preview are unchanged: the define is added only when `isDev` is true.

Changes:
- `packages/start-plugin-core/src/rsbuild/plugin.ts`: add the dev-only `TSS_SHELL` defines to the Rsbuild define block.
- `packages/start-plugin-core/tests/rsbuild/spa-shell-define.test.ts`: new test that calls the plugin's `modifyRsbuildConfig` hook. It checks that `TSS_SHELL` is `"true"` in dev with SPA enabled, `"false"` in dev without SPA, and not defined in build.
- `.changeset/rsbuild-spa-dev-shell.md`: patch changeset for `@tanstack/start-plugin-core`.

Fixes #8543

Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Assisted-by: claude-sonnet-5-5 (via Claude Code)

* test(start-plugin-core): check the SPA shell on a real Rsbuild dev server

- `src/rsbuild/plugin.ts`: the `TSS_SHELL` define gets #8817's comment.
- The regression test serves a real app with `rsbuild dev` (a new
  `startRsbuildDevServer` in `tests/integration/start-app.ts`) and fetches
  its `/` route: with `spa.enabled` the loader no longer runs on the
  server; without it, the control still renders the route there. This is
  #8817's `integration/rsbuild/dev-server-config.test.ts` scenario, and it
  replaces the unit test that stubbed the plugin API.
- The changeset says what users see.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(start-plugin-core): the SPA dev test checks the shell and counts loader runs

The SPA test only checked a 200 without `MARK_SERVER`, which an empty
answer or a loader run whose output the shell drops would also pass.
The root route now renders its own text, so the SPA answer must hold it
without the `/` route's; the loader counts its runs on `globalThis`
(Rsbuild dev runs the server bundle in the test's process), so the SPA
test asserts none and the control asserts one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(react-start): check the dev SPA shell with an e2e on Vite and Rsbuild

Replace the synthetic Rsbuild integration test with one e2e in
e2e/react-start/basic, run against both dev servers:
test:e2e--vite-spa--dev and test:e2e--rsbuild-spa--dev
(playwrightModes with E2E_DEV_SERVER, no app build, the shared dev
server prewarm). spa-shell.spec.ts checks that the raw document is the
shell, that the route's loader and beforeLoad run in the browser, and
that client navigation works from the shell. It runs in the prod SPA
mode too.

tests/integration/start-app.ts is back to main's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Signed-off-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Co-authored-by: Pujitha Paladugu <10557236+pujitha24@users.noreply.github.com>
Co-authored-by: Sheraff <me@florianpellet.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 20:28:58 +01:00
Flo
d05c6c66e7
fix(vue-start): pre-bundle @tanstack/vue-store so a cold dev start doesn't reload the page (#8869)
fix(vue-start): pre-bundle @tanstack/vue-store so a cold dev start doesn't reload

Vue Start excludes `@tanstack/vue-router` from optimization, so Vite's
scanner never sees its `@tanstack/vue-store` import. Discovered while the
first page loads, it imports `vue` and re-chunks the already optimized
`vue`: Vite logs "optimized dependencies changed. reloading" and reloads
the page on every cold start. Declare it through `optimizeDeps.include`,
as React Start does for `@tanstack/react-store`.

From #8817.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 13:38:11 +01:00
Flo
ff157f0079
fix(router-utils): parse decorators after export (#8867)
The shared Babel parser options set `decoratorsBeforeExport: true`, so
`export @dec class Store {}` failed to parse. The route generator logged
the error and wrote no route tree, and the code splitter left the route
unsplit. Start's compilers use the same options.

Dropping the option lets Babel accept decorators on either side of
`export`; decorators before `export` still print where they were.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 13:36:34 +01:00
Flo
f420d4a6da
fix(router-plugin): write import.meta.hot.accept( out in Vite route HMR (#8870)
* fix(router-plugin): write `import.meta.hot.accept(` out in Vite route HMR

Vite's import analysis marks a module as a hot boundary only when its
code spells `import.meta.hot.accept(` out. The route HMR code called it
through `const hot = import.meta.hot`, so a route module no framework
plugin accepted (a `.ts` route file, or an app without
`@vitejs/plugin-react`) reloaded the page on every edit.

The React HMR code also declared a top-level `const hot`, which made a
route file with its own `hot` binding fail with `Duplicate declaration
"hot"`. Both now read `import.meta.hot` directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(router-plugin): keep the user's `hot` binding in the module under test

Split, the component reading `hot` moves to its chunk, and with it the
user's `const hot`, so the served route module no longer holds the
binding the HMR code could collide with. Serve the route unsplit and
assert the declaration is still there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 13:31:55 +01:00
Flo
545a8d3790
fix(start-plugin-core): require exsolve ^1.1.3, and see new entry files after a dev server restart (#8871)
* fix(start-plugin-core): require exsolve ^1.1.3 and bypass its cache for entry lookups

exsolve caches a failed `try: true` lookup as an Error in its
process-wide cache. Before 1.1.2 that Error kept its call sites, and
with them its callers, alive for the life of the process (unjs/exsolve#63),
so each build in one process left its objects behind. Require ^1.1.3.

The cache also kept misses: Start looks up its optional entries
(`src/start.ts`, `src/client.tsx`, `src/server.ts`) once per plugin
instance, and a dev server restart got the cached miss for an entry
created since. Entry lookups now pass `cache: false`.

From #8817.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changeset): narrow the exsolve memory claim

exsolve still caches lookups, and other packages in an app's build (for
example Nitro, which bundles an older exsolve) share its process-wide
cache. Say what the bump fixes: Start's cached failed lookups no longer
keep each build's objects alive.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 13:28:02 +01:00
Sarah Gerrard
1ba19a0445
fix(router-plugin): omit browser warnings from production bundles (#8269)
* fix(router-plugin): omit browser warnings from production bundles

* fix(router-plugin): only the bundler's mode keeps the warning out of the page

The code splitter always passes isProduction, so the NODE_ENV fallback in the compiler was reachable only from direct test calls. The changeset now names the bug users see.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(router-plugin): real webpack and Rspack production builds ship no splitter warning

Builds an app whose route exports its component, with mode 'production' and with mode left out, and checks that no emitted JS names the app's absolute path. Fails on main. Replaces the fake-compiler matrix in router-plugin-context.test.ts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Sheraff <me@florianpellet.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 11:30:55 +01:00
273 changed files with 6114 additions and 4280 deletions

Some files were not shown because too many files have changed in this diff Show more