0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
router/e2e/react-start/css-modules
Sheraff 0517895892
build: one sass in the workspace so every package resolves the same vite
vite's optional peers `sass` and `sass-embedded` are resolved from whatever
versions exist anywhere in the lockfile graph. Two sass versions were in the
graph: 1.97.2 (the `^1.97.2` devDependency of the three Start css-modules
e2e apps) and 1.105.1 (pulled by `sass-embedded`, which
`@rsbuild/plugin-sass` brings into e2e/react-start/css-modules). Importers
resolved at different times got different vite peer variants: compiler-test-
utils, react-start-rsc and eslint-plugin-start got vite(sass@1.105.1), the
rest vite(sass@1.97.2). Two copies of vite break Start's
`isRunnableDevEnvironment` (instanceof) check, so Start's dev server
middleware never ran in the compiler test dev servers.

The css-modules e2e apps now ask for sass ^1.105.1, the version sass-embedded
already uses; the graph has one sass and one vite@8.3.4 (esbuild 0.28.2)
variant.

With Start's dev middleware working, the client-rendered route HMR test
turns it off explicitly (it serves index.html, not Start's SSR); the Start
dev-server harness accepts the Vite plugin options for that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
History 2026-10-18 18:00:16 +02:00
..
.devcontainer docs: add devcontainer.json to all e2e/examples (#6972) 2026-03-18 15:43:14 +01:00
src fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS (#8695) 2026-10-13 01:07:27 +02:00
tests fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS (#8695) 2026-10-13 01:07:27 +02:00
.gitignore fix: css dev extraction correctness and performance (#6383) 2026-01-13 20:21:14 +01:00
.prettierignore feat: collect styles in dev (#6343) 2026-01-10 04:07:23 +01:00
package.json build: one sass in the workspace so every package resolves the same vite 2026-10-18 18:00:16 +02:00
playwright.config.ts fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS (#8695) 2026-10-13 01:07:27 +02:00
rsbuild.config.ts fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS (#8695) 2026-10-13 01:07:27 +02:00
tsconfig.json chore: upgrade tooling to typescript 6 (#7024) 2026-03-23 22:59:52 +01:00
vite.config.cloudflare.ts docs: update examples/e2e to vite 8 (#6958) 2026-03-17 20:37:11 +01:00
vite.config.ts fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS (#8695) 2026-10-13 01:07:27 +02:00
wrangler.jsonc fix: dev style with non runnable dev environments and basepath support (#6348) 2026-01-10 14:51:33 +01:00