0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
router/packages/react-router/tests
Jason Xie 4814d4ef90
fix(router-core): use encodeURIComponent for splat route params (#6520)
* fix(router-core): use encodeURIComponent for splat route params

Use encodeURIComponent instead of encodeURI for splat route parameters
to properly encode spaces, plus signs, and other special characters.

This fixes an SSR redirect loop that occurs when:
1. User navigates to a splat route with encoded characters (e.g., %20)
2. TanStack Router decodes params with decodeURIComponent
3. When rebuilding URL, encodeURI doesn't encode spaces/special chars
4. URL mismatch triggers redirect loop (307 redirects)

encodeURIComponent properly encodes these characters, preventing the
mismatch while still preserving forward slashes as path separators.

* update tests to use correct encoding for splat params

* use encodePathParam for splat/catch-all

* perf(router-core): add early return for URL-safe splat values

Add performance optimization that skips the split/map/join operation
when splat values only contain URL-safe characters (alphanumeric,
dash, period, underscore, tilde, exclamation, forward slash).

This avoids unnecessary processing in the hot path for common cases.

* fix(router-core): encode whitespace in encodeNonAscii

Update encodeNonAscii to also encode whitespace characters (spaces, tabs, etc.)
in addition to non-ASCII characters. This fixes SSR redirect loops where:

1. Request URL contains encoded spaces: /path/file%20name.pdf
2. parseLocation decodes pathname: /path/file name.pdf
3. buildLocation calls encodeNonAscii but spaces weren't encoded
4. URL mismatch triggers redirect loop

Now encodeNonAscii properly encodes:
- Whitespace characters (spaces become %20)
- Non-ASCII/unicode characters (including emojis)

Other ASCII special characters (parentheses, brackets, etc.) are preserved
as they are valid in URL paths.

* refactor(router-core): use regex in encodeNonAscii like original

* refactor(router-core): rename encodeNonAscii to encodePathLikeUrl

Rename the function to better reflect its expanded responsibility of
encoding paths the same way new URL() would, including:
- Whitespace characters (spaces → %20, tabs → %09)
- Non-ASCII/Unicode characters (emojis, accented characters)

The old name 'encodeNonAscii' was misleading since the function now
encodes more than just non-ASCII characters.

---------

Co-authored-by: Nico Lynzaad <nlynzaad@zylangroup.com>
Co-authored-by: Nico Lynzaad <44094871+nlynzaad@users.noreply.github.com>
History 2026-01-26 23:53:20 +02:00
..
lazy test: Add test cases for route id consistency (#2401) 2024-10-15 21:35:04 +02:00
blocker.test.tsx feat: Merge alpha to main (#4365) 2025-06-10 23:19:32 +02:00
ClientOnly.test.tsx feat: Merge alpha to main (#4365) 2025-06-10 23:19:32 +02:00
createLazyRoute.test.tsx test(react-router): correct usage of act and waitFor (#1986) 2024-07-19 10:42:40 +12:00
disableGlobalCatchBoundary.test.tsx feat(react-router): add disableGlobalCatchBoundary option (#4765) 2025-07-26 22:45:20 +02:00
errorComponent.test.tsx feat: Merge alpha to main (#4365) 2025-06-10 23:19:32 +02:00
fileRoute.test-d.tsx refactor(router-core): begin migrating types from react-router and solid-router to router-core (#3538) 2025-02-23 23:18:16 +01:00
fileRoute.test.ts refactor(router-core): move AnyRoute and AnyRouter to router-core (#3640) 2025-03-04 21:48:58 +01:00
link.bench.tsx feat(react-router): add remountDeps (#3269) 2025-01-29 01:03:33 +01:00
link.test-d.tsx chore: bump deps (#6408) 2026-01-18 02:14:48 +01:00
link.test.tsx fix(router-core): use encodeURIComponent for splat route params (#6520) 2026-01-26 23:53:20 +02:00
loaders.test.tsx fix(router-core): handle AbortError in router execution flow (#4570) 2026-01-07 22:55:00 +01:00
Matches.test-d.tsx fix: make to required if from is not set (#3099) 2025-01-04 18:48:57 +01:00
Matches.test.tsx fix: revert "refactor: don't reparse upon navigation (#6398)" (#6468) 2026-01-23 16:50:10 +01:00
navigate.test.tsx fix(router-core): use encodeURIComponent for splat route params (#6520) 2026-01-26 23:53:20 +02:00
not-found.test.tsx fix: update error handling in MatchInner to access error data directly (#4746) 2025-11-19 19:46:29 +01:00
optional-path-params.test-d.tsx feat: optional path params (#4597) 2025-07-16 13:41:58 -06:00
optional-path-params.test.tsx refactor(router-core): interpolatePath skips optional segments w/ nullish param value (#5934) 2025-11-21 23:55:16 +01:00
redirect.test.tsx refactor(router-core): skip URL constructor in buildLocation (#6447) 2026-01-24 11:42:55 +01:00
redirects.test-d.tsx fix: make to required if from is not set (#3099) 2025-01-04 18:48:57 +01:00
route.test-d.tsx feat: Merge alpha to main (#4365) 2025-06-10 23:19:32 +02:00
route.test.tsx feat: Add style to HeadContent (#4559) 2025-07-02 00:28:12 +02:00
routeApi.test-d.tsx fix: fullpath handling (#6404) 2026-01-17 17:21:10 +01:00
routeContext.test.tsx fix: commit route context (#6053) 2025-12-09 21:17:36 +01:00
router.test-d.tsx refactor(router-core): move AnyRoute and AnyRouter to router-core (#3640) 2025-03-04 21:48:58 +01:00
router.test.tsx refactor(router-core): parseLocation fast path w/ no rewrites (#6516) 2026-01-26 07:36:11 +01:00
RouterProvider.test-d.tsx feat: trailingSlashes option on the type level (#1509) 2024-04-25 20:05:34 +02:00
Scripts.test.tsx fix: cleanly separate dev styles from prod runtime (#6356) 2026-01-11 03:28:20 +01:00
searchMiddleware.test.tsx feat: Merge alpha to main (#4365) 2025-06-10 23:19:32 +02:00
setupTests.tsx chore: silence error in test (#4794) 2025-07-26 23:05:17 +02:00
store-updates-during-navigation.test.tsx test(react-router): fix store-updates flakiness (#6454) 2026-01-22 14:57:11 +01:00
useBlocker.test-d.tsx feat(react-router): add useCanGoBack (#3017) 2025-01-03 21:09:58 +01:00
useBlocker.test.tsx fix(router-core): useBlocker navigation issues for 404 pages and external URLs (#4917) 2025-11-23 01:29:13 +01:00
useCanGoBack.test.tsx feat(react-router): add useCanGoBack (#3017) 2025-01-03 21:09:58 +01:00
useLoaderData.test-d.tsx fix: only call head() when loaderData is available (#3410) 2025-02-13 13:06:13 -07:00
useLocation.test-d.tsx feat(react-router): add support for structural sharing for finegrained selectors (#2647) 2024-11-09 22:41:12 +01:00
useMatch.test-d.tsx refactor(router-core): migrate matches and route options to core (#3552) 2025-02-24 23:17:58 +01:00
useMatch.test.tsx feat: Merge alpha to main (#4365) 2025-06-10 23:19:32 +02:00
useNavigate.test-d.tsx fix: make to required if from is not set (#3099) 2025-01-04 18:48:57 +01:00
useNavigate.test.tsx fix(router-core): use encodeURIComponent for splat route params (#6520) 2026-01-26 23:53:20 +02:00
useParams.test-d.tsx feat(react-router): add shouldThrow option to useParams and useSearch (#3368) 2025-02-08 22:36:40 +01:00
useParams.test.tsx refactor(router-core): skip full matchRoutesInternal for Link's buildLocation, use simple getMatchedRoutes (#6445) 2026-01-22 23:24:56 +01:00
useRouteContext.test-d.tsx feat(react-router): add support for structural sharing for finegrained selectors (#2647) 2024-11-09 22:41:12 +01:00
useRouterState.test-d.tsx feat(react-router): add support for structural sharing for finegrained selectors (#2647) 2024-11-09 22:41:12 +01:00
useSearch.test-d.tsx fix: only call head() when loaderData is available (#3410) 2025-02-13 13:06:13 -07:00
utils.ts feat(react-router) add search middleware (#2521) 2024-10-14 20:34:35 +02:00