0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
router/e2e/solid-router
Nico Lynzaad ab12c06634
fix(router-core): parse non-nested path params correctly (#5165)
When parsing path params to interpolate the path non-nested path params
```/path/$param_``` was being parsed in the same manner as regular path
params ```/path/$param```.

This PR adds consideration for the trailing underscore when parsing the
path for non-nested path params as well as unit tests on path
interpolation and e2e tests for useParams to ensure this is parsed
correctly and updates correctly when params change.

This resolves #5164

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- New Features
- Support trailing-underscore non-nested path params (e.g., /users/$id_
→ /users/123).
- UI shows an additional navigation link for the non-nested route
(/params-ps/non-nested/foo2/bar2) and improved link display text.

- Tests
- Expanded React and Solid e2e tests to cover the new link, navigation,
and param parsing for foo2/bar2.
- Added unit tests validating interpolation/matching for the $param_
syntax.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
History 2025-09-18 20:28:01 +02:00
..
basic test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
basic-esbuild-file-based test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
basic-file-based fix(router-core): parse non-nested path params correctly (#5165) 2025-09-18 20:28:01 +02:00
basic-file-based-code-splitting test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
basic-scroll-restoration chore: fix build in CI (#4790) 2025-07-26 21:28:55 +02:00
basic-solid-query test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
basic-solid-query-file-based test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
basic-virtual-file-based test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
basic-virtual-named-export-config-file-based test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
rspack-basic-file-based test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
rspack-basic-virtual-named-export-config-file-based test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00
scroll-restoration-sandbox-vite test(e2e): use locally hosted api over an external provider (#4725) 2025-07-22 00:15:28 +02:00