Commit graph

62 commits

Author SHA1 Message Date
Pete Bacon Darwin
4d90f32531
[ci] Require vouched collaborators for pull requests (#16182)
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
2026-10-09 17:29:26 +01:00
Dario Piotrowicz
3bffc5e4ef
chore: make remote-tests fail if they are from a fork and the ci:run-remote-tests label is set (#15966) 2026-10-05 11:19:12 +01:00
Yiğit Tanrıverdi
2f6008bae6
[docs] Update linting and formatting tool references (#15402) 2026-09-01 15:49:27 +01:00
Ben
6e0e7270f7
fix: repository labels to use new conventions (#14204) 2026-06-05 18:30:57 +00:00
Somhairle MacLeòid
3a746ac56a
[tools] Lint that all non-bundled deps of published packages are pinned (#14112)
Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
2026-06-01 16:00:26 +00:00
omribz156
bcab9bb6b5
docs: document experimental flag naming (#13949) 2026-05-18 10:49:00 +01:00
Somhairle MacLeòid
e25bd0ef64
Update prettier to 3.8.1 (#12939) 2026-03-17 11:41:29 -04:00
Pete Bacon Darwin
f0362f52ad
Gate E2E API token behind Version Packages PR, merge queue, or run-remote-tests label (#12865) 2026-03-13 09:53:15 +00:00
Pete Bacon Darwin
a31ee0b0c7
[workers-playground] Migrate from Cloudflare Pages to Cloudflare Workers (#12655)
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-03-11 13:11:10 +00:00
Somhairle MacLeòid
a7afdd6734
Expand hotfix details (#11953)
* Update CONTRIBUTING.md

* Remove hotfix release section from CONTRIBUTING.md

Removed hotfix release guidelines from CONTRIBUTING.md.
2026-01-19 11:12:36 +00:00
Pete Bacon Darwin
c17e971af0
chore: add CI validation for external package dependencies (#11898)
* chore: add CI validation for external package dependencies

Add a validation check that ensures packages explicitly declare their
external (non-bundled) dependencies to prevent dependency chain poisoning.

- Add tools/deployments/validate-package-dependencies.ts validation script
- Add check:package-deps npm script and integrate into pnpm check
- Create scripts/deps.ts allowlists for packages with external dependencies:
  - miniflare (12 deps)
  - @cloudflare/vite-plugin (8 deps)
  - @cloudflare/vitest-pool-workers (7 deps)
  - @cloudflare/kv-asset-handler (1 dep)
  - @cloudflare/workers-editor-shared (1 dep)
- Update CONTRIBUTING.md with documentation on managing dependencies
- Add unit tests for the validation logic (22 tests)

* fix(kv-asset-handler): bundle mime dependency instead of keeping it external

Move mime from dependencies to devDependencies so it gets bundled into
the distributable. This follows the project's practice of bundling
dependencies to prevent dependency chain poisoning.

* fix(miniflare): bundle acorn and acorn-walk dependencies

Move acorn and acorn-walk from dependencies to devDependencies so they
get bundled into the distributable. These are pure JavaScript parsing
libraries with no special runtime requirements, so they can be safely
bundled.

* chore: bundle more dependencies to reduce supply chain risk

Move 13 dependencies from dependencies to devDependencies so they get
bundled into the distributed packages rather than being installed as
transitive dependencies by users.

Packages updated:
- miniflare: bundle exit-hook, glob-to-regexp, stoppable, youch
- @cloudflare/vitest-pool-workers: bundle birpc, devalue, get-port, semver
- @cloudflare/vite-plugin: bundle @remix-run/node-fetch-server, defu,
  get-port, picocolors, tinyglobby

Also updates the EXTERNAL_DEPENDENCIES comments to explain WHY each
remaining dependency cannot be bundled (native binaries, optional native
bindings, runtime resolution needs) rather than just describing how
they are used.

* fix(vitest-pool-workers): bundle dependencies that were moved to devDependencies

* chore: add changeset for dependency bundling

* fixup: remove unnecessary stuff from CONTRIBUTING
2026-01-14 21:11:35 +00:00
Matt Kane
47dde2e021
ci: use Claude to review changesets (#11599)
* Get Claude to review changesets

* Run on pull_reuest_target

* Extract changeset rules into readme

* Use GitHub API instead of checking out PR code

This avoids the CodeQL security warning about checking out untrusted
code in a privileged workflow. Claude now uses `gh` CLI to inspect
PR contents via the API instead of having the files on disk.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add changeset guidelines to CLAUDE.md

Reference the detailed guidelines in .changeset/README.md and document
the preferred workflow using `pnpm changeset add --empty`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Format

* Apply suggestions from code review

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

* Address review feedback

- Add note about automatic dependency releases (no need to include dependent packages)
- Add CI-only changes to list of things not requiring changesets
- Call out that experimental features should be mentioned in changeset descriptions
- Remove unnecessary id-token permission
- Update prompt to note major version constraints from README
- Instruct Claude to fail the check (exit 1) for blocking issues

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Address additional review feedback

- Change 'workspaces' to 'packages' in README (fixtures aren't relevant)
- Add note that breaking changes to experimental features are not major
- Add use_sticky_comment to avoid multiple comments on the same PR
- Keep direct_prompt (verified correct for beta version)
- Keep GH_TOKEN env for gh CLI compatibility

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Migrate to claude-code-action v1

- Change @beta to @v1
- Change direct_prompt to prompt (per migration guide)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
2025-12-11 14:54:57 +00:00
lrapoport-cf
af6cd39f43
Update CONTRIBUTING.md (#11243)
* Update CONTRIBUTING.md

* Apply suggestion from @ascorbic

Co-authored-by: Matt Kane <m@mk.gg>

---------

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
Co-authored-by: Matt Kane <m@mk.gg>
2025-11-12 12:44:26 +00:00
emily-shen
41dab1f9af
add tldr to contributing (#10417) 2025-09-10 12:32:03 +01:00
Pete Bacon Darwin
64af5da727
Further updates to e2e test running helpers and instructions (#9969)
* further updates to e2e test running helpers and instructions

* Update packages/wrangler/e2e/README.md

Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>

---------

Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
2025-07-15 14:31:36 +01:00
Somhairle MacLeòid
57d3d01e3d
Skip remote E2E tests when no auth available (#9826)
* Make E2E's easier to run locally

* Skip local E2Es

* fork workflow

* Improve contributing docs for E2E

* change spreading
2025-07-03 15:50:13 +00:00
Dario Piotrowicz
81bd41c253
clarify and ensure that for local e2e any account can be used (#9762)
in the CONTRIBUTING.md document clarify the fact that any account
can be used to create an API token for the tests (instead of suggesting
to use DevProd Testing account alongise saying that other accounts can be
used as well)

as part of this remove the unnecessary validation check that ensures
that the account being used for the tests is the DevProd Testing one
(since this is not really necessary)
2025-07-02 15:03:57 +00:00
Pete Bacon Darwin
c2b6f11fd2
Update CONTRIBUTING for hotfixes (#9630)
It is not necessary to create a changeset for the hotfix, this would only trigger another release of the package during the next normal release process. If such a release is necessary it would be triggered by the existence of a changeset for the feature/fix that needs releasing.

What is important is that the version in package.json is equal to the latest released version of the package. If it is behind then any changesets for that package that should trigger a release may only bump the version to the hotfix release version and so would not actually trigger a release of that package.
2025-06-17 17:36:42 +02:00
Somhairle MacLeòid
a9375723e8
Migrate prereleases to pkg-pr-new (#9492)
* try out pkg-pr-new

* try again

* compact

* versions

* fully migrate

* fix name

* it's a tool

* mjs

* label

* label

* label

* add env

* indent

* Update prerelease.yml

* Update prerelease.yml
2025-06-05 17:30:14 +00:00
lrapoport-cf
6331e985b3
Update types of changes in contrib guide (#8855) 2025-04-08 16:09:57 -04:00
Somhairle MacLeòid
a3d9d64f68
add label customisation (#8284) 2025-02-27 14:54:18 +00:00
Somhairle MacLeòid
23be4f4536
Hotfix action (#8192)
* Hotfix action

* Update CONTRIBUTING.md

* Apply suggestions from code review

Co-authored-by: lrapoport-cf <107272160+lrapoport-cf@users.noreply.github.com>

* format

* Update CONTRIBUTING.md

Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>

* Update .github/workflows/hotfix-release.yml

Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>

* Update CONTRIBUTING.md

* fix formatting

---------

Co-authored-by: lrapoport-cf <107272160+lrapoport-cf@users.noreply.github.com>
Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>
2025-02-27 10:45:14 +00:00
Pete Bacon Darwin
419b93d4e7
Update contributing guide (#8110)
* Fix linting

* chore: update CONTRIBUTING guide and root test script

* feedback fixes

---------

Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>
2025-02-19 14:00:37 +01:00
Somhairle MacLeòid
79418d4b3b
Add a section on Git hygiene (#7960) 2025-01-29 13:27:02 +00:00
Sakib Hasan
806cee8467
chore(CONTRIBUTING.md): fix invalid link (#7829) 2025-01-20 18:53:50 +01:00
Andy Jessop
17c2cdd90f
docs: clarify difference between external contributors and Cloudflare employees (#7660)
* docs: clarify difference between external contributors and Cloudflare employees

* chore: update wording on write access

* chore: run prettier
2025-01-08 20:01:53 +00:00
Somhairle MacLeòid
8937b01df9
Use pnpm changeset in contributing guide (#7496) 2024-12-10 11:08:28 +01:00
Andy Jessop
f1f508ec1a
chore: change wrangler-devtools name to workers-devtools (#7258)
chore: add changeset

chore: update lock file

chore: update formatting

chore: fix snapshot tests
2024-11-19 19:41:56 +01:00
Somhairle MacLeòid
0c0606c2af
Clarify preview:... labels (#7174) 2024-11-05 18:33:48 +00:00
Somhairle MacLeòid
020b049212
Relax changeset format docs (#6984)
* Relax changeset format docs

* relax linting

* fix test
2024-10-17 11:52:48 +01:00
Somhairle MacLeòid
f866217bb3
Add link to Vitest & Ava docs (#6983) 2024-10-15 14:44:46 +01:00
Enoch
083dfb70cb
fix: Update CONTRIBUTING.md (#6638) 2024-09-13 11:43:58 +02:00
Victor Berchet
2d080df3b6
Update CONTRIBUTING.md (#6592)
Minor updates to CONTRIBUTING.md
2024-09-13 10:39:53 +02:00
Pete Bacon Darwin
68fac09dbd
chore: change vitest config to be ESM (for sure) to avoid warnings (#6055)
Without this we often see:

```
 The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
```
2024-06-18 12:32:03 +01:00
Somhairle MacLeòid
db4930586e
Jest -> Vitest (#5896)
* So long, and thanks for all the fish
2024-05-22 20:14:06 +01:00
dbenCF
bbb9ea7062
CLI Styleguide Markdown file (#5206)
* Add Wrangler styleguide to repo

* Fix styleguide formatting

* Fix more formatting of styleguide

* Fix typos and change headings

* add changeset file

* Update CONTRIBUTING.md and STYLEGUIDE.md

* Fix typos

* Add C3 prompt convention

* Add copy to prompt guidelines

* Updating description contnet

* Update heading description

* Update command syntax in STYLEGUIDE.md

Co-authored-by: MrBBot <me@mrbbot.dev>

* Update CONTRIBUTING.md

Co-authored-by: MrBBot <me@mrbbot.dev>

* deleted unecessary changeset

* update with npm fix

* Update STYLEGUIDE.md

Co-authored-by: MrBBot <me@mrbbot.dev>

---------

Co-authored-by: MrBBot <me@mrbbot.dev>
2024-04-05 13:52:54 +01:00
Charl Kruger
9e60c7ee53
Update CONTRIBUTING.md communicate type (#5404)
Was a type so changing commnicate -> communicate
2024-03-27 10:25:19 +00:00
Rahul Sethi
c5135224f5
Add e2e tests for Versions (#5329)
* add e2e tests for Versions

* add how to run e2e tests locally to CONTRIBUTING.md

* fix: don't print `undefined` in spinner.stop in non-interactive environments
2024-03-20 20:58:50 +00:00
Pete Bacon Darwin
594d688b1d
Deploy non-npm packages via changesets (#5130)
* Rename and improve docs around Preview Playground Worker integration test workflow

* Remove workflows that deployed Workers to production

These implemented the `deploy-worker/...` branch approach
which is being replaced.

* Update Pages preview deployment workflows

The reusable action has been removed and the workflow simplified.
It is no longer triggered by changes to `main`, since that will be handled by changesets going forward.

* Implement non-npm package deployments via changesets

* Remove deployment of pre-release Worker from the pre-release workflow

This should now be handled by changesets

* Update Github Actions docs

* Ensure C3 e2e tests run on PRs and main

* fixup! Update Github Actions docs

* fixup! Implement non-npm package deployments via changesets

* fixup! Implement non-npm package deployments via changesets
2024-03-05 15:15:45 +00:00
lrapoport-cf
04b37fc242
Add "before getting started" section to contributing guide (#5142)
* Add section to contributing guide

* Fix formatting
2024-03-05 09:46:11 -05:00
Dario Piotrowicz
3cb2a8a05f
remove outdated and no longer valid miniflare development section from CONTRIBUTING.md (#4893) 2024-02-01 14:33:10 +00:00
Pete Bacon Darwin
e4011b1481
chore: inherit vitest settings from the root (#4800) 2024-01-22 17:04:46 +00:00
Somhairle MacLeòid
199e1a127f
Add test docs (#4435)
Co-authored-by: lrapoport-cf <107272160+lrapoport-cf@users.noreply.github.com>
2023-11-21 18:28:47 +00:00
Somhairle MacLeòid
0938e257b2
Migrate to pnpm (#3889)
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
Co-authored-by: James <jculveyhouse@cloudflare.com>
2023-09-06 16:08:36 +01:00
lrapoport-cf
2d82ef786c
Add instruction about highlight pr review (#3682)
Co-authored-by: MrBBot <bcoll@cloudflare.com>
2023-07-31 10:34:12 -04:00
Jacob M-G Evans
05099f4c9f
Turborepo Implementation & Monorepo standardization (#3261)
* Turborepo 
- Turbo Workspaces: isolated tasks and localized pipelines more complex packages to exist in the monorepo.
- Persistent mode for dev keyword let's Turborepo know it's something that will be watched or run long term.
- Update all packages with namespaced ones for configs
- Namespacing TSConfig & ESlint with `@Cloudflare/` per security suggestion by Greg Brimble

* ESLint and TSConfig Monorepo Configuration
   - ESLint & TSConfig are local packages, the monorepo now isolates its configs to packages utilizing them, 
      configurations are now monorepo packages
   -  Type Checking TypeScript can now directly
       use the TSConfig which infers from valid TS config formats, since we are using Monorepo conventions each 
       package only needs to care about its own config specifics and the extended global config as a package.
   - Wrangler Emit TSConfig: Figure out if this can be part of the TurboRepo pipeline then move this into the workers- 
      tsconfig package as "wrangler-emit"
   - TurboRepo setup to work with TypeScript subdirectories as TS projects & added configs to more fixtures
   - Instructions for VSCode TypeScript Project Version
   - ESLint & Turbo require the `.` declared where to run monorepo tasks from each package

* Dependencies 
  - Adding Wrangler as direct Dependency for Fixtures that need it
  - Standardize Monorepo packaging in Fixtures 
  - All Wrangler dependencies are now devDependency

* Vitest
   - Update Vitest & remove global Vitest config
   - Added Vitest script for explicit test:watch
   - Refactor pages-simple-assets test
   - Fix tests in fixtures (thanks @petebacondarwin)
2023-06-12 12:57:01 -05:00
James Ross
ab2cdf4c6b
chore: rename repo in contributing guidelines (#3404) 2023-06-06 12:49:47 -05:00
MrBBot
3b3fadfa16 [wrangler] feature: rename publish command to deploy and alias (#3190)
* feature: rename `publish` command to `deploy` and alias

This renames `wrangler (pages) publish` to `wrangler (pages) deploy`,
and adds a deprecated alias for `publish`. We'll remove this alias
in Wrangler 4.

* fixup! feature: rename `publish` command to `deploy` and alias

Rename `publish` directory too

* fixup! feature: rename `publish` command to `deploy` and alias

Fix import order lint errors
2023-05-17 14:08:28 +01:00
lrapoport-cf
a48711659e
Add release note to CONTRIBUTING (#3093) 2023-04-26 20:26:41 -04:00
Somhairle MacLeòid
26d8066ad1
Update CONTRIBUTING.md (#2782) 2023-02-23 12:08:52 +00:00