* Notify when security advisories are submitted to workers-sdk
* Use repository_advisory event instead of security_advisory
* add description to body
* Add devprod status bot to COFS exceptions
The quick-edit deployment does not hit the production dashboard until a
change is made to the internal dashboard project, so it is safe to
deploy this worker via the changeset-triggered deployment process.
* chore: add CI validation for external package dependencies
Add a validation check that ensures packages explicitly declare their
external (non-bundled) dependencies to prevent dependency chain poisoning.
- Add tools/deployments/validate-package-dependencies.ts validation script
- Add check:package-deps npm script and integrate into pnpm check
- Create scripts/deps.ts allowlists for packages with external dependencies:
- miniflare (12 deps)
- @cloudflare/vite-plugin (8 deps)
- @cloudflare/vitest-pool-workers (7 deps)
- @cloudflare/kv-asset-handler (1 dep)
- @cloudflare/workers-editor-shared (1 dep)
- Update CONTRIBUTING.md with documentation on managing dependencies
- Add unit tests for the validation logic (22 tests)
* fix(kv-asset-handler): bundle mime dependency instead of keeping it external
Move mime from dependencies to devDependencies so it gets bundled into
the distributable. This follows the project's practice of bundling
dependencies to prevent dependency chain poisoning.
* fix(miniflare): bundle acorn and acorn-walk dependencies
Move acorn and acorn-walk from dependencies to devDependencies so they
get bundled into the distributable. These are pure JavaScript parsing
libraries with no special runtime requirements, so they can be safely
bundled.
* chore: bundle more dependencies to reduce supply chain risk
Move 13 dependencies from dependencies to devDependencies so they get
bundled into the distributed packages rather than being installed as
transitive dependencies by users.
Packages updated:
- miniflare: bundle exit-hook, glob-to-regexp, stoppable, youch
- @cloudflare/vitest-pool-workers: bundle birpc, devalue, get-port, semver
- @cloudflare/vite-plugin: bundle @remix-run/node-fetch-server, defu,
get-port, picocolors, tinyglobby
Also updates the EXTERNAL_DEPENDENCIES comments to explain WHY each
remaining dependency cannot be bundled (native binaries, optional native
bindings, runtime resolution needs) rather than just describing how
they are used.
* fix(vitest-pool-workers): bundle dependencies that were moved to devDependencies
* chore: add changeset for dependency bundling
* fixup: remove unnecessary stuff from CONTRIBUTING
* ci: make the release failure alert resilient to missing `DEPLOYMENT_STATUS`
If the npm release fails then the non-npm release is not even attempted.
In which case the `DEPLOYMENT_STATUS` is empty, which was causing the JSON parsing to fail and no alert to be sent.
* Apply suggestion from @edmundhung
---------
Co-authored-by: Edmund Hung <edmund@cloudflare.com>
Something about the `per_page` parameter seems to cause the listing of Pages projects to respond with a 400 Bad Request. Removing it and going with the default seems fine.
We will now retry wrangler e2e tests up to 4 times.
Also we batch them up so that we don't necessarily retry the previously failed test immediately, since this could actually be a source of the flake.
* change basic actions to use single cpu runners
* rename C3 e2e job to distinguish it from wrangler e2e
* move creation of the worker needed for C3 e2e into the test
* simplify c3 e2e matrix; skipping yarn and experimental jobs
* split c3 e2e tests
* improve resilience of snapshots to time-ago messages
* Update email and PM assignments for pages
@dcartertwo and I can help on this part with issues that come in
* remove reference to label that was removed already
---------
Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com>
* iterative improvements to the auto-assigner
* add initial ANT assignees
* fixup! add initial ANT assignees
* fixup! iterative improvements to the auto-assigner
* Auto-assign issues via a GitHub Action
Runs whenever a new label is added to an issue.
If that label has a team configured for it, then it will assign all the configured team members to the issue.
* clean up
---------
Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com>
* add `@cloudflare/` scope to all private packages and rename root package
* move `::group::` inside then
* update blob and fixtures ignoring
* revert incorrect `::group::` change
* use `@cloudflare/vite-plugin-e2e-` as suggested in PR
* update import-example fixture package name
* chore: improvements to remote-bindings tests to reduce flakes
* retry wrangler-remote-resources checks a few times
* move the getPlatformProxy remote-bindings tests to the e2e CI job
* move `startDev` into its own module so it is possible to mock it
* move `startRemoteProxySession` into its own module so it is possible to mock it
* add missing types to `Binding` type
* add missing `remote` property and update jsdoc for Config type
* Allow config watching in unit tests
The tests were previously failing because the controller had not been been torn down before the end of the test, rather than the actual watching being a problem in itself.
When the tests end, the current working directory gets reverted from the temporary directory that was created for it. Since the controller had not been torn down, the config file change triggered a config change event which then tries to read the config from the wrong current working directory, causing an exception.
* Remove wrangler-remote-resources e2e test
This is now covered by a combination of:
- `packages/wrangler/e2e/remote-binding/miniflare-remote-resources.test.ts` - actually tests that we can create, deploy and connect to the remote dev session worker.
- `packages/wrangler/src/__tests__/dev/remote-bindings.test.ts` - tests that we generate the correct config for the remote session proxy worker and local miniflare session.
The removed e2e test was very flaky and slow as it required creating and deleting a lot of resources in Cloudflare.
The new test runs entirely without any dependency on Cloudflare and is super fast (<20 secs).
* add Wrangler remote bindings unit tests
* ensure configcontroller is torn down before tmp directory is deleted
* wait for config watching to be updated
* ignore changes if the watcher is closed
* Allow the "too large" upload test more time to pass
Sometimes timesout on Windows
* abort if this config controller is no longer viable
* remove unnecessary `console.dir()` calls in tests
* update ubuntu in CI tests
* run wrangler tests before fixtures
* Update packages/wrangler/e2e/helpers/e2e-wrangler-test.ts
Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>
* run all linux tests on ubuntu 24
---------
Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>
* ci: ensure existing-script-test-do-not-delete worker exists before C3 E2E tests
Add deployment step to create-cloudflare E2E workflow that deploys the
existing-script-test-do-not-delete worker before tests run. This ensures
the worker exists with the correct configuration (FOO=bar variable and
Hello World response) that the --existing-script test relies on.
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Address PR feedback: use wrangler.jsonc, handle fork PRs, check worker existence
- Convert wrangler.toml to wrangler.jsonc format as requested
- Add condition to skip deployment if TEST_CLOUDFLARE_ACCOUNT_ID is not set (handles fork PRs)
- Check if worker exists before deploying to avoid unnecessary deployments
Addresses feedback from @petebacondarwin in PR comments.
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Fix worker URL in curl existence check
Use the correct worker URL https://existing-script-test-do-not-delete.devprod-testing7928.workers.dev
as specified by @petebacondarwin in PR comment feedback.
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Update condition to check for API token instead of account ID
Change from env.TEST_CLOUDFLARE_ACCOUNT_ID to secrets.TEST_CLOUDFLARE_API_TOKEN
as suggested by @petebacondarwin in PR comment feedback.
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Trigger CI to pick up no-changeset-required label
This empty commit forces CI to re-run with the no-changeset-required label
that was added to the PR after the last commit.
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Fix GitHub Actions YAML syntax error in worker deployment condition
Replace invalid secrets.TEST_CLOUDFLARE_API_TOKEN check with proper fork detection
pattern used elsewhere in the repository.
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Refactor CI to use permanent test worker files from tools/test-workers/
- Move worker definition from inline CI creation to tools/test-workers/existing-script-test-do-not-delete/
- Update C3 E2E workflow to reference permanent worker files instead of creating temporary ones
- Add documentation for test workers in tools/README.md
- Create deploy-all.sh script for future extensibility
- Add .eslintignore to exclude test worker files from strict TypeScript linting
- Maintain same deployment logic with existence check and fork PR handling
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Address PR feedback: convert deployment script to TypeScript and use separate CI job
- Convert tools/test-workers/deploy-all.sh to TypeScript using Node.js patterns
- Move environment variable checks and fetch-based existence check into TypeScript script
- Refactor CI workflow to use separate 'deploy-test-workers' job with needs: dependency
- Use 'node -r esbuild-register' execution pattern following tools/package.json conventions
- Remove trigger_ci.md file which was only for triggering CI
- Maintain all existing functionality while improving maintainability
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Trigger fresh CI validation
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Remove temporary trigger file
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Fix linting issues: remove unused error variable and enable allowJs for test workers
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Add documentation for deploy-all script as requested in PR feedback
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Update README with deploy-all documentation
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* Fix unused @ts-expect-error directive in changeset-version.test.ts
The directive was no longer needed after enabling allowJs in TypeScript config,
causing a compilation error in CI checks.
Co-Authored-By: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* use `pnpx` rather than `npx`
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: pbacondarwin@cloudflare.com <pete@bacondarwin.com>
* update eslint versions and ban direct console usage in Wrangler, Miniflare and C3
* fixup! update eslint versions and ban direct console usage in Wrangler, Miniflare and C3
* fixup! update eslint versions and ban direct console usage in Wrangler, Miniflare and C3
* fixup! update eslint versions and ban direct console usage in Wrangler, Miniflare and C3
* rebase catchups of new eslint errors