mirror of
https://github.com/imputnet/helium.git
synced 2026-11-17 18:59:24 +00:00
[Bug]: [Cosmetic] Misaligned Tab and MacOS Window Button on Custom Themes #2874
Labels
No labels
approved
approved
approved
bad ux
bot:review
bot:size
bug
bug
bug
can't replicate
can't replicate
can't replicate
confirmed
confirmed
confirmed
external
feat
feat
feat
good first issue
good first issue
good first issue
invalid
invalid
invalid
needs more info
needs more info
needs more info
pending
pending
pending
upstream
upstream
upstream
WAI
WAI
WAI
wontfix
wontfix
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
imputnet/helium#2874
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Operating system
macOS
Version
0.20.2.1 (Official Build, Chromium 156.0.8078.73) (arm64)
Have you tested that this is not an upstream issue or an issue with your configuration?
--user-data-dircommand line argument and it could not be reproduced thereDescription
There's a height mismatch in the Tab Layout of Helium's Classic Layout. Where there is a height mismatch between the Forward and Back button container and the Address bar container height (Depends on how you look at it, it could also be that the tab container height is larger than the MacOS window manager buttons container height). This is noticeable when using custom themes. I have added steps to reproduce.
Crash ID
No response
How to Reproduce?
NB: Make sure in helium://settings/ you are using the Classic Layout.
I have attached screenshots to show this in action
Helium

Chrome
Actual behavior
There's a simple ui/visual height mismatch between the back/forward button container and the address bar container when using custom themes
Expected behavior
There heights between the address bar container and the forward and back button should be uniform. and the height of both the tab layout and the window manager button (container) should be uniform.
Additional context
Reproduced a similar Classic-layout misalignment on Linux (Omarchy, Helium 0.21.2.1 / Chromium 157.0.8103.50). This investigation was assisted by Codex; the macOS case has not been tested.
Before / after
These are actual native browser screenshots at 2× scale. The “after” image uses a runtime geometry adjustment, not a rebuilt binary.
Before:
After:
Finding and proposed change
In
BrowserViewTabbedLayoutImpl::CalculateProposedLayout, the non-dynamic horizontal-tab path subtractskHeliumBasePadding(3 logical pixels) from the tab-strip bottom to position the toolbar. Helium's dedicatedkTabstripToolbarOverlapis 0. With contrasting frame/toolbar colours, that overlap produces the stepped background beneath the window controls and reduces the space above the address bar. No font metrics needed changing in the runtime experiment.Proposed change in
chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc(the released source after applying Helium's patch series):This retains the frameless-animation scaling and leaves the separate Dynamic-layout calculation unchanged.
Source references at the tested release's shared-source commit: dynamic.patch, layout constants, and zen-mode.patch.
Verification
Used the released binary mounted read-only in a network-isolated Docker container with Xvfb/Openbox, fresh disposable profiles and a synthetic contrasting theme. The everyday installation and profile were unchanged.
Chromium's native UI DevTools reported the tab-strip region at y=0, height=34, and
TopContainerViewat y=31. Moving only that container to y=34 removed both visible symptoms; restoring y=31 brought them back. Bounds were read back after each change, and screenshot pixel assertions measured the frame-background step.The affected source file was reconstructed from Chromium 157.0.8103.50 plus all 10 applicable release patches, in series order, with zero fuzz. The candidate patch passed forward and reverse dry-run application checks.
Limit: this is native runtime geometry verification, not a compiled patched browser. The inspector manually applies the proposed toolbar position; it does not execute the changed C++. Resizing, fullscreen, animation, dependent content layout and macOS still need validation in a rebuilt browser.
History
The 4 November update to frame-background.patch changed offsets and a build dependency, not painting behaviour. The 12 October theme changes switched tab-strip backgrounds to the frame theme and likely made the existing overlap visible. The base-padding substitution dates to this March change. No historical-binary bisect was performed, so this does not establish a first bad release.
Reproduced a similar Classic-layout misalignment on Linux (Omarchy, Helium 0.21.2.1 / Chromium 157.0.8103.50). This investigation was assisted by Codex; the macOS case has not been tested.
Before / after
These are actual native browser screenshots at 2× scale. The “after” image uses a runtime geometry adjustment, not a rebuilt binary.
Before:
After:
Finding and proposed change
In
BrowserViewTabbedLayoutImpl::CalculateProposedLayout, the non-dynamic horizontal-tab path subtractskHeliumBasePadding(3 logical pixels) from the tab-strip bottom to position the toolbar. Helium's dedicatedkTabstripToolbarOverlapis 0. With contrasting frame/toolbar colours, that overlap produces the stepped background beneath the window controls and reduces the space above the address bar. No font metrics needed changing in the runtime experiment.Proposed change in
chrome/browser/ui/views/frame/layout/browser_view_tabbed_layout_impl.cc(the released source after applying Helium's patch series):This retains the frameless-animation scaling and leaves the separate Dynamic-layout calculation unchanged.
Source references at the tested release's shared-source commit: dynamic.patch, layout constants, and zen-mode.patch.
Verification
Used the released binary mounted read-only in a network-isolated Docker container with Xvfb/Openbox, fresh disposable profiles and a synthetic contrasting theme. The everyday installation and profile were unchanged.
Chromium's native UI DevTools reported the tab-strip region at y=0, height=34, and
TopContainerViewat y=31. Moving only that container to y=34 removed both visible symptoms; restoring y=31 brought them back. Bounds were read back after each change, and screenshot pixel assertions measured the frame-background step.The affected source file was reconstructed from Chromium 157.0.8103.50 plus all 10 applicable release patches, in series order, with zero fuzz. The candidate patch passed forward and reverse dry-run application checks.
Limit: this is native runtime geometry verification, not a compiled patched browser. The inspector manually applies the proposed toolbar position; it does not execute the changed C++. Resizing, fullscreen, animation, dependent content layout and macOS still need validation in a rebuilt browser.
History
The 4 November update to frame-background.patch changed offsets and a build dependency, not painting behaviour. The 12 October theme changes switched tab-strip backgrounds to the frame theme and likely made the existing overlap visible. The base-padding substitution dates to this March change. No historical-binary bisect was performed, so this does not establish a first bad release.
Also happening on Windows 11 (25H2), Helium 0.21.2.1, 150% scaling.
Using: classic layout, custom theme with frame 31,31,31 and toolbar 52,52,52.
The step under the caption buttons measures 4 physical px, consistent with the 3 logical px overlap identified above.