2019-06-04 10:11:33 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-09-03 15:24:57 +03:00
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
2021-06-23 13:05:47 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-07-15 11:47:34 -04:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2007-09-17 11:56:21 -07:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2009-04-23 18:52:52 +02:00
|
|
|
|
2008-04-08 15:14:40 -04:00
|
|
|
|
2008-02-23 15:17:11 +01:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
cfg80211: rework key operation
This reworks the key operation in cfg80211, and now only
allows, from userspace, configuring keys (via nl80211)
after the connection has been established (in managed
mode), the IBSS been joined (in IBSS mode), at any time
(in AP[_VLAN] modes) or never for all the other modes.
In order to do shared key authentication correctly, it
is now possible to give a WEP key to the AUTH command.
To configure static WEP keys, these are given to the
CONNECT or IBSS_JOIN command directly, for a userspace
SME it is assumed it will configure it properly after
the connection has been established.
Since mac80211 used to check the default key in IBSS
mode to see whether or not the network is protected,
it needs an update in that area, as well as an update
to make use of the WEP key passed to auth() for shared
key authentication.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-07-08 14:22:54 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2014-01-20 23:55:44 +01:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2009-01-22 15:05:53 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2020-09-21 19:28:14 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-02-25 16:27:43 +01:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2011-11-16 15:28:55 +01:00
|
|
|
|
2009-03-23 17:28:35 +01:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2011-11-16 15:28:55 +01:00
|
|
|
|
2009-03-23 17:28:35 +01:00
|
|
|
|
|
|
|
|
|
2011-11-16 15:28:55 +01:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-12-19 01:31:26 +01:00
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2008-01-24 19:38:38 +01:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-01-24 19:38:38 +01:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
|
|
|
|
|
2008-10-11 01:51:51 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2008-01-24 19:38:38 +01:00
|
|
|
|
2012-04-11 08:47:56 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-12-19 01:31:26 +01:00
|
|
|
|
|
|
|
|
|
2008-05-15 12:55:29 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-12-28 14:32:58 +01:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-05-15 12:55:27 +02:00
|
|
|
|
|
|
|
|
|
2012-04-11 08:47:56 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-07-27 15:43:24 +02:00
|
|
|
|
2008-05-15 12:55:29 +02:00
|
|
|
|
2008-01-24 19:38:38 +01:00
|
|
|
|
|
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
|
|
|
|
|
2008-10-11 01:51:51 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-12-19 01:31:26 +01:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-05-15 12:55:29 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-12-28 14:32:58 +01:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-05-15 12:55:27 +02:00
|
|
|
|
|
|
|
|
|
2012-04-11 08:47:56 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-07-27 15:43:24 +02:00
|
|
|
|
2008-05-15 12:55:29 +02:00
|
|
|
|
2008-01-24 19:38:38 +01:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
|
|
|
|
|
2008-10-11 01:51:51 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2008-09-12 22:52:47 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2008-05-15 12:55:29 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2013-07-08 16:55:51 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-10-01 13:19:23 +02:00
|
|
|
|
|
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-09-14 18:00:34 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-10-01 13:19:23 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
2019-10-01 13:19:23 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-10-01 13:19:23 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
2019-10-01 13:19:23 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
2019-10-01 13:19:23 +02:00
|
|
|
|
|
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-11-03 14:48:18 +05:30
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
2020-11-03 14:48:18 +05:30
|
|
|
|
|
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-07-04 12:49:59 +02:00
|
|
|
|
|
|
|
|
|
2016-05-19 10:37:48 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-07-04 12:49:59 +02:00
|
|
|
|
|
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-06-18 20:07:15 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-07-04 12:49:59 +02:00
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-04-07 16:48:40 +02:00
|
|
|
|
|
|
|
|
|
2009-03-23 17:28:42 +01:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
2012-03-28 11:04:27 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-11-24 15:29:53 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
2015-11-24 15:29:53 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
2015-11-24 15:29:53 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: fix aggregation for hardware with ampdu queues
Hardware with AMPDU queues currently has broken aggregation.
This patch fixes it by making all A-MPDUs go over the regular AC queues,
but keeping track of the hardware queues in mac80211. As a first rough
version, it actually stops the AC queue for extended periods of time,
which can be removed by adding buffering internal to mac80211, but is
currently not a huge problem because people rarely use multiple TIDs
that are in the same AC (and iwlwifi currently doesn't operate as AP).
This is a short-term fix, my current medium-term plan, which I hope to
execute soon as well, but am not sure can finish before .30, looks like
this:
1) rework the internal queuing layer in mac80211 that we use for
fragments if the driver stopped queue in the middle of a fragmented
frame to be able to queue more frames at once (rather than just a
single frame with its fragments)
2) instead of stopping the entire AC queue, queue up the frames in a
per-station/per-TID queue during aggregation session initiation,
when the session has come up take all those frames and put them
onto the queue from 1)
3) push the ampdu queue layer abstraction this patch introduces in
mac80211 into the driver, and remove the virtual queue stuff from
mac80211 again
This plan will probably also affect ath9k in that mac80211 queues the
frames instead of passing them down, even when there are no ampdu queues.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-02-12 00:51:53 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-03-22 13:42:43 -07:00
|
|
|
|
|
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
2010-03-22 13:42:43 -07:00
|
|
|
|
|
|
|
|
|
2009-06-17 17:43:56 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
mac80211: fix aggregation for hardware with ampdu queues
Hardware with AMPDU queues currently has broken aggregation.
This patch fixes it by making all A-MPDUs go over the regular AC queues,
but keeping track of the hardware queues in mac80211. As a first rough
version, it actually stops the AC queue for extended periods of time,
which can be removed by adding buffering internal to mac80211, but is
currently not a huge problem because people rarely use multiple TIDs
that are in the same AC (and iwlwifi currently doesn't operate as AP).
This is a short-term fix, my current medium-term plan, which I hope to
execute soon as well, but am not sure can finish before .30, looks like
this:
1) rework the internal queuing layer in mac80211 that we use for
fragments if the driver stopped queue in the middle of a fragmented
frame to be able to queue more frames at once (rather than just a
single frame with its fragments)
2) instead of stopping the entire AC queue, queue up the frames in a
per-station/per-TID queue during aggregation session initiation,
when the session has come up take all those frames and put them
onto the queue from 1)
3) push the ampdu queue layer abstraction this patch introduces in
mac80211 into the driver, and remove the virtual queue stuff from
mac80211 again
This plan will probably also affect ath9k in that mac80211 queues the
frames instead of passing them down, even when there are no ampdu queues.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-02-12 00:51:53 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2010-01-05 18:00:58 +01:00
|
|
|
|
2012-07-04 12:49:59 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2010-04-07 16:48:40 +02:00
|
|
|
|
|
|
|
|
|
2009-03-23 17:28:42 +01:00
|
|
|
|
|
|
|
|
|
mac80211: fix aggregation for hardware with ampdu queues
Hardware with AMPDU queues currently has broken aggregation.
This patch fixes it by making all A-MPDUs go over the regular AC queues,
but keeping track of the hardware queues in mac80211. As a first rough
version, it actually stops the AC queue for extended periods of time,
which can be removed by adding buffering internal to mac80211, but is
currently not a huge problem because people rarely use multiple TIDs
that are in the same AC (and iwlwifi currently doesn't operate as AP).
This is a short-term fix, my current medium-term plan, which I hope to
execute soon as well, but am not sure can finish before .30, looks like
this:
1) rework the internal queuing layer in mac80211 that we use for
fragments if the driver stopped queue in the middle of a fragmented
frame to be able to queue more frames at once (rather than just a
single frame with its fragments)
2) instead of stopping the entire AC queue, queue up the frames in a
per-station/per-TID queue during aggregation session initiation,
when the session has come up take all those frames and put them
onto the queue from 1)
3) push the ampdu queue layer abstraction this patch introduces in
mac80211 into the driver, and remove the virtual queue stuff from
mac80211 again
This plan will probably also affect ath9k in that mac80211 queues the
frames instead of passing them down, even when there are no ampdu queues.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-02-12 00:51:53 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-03-28 11:04:27 +02:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2010-01-05 18:00:58 +01:00
|
|
|
|
2012-07-04 12:49:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-01-05 18:00:58 +01:00
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-06-18 20:07:15 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-07-04 12:49:59 +02:00
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
mac80211: add stop/start logic for software TXQs
Sometimes, it is required to stop the transmissions momentarily and
resume it later; stopping the txqs becomes very critical in scenarios where
the packet transmission has to be ceased completely. For example, during
the hardware restart, during off channel operations,
when initiating CSA(upon detecting a radar on the DFS channel), etc.
The TX queue stop/start logic in mac80211 works well in stopping the TX
when drivers make use of netdev queues, i.e, when Qdiscs in network layer
take care of traffic scheduling. Since the devices implementing
wake_tx_queue can run without Qdiscs, packets will be handed to mac80211
directly without queueing them in the netdev queues.
Also, mac80211 does not invoke any of the
netif_stop_*/netif_wake_* APIs if wake_tx_queue is implemented.
Since the queues are not stopped in this case, transmissions can continue
and this will impact negatively on the operation of the wireless device.
For example,
During hardware restart, we stop the netdev queues so that packets are
not sent to the driver. Since ath10k implements wake_tx_queue,
TX queues will not be stopped and packets might reach the hardware while
it is restarting; this can make hardware unresponsive and the only
possible option for recovery is to reboot the entire system.
There is another problem to this, it is observed that the packets
were sent on the DFS channel for a prolonged duration after radar
detection impacting the channel closing time.
We can still invoke netif stop/wake APIs when wake_tx_queue is implemented
but this could lead to packet drops in network layer; adding stop/start
logic for software TXQs in mac80211 instead makes more sense; the change
proposed adds the same in mac80211.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2018-07-11 00:12:53 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
|
|
|
|
|
2010-01-05 18:00:58 +01:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
mac80211: fix aggregation for hardware with ampdu queues
Hardware with AMPDU queues currently has broken aggregation.
This patch fixes it by making all A-MPDUs go over the regular AC queues,
but keeping track of the hardware queues in mac80211. As a first rough
version, it actually stops the AC queue for extended periods of time,
which can be removed by adding buffering internal to mac80211, but is
currently not a huge problem because people rarely use multiple TIDs
that are in the same AC (and iwlwifi currently doesn't operate as AP).
This is a short-term fix, my current medium-term plan, which I hope to
execute soon as well, but am not sure can finish before .30, looks like
this:
1) rework the internal queuing layer in mac80211 that we use for
fragments if the driver stopped queue in the middle of a fragmented
frame to be able to queue more frames at once (rather than just a
single frame with its fragments)
2) instead of stopping the entire AC queue, queue up the frames in a
per-station/per-TID queue during aggregation session initiation,
when the session has come up take all those frames and put them
onto the queue from 1)
3) push the ampdu queue layer abstraction this patch introduces in
mac80211 into the driver, and remove the virtual queue stuff from
mac80211 again
This plan will probably also affect ath9k in that mac80211 queues the
frames instead of passing them down, even when there are no ampdu queues.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-02-12 00:51:53 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-07-27 10:33:31 +02:00
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
2009-07-27 10:33:31 +02:00
|
|
|
|
|
|
|
|
|
2012-10-10 22:40:23 +02:00
|
|
|
|
2009-07-27 10:33:31 +02:00
|
|
|
|
|
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2009-06-17 17:43:56 +02:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-20 11:19:58 +01:00
|
|
|
|
|
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-09-29 16:04:30 +02:00
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-07-27 10:33:31 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-10-10 22:40:23 +02:00
|
|
|
|
2009-07-27 10:33:31 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-03 16:28:50 +02:00
|
|
|
|
2012-03-28 11:04:28 +02:00
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2012-03-28 11:04:28 +02:00
|
|
|
|
2009-06-17 17:43:56 +02:00
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
|
|
|
|
|
2009-06-17 17:43:56 +02:00
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
2009-06-07 21:58:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-07-24 21:02:04 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-06-17 17:43:56 +02:00
|
|
|
|
|
|
|
|
|
mac80211: fix aggregation for hardware with ampdu queues
Hardware with AMPDU queues currently has broken aggregation.
This patch fixes it by making all A-MPDUs go over the regular AC queues,
but keeping track of the hardware queues in mac80211. As a first rough
version, it actually stops the AC queue for extended periods of time,
which can be removed by adding buffering internal to mac80211, but is
currently not a huge problem because people rarely use multiple TIDs
that are in the same AC (and iwlwifi currently doesn't operate as AP).
This is a short-term fix, my current medium-term plan, which I hope to
execute soon as well, but am not sure can finish before .30, looks like
this:
1) rework the internal queuing layer in mac80211 that we use for
fragments if the driver stopped queue in the middle of a fragmented
frame to be able to queue more frames at once (rather than just a
single frame with its fragments)
2) instead of stopping the entire AC queue, queue up the frames in a
per-station/per-TID queue during aggregation session initiation,
when the session has come up take all those frames and put them
onto the queue from 1)
3) push the ampdu queue layer abstraction this patch introduces in
mac80211 into the driver, and remove the virtual queue stuff from
mac80211 again
This plan will probably also affect ath9k in that mac80211 queues the
frames instead of passing them down, even when there are no ampdu queues.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-02-12 00:51:53 +01:00
|
|
|
|
2009-03-23 17:28:42 +01:00
|
|
|
|
|
|
|
|
|
mac80211: fix aggregation for hardware with ampdu queues
Hardware with AMPDU queues currently has broken aggregation.
This patch fixes it by making all A-MPDUs go over the regular AC queues,
but keeping track of the hardware queues in mac80211. As a first rough
version, it actually stops the AC queue for extended periods of time,
which can be removed by adding buffering internal to mac80211, but is
currently not a huge problem because people rarely use multiple TIDs
that are in the same AC (and iwlwifi currently doesn't operate as AP).
This is a short-term fix, my current medium-term plan, which I hope to
execute soon as well, but am not sure can finish before .30, looks like
this:
1) rework the internal queuing layer in mac80211 that we use for
fragments if the driver stopped queue in the middle of a fragmented
frame to be able to queue more frames at once (rather than just a
single frame with its fragments)
2) instead of stopping the entire AC queue, queue up the frames in a
per-station/per-TID queue during aggregation session initiation,
when the session has come up take all those frames and put them
onto the queue from 1)
3) push the ampdu queue layer abstraction this patch introduces in
mac80211 into the driver, and remove the virtual queue stuff from
mac80211 again
This plan will probably also affect ath9k in that mac80211 queues the
frames instead of passing them down, even when there are no ampdu queues.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-02-12 00:51:53 +01:00
|
|
|
|
2009-06-17 17:43:56 +02:00
|
|
|
|
2013-04-10 15:41:40 -07:00
|
|
|
|
|
|
|
|
|
2009-06-17 17:43:56 +02:00
|
|
|
|
|
|
|
|
|
2008-07-24 21:02:04 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2018-12-03 21:15:49 +02:00
|
|
|
|
2008-12-18 23:35:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2007-07-27 15:43:23 +02:00
|
|
|
|
|
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
2014-06-13 16:30:06 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-13 12:11:00 +01:00
|
|
|
|
2014-06-13 16:30:06 +03:00
|
|
|
|
2013-02-13 12:11:00 +01:00
|
|
|
|
2015-06-02 21:39:54 +02:00
|
|
|
|
2013-02-13 12:11:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:06 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-09 18:50:21 +02:00
|
|
|
|
|
|
|
|
|
2015-01-07 15:42:39 +02:00
|
|
|
|
2014-06-13 16:30:06 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-09 18:50:21 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-06-02 21:39:54 +02:00
|
|
|
|
2014-11-09 18:50:21 +02:00
|
|
|
|
2014-06-13 16:30:06 +03:00
|
|
|
|
2014-06-13 16:30:04 +03:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2015-01-07 15:42:39 +02:00
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2014-06-13 16:30:04 +03:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2013-02-13 12:11:00 +01:00
|
|
|
|
|
|
|
|
|
2014-11-09 18:50:21 +02:00
|
|
|
|
2015-01-07 15:42:39 +02:00
|
|
|
|
2014-11-09 18:50:21 +02:00
|
|
|
|
2015-01-07 15:42:39 +02:00
|
|
|
|
2014-11-09 18:50:21 +02:00
|
|
|
|
|
|
|
|
|
2014-06-13 16:30:06 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
2007-11-28 10:55:32 +01:00
|
|
|
|
2007-12-19 01:31:27 +01:00
|
|
|
|
2008-09-11 00:01:58 +02:00
|
|
|
|
2016-08-29 23:25:15 +03:00
|
|
|
|
2013-05-28 13:01:53 +02:00
|
|
|
|
|
|
|
|
|
2008-09-11 00:01:58 +02:00
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
2010-09-16 14:58:23 +02:00
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
|
|
|
|
|
2012-11-06 20:23:30 +01:00
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
2012-11-06 20:23:30 +01:00
|
|
|
|
2020-09-22 12:19:56 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
2009-11-25 17:46:19 +01:00
|
|
|
|
2007-12-19 01:31:26 +01:00
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
2007-11-28 10:55:32 +01:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
|
|
|
|
|
2021-11-12 13:51:44 +01:00
|
|
|
|
2012-11-06 20:23:30 +01:00
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
2012-11-06 20:23:30 +01:00
|
|
|
|
2012-07-11 16:38:09 +02:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
2012-07-11 16:38:09 +02:00
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
|
|
|
|
|
2007-11-28 10:55:32 +01:00
|
|
|
|
2007-11-09 01:57:29 +01:00
|
|
|
|
2008-05-10 13:40:49 +02:00
|
|
|
|
2008-09-08 16:40:36 +02:00
|
|
|
|
2021-01-22 16:19:43 +01:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-01-22 16:19:43 +01:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
2015-03-01 09:10:15 +02:00
|
|
|
|
|
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
2021-01-22 16:19:43 +01:00
|
|
|
|
2013-08-21 22:07:20 +02:00
|
|
|
|
2014-10-22 12:30:59 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-12-28 22:14:53 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-10-22 12:30:59 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-11-13 13:37:47 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-12 08:53:24 +02:00
|
|
|
|
|
|
|
|
|
2015-06-10 20:18:55 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-04-09 12:40:19 +03:00
|
|
|
|
2015-03-12 08:53:24 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-07-29 20:08:07 -04:00
|
|
|
|
|
|
|
|
|
2015-01-22 23:32:46 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-07-29 20:08:07 -04:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-01-22 23:32:46 +02:00
|
|
|
|
|
|
|
|
|
2009-11-19 14:29:39 +01:00
|
|
|
|
2015-01-22 23:32:46 +02:00
|
|
|
|
2009-07-29 20:08:07 -04:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-12-11 20:10:24 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:29:22 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-02-23 13:19:26 +08:00
|
|
|
|
2020-01-31 13:12:58 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
2020-01-31 13:12:58 +02:00
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:30 +02:00
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2020-05-28 21:34:30 +02:00
|
|
|
|
|
|
|
|
|
2022-02-14 17:29:59 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-01-16 18:22:56 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
2013-03-26 14:54:16 +01:00
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2019-02-07 22:18:19 +01:00
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
2019-02-07 22:18:19 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-10-24 14:19:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-03-25 18:29:27 +01:00
|
|
|
|
2013-03-26 14:54:16 +01:00
|
|
|
|
2013-10-14 19:08:27 -07:00
|
|
|
|
2014-11-09 18:50:15 +02:00
|
|
|
|
2014-11-09 18:50:18 +02:00
|
|
|
|
|
|
|
|
|
2017-04-26 10:58:47 +03:00
|
|
|
|
2020-01-31 13:12:57 +02:00
|
|
|
|
2020-09-21 19:28:08 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-09-21 19:28:15 -07:00
|
|
|
|
2020-09-21 19:28:08 -07:00
|
|
|
|
2013-03-26 14:54:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-10-24 14:19:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2014-11-09 18:50:18 +02:00
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2014-11-09 18:50:18 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2014-11-09 18:50:18 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-09 18:50:15 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-03-27 14:30:12 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-12 16:27:04 +01:00
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-03-27 14:31:53 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2012-10-10 11:33:04 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-01-31 13:12:58 +02:00
|
|
|
|
2012-10-10 11:33:04 +00:00
|
|
|
|
2020-01-31 13:12:58 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-10-10 11:33:04 +00:00
|
|
|
|
2013-02-07 22:24:55 +01:00
|
|
|
|
2020-01-31 13:12:58 +02:00
|
|
|
|
2013-02-07 22:24:55 +01:00
|
|
|
|
2020-01-31 13:12:58 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-07 22:24:55 +01:00
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-01-30 18:14:08 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
2012-08-01 16:13:02 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2013-03-26 14:13:58 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-03-25 18:29:27 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-10-14 19:08:27 -07:00
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2013-10-14 19:08:27 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-03-26 14:54:16 +01:00
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2013-03-26 14:54:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2013-03-26 14:54:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-09-05 13:07:00 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
mac80211: support DTPC IE (from Cisco Client eXtensions)
Linux already supports 802.11h, where the access point can tell the
client to reduce its transmission power. However, 802.11h is only
defined for 5 GHz, where the need for this is much smaller than on
2.4 GHz.
Cisco has their own solution, called DTPC (Dynamic Transmit Power
Control). Cisco APs on a controller sometimes but not always send
802.11h; they always send DTPC, even on 2.4 GHz. This patch adds support
for parsing and honoring the DTPC IE in addition to the 802.11h
element (they do not always contain the same limits, so both must
be honored); the format is not documented, but very simple.
Tested (on top of wireless.git and on 3.16.1) against a Cisco Aironet
1142 joined to a Cisco 2504 WLC, by setting various transmit power
levels for the given access points and observing the results.
The Wireshark 802.11 dissector agrees with the interpretation of the
element, except for negative numbers, which seem to never happen
anyway.
Signed-off-by: Steinar H. Gunderson <sgunderson@bigfoot.com>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
2014-09-03 06:48:37 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-07-13 18:36:41 +02:00
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2019-07-13 18:36:41 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2013-03-27 14:38:07 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
2017-04-26 10:58:47 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-01-31 13:12:57 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-08-20 08:20:40 -04:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
2020-01-31 13:12:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
2020-09-21 19:28:08 -07:00
|
|
|
|
2021-06-18 13:41:45 +03:00
|
|
|
|
2020-09-21 19:28:08 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-09-21 19:28:15 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-10-24 14:22:37 +02:00
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
2019-02-07 22:18:19 +01:00
|
|
|
|
mac80211: Filter duplicate IE ids
mac80211 is lenient with respect to reception of corrupted beacons.
Even if the frame is corrupted as a whole, the available IE elements
are still passed back and accepted, sometimes replacing legitimate
data. It is unknown to what extent this "feature" is made use of,
but it is clear that in some cases, this is detrimental. One such
case is reported in http://crosbug.com/26832 where an AP corrupts
its beacons but not its probe responses.
One approach would be to completely reject frames with invaid data
(for example, if the last tag extends beyond the end of the enclosing
PDU). The enclosed approach is much more conservative: we simply
prevent later IEs from overwriting the state from previous ones.
This approach hopes that there might be some salient data in the
IE stream before the corruption, and seeks to at least prevent that
data from being overwritten. This approach will fix the case above.
Further, we flag element structures that contain data we think might
be corrupted, so that as we fill the mac80211 BSS structure, we try
not to replace data from an un-corrupted probe response with that
of a corrupted beacon, for example.
Short of any statistics gathering in the various forms of AP breakage,
it's not possible to ascertain the side effects of more stringent
discarding of data.
Signed-off-by: Paul Stewart <pstew@chromium.org>
Cc: Sam Leffler <sleffler@chromium.org>
Cc: Eliad Peller <eliad@wizery.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-23 17:59:53 -08:00
|
|
|
|
|
|
|
|
|
2011-11-18 16:54:50 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
mac80211: always allocate struct ieee802_11_elems
As the 802.11 spec evolves, we need to parse more and more
elements. This is causing the struct to grow, and we can no
longer get away with putting it on the stack.
Change the API to always dynamically allocate and return an
allocated pointer that must be kfree()d later.
As an alternative, I contemplated a scheme whereby we'd say
in the code which elements we needed, e.g.
DECLARE_ELEMENT_PARSER(elems,
SUPPORTED_CHANNELS,
CHANNEL_SWITCH,
EXT(KEY_DELIVERY));
ieee802_11_parse_elems(..., &elems, ...);
and while I think this is possible and will save us a lot
since most individual places only care about a small subset
of the elements, it ended up being a bit more work since a
lot of places do the parsing and then pass the struct to
other functions, sometimes with multiple levels.
Link: https://lore.kernel.org/r/20210920154009.26caff6b5998.I05ae58768e990e611aee8eca8abefd9d7bc15e05@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2021-09-20 15:40:10 +02:00
|
|
|
|
|
|
|
|
|
2019-04-11 11:59:50 +03:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-04-11 11:59:50 +03:00
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
2019-04-11 11:59:50 +03:00
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
mac80211: always allocate struct ieee802_11_elems
As the 802.11 spec evolves, we need to parse more and more
elements. This is causing the struct to grow, and we can no
longer get away with putting it on the stack.
Change the API to always dynamically allocate and return an
allocated pointer that must be kfree()d later.
As an alternative, I contemplated a scheme whereby we'd say
in the code which elements we needed, e.g.
DECLARE_ELEMENT_PARSER(elems,
SUPPORTED_CHANNELS,
CHANNEL_SWITCH,
EXT(KEY_DELIVERY));
ieee802_11_parse_elems(..., &elems, ...);
and while I think this is possible and will save us a lot
since most individual places only care about a small subset
of the elements, it ended up being a bit more work since a
lot of places do the parsing and then pass the struct to
other functions, sometimes with multiple levels.
Link: https://lore.kernel.org/r/20210920154009.26caff6b5998.I05ae58768e990e611aee8eca8abefd9d7bc15e05@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2021-09-20 15:40:10 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-01-16 18:22:56 +02:00
|
|
|
|
mac80211: always allocate struct ieee802_11_elems
As the 802.11 spec evolves, we need to parse more and more
elements. This is causing the struct to grow, and we can no
longer get away with putting it on the stack.
Change the API to always dynamically allocate and return an
allocated pointer that must be kfree()d later.
As an alternative, I contemplated a scheme whereby we'd say
in the code which elements we needed, e.g.
DECLARE_ELEMENT_PARSER(elems,
SUPPORTED_CHANNELS,
CHANNEL_SWITCH,
EXT(KEY_DELIVERY));
ieee802_11_parse_elems(..., &elems, ...);
and while I think this is possible and will save us a lot
since most individual places only care about a small subset
of the elements, it ended up being a bit more work since a
lot of places do the parsing and then pass the struct to
other functions, sometimes with multiple levels.
Link: https://lore.kernel.org/r/20210920154009.26caff6b5998.I05ae58768e990e611aee8eca8abefd9d7bc15e05@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2021-09-20 15:40:10 +02:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
mac80211: always allocate struct ieee802_11_elems
As the 802.11 spec evolves, we need to parse more and more
elements. This is causing the struct to grow, and we can no
longer get away with putting it on the stack.
Change the API to always dynamically allocate and return an
allocated pointer that must be kfree()d later.
As an alternative, I contemplated a scheme whereby we'd say
in the code which elements we needed, e.g.
DECLARE_ELEMENT_PARSER(elems,
SUPPORTED_CHANNELS,
CHANNEL_SWITCH,
EXT(KEY_DELIVERY));
ieee802_11_parse_elems(..., &elems, ...);
and while I think this is possible and will save us a lot
since most individual places only care about a small subset
of the elements, it ended up being a bit more work since a
lot of places do the parsing and then pass the struct to
other functions, sometimes with multiple levels.
Link: https://lore.kernel.org/r/20210920154009.26caff6b5998.I05ae58768e990e611aee8eca8abefd9d7bc15e05@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2021-09-20 15:40:10 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-01-16 18:22:56 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-04-11 11:59:50 +03:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
2019-01-16 18:22:56 +02:00
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
2019-01-16 18:22:56 +02:00
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:04 +02:00
|
|
|
|
2019-01-16 18:22:56 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-03-15 17:39:06 +02:00
|
|
|
|
|
|
|
|
|
2021-09-20 15:40:08 +02:00
|
|
|
|
mac80211: always allocate struct ieee802_11_elems
As the 802.11 spec evolves, we need to parse more and more
elements. This is causing the struct to grow, and we can no
longer get away with putting it on the stack.
Change the API to always dynamically allocate and return an
allocated pointer that must be kfree()d later.
As an alternative, I contemplated a scheme whereby we'd say
in the code which elements we needed, e.g.
DECLARE_ELEMENT_PARSER(elems,
SUPPORTED_CHANNELS,
CHANNEL_SWITCH,
EXT(KEY_DELIVERY));
ieee802_11_parse_elems(..., &elems, ...);
and while I think this is possible and will save us a lot
since most individual places only care about a small subset
of the elements, it ended up being a bit more work since a
lot of places do the parsing and then pass the struct to
other functions, sometimes with multiple levels.
Link: https://lore.kernel.org/r/20210920154009.26caff6b5998.I05ae58768e990e611aee8eca8abefd9d7bc15e05@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2021-09-20 15:40:10 +02:00
|
|
|
|
|
|
|
|
|
2019-01-16 18:22:56 +02:00
|
|
|
|
|
|
|
|
|
2018-03-28 13:24:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-08-22 13:52:21 +02:00
|
|
|
|
2018-03-28 13:24:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-08-22 13:52:21 +02:00
|
|
|
|
2018-03-28 13:24:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-08-22 13:52:21 +02:00
|
|
|
|
2018-03-28 13:24:10 +03:00
|
|
|
|
2018-08-22 13:52:21 +02:00
|
|
|
|
2018-03-28 13:24:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:04 +03:00
|
|
|
|
2018-03-28 13:24:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-03-02 15:56:59 +01:00
|
|
|
|
2015-10-22 17:46:04 +02:00
|
|
|
|
2008-09-09 12:56:01 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-07-26 17:24:39 +02:00
|
|
|
|
2012-03-28 11:04:25 +02:00
|
|
|
|
2015-10-22 17:46:04 +02:00
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
2009-05-07 16:16:24 +02:00
|
|
|
|
2008-09-09 12:56:01 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-03-28 11:04:25 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-09-09 12:56:01 +02:00
|
|
|
|
|
|
|
|
|
2012-07-26 17:24:39 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2009-05-07 16:16:24 +02:00
|
|
|
|
2012-07-26 17:24:39 +02:00
|
|
|
|
2008-09-09 12:56:01 +02:00
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
|
|
|
|
|
2013-09-09 23:03:41 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-09-09 12:56:01 +02:00
|
|
|
|
2013-09-09 23:03:41 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-05-30 10:56:46 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-05-30 10:56:46 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-05-30 10:56:46 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-05-30 10:56:46 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-05-30 10:56:46 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-05-30 10:56:46 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-05-07 16:16:24 +02:00
|
|
|
|
2018-03-28 13:24:10 +03:00
|
|
|
|
2008-09-09 12:56:01 +02:00
|
|
|
|
2010-01-12 10:42:31 +02:00
|
|
|
|
|
|
|
|
|
2012-03-28 11:04:25 +02:00
|
|
|
|
|
|
|
|
|
2009-05-07 16:16:24 +02:00
|
|
|
|
2010-03-29 12:18:34 +02:00
|
|
|
|
2012-06-18 20:07:15 +02:00
|
|
|
|
2016-09-20 17:31:14 +03:00
|
|
|
|
|
|
|
|
|
2012-05-30 10:56:46 +02:00
|
|
|
|
2012-03-02 15:56:59 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-07-23 10:47:11 +05:30
|
|
|
|
2008-09-09 12:56:01 +02:00
|
|
|
|
2008-09-09 15:07:09 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
2012-09-30 19:29:37 +03:00
|
|
|
|
2013-02-12 16:43:19 +01:00
|
|
|
|
2013-01-29 15:02:27 +01:00
|
|
|
|
|
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
cfg80211: rework key operation
This reworks the key operation in cfg80211, and now only
allows, from userspace, configuring keys (via nl80211)
after the connection has been established (in managed
mode), the IBSS been joined (in IBSS mode), at any time
(in AP[_VLAN] modes) or never for all the other modes.
In order to do shared key authentication correctly, it
is now possible to give a WEP key to the AUTH command.
To configure static WEP keys, these are given to the
CONNECT or IBSS_JOIN command directly, for a userspace
SME it is assumed it will configure it properly after
the connection has been established.
Since mac80211 used to check the default key in IBSS
mode to see whether or not the network is protected,
it needs an update in that area, as well as an update
to make use of the WEP key passed to auth() for shared
key authentication.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-07-08 14:22:54 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
2013-09-24 10:33:01 +08:00
|
|
|
|
2014-06-10 20:00:08 +03:00
|
|
|
|
|
|
|
|
|
2011-08-29 14:17:31 -07:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
2011-08-29 14:17:31 -07:00
|
|
|
|
2014-06-10 20:00:08 +03:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
networking: convert many more places to skb_put_zero()
There were many places that my previous spatch didn't find,
as pointed out by yuan linyu in various patches.
The following spatch found many more and also removes the
now unnecessary casts:
@@
identifier p, p2;
expression len;
expression skb;
type t, t2;
@@
(
-p = skb_put(skb, len);
+p = skb_put_zero(skb, len);
|
-p = (t)skb_put(skb, len);
+p = skb_put_zero(skb, len);
)
... when != p
(
p2 = (t2)p;
-memset(p2, 0, len);
|
-memset(p, 0, len);
)
@@
type t, t2;
identifier p, p2;
expression skb;
@@
t *p;
...
(
-p = skb_put(skb, sizeof(t));
+p = skb_put_zero(skb, sizeof(t));
|
-p = (t *)skb_put(skb, sizeof(t));
+p = skb_put_zero(skb, sizeof(t));
)
... when != p
(
p2 = (t2)p;
-memset(p2, 0, sizeof(*p));
|
-memset(p, 0, sizeof(*p));
)
@@
expression skb, len;
@@
-memset(skb_put(skb, len), 0, len);
+skb_put_zero(skb, len);
Apply it to the tree (with one manual fixup to keep the
comment in vxlan.c, which spatch removed.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 14:29:19 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
2012-01-09 19:43:06 +01:00
|
|
|
|
2009-11-25 17:46:19 +01:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-09-30 19:29:37 +03:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.
An spatch similar to the one for skb_put_zero() converts many
of the places using it:
@@
identifier p, p2;
expression len, skb, data;
type t, t2;
@@
(
-p = skb_put(skb, len);
+p = skb_put_data(skb, data, len);
|
-p = (t)skb_put(skb, len);
+p = skb_put_data(skb, data, len);
)
(
p2 = (t2)p;
-memcpy(p2, data, len);
|
-memcpy(p, data, len);
)
@@
type t, t2;
identifier p, p2;
expression skb, data;
@@
t *p;
...
(
-p = skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
|
-p = (t *)skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
)
(
p2 = (t2)p;
-memcpy(p2, data, sizeof(*p));
|
-memcpy(p, data, sizeof(*p));
)
@@
expression skb, len, data;
@@
-memcpy(skb_put(skb, len), data, len);
+skb_put_data(skb, data, len);
(again, manually post-processed to retain some comments)
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 14:29:20 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
cfg80211: rework key operation
This reworks the key operation in cfg80211, and now only
allows, from userspace, configuring keys (via nl80211)
after the connection has been established (in managed
mode), the IBSS been joined (in IBSS mode), at any time
(in AP[_VLAN] modes) or never for all the other modes.
In order to do shared key authentication correctly, it
is now possible to give a WEP key to the AUTH command.
To configure static WEP keys, these are given to the
CONNECT or IBSS_JOIN command directly, for a userspace
SME it is assumed it will configure it properly after
the connection has been established.
Since mac80211 used to check the default key in IBSS
mode to see whether or not the network is protected,
it needs an update in that area, as well as an update
to make use of the WEP key passed to auth() for shared
key authentication.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-07-08 14:22:54 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:33 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
cfg80211: rework key operation
This reworks the key operation in cfg80211, and now only
allows, from userspace, configuring keys (via nl80211)
after the connection has been established (in managed
mode), the IBSS been joined (in IBSS mode), at any time
(in AP[_VLAN] modes) or never for all the other modes.
In order to do shared key authentication correctly, it
is now possible to give a WEP key to the AUTH command.
To configure static WEP keys, these are given to the
CONNECT or IBSS_JOIN command directly, for a userspace
SME it is assumed it will configure it properly after
the connection has been established.
Since mac80211 used to check the default key in IBSS
mode to see whether or not the network is protected,
it needs an update in that area, as well as an update
to make use of the WEP key passed to auth() for shared
key authentication.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2009-07-08 14:22:54 +02:00
|
|
|
|
|
|
|
|
|
2013-01-29 15:02:27 +01:00
|
|
|
|
|
|
|
|
|
2009-11-18 18:42:05 +01:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
2012-09-07 13:28:52 +02:00
|
|
|
|
2019-08-30 14:24:51 +03:00
|
|
|
|
|
|
|
|
|
2012-09-07 13:28:52 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-08-30 14:24:51 +03:00
|
|
|
|
2012-09-07 13:28:52 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.
An spatch similar to the one for skb_put_zero() converts many
of the places using it:
@@
identifier p, p2;
expression len, skb, data;
type t, t2;
@@
(
-p = skb_put(skb, len);
+p = skb_put_data(skb, data, len);
|
-p = (t)skb_put(skb, len);
+p = skb_put_data(skb, data, len);
)
(
p2 = (t2)p;
-memcpy(p2, data, len);
|
-memcpy(p, data, len);
)
@@
type t, t2;
identifier p, p2;
expression skb, data;
@@
t *p;
...
(
-p = skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
|
-p = (t *)skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
)
(
p2 = (t2)p;
-memcpy(p2, data, sizeof(*p));
|
-memcpy(p, data, sizeof(*p));
)
@@
expression skb, len, data;
@@
-memcpy(skb_put(skb, len), data, len);
+skb_put_data(skb, data, len);
(again, manually post-processed to retain some comments)
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 14:29:20 +02:00
|
|
|
|
2012-09-07 13:28:52 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
2018-05-28 15:47:38 +02:00
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
2022-02-14 17:30:01 +01:00
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
2010-08-28 19:36:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
2014-11-24 15:49:44 +01:00
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
2009-10-27 20:59:55 +01:00
|
|
|
|
2012-07-09 19:57:28 +03:00
|
|
|
|
|
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-08-28 19:36:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-08-28 19:36:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
|
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
2010-08-28 19:36:10 +03:00
|
|
|
|
|
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
2010-08-28 19:36:10 +03:00
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
2010-08-28 19:36:10 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
|
|
|
|
|
2010-08-28 19:37:51 +03:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
2010-08-28 19:37:51 +03:00
|
|
|
|
|
|
|
|
|
2018-05-28 15:47:41 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-08-05 11:44:32 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 11:32:00 -08:00
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
2009-03-31 12:12:07 +02:00
|
|
|
|
2014-02-04 09:48:34 +01:00
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
2014-02-04 09:48:34 +01:00
|
|
|
|
2017-08-05 11:44:32 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-04 09:48:34 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-08-05 11:44:29 +03:00
|
|
|
|
2017-08-05 11:44:32 +03:00
|
|
|
|
2014-02-04 09:48:34 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
|
|
|
|
|
2014-11-24 15:49:44 +01:00
|
|
|
|
|
|
|
|
|
2015-01-01 13:43:17 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-11-24 15:49:44 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
|
|
|
|
|
2012-07-02 11:25:12 +00:00
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
2012-07-02 11:25:12 +00:00
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:50 +03:00
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:40 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-02 10:49:34 +02:00
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:42 +03:00
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
2022-02-14 17:30:01 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-18 13:41:42 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-11-29 12:45:18 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-05-28 15:47:41 +02:00
|
|
|
|
2009-04-01 11:58:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-05-28 15:47:38 +02:00
|
|
|
|
|
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-05-28 15:47:38 +02:00
|
|
|
|
|
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-11-11 08:50:18 +02:00
|
|
|
|
2014-06-12 22:24:31 +02:00
|
|
|
|
|
|
|
|
|
2012-07-23 14:53:27 +02:00
|
|
|
|
2010-11-11 08:50:18 +02:00
|
|
|
|
2011-06-23 09:00:11 -08:00
|
|
|
|
2018-05-28 15:47:38 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
2012-11-29 13:00:10 +01:00
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
2011-06-23 09:00:11 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2018-05-28 15:47:38 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2011-06-23 09:00:11 -08:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2010-08-28 19:37:51 +03:00
|
|
|
|
2014-06-12 22:24:31 +02:00
|
|
|
|
2021-11-29 15:32:45 +02:00
|
|
|
|
2011-11-08 13:04:41 +01:00
|
|
|
|
2012-11-29 13:00:10 +01:00
|
|
|
|
|
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
2014-02-05 15:21:13 +02:00
|
|
|
|
|
|
|
|
|
2018-05-28 15:47:38 +02:00
|
|
|
|
2012-11-29 13:00:10 +01:00
|
|
|
|
2010-01-05 20:16:44 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
2010-01-05 20:16:44 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-11-18 18:42:05 +01:00
|
|
|
|
2011-11-08 13:04:41 +01:00
|
|
|
|
2010-11-11 08:50:18 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
2017-04-27 12:45:38 +05:30
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2017-04-27 12:45:38 +05:30
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-02 21:21:21 -07:00
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-02 21:21:21 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
2012-04-02 21:21:21 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-02-15 12:44:28 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2009-08-20 20:02:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-11-30 08:59:23 +01:00
|
|
|
|
2009-08-20 20:02:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-01-10 14:07:53 +01:00
|
|
|
|
2009-08-20 20:02:20 +02:00
|
|
|
|
|
|
|
|
|
2015-12-08 16:04:38 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-04-30 14:19:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-06-10 20:19:37 +03:00
|
|
|
|
2014-04-30 14:19:04 +02:00
|
|
|
|
2015-12-08 16:04:38 +02:00
|
|
|
|
|
|
|
|
|
2014-04-30 14:19:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-28 10:55:30 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-12-08 16:04:39 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-09-20 17:31:20 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-12 14:03:40 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-09-20 17:31:20 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-07-26 17:24:39 +02:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2011-07-14 20:29:42 +03:00
|
|
|
|
2013-01-10 23:55:33 +01:00
|
|
|
|
2013-12-08 21:48:57 +02:00
|
|
|
|
2014-11-19 11:55:49 +01:00
|
|
|
|
2013-12-08 21:48:57 +02:00
|
|
|
|
2015-07-08 15:41:47 +03:00
|
|
|
|
2022-03-08 17:23:24 +05:30
|
|
|
|
2013-01-10 23:55:33 +01:00
|
|
|
|
2014-12-14 11:05:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-01-11 00:28:01 +01:00
|
|
|
|
2015-07-08 15:41:47 +03:00
|
|
|
|
2009-11-19 14:29:39 +01:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2011-05-04 15:37:29 +02:00
|
|
|
|
2015-07-08 15:41:47 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-05-04 15:37:29 +02:00
|
|
|
|
2013-08-07 20:11:55 +02:00
|
|
|
|
2011-05-04 15:37:29 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-07-08 15:41:47 +03:00
|
|
|
|
2011-05-04 15:37:29 +02:00
|
|
|
|
2013-01-10 23:55:33 +01:00
|
|
|
|
2015-07-08 15:41:47 +03:00
|
|
|
|
2011-05-04 15:37:29 +02:00
|
|
|
|
|
|
|
|
|
2011-07-14 16:48:54 +02:00
|
|
|
|
2015-10-25 10:59:35 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-10-25 10:59:36 +02:00
|
|
|
|
|
|
|
|
|
2011-07-14 16:48:54 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-07-08 15:41:47 +03:00
|
|
|
|
2014-04-30 14:19:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-07-14 16:48:54 +02:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
2011-12-30 16:34:25 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-07-14 16:48:54 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2021-11-12 13:51:44 +01:00
|
|
|
|
2012-04-03 14:35:57 +02:00
|
|
|
|
2013-03-27 23:20:27 +01:00
|
|
|
|
|
|
|
|
|
2012-04-03 14:35:57 +02:00
|
|
|
|
|
|
|
|
|
2014-03-24 00:51:43 +05:30
|
|
|
|
2012-04-03 14:35:57 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:04 +02:00
|
|
|
|
2011-11-03 14:41:13 +01:00
|
|
|
|
2015-03-01 09:10:04 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
2012-07-26 17:24:39 +02:00
|
|
|
|
2012-11-19 12:01:05 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-06-25 12:35:06 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-11-19 12:01:05 +01:00
|
|
|
|
2012-07-26 17:24:39 +02:00
|
|
|
|
2021-11-12 13:51:44 +01:00
|
|
|
|
|
|
|
|
|
2014-04-26 09:43:40 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-11-19 22:19:08 +01:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-05-05 09:44:02 +02:00
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:31 +01:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2010-05-05 09:44:02 +02:00
|
|
|
|
2015-12-08 16:04:39 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-02-06 13:17:12 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-07-07 15:45:48 -05:00
|
|
|
|
2015-12-08 16:04:39 +02:00
|
|
|
|
|
|
|
|
|
2020-07-07 15:45:48 -05:00
|
|
|
|
2015-12-08 16:04:39 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-05-05 09:44:02 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-07-19 16:39:04 +02:00
|
|
|
|
2011-11-01 15:16:55 +02:00
|
|
|
|
2012-10-24 10:59:25 +02:00
|
|
|
|
2018-03-22 12:18:03 -07:00
|
|
|
|
|
|
|
|
|
2010-05-05 09:44:02 +02:00
|
|
|
|
2016-02-16 12:48:18 +02:00
|
|
|
|
2015-12-08 16:04:31 +02:00
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
2011-12-12 14:10:49 +02:00
|
|
|
|
2012-07-27 12:33:22 +03:00
|
|
|
|
|
|
|
|
|
2012-12-12 10:12:24 +02:00
|
|
|
|
2013-05-16 17:34:17 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-12-12 10:12:24 +02:00
|
|
|
|
2017-04-26 10:58:47 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-05-10 12:32:47 +02:00
|
|
|
|
2010-05-05 09:44:02 +02:00
|
|
|
|
2013-05-10 12:32:47 +02:00
|
|
|
|
2010-05-05 09:44:02 +02:00
|
|
|
|
2014-11-03 10:33:18 +01:00
|
|
|
|
2014-11-03 10:33:19 +01:00
|
|
|
|
|
|
|
|
|
2014-11-03 10:33:18 +01:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2010-05-05 09:44:02 +02:00
|
|
|
|
2020-07-07 15:45:48 -05:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2012-11-14 15:21:17 +01:00
|
|
|
|
2011-11-22 19:33:18 +02:00
|
|
|
|
2018-10-03 20:19:20 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-10-19 15:44:42 +02:00
|
|
|
|
2011-11-22 19:33:18 +02:00
|
|
|
|
|
|
|
|
|
2012-10-19 15:44:42 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-07-07 15:45:48 -05:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2012-12-14 14:17:26 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2016-09-20 17:31:20 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
2012-06-16 00:19:54 +02:00
|
|
|
|
2014-04-26 09:43:41 +08:00
|
|
|
|
2012-06-18 20:07:15 +02:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2010-08-12 15:38:38 +02:00
|
|
|
|
2010-09-16 14:58:23 +02:00
|
|
|
|
|
|
|
|
|
2020-11-09 10:57:46 +01:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-10-14 18:02:43 +02:00
|
|
|
|
2011-11-09 12:29:06 +02:00
|
|
|
|
2012-01-26 13:36:05 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-11-08 14:06:28 +01:00
|
|
|
|
|
|
|
|
|
2012-01-26 13:36:05 +02:00
|
|
|
|
2015-09-24 16:14:55 +02:00
|
|
|
|
2012-01-26 13:36:05 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-06-03 23:31:56 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-07-02 15:40:14 +05:30
|
|
|
|
|
|
|
|
|
2012-06-03 23:31:56 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-05-29 02:00:22 -07:00
|
|
|
|
2015-05-13 09:16:48 +00:00
|
|
|
|
2019-08-30 14:24:49 +03:00
|
|
|
|
2012-05-29 02:00:22 -07:00
|
|
|
|
2015-10-25 10:59:33 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-12-16 15:45:45 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-10-25 10:59:33 +02:00
|
|
|
|
2015-12-16 15:45:45 +02:00
|
|
|
|
2015-10-25 10:59:33 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-01-22 16:19:43 +01:00
|
|
|
|
2015-10-25 10:59:33 +02:00
|
|
|
|
2012-07-02 15:08:25 +03:00
|
|
|
|
2012-06-06 11:25:02 +03:00
|
|
|
|
2013-03-27 23:20:27 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2010-06-10 10:21:29 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-06-02 21:39:54 +02:00
|
|
|
|
2010-06-10 10:21:29 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-09-21 15:50:26 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-09-29 16:04:36 +02:00
|
|
|
|
2010-02-03 09:28:55 -08:00
|
|
|
|
2010-06-10 10:21:29 +02:00
|
|
|
|
|
|
|
|
|
2010-02-03 09:28:55 -08:00
|
|
|
|
|
|
|
|
|
2021-11-29 15:32:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-10-29 11:51:08 +02:00
|
|
|
|
2022-03-08 17:23:24 +05:30
|
|
|
|
2017-10-29 11:51:08 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-05-29 15:25:30 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-10-29 11:51:08 +02:00
|
|
|
|
|
|
|
|
|
2013-02-13 12:25:28 +01:00
|
|
|
|
2014-06-13 16:30:05 +03:00
|
|
|
|
|
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
2022-03-08 17:23:24 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-07-08 15:41:47 +03:00
|
|
|
|
2009-05-17 11:40:42 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-11-19 14:29:39 +01:00
|
|
|
|
2009-05-17 11:40:42 +02:00
|
|
|
|
2009-11-19 14:29:39 +01:00
|
|
|
|
|
|
|
|
|
2009-05-17 11:40:42 +02:00
|
|
|
|
2015-12-08 16:04:38 +02:00
|
|
|
|
2015-01-24 10:30:02 +02:00
|
|
|
|
2014-12-14 11:05:53 +02:00
|
|
|
|
2014-11-04 11:43:54 +02:00
|
|
|
|
|
|
|
|
|
2013-04-29 14:57:44 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-04-01 13:52:48 +02:00
|
|
|
|
2009-05-17 11:40:42 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-12-08 21:48:57 +02:00
|
|
|
|
2009-04-14 10:09:24 +02:00
|
|
|
|
|
|
|
|
|
2009-07-29 20:08:07 -04:00
|
|
|
|
2022-03-08 17:23:24 +05:30
|
|
|
|
2011-07-12 12:30:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-03-08 17:23:24 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-07-12 12:30:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-03-08 17:23:24 +05:30
|
|
|
|
2011-07-12 12:30:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-03-08 17:23:24 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-07-12 12:30:59 +02:00
|
|
|
|
|
|
|
|
|
2012-09-11 14:34:12 +02:00
|
|
|
|
2009-12-01 13:37:02 +01:00
|
|
|
|
2012-09-11 14:34:12 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-12-01 13:37:02 +01:00
|
|
|
|
2012-09-11 14:34:12 +02:00
|
|
|
|
2009-12-01 13:37:02 +01:00
|
|
|
|
2012-09-11 14:34:12 +02:00
|
|
|
|
|
|
|
|
|
2009-12-01 13:37:02 +01:00
|
|
|
|
2015-10-25 10:59:40 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-09-11 10:17:11 +02:00
|
|
|
|
2009-12-01 13:37:02 +01:00
|
|
|
|
2012-09-11 14:34:12 +02:00
|
|
|
|
|
|
|
|
|
2012-09-11 10:17:11 +02:00
|
|
|
|
2012-09-11 14:34:12 +02:00
|
|
|
|
2009-12-01 13:37:02 +01:00
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
2013-11-11 20:14:01 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2009-12-23 13:15:38 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-07-08 08:46:22 -07:00
|
|
|
|
2011-11-18 11:32:00 -08:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 11:32:00 -08:00
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-11-18 11:32:00 -08:00
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-07-02 11:25:12 +00:00
|
|
|
|
2012-12-07 12:45:06 +01:00
|
|
|
|
2012-07-02 11:25:12 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-10-10 11:25:40 +00:00
|
|
|
|
|
|
|
|
|
2012-07-02 11:25:12 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-02 10:49:34 +02:00
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-02 10:49:34 +02:00
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-02 10:49:34 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-02 10:49:34 +02:00
|
|
|
|
|
|
|
|
|
2018-06-09 09:14:44 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:32 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-23 13:05:47 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:32 +02:00
|
|
|
|
|
|
|
|
|
2021-06-23 13:05:47 +02:00
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:32 +02:00
|
|
|
|
2021-06-23 13:05:47 +02:00
|
|
|
|
2020-05-28 21:34:32 +02:00
|
|
|
|
|
|
|
|
|
2020-07-01 19:20:24 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:32 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-07-07 15:45:48 -05:00
|
|
|
|
2020-05-28 21:34:32 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:39 +02:00
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:32 +02:00
|
|
|
|
|
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
2012-11-09 11:39:59 +01:00
|
|
|
|
2015-10-25 10:59:34 +02:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-11-09 11:39:59 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
2012-04-18 19:24:14 -07:00
|
|
|
|
2012-11-09 11:39:59 +01:00
|
|
|
|
|
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
2011-11-30 16:56:33 +01:00
|
|
|
|
2015-10-25 10:59:34 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-30 14:20:29 -07:00
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
2017-05-23 17:00:42 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-05-23 17:00:42 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:02 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-02-15 15:02:06 +01:00
|
|
|
|
2015-03-01 09:10:02 +02:00
|
|
|
|
|
|
|
|
|
2017-02-15 15:02:06 +01:00
|
|
|
|
2015-03-01 09:10:02 +02:00
|
|
|
|
2015-09-04 10:58:05 +08:00
|
|
|
|
2017-02-15 15:02:06 +01:00
|
|
|
|
2015-03-01 09:10:02 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-02-15 15:02:06 +01:00
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
2017-02-15 15:02:06 +01:00
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
2017-02-15 15:02:06 +01:00
|
|
|
|
2015-03-01 09:10:02 +02:00
|
|
|
|
|
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:02 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-01 09:10:02 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
|
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:33 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-07-24 18:33:56 +02:00
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
2012-03-15 19:45:16 +01:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
|
|
|
|
|
2011-10-26 14:47:26 -07:00
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:35 +02:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-02-10 15:07:28 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:35 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
|
|
|
|
|
2020-02-10 15:07:28 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:35 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-07-07 15:45:48 -05:00
|
|
|
|
2020-05-28 21:34:35 +02:00
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2020-05-28 21:34:35 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2020-02-10 15:07:28 +02:00
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2020-02-10 15:07:28 +02:00
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2016-02-01 11:40:55 +02:00
|
|
|
|
|
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
|
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
2018-08-31 11:31:18 +03:00
|
|
|
|
|
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
|
|
|
|
|
2015-12-18 15:08:34 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-20 06:37:01 +01:00
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
2021-09-24 06:00:48 -04:00
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-09-24 06:00:48 -04:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
2020-09-18 13:53:04 +02:00
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-11-23 16:45:52 +08:00
|
|
|
|
2020-09-21 19:28:15 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-05-28 21:34:36 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-06-28 10:33:25 +02:00
|
|
|
|
2012-07-23 14:53:27 +02:00
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
2012-06-28 10:33:25 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
2012-07-23 14:53:27 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-02 21:21:20 -07:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-02 21:21:20 -07:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-06-28 10:33:25 +02:00
|
|
|
|
2012-07-23 14:53:27 +02:00
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-09-07 23:40:44 -07:00
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
2012-06-28 10:33:25 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
2012-07-23 14:53:27 +02:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-02 21:21:20 -07:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-02 21:21:20 -07:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2011-09-28 14:12:51 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-13 12:02:57 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-04-23 09:30:32 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-08-28 10:52:54 +02:00
|
|
|
|
2012-04-13 12:02:57 -07:00
|
|
|
|
2012-04-20 11:57:00 -07:00
|
|
|
|
2012-09-11 14:34:12 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-12-06 14:54:45 +02:00
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2018-04-20 13:49:21 +03:00
|
|
|
|
|
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
2020-12-06 14:54:45 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
|
|
|
|
|
2017-04-26 11:13:00 +02:00
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
2020-12-06 14:54:45 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
|
|
|
|
|
2012-11-09 15:07:02 +01:00
|
|
|
|
|
|
|
|
|
2017-04-26 13:51:41 +02:00
|
|
|
|
2017-04-26 11:13:00 +02:00
|
|
|
|
2012-11-09 15:07:02 +01:00
|
|
|
|
2020-12-06 14:54:45 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-07-07 15:45:48 -05:00
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
2015-01-15 16:14:02 +01:00
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
|
|
|
|
|
2013-07-08 16:55:53 +02:00
|
|
|
|
|
|
|
|
|
2016-01-25 15:46:34 +02:00
|
|
|
|
|
|
|
|
|
2016-04-12 15:56:15 +02:00
|
|
|
|
2016-01-25 15:46:34 +02:00
|
|
|
|
|
|
|
|
|
2017-04-26 11:13:00 +02:00
|
|
|
|
2016-01-25 15:46:34 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-04-26 12:14:59 +02:00
|
|
|
|
|
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-10-11 15:47:06 +02:00
|
|
|
|
2016-02-24 11:49:45 +02:00
|
|
|
|
|
|
|
|
|
2017-04-26 13:51:41 +02:00
|
|
|
|
2013-10-11 15:47:06 +02:00
|
|
|
|
2012-11-13 10:46:27 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-11-06 13:55:51 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
2017-04-26 10:58:53 +03:00
|
|
|
|
2021-01-22 16:19:43 +01:00
|
|
|
|
2017-04-26 10:58:53 +03:00
|
|
|
|
mac80211: fix iflist_mtx/mtx locking in radar detection
The scan code creates an iflist_mtx -> mtx locking dependency,
and a few other places, notably radar detection, were creating
the opposite dependency, causing lockdep to complain. As scan
and radar detection are mutually exclusive, the deadlock can't
really happen in practice, but it's still bad form.
A similar issue exists in the monitor mode code, but this is
only used by channel-context drivers right now and those have
to have hardware scan, so that also can't happen.
Still, fix these issues by making some of the channel context
code require the mtx to be held rather than acquiring it, thus
allowing the monitor/radar callers to keep the iflist_mtx->mtx
lock ordering.
While at it, also fix access to the local->scanning variable
in the radar code, and document that radar_detect_enabled is
now properly protected by the mtx.
All this would now introduce an ABBA deadlock between the DFS
work cancelling and local->mtx, so change the locking there a
bit to not need to use cancel_delayed_work_sync() but be able
to just use cancel_delayed_work(). The work is also safely
stopped/removed when the interface is stopped, so no extra
changes are needed.
Reported-by: Kalle Valo <kvalo@qca.qualcomm.com>
Tested-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-12-18 09:43:33 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
mac80211: fix iflist_mtx/mtx locking in radar detection
The scan code creates an iflist_mtx -> mtx locking dependency,
and a few other places, notably radar detection, were creating
the opposite dependency, causing lockdep to complain. As scan
and radar detection are mutually exclusive, the deadlock can't
really happen in practice, but it's still bad form.
A similar issue exists in the monitor mode code, but this is
only used by channel-context drivers right now and those have
to have hardware scan, so that also can't happen.
Still, fix these issues by making some of the channel context
code require the mtx to be held rather than acquiring it, thus
allowing the monitor/radar callers to keep the iflist_mtx->mtx
lock ordering.
While at it, also fix access to the local->scanning variable
in the radar code, and document that radar_detect_enabled is
now properly protected by the mtx.
All this would now introduce an ABBA deadlock between the DFS
work cancelling and local->mtx, so change the locking there a
bit to not need to use cancel_delayed_work_sync() but be able
to just use cancel_delayed_work(). The work is also safely
stopped/removed when the interface is stopped, so no extra
changes are needed.
Reported-by: Kalle Valo <kvalo@qca.qualcomm.com>
Tested-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-12-18 09:43:33 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
|
|
|
|
|
2013-11-06 13:55:51 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
|
|
|
|
|
2013-11-06 13:55:51 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mac80211: fix iflist_mtx/mtx locking in radar detection
The scan code creates an iflist_mtx -> mtx locking dependency,
and a few other places, notably radar detection, were creating
the opposite dependency, causing lockdep to complain. As scan
and radar detection are mutually exclusive, the deadlock can't
really happen in practice, but it's still bad form.
A similar issue exists in the monitor mode code, but this is
only used by channel-context drivers right now and those have
to have hardware scan, so that also can't happen.
Still, fix these issues by making some of the channel context
code require the mtx to be held rather than acquiring it, thus
allowing the monitor/radar callers to keep the iflist_mtx->mtx
lock ordering.
While at it, also fix access to the local->scanning variable
in the radar code, and document that radar_detect_enabled is
now properly protected by the mtx.
All this would now introduce an ABBA deadlock between the DFS
work cancelling and local->mtx, so change the locking there a
bit to not need to use cancel_delayed_work_sync() but be able
to just use cancel_delayed_work(). The work is also safely
stopped/removed when the interface is stopped, so no extra
changes are needed.
Reported-by: Kalle Valo <kvalo@qca.qualcomm.com>
Tested-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2013-12-18 09:43:33 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-11-05 14:48:46 +01:00
|
|
|
|
2014-10-10 12:43:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
2021-01-22 16:19:43 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
2021-01-22 16:19:43 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
2014-10-10 12:43:23 +02:00
|
|
|
|
|
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
2013-11-05 14:48:46 +01:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-04-26 10:58:53 +03:00
|
|
|
|
2013-02-08 18:16:20 +01:00
|
|
|
|
|
|
|
|
|
2013-08-28 13:41:29 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:00 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-08-28 13:41:29 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-06-01 23:22:47 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-08-28 13:41:29 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-10-01 16:45:43 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-10-14 19:08:28 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-09-08 11:54:46 +02:00
|
|
|
|
|
|
|
|
|
2013-10-14 19:08:28 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-05-23 17:00:42 +02:00
|
|
|
|
2013-10-14 19:08:28 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
networking: convert many more places to skb_put_zero()
There were many places that my previous spatch didn't find,
as pointed out by yuan linyu in various patches.
The following spatch found many more and also removes the
now unnecessary casts:
@@
identifier p, p2;
expression len;
expression skb;
type t, t2;
@@
(
-p = skb_put(skb, len);
+p = skb_put_zero(skb, len);
|
-p = (t)skb_put(skb, len);
+p = skb_put_zero(skb, len);
)
... when != p
(
p2 = (t2)p;
-memset(p2, 0, len);
|
-memset(p, 0, len);
)
@@
type t, t2;
identifier p, p2;
expression skb;
@@
t *p;
...
(
-p = skb_put(skb, sizeof(t));
+p = skb_put_zero(skb, sizeof(t));
|
-p = (t *)skb_put(skb, sizeof(t));
+p = skb_put_zero(skb, sizeof(t));
)
... when != p
(
p2 = (t2)p;
-memset(p2, 0, sizeof(*p));
|
-memset(p, 0, sizeof(*p));
)
@@
expression skb, len;
@@
-memset(skb_put(skb, len), 0, len);
+skb_put_zero(skb, len);
Apply it to the tree (with one manual fixup to keep the
comment in vxlan.c, which spatch removed.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 14:29:19 +02:00
|
|
|
|
2013-10-14 19:08:28 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-11-12 10:31:48 +08:00
|
|
|
|
2013-10-14 19:08:28 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2017-05-23 17:00:42 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-10-14 19:08:28 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-03-24 14:23:27 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-12-16 21:49:14 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-10-27 08:35:11 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-12-16 21:49:14 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2013-12-19 10:25:15 -08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
2014-06-25 12:35:07 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-27 11:07:21 +02:00
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-21 14:25:14 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
2019-07-22 12:44:50 +05:30
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
2014-06-25 12:35:06 +02:00
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
2014-02-27 11:07:21 +02:00
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-12 08:53:30 +02:00
|
|
|
|
2019-07-22 12:44:50 +05:30
|
|
|
|
|
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-02-13 11:31:59 +02:00
|
|
|
|
2014-04-09 15:29:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-04-09 15:29:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-06-25 12:35:06 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-04-09 15:29:23 +02:00
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
|
|
|
|
|
2014-04-09 15:29:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
2014-04-09 15:29:23 +02:00
|
|
|
|
2016-10-12 18:25:35 +05:30
|
|
|
|
|
|
|
|
|
2014-04-09 15:29:23 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-09-21 19:28:05 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-04-09 15:29:23 +02:00
|
|
|
|
2014-07-17 17:14:23 +03:00
|
|
|
|
2020-09-21 19:28:15 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2014-07-17 17:14:23 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2015-03-27 21:30:37 +01:00
|
|
|
|
2016-01-27 15:26:12 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-09-22 19:04:20 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2016-01-27 15:26:12 +01:00
|
|
|
|
|
|
|
|
|
2016-09-22 19:04:20 +02:00
|
|
|
|
2016-01-27 15:26:12 +01:00
|
|
|
|
|
|
|
|
|
2016-09-22 19:04:20 +02:00
|
|
|
|
2016-01-27 15:26:12 +01:00
|
|
|
|
|
|
|
|
|
2016-10-18 23:12:12 +03:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2020-09-21 19:28:10 -07:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2022-02-14 17:30:01 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|