tcp: ensure proper barriers in lockless contexts

Browse source

Some functions access TCP sockets without holding a lock and
might output non consistent data, depending on compiler and or
architecture.

tcp_diag_get_info(), tcp_get_info(), tcp_poll(), get_tcp4_sock() ...

Introduce sk_state_load() and sk_state_store() to fix the issues,
and more clearly document where this lack of locking is happening.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Eric Dumazet 2015-11-12 08:43:18 -08:00 • committed by David S. Miller

parent 5883d9c6d7

commit 00fd38d938

6 changed files with 62 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

include/net/sock.h

View file

4

net/ipv4/inet_connection_sock.c

View file

21

net/ipv4/tcp.c

View file

2

net/ipv4/tcp_diag.c

View file

14

net/ipv4/tcp_ipv4.c

View file

19

net/ipv6/tcp_ipv6.c

View file