mac80211: fix deadlock with multiple interfaces

Browse source

The locking around ieee80211_recalc_smps is
buggy -- it cannot acquire another interface's
mutex while the iflist mutex is held because
another code path could be holding the iface
mutex and trying to acquire the iflist mutex.

But the locking is also unnecessary, we only
check "ifmgd->associated" as a bool, and don't
use the pointer (in check_mgd_smps).

Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

...

This commit is contained in:

Johannes Berg 2010-10-05 10:41:47 +02:00 • committed by John W. Linville

parent 6774889314

commit 025e6be220

5 changed files with 7 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

net/mac80211/cfg.c

View file

3

net/mac80211/ieee80211_i.h

View file

2

net/mac80211/main.c

View file

2

net/mac80211/mlme.c

View file

20

net/mac80211/util.c

View file