ASoC: ti: omap-mcbsp: Fix an error handling path in 'asoc_mcbsp_probe()'

Browse source

If an error occurs after the call to 'omap_mcbsp_init()', the reference to
'mcbsp->fclk' must be decremented, as already done in the remove function.

This can be achieved easily by using the devm_ variant of 'clk_get()'
when the reference is taken in 'omap_mcbsp_init()'

This fixes the leak in the probe and has the side effect to simplify both
the error handling path of 'omap_mcbsp_init()' and the remove function.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Peter Ujfalusi <peter.ujflausi@ti.com>
Link: https://lore.kernel.org/r/20200512134325.252073-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Christophe JAILLET 2020-05-12 15:43:25 +02:00 • committed by Mark Brown

parent cc2d025a81

commit 03990fd58d

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

1 changed files with 2 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

sound/soc/ti/omap-mcbsp.c

View file