V4L/DVB: saa7146: fix regression of the av7110/budget-av driver

Browse source

An earlier regression fix for the mxb driver (V4L/DVB: saa7146_vv: fix
regression where v4l2_device was registered too late) caused a new
regression in the av7110 driver.

Reverted the old fix and fixed the problem in the mxb driver instead.
Tested on mxb and budget-av cards.

The real problem is that the saa7146 framework has separate probe()
and attach() driver callbacks which should be rolled into one. This
is now done for the mxb driver, but others should do the same. Lack
of hardware makes this hard to do, though. I hope to get hold of some
hexium cards and then I can try to improve the framework to prevent
this from happening again.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

...

This commit is contained in:

Hans Verkuil 2010-03-24 19:09:55 -03:00 • committed by Mauro Carvalho Chehab

parent d2f2d6d0a1

commit 03b1930efd

5 changed files with 13 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

11

drivers/media/common/saa7146_fops.c

View file

3

drivers/media/video/hexium_gemini.c

View file

4

drivers/media/video/hexium_orion.c

View file

17

drivers/media/video/mxb.c

View file

1

include/media/saa7146_vv.h

View file