watch_queue: fix IOC_WATCH_QUEUE_SET_SIZE alloc error paths

Browse source

The watch_queue_set_size() allocation error paths return the ret value
set via the prior pipe_resize_ring() call, which will always be zero.

As a result, IOC_WATCH_QUEUE_SET_SIZE callers such as "keyctl watch"
fail to detect kernel wqueue->notes allocation failures and proceed to
KEYCTL_WATCH_KEY, with any notifications subsequently lost.

Fixes: c73be61ced ("pipe: Add general notification queue support")
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>

...

This commit is contained in:

David Disseldorp 2023-03-07 16:21:06 +01:00 • committed by Christian Brauner (Microsoft)

parent fe15c26ee2

commit 03e1d60e17

No known key found for this signature in database

GPG key ID: 91C61BC06578DCA2

1 changed files with 1 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

kernel/watch_queue.c

View file