NFSv4: nfs4_do_open() is incorrectly triggering state recovery

Browse source

We're seeing spurious calls to nfs4_schedule_stateid_recovery() from
nfs4_do_open() in situations where there is no trigger coming from the
server.
In theory the code path being triggered is supposed to notice that state
recovery happened while we were processing the open call result from the
server, before the open stateid is published. However in the years since
that code was added, we've also added the 'session draining' mechanism,
which ensures that the state recovery will wait until all the session
slots have been returned. In nfs4_do_open() the session slot is only
returned on exit of the function, so we don't need the legacy mechanism.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

...

This commit is contained in:

Trond Myklebust 2024-02-24 15:59:28 -05:00

parent 2fdbc20036

commit 0460253913

4 changed files with 8 additions and 16 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

fs/nfs/delegation.c

View file

1

fs/nfs/nfs4_fs.h

View file

7

fs/nfs/nfs4proc.c

View file

12

fs/nfs/nfs4state.c

View file