staging: comedi: have comedi_set_spriv() allocate the memory

Browse source

As suggested by Ian Abbott, comedi_set_spriv() can only be used to
set the subdevice->private pointer to something that can be kfree()'d.
Rename the function to comedi_alloc_spriv() and have it kzalloc() the
memory as well as set the private pointer. This saves a function call
in the drivers and avoids the possibility of incorrectly calling
comedi_set_spriv() for some pointer that is not meant to be kfree()'d.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

H Hartley Sweeten 2013-06-19 15:24:36 -07:00 • committed by Greg Kroah-Hartman

parent 2eb226dced

commit 0480bcb9fb

6 changed files with 28 additions and 42 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

drivers/staging/comedi/comedi_fops.c

View file

3

drivers/staging/comedi/comedidev.h

View file

4

drivers/staging/comedi/drivers/8255.c

View file

3

drivers/staging/comedi/drivers/addi_watchdog.c

View file

9

drivers/staging/comedi/drivers/amplc_dio200_common.c

View file

37

drivers/staging/comedi/drivers/ni_65xx.c

View file