staging: lustre: remove the CFS_HOP() macro

Browse source

CFS_HOP() is a terrible macro.  It chops the struct member name in half
so that it's not possible to use tools like grep or to search for how
a function pointer is used.

I removed a couple calls to:

	LASSERT(CFS_HOP(hs, put_locked) != NULL);

because they isn't a need for them.  Anyway dereferencing a NULL pointer
generates a pretty good stack trace already without adding extra debug
code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Dan Carpenter 2015-01-22 10:49:54 +03:00 • committed by Greg Kroah-Hartman

parent f8bd34d216

commit 052f4f61ec

2 changed files with 18 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

28

drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h

View file

14

drivers/staging/lustre/lustre/libcfs/hash.c

View file