net: stmmac: free an skb first when there are no longer any descriptors using it

Browse source

When having the skb pointer in the first descriptor, stmmac_tx_clean
can get called at a moment where the IP has only cleared the own bit
of the first descriptor, thus freeing the skb, even though there can
be several descriptors whose buffers point into the same skb.

By simply moving the skb pointer from the first descriptor to the last
descriptor, a skb will get freed only when the IP has cleared the
own bit of all the descriptors that are using that skb.

Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Niklas Cassel 2017-06-20 14:32:41 +02:00 • committed by David S. Miller

parent 57f0c9cf58

commit 05cf0d1bf4

1 changed files with 16 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

View file