drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool

Browse source

Some very low hanging fruit, but contention on the pool->lock is
noticeable between intel_gt_get_buffer_pool() and pool_retire(), with
the majority of the hold time due to the locked list iteration. If we
make the node itself RCU protected, we can perform the search for an
suitable node just under RCU, reserving taking the lock itself for
claiming the node and manipulating the list.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200729080245.8070-1-chris@chris-wilson.co.uk
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

...

This commit is contained in:

Chris Wilson 2020-07-29 09:02:45 +01:00 • committed by Joonas Lahtinen

parent a817c891c1

commit 06b73c2d0b

2 changed files with 64 additions and 42 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

120

drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c

View file

6

drivers/gpu/drm/i915/gt/intel_gt_buffer_pool_types.h

View file